301142 |
01-Jun-2016 |
truckman |
MFC r300633
Fix acpidb CIDs 1011279 (Buffer not null terminated) and 978405 and 1199380 (Resource leak).
load_dsdt() calls strncpy() to copy a filename and Coverity warns that the destination buffer may not be NUL terminated. Fix this by using strlcpy() instead. If silent truncation occurs, then the filename was not valid anyway.
load_dsdt() leaks an fd (CID 978405) and a memory region allocated using mmap() (CID 1199380) when it returns. Fix these by calling close() and munmap() as appropriate.
Don't bother fixing the minor memory leak "list", allocated by AcGetAllTablesFromFile() (CID 1355191).
Check for truncation when creating the temp file name.
Set a flag to indicate that the temp file should be unlinked. Relying on a strcmp() test could delete the input file in contrived cases.
Reported by: Coverity CID: 1011279, 978405, 1199380 Reviewed by: jkim Differential Revision: https://reviews.freebsd.org/D6368 |
173766 |
20-Nov-2007 |
jb |
These are the things that the tinderbox has problems with because it doesn't use the default CFLAGS which contain -fno-strict-aliasing.
Until the code is cleaned up, just add -fno-strict-aliasing to the CFLAGS of these for the tinderboxes' sake, allowing the rest of the tree to have -Werror enabled again.
|