When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Close the fingerprints file in the child after it has been loaded.

I missed this part in my previous commit.

Hoist opening pf.os(5) fingerprints '-o' earlier so that it doesn't
need to be unveiled at runtime in the monitor process.

Cleanup the unused internal privsep "getlines" code, we now explictly
fdpass the OS fingerprints file instead.

ok mestre@ kn@

Reduce differences between the two pfctl_osfp.c files.

Apply three commits from pfctl/pfctl_osfp.c

OK bluhm@

Catch up with pfctl/pfctl_osfp.c, no binary change.

OK deraadt@

Remove two sets of NULL-checks before free().

Adjust <sys/param.h> comments regarding use of use of MSIZE, or
delete <sys/param.h> if now possible
ok guenther

No use for <netinet/in_systm.h> nor <netinet/tcpip.h>.

ctype cleanups, now that the kernel has u_char strings (that is the
easy road, otherwise this would be a righteous mess)
ok florian

Revert non-compatible and undocumented bullshit commited by 3 developers
who decided to just do it on their own. henning, mcbride, jsing -- shame
on you -- if you had shown this diff to just 1 other network developer,
the astounding mistake in it would have been noticed. Start practicing
inclusionary development instead of going alone.
ok claudio

Add quirks support to operating system fingerprinting. tcpdump part
by mcbride@.

ok mcbride@ henning@

use correct struct when checking DF or INET6, ok frantzen@ months ago
forgotten in one of my trees

IPv6 passive OS fingerprinting.
reuses IPv4 signature file (assuming that TCP code is shared among IPv4/v6).
mcbride ok.

Fix indentation as to not mislead the code reader. No functional change.

use strchr instead of index

privilege separated tcpdump, joint work with otto@

tested by avsm@ vincent@ dhartmei@ markus@ hshoexer@ and others
go for it deraadt@

Close the fingerprints file in the child after it has been loaded.

I missed this part in my previous commit.

Hoist opening pf.os(5) fingerprints '-o' earlier so that it doesn't
need to be unveiled at runtime in the monitor process.

Cleanup the unused internal privsep "getlines" code, we now explictly
fdpass the OS fingerprints file instead.

ok mestre@ kn@

Reduce differences between the two pfctl_osfp.c files.

Apply three commits from pfctl/pfctl_osfp.c

OK bluhm@

Catch up with pfctl/pfctl_osfp.c, no binary change.

OK deraadt@

Remove two sets of NULL-checks before free().

Adjust <sys/param.h> comments regarding use of use of MSIZE, or
delete <sys/param.h> if now possible
ok guenther

No use for <netinet/in_systm.h> nor <netinet/tcpip.h>.

ctype cleanups, now that the kernel has u_char strings (that is the
easy road, otherwise this would be a righteous mess)
ok florian

Revert non-compatible and undocumented bullshit commited by 3 developers
who decided to just do it on their own. henning, mcbride, jsing -- shame
on you -- if you had shown this diff to just 1 other network developer,
the astounding mistake in it would have been noticed. Start practicing
inclusionary development instead of going alone.
ok claudio

Add quirks support to operating system fingerprinting. tcpdump part
by mcbride@.

ok mcbride@ henning@

use correct struct when checking DF or INET6, ok frantzen@ months ago
forgotten in one of my trees

IPv6 passive OS fingerprinting.
reuses IPv4 signature file (assuming that TCP code is shared among IPv4/v6).
mcbride ok.

Fix indentation as to not mislead the code reader. No functional change.

use strchr instead of index

privilege separated tcpdump, joint work with otto@

tested by avsm@ vincent@ dhartmei@ markus@ hshoexer@ and others
go for it deraadt@

Reduce differences between the two pfctl_osfp.c files.

Apply three commits from pfctl/pfctl_osfp.c

OK bluhm@

Catch up with pfctl/pfctl_osfp.c, no binary change.

OK deraadt@

Remove two sets of NULL-checks before free().

Adjust <sys/param.h> comments regarding use of use of MSIZE, or
delete <sys/param.h> if now possible
ok guenther

No use for <netinet/in_systm.h> nor <netinet/tcpip.h>.

ctype cleanups, now that the kernel has u_char strings (that is the
easy road, otherwise this would be a righteous mess)
ok florian

Revert non-compatible and undocumented bullshit commited by 3 developers
who decided to just do it on their own. henning, mcbride, jsing -- shame
on you -- if you had shown this diff to just 1 other network developer,
the astounding mistake in it would have been noticed. Start practicing
inclusionary development instead of going alone.
ok claudio

Add quirks support to operating system fingerprinting. tcpdump part
by mcbride@.

ok mcbride@ henning@

use correct struct when checking DF or INET6, ok frantzen@ months ago
forgotten in one of my trees

IPv6 passive OS fingerprinting.
reuses IPv4 signature file (assuming that TCP code is shared among IPv4/v6).
mcbride ok.

Fix indentation as to not mislead the code reader. No functional change.

use strchr instead of index

privilege separated tcpdump, joint work with otto@

tested by avsm@ vincent@ dhartmei@ markus@ hshoexer@ and others
go for it deraadt@