remove prototypes with no matching function and externs with no var
partly checked by millert@

spelling fixes; from paul tagliamonte
any parts of his diff not taken are noted on tech

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

We can safely assume that our utmp(5) file format implementation can guarantee
space for the NUL character, nevertheless there will always be some piece of
software that can get it wrong and corrupt the database, so we must take this
into consideration.

That being said, there is one strlcpy(3) that needs to be reverted back into
strncpy(3) + '\0' since if we try to use a bogus wtmp(5) file with ac(8) that
is big enough then the NUL char is not verified and it will write memory
out-of-bounds which will make the program crash.

discussed with and OK cheloha@ deraadt@

Since we can feed localtime(3) with garbage input, or with input it cannot
interpret, we always need to check its return value, and in the case it's NULL
then error and exit before proceeding further otherwise in this specific
program we would find a null dereference down the road which would make the
program segfault.

OK cheloha@

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

pledge to only use "stdio rpath"; rpath is for readig the wtmp files.
ok doug

clean up flags++ instances around getopt()
ok florian

Update license to two-clause BSD. Permission to do so was granted
by the authors as per Ed Schouten.

Remove the non-standard, commented out, -c option.
OK tedu@ jmc@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

the usage message should start with "usage:";
no need for "users", ellipsis allows various users to be specified;
synchronize synopsis and usage

ok jmc@

Change an int to size_t
Remove NEW()
Remove unused return value of add_tty()

ok moritz@

0 vs NULL, from Joris Vink

spacing

ignore backwards going entries

some ansification, some de-register

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

minor KNF

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

- Let '-' mean stdin.
- Correct usage message: -p and -d cannot be usefully used together.
- Use __progname in usage()
millert@ ok

use strlcpy vs strncpy+a[n-1]='\0'

if user specified wtmp file, use timestamp on final record instead of
current system time for "end of run" time; tim@pool1.convey.ru

incorrect length in comparison; hubert.feyrer@rz.uni-regensburg.de

catch ptys correctly; tolik@www.tomsk.su

correct for our pty list

getopt(3) returns -1 when out of args, not EOF, whee!

fix warnings

branches: 1.1.1;
Initial revision

spelling fixes; from paul tagliamonte
any parts of his diff not taken are noted on tech

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

We can safely assume that our utmp(5) file format implementation can guarantee
space for the NUL character, nevertheless there will always be some piece of
software that can get it wrong and corrupt the database, so we must take this
into consideration.

That being said, there is one strlcpy(3) that needs to be reverted back into
strncpy(3) + '\0' since if we try to use a bogus wtmp(5) file with ac(8) that
is big enough then the NUL char is not verified and it will write memory
out-of-bounds which will make the program crash.

discussed with and OK cheloha@ deraadt@

Since we can feed localtime(3) with garbage input, or with input it cannot
interpret, we always need to check its return value, and in the case it's NULL
then error and exit before proceeding further otherwise in this specific
program we would find a null dereference down the road which would make the
program segfault.

OK cheloha@

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

pledge to only use "stdio rpath"; rpath is for readig the wtmp files.
ok doug

clean up flags++ instances around getopt()
ok florian

Update license to two-clause BSD. Permission to do so was granted
by the authors as per Ed Schouten.

Remove the non-standard, commented out, -c option.
OK tedu@ jmc@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

the usage message should start with "usage:";
no need for "users", ellipsis allows various users to be specified;
synchronize synopsis and usage

ok jmc@

Change an int to size_t
Remove NEW()
Remove unused return value of add_tty()

ok moritz@

0 vs NULL, from Joris Vink

spacing

ignore backwards going entries

some ansification, some de-register

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

minor KNF

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

- Let '-' mean stdin.
- Correct usage message: -p and -d cannot be usefully used together.
- Use __progname in usage()
millert@ ok

use strlcpy vs strncpy+a[n-1]='\0'

if user specified wtmp file, use timestamp on final record instead of
current system time for "end of run" time; tim@pool1.convey.ru

incorrect length in comparison; hubert.feyrer@rz.uni-regensburg.de

catch ptys correctly; tolik@www.tomsk.su

correct for our pty list

getopt(3) returns -1 when out of args, not EOF, whee!

fix warnings

branches: 1.1.1;
Initial revision

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

We can safely assume that our utmp(5) file format implementation can guarantee
space for the NUL character, nevertheless there will always be some piece of
software that can get it wrong and corrupt the database, so we must take this
into consideration.

That being said, there is one strlcpy(3) that needs to be reverted back into
strncpy(3) + '\0' since if we try to use a bogus wtmp(5) file with ac(8) that
is big enough then the NUL char is not verified and it will write memory
out-of-bounds which will make the program crash.

discussed with and OK cheloha@ deraadt@

Since we can feed localtime(3) with garbage input, or with input it cannot
interpret, we always need to check its return value, and in the case it's NULL
then error and exit before proceeding further otherwise in this specific
program we would find a null dereference down the road which would make the
program segfault.

OK cheloha@

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

pledge to only use "stdio rpath"; rpath is for readig the wtmp files.
ok doug

clean up flags++ instances around getopt()
ok florian

Update license to two-clause BSD. Permission to do so was granted
by the authors as per Ed Schouten.

Remove the non-standard, commented out, -c option.
OK tedu@ jmc@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

the usage message should start with "usage:";
no need for "users", ellipsis allows various users to be specified;
synchronize synopsis and usage

ok jmc@

Change an int to size_t
Remove NEW()
Remove unused return value of add_tty()

ok moritz@

0 vs NULL, from Joris Vink

spacing

ignore backwards going entries

some ansification, some de-register

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

minor KNF

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

- Let '-' mean stdin.
- Correct usage message: -p and -d cannot be usefully used together.
- Use __progname in usage()
millert@ ok

use strlcpy vs strncpy+a[n-1]='\0'

if user specified wtmp file, use timestamp on final record instead of
current system time for "end of run" time; tim@pool1.convey.ru

incorrect length in comparison; hubert.feyrer@rz.uni-regensburg.de

catch ptys correctly; tolik@www.tomsk.su

correct for our pty list

getopt(3) returns -1 when out of args, not EOF, whee!

fix warnings

branches: 1.1.1;
Initial revision

We can safely assume that our utmp(5) file format implementation can guarantee
space for the NUL character, nevertheless there will always be some piece of
software that can get it wrong and corrupt the database, so we must take this
into consideration.

That being said, there is one strlcpy(3) that needs to be reverted back into
strncpy(3) + '\0' since if we try to use a bogus wtmp(5) file with ac(8) that
is big enough then the NUL char is not verified and it will write memory
out-of-bounds which will make the program crash.

discussed with and OK cheloha@ deraadt@

Since we can feed localtime(3) with garbage input, or with input it cannot
interpret, we always need to check its return value, and in the case it's NULL
then error and exit before proceeding further otherwise in this specific
program we would find a null dereference down the road which would make the
program segfault.

OK cheloha@

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

pledge to only use "stdio rpath"; rpath is for readig the wtmp files.
ok doug

clean up flags++ instances around getopt()
ok florian

Update license to two-clause BSD. Permission to do so was granted
by the authors as per Ed Schouten.

Remove the non-standard, commented out, -c option.
OK tedu@ jmc@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

the usage message should start with "usage:";
no need for "users", ellipsis allows various users to be specified;
synchronize synopsis and usage

ok jmc@

Change an int to size_t
Remove NEW()
Remove unused return value of add_tty()

ok moritz@

0 vs NULL, from Joris Vink

spacing

ignore backwards going entries

some ansification, some de-register

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

minor KNF

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

- Let '-' mean stdin.
- Correct usage message: -p and -d cannot be usefully used together.
- Use __progname in usage()
millert@ ok

use strlcpy vs strncpy+a[n-1]='\0'

if user specified wtmp file, use timestamp on final record instead of
current system time for "end of run" time; tim@pool1.convey.ru

incorrect length in comparison; hubert.feyrer@rz.uni-regensburg.de

catch ptys correctly; tolik@www.tomsk.su

correct for our pty list

getopt(3) returns -1 when out of args, not EOF, whee!

fix warnings

branches: 1.1.1;
Initial revision

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

pledge to only use "stdio rpath"; rpath is for readig the wtmp files.
ok doug

clean up flags++ instances around getopt()
ok florian

Update license to two-clause BSD. Permission to do so was granted
by the authors as per Ed Schouten.

Remove the non-standard, commented out, -c option.
OK tedu@ jmc@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

the usage message should start with "usage:";
no need for "users", ellipsis allows various users to be specified;
synchronize synopsis and usage

ok jmc@

Change an int to size_t
Remove NEW()
Remove unused return value of add_tty()

ok moritz@

0 vs NULL, from Joris Vink

spacing

ignore backwards going entries

some ansification, some de-register

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

minor KNF

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

- Let '-' mean stdin.
- Correct usage message: -p and -d cannot be usefully used together.
- Use __progname in usage()
millert@ ok

use strlcpy vs strncpy+a[n-1]='\0'

if user specified wtmp file, use timestamp on final record instead of
current system time for "end of run" time; tim@pool1.convey.ru

incorrect length in comparison; hubert.feyrer@rz.uni-regensburg.de

catch ptys correctly; tolik@www.tomsk.su

correct for our pty list

getopt(3) returns -1 when out of args, not EOF, whee!

fix warnings

branches: 1.1.1;
Initial revision

pledge to only use "stdio rpath"; rpath is for readig the wtmp files.
ok doug

clean up flags++ instances around getopt()
ok florian

Update license to two-clause BSD. Permission to do so was granted
by the authors as per Ed Schouten.

Remove the non-standard, commented out, -c option.
OK tedu@ jmc@ deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

the usage message should start with "usage:";
no need for "users", ellipsis allows various users to be specified;
synchronize synopsis and usage

ok jmc@

Change an int to size_t
Remove NEW()
Remove unused return value of add_tty()

ok moritz@

0 vs NULL, from Joris Vink

spacing

ignore backwards going entries

some ansification, some de-register

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

minor KNF

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

- Let '-' mean stdin.
- Correct usage message: -p and -d cannot be usefully used together.
- Use __progname in usage()
millert@ ok

use strlcpy vs strncpy+a[n-1]='\0'

if user specified wtmp file, use timestamp on final record instead of
current system time for "end of run" time; tim@pool1.convey.ru

incorrect length in comparison; hubert.feyrer@rz.uni-regensburg.de

catch ptys correctly; tolik@www.tomsk.su

correct for our pty list

getopt(3) returns -1 when out of args, not EOF, whee!

fix warnings

branches: 1.1.1;
Initial revision