spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Use password/group cache functions and avoid stashing a pointer to
the return value of getgrgid(3) or getgrnam(3) which relies on
undefined behavior. The rdist server will now use getgroups(2) to
determine group membership of the invoking user. In addition, there
is now one implementation of tilde expansion instead of two.
OK tb@ tim@

Fix a crash in rdistd triggered by the recent getpw{ent,nam,uid}
changes. This stems from rdist stashing a pointer to the static
area used by getpw{ent,nam,uid} and using it to avoid repeating
passwd lookups when pw->pw_name matches the user to be looked up.

This relied on undefined behavior, and with the recent passwd
changes, is no longer possible as the old pointer will be invalidated.
A better approach is to use the upcoming uid_from_user(3) functions.
Found by and fix OK tim@

remove needless allocation casts

Split out from rdist/defs.h the client-only and server-only bits into
rdist/client.h and rdistd/server.h
Only put #includes in .h files that are necessary for the .h to be used;
all other #includes go in the .c files
Move all extern variable declarations to the .h files, renaming local
variables to avoid shadowing
Replace me_type member of mntent_t with an "is NFS?" flag bit

Don't use utime(), so don't need <utime.h>

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Kill os-openbsd.h: we have <paths.h>, _PATH_RSH, and utimes()

SETARGS and NEED_HASMNTOPT paths are dead; rshrcmd() and libz stuff are
no longer (were never?) used

Assume POSIX: write() takes size_t and returns ssize_t

Assume POSIX: lchown(), fchown(), fchmod(), fchmodat()
Assume we have rcmdsh()

Assume POSIX: uid_t and gid_t

Assume C89: stdargs, const, and setvbuf()
Assume POSIX: O_NONBLOCK and S_IS{DIR,REG,LNK}

Use void* in malloc/realloc/calloc wrappers

delete a stupid SIGSEGV handler (not used)

Print size_t with %zu and ssize_t with %zd in error/debug output.
Not %d or %u. May help some of the issues reported by Richard Toohey.
Tested by Steven R. Gerber.

Apply some tough type-love and give rdist a chance to handle files
larger than 2GB. Diff from Stephan R. Gerber via PR#6586, tweaks
by me.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

remove unused function

from tobias@

ok millert@ tobias@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

o Sync w/ freerdist 0.92 minus the compress option
o KNF and ANSIfy the function headers

Sparse file support is currently a no-op since it didn't work.
Proper sparse file support will be added later.

Now that rcmdsh(3) can deal with an rsh command w/ args, deal with
-P path elements that have spaces.

strcpy/strcat/sprintf removal; krw@ OK

strings; ok miod ho krw

uid_t and gid_t are unsigned

a real pid_t cleanup.

espie@ ok for make/,
deraadt@ one extra eye,
millert@ ok

unsigned vs unsigned int

do not install a SIGSEGV handler

kill more registers

millert@ ok

correct type on last arg to execl(); nordin@cse.ogi.edu

seperate -> separate, okay aaron@

correct error msg so it considers the terminating null byte

Fix a serious memory consumption problem when running over directories
that contain many hard-linked files; johnh@isi.edu
Also add an xstrdup() that behaves like xmalloc() on failure.

save_errno

rdist 6.1.4 + OpenBSD patches + some -Wall

Don't use cached name value for uid/gid if last lookup was by id (and not name).
Fix also sent to rdist-bugs@usc.edu

Pull in more includes to properly prototype library functions, kill local
decls of library functions, kill local implementation of setproctitle().

This of course points out how utterly bad this code is and that someone needs
to come in here with a chainsaw sometime.

rcsid

rdist 6.1.2

rdist 6.1.1

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Use password/group cache functions and avoid stashing a pointer to
the return value of getgrgid(3) or getgrnam(3) which relies on
undefined behavior. The rdist server will now use getgroups(2) to
determine group membership of the invoking user. In addition, there
is now one implementation of tilde expansion instead of two.
OK tb@ tim@

Fix a crash in rdistd triggered by the recent getpw{ent,nam,uid}
changes. This stems from rdist stashing a pointer to the static
area used by getpw{ent,nam,uid} and using it to avoid repeating
passwd lookups when pw->pw_name matches the user to be looked up.

This relied on undefined behavior, and with the recent passwd
changes, is no longer possible as the old pointer will be invalidated.
A better approach is to use the upcoming uid_from_user(3) functions.
Found by and fix OK tim@

remove needless allocation casts

Split out from rdist/defs.h the client-only and server-only bits into
rdist/client.h and rdistd/server.h
Only put #includes in .h files that are necessary for the .h to be used;
all other #includes go in the .c files
Move all extern variable declarations to the .h files, renaming local
variables to avoid shadowing
Replace me_type member of mntent_t with an "is NFS?" flag bit

Don't use utime(), so don't need <utime.h>

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Kill os-openbsd.h: we have <paths.h>, _PATH_RSH, and utimes()

SETARGS and NEED_HASMNTOPT paths are dead; rshrcmd() and libz stuff are
no longer (were never?) used

Assume POSIX: write() takes size_t and returns ssize_t

Assume POSIX: lchown(), fchown(), fchmod(), fchmodat()
Assume we have rcmdsh()

Assume POSIX: uid_t and gid_t

Assume C89: stdargs, const, and setvbuf()
Assume POSIX: O_NONBLOCK and S_IS{DIR,REG,LNK}

Use void* in malloc/realloc/calloc wrappers

delete a stupid SIGSEGV handler (not used)

Print size_t with %zu and ssize_t with %zd in error/debug output.
Not %d or %u. May help some of the issues reported by Richard Toohey.
Tested by Steven R. Gerber.

Apply some tough type-love and give rdist a chance to handle files
larger than 2GB. Diff from Stephan R. Gerber via PR#6586, tweaks
by me.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

remove unused function

from tobias@

ok millert@ tobias@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

o Sync w/ freerdist 0.92 minus the compress option
o KNF and ANSIfy the function headers

Sparse file support is currently a no-op since it didn't work.
Proper sparse file support will be added later.

Now that rcmdsh(3) can deal with an rsh command w/ args, deal with
-P path elements that have spaces.

strcpy/strcat/sprintf removal; krw@ OK

strings; ok miod ho krw

uid_t and gid_t are unsigned

a real pid_t cleanup.

espie@ ok for make/,
deraadt@ one extra eye,
millert@ ok

unsigned vs unsigned int

do not install a SIGSEGV handler

kill more registers

millert@ ok

correct type on last arg to execl(); nordin@cse.ogi.edu

seperate -> separate, okay aaron@

correct error msg so it considers the terminating null byte

Fix a serious memory consumption problem when running over directories
that contain many hard-linked files; johnh@isi.edu
Also add an xstrdup() that behaves like xmalloc() on failure.

save_errno

rdist 6.1.4 + OpenBSD patches + some -Wall

Don't use cached name value for uid/gid if last lookup was by id (and not name).
Fix also sent to rdist-bugs@usc.edu

Pull in more includes to properly prototype library functions, kill local
decls of library functions, kill local implementation of setproctitle().

This of course points out how utterly bad this code is and that someone needs
to come in here with a chainsaw sometime.

rcsid

rdist 6.1.2

rdist 6.1.1

Use password/group cache functions and avoid stashing a pointer to
the return value of getgrgid(3) or getgrnam(3) which relies on
undefined behavior. The rdist server will now use getgroups(2) to
determine group membership of the invoking user. In addition, there
is now one implementation of tilde expansion instead of two.
OK tb@ tim@

Fix a crash in rdistd triggered by the recent getpw{ent,nam,uid}
changes. This stems from rdist stashing a pointer to the static
area used by getpw{ent,nam,uid} and using it to avoid repeating
passwd lookups when pw->pw_name matches the user to be looked up.

This relied on undefined behavior, and with the recent passwd
changes, is no longer possible as the old pointer will be invalidated.
A better approach is to use the upcoming uid_from_user(3) functions.
Found by and fix OK tim@

remove needless allocation casts

Split out from rdist/defs.h the client-only and server-only bits into
rdist/client.h and rdistd/server.h
Only put #includes in .h files that are necessary for the .h to be used;
all other #includes go in the .c files
Move all extern variable declarations to the .h files, renaming local
variables to avoid shadowing
Replace me_type member of mntent_t with an "is NFS?" flag bit

Don't use utime(), so don't need <utime.h>

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Kill os-openbsd.h: we have <paths.h>, _PATH_RSH, and utimes()

SETARGS and NEED_HASMNTOPT paths are dead; rshrcmd() and libz stuff are
no longer (were never?) used

Assume POSIX: write() takes size_t and returns ssize_t

Assume POSIX: lchown(), fchown(), fchmod(), fchmodat()
Assume we have rcmdsh()

Assume POSIX: uid_t and gid_t

Assume C89: stdargs, const, and setvbuf()
Assume POSIX: O_NONBLOCK and S_IS{DIR,REG,LNK}

Use void* in malloc/realloc/calloc wrappers

delete a stupid SIGSEGV handler (not used)

Print size_t with %zu and ssize_t with %zd in error/debug output.
Not %d or %u. May help some of the issues reported by Richard Toohey.
Tested by Steven R. Gerber.

Apply some tough type-love and give rdist a chance to handle files
larger than 2GB. Diff from Stephan R. Gerber via PR#6586, tweaks
by me.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

remove unused function

from tobias@

ok millert@ tobias@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

o Sync w/ freerdist 0.92 minus the compress option
o KNF and ANSIfy the function headers

Sparse file support is currently a no-op since it didn't work.
Proper sparse file support will be added later.

Now that rcmdsh(3) can deal with an rsh command w/ args, deal with
-P path elements that have spaces.

strcpy/strcat/sprintf removal; krw@ OK

strings; ok miod ho krw

uid_t and gid_t are unsigned

a real pid_t cleanup.

espie@ ok for make/,
deraadt@ one extra eye,
millert@ ok

unsigned vs unsigned int

do not install a SIGSEGV handler

kill more registers

millert@ ok

correct type on last arg to execl(); nordin@cse.ogi.edu

seperate -> separate, okay aaron@

correct error msg so it considers the terminating null byte

Fix a serious memory consumption problem when running over directories
that contain many hard-linked files; johnh@isi.edu
Also add an xstrdup() that behaves like xmalloc() on failure.

save_errno

rdist 6.1.4 + OpenBSD patches + some -Wall

Don't use cached name value for uid/gid if last lookup was by id (and not name).
Fix also sent to rdist-bugs@usc.edu

Pull in more includes to properly prototype library functions, kill local
decls of library functions, kill local implementation of setproctitle().

This of course points out how utterly bad this code is and that someone needs
to come in here with a chainsaw sometime.

rcsid

rdist 6.1.2

rdist 6.1.1

remove needless allocation casts

Split out from rdist/defs.h the client-only and server-only bits into
rdist/client.h and rdistd/server.h
Only put #includes in .h files that are necessary for the .h to be used;
all other #includes go in the .c files
Move all extern variable declarations to the .h files, renaming local
variables to avoid shadowing
Replace me_type member of mntent_t with an "is NFS?" flag bit

Don't use utime(), so don't need <utime.h>

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Kill os-openbsd.h: we have <paths.h>, _PATH_RSH, and utimes()

SETARGS and NEED_HASMNTOPT paths are dead; rshrcmd() and libz stuff are
no longer (were never?) used

Assume POSIX: write() takes size_t and returns ssize_t

Assume POSIX: lchown(), fchown(), fchmod(), fchmodat()
Assume we have rcmdsh()

Assume POSIX: uid_t and gid_t

Assume C89: stdargs, const, and setvbuf()
Assume POSIX: O_NONBLOCK and S_IS{DIR,REG,LNK}

Use void* in malloc/realloc/calloc wrappers

delete a stupid SIGSEGV handler (not used)

Print size_t with %zu and ssize_t with %zd in error/debug output.
Not %d or %u. May help some of the issues reported by Richard Toohey.
Tested by Steven R. Gerber.

Apply some tough type-love and give rdist a chance to handle files
larger than 2GB. Diff from Stephan R. Gerber via PR#6586, tweaks
by me.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

remove unused function

from tobias@

ok millert@ tobias@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

o Sync w/ freerdist 0.92 minus the compress option
o KNF and ANSIfy the function headers

Sparse file support is currently a no-op since it didn't work.
Proper sparse file support will be added later.

Now that rcmdsh(3) can deal with an rsh command w/ args, deal with
-P path elements that have spaces.

strcpy/strcat/sprintf removal; krw@ OK

strings; ok miod ho krw

uid_t and gid_t are unsigned

a real pid_t cleanup.

espie@ ok for make/,
deraadt@ one extra eye,
millert@ ok

unsigned vs unsigned int

do not install a SIGSEGV handler

kill more registers

millert@ ok

correct type on last arg to execl(); nordin@cse.ogi.edu

seperate -> separate, okay aaron@

correct error msg so it considers the terminating null byte

Fix a serious memory consumption problem when running over directories
that contain many hard-linked files; johnh@isi.edu
Also add an xstrdup() that behaves like xmalloc() on failure.

save_errno

rdist 6.1.4 + OpenBSD patches + some -Wall

Don't use cached name value for uid/gid if last lookup was by id (and not name).
Fix also sent to rdist-bugs@usc.edu

Pull in more includes to properly prototype library functions, kill local
decls of library functions, kill local implementation of setproctitle().

This of course points out how utterly bad this code is and that someone needs
to come in here with a chainsaw sometime.

rcsid

rdist 6.1.2

rdist 6.1.1