remove UADDR_HINT_MAXGAP, missed when uaddr_hint allocator was removed

remove prototypes with no matching function
ok mpi@

correct indentation

no functional change, found by smatch warnings
ok miod@ bluhm@

Assert the VM map lock is held in function used by mmap/mprotect/munmap.

Also grab the lock in uvm_map_teardown() and uvm_map_deallocate() to
satisfy the assertions. Grabbing the lock there shouldn't be strictly
necessary, because no other reference to the map should exist when the
reaper is holding it, but it doesn't hurt and makes our life easier.

Inputs & tests from Ivo van der Sangen, tb@, gnezdo@, kn@

kettenis@ and tb@ agree with the direction, ok kn@

interting -> inserting

Sync some comments in order to reduce the difference with NetBSD.

No functionnal change.

ok kettenis@

Spell inline correctly.

Reduce differences with NetBSD.

ok mvs@, kettenis@

Include <sys/systm.h> directly instead of relying on uvm_map.h to pull it.

Avoid overflow in constraint computation; ok kettenis@ tb@

- Make rnd hints avoid the brk area. The rnd allocator refuses to allocate in
the brk area anyway.
- Use a larger hint bound to spread the allocations more for the 32-bit case
- Simplified the overy abstracted brs/stack allocator and switch of
guard pages for the brk case. This allows i386 some extra space,
depending on memory usage patterns.
- Reduce brk area on i386 to give the rnd space more room

ok stefan@ sthen@

Fix stop condition for linear search by taking into account the search
direction, otherwise we might break the loop prematurely; ok stefan@

Move static function to the bottom of the file, to the only user
of that function, to guard it with SMALL_KERNEL.

ok mpi@

Remove uaddr_hint allocator

The hint allocator would have to check that the
allocation does not overlap with brk, stack or text
areas. This would make the address selectors too
entagled. Just use the rnd allocator for hinted allocations
in case pivots are used. This also reduces the amount of code somewhat.

ok kettenis visa deraadt

fix spelling of RBT_NEXT in a comment

move uaddr_free_rbtree from RB macros to RBT functions

move the uvm_map_addr RB tree from RB macros to the RBT functions

this tree is interesting because it uses all the red black tree
features, specifically the augment callback thats called on tree
topology changes, and it poisons and checks entries as theyre removed
from and inserted back into the tree respectively.

ok stefan@

all pools have their ipl set via pool_setipl, so fold it into pool_init.

the ioff argument to pool_init() is unused and has been for many
years, so this replaces it with an ipl argument. because the ipl
will be set on init we no longer need pool_setipl.

most of these changes have been done with coccinelle using the spatch
below. cocci sucks at formatting code though, so i fixed that by hand.

the manpage and subr_pool.c bits i did myself.

ok tedu@ jmatthew@

@ipl@
expression pp;
expression ipl;
expression s, a, o, f, m, p;
@@
-pool_init(pp, s, a, o, f, m, p);
-pool_setipl(pp, ipl);
+pool_init(pp, s, a, ipl, f, m, p);

Mask out lower bits of randomly selected address

Fixes uvm pivots bug that would create non-page aligned addresses.
This fix is in code that's not yet enabled.

Add a few checks for potential integer overflow and underflow related to the
size of an address range.

ok deraadt@, tedu@

print the size when an unavailable address is returned. it is useful.
ok millert stefan

Sync no-argument function declaration and definition by adding (void).
ok mpi@ millert@

Release the kernel lock while tearing down the uvm map in the reaper. Speeds
up workloads that fork a lot of processes and, more importantly reduces
latency because it makes sure the reaper doesn't hold on to the kernel lock
for long periods of time.

This almost certainly breaks MP kernels on alpha, macppc, m88k and sgi;
hppa might work, but probably doesn't.

ok deraadt@, beck@

Extend uvm_map_hint() to get an address range as extra arguments, and make
sure it will return an address within that range.

Use this in uaddr_rnd_select() to make sure we will not attempt to pick
an address beyond what we are allowed to map.

In my trees for 9 months, blackmailed s2k15 attendees into agreeing now would
be a good time to commit.

#if 0 various unused definitions.

convert nointr pool_init argument to pr_waitok

move arc4random prototype to systm.h. more appropriate for most code
to include that than rdnvar.h. ok deraadt dlg

bzero -> memset

KNF

compress code by turning four line comments into one line comments.
emphatic ok usual suspects, grudging ok miod

reduce the length of some pool names. ok deraadt guenther mpi

comment typo; s/lineair/linear/

Fix address-space randomization that was accidentally disabled in
uvm_addr.c r1.3.

ok deraadt, tedu

vmmap: speed up allocations

Reduces O(n log n) allocations to O(log n).

ok deraadt, tedu

Reduce installmedia pressure from new vmmap.

Has less special allocators on install media (where they aren't required
anyway).
Bonus: makes the vmmap initialization code easier to read.

New vmmap implementation.

no oks (it is really a pain to review properly)
extensively tested, I'm confident it'll be stable
'now is the time' from several icb inhabitants

Diff provides:
- ability to specify different allocators for different regions/maps
- a simpler implementation of the current allocator
- currently in compatibility mode: it will generate similar addresses
as the old allocator

remove prototypes with no matching function
ok mpi@

correct indentation

no functional change, found by smatch warnings
ok miod@ bluhm@

Assert the VM map lock is held in function used by mmap/mprotect/munmap.

Also grab the lock in uvm_map_teardown() and uvm_map_deallocate() to
satisfy the assertions. Grabbing the lock there shouldn't be strictly
necessary, because no other reference to the map should exist when the
reaper is holding it, but it doesn't hurt and makes our life easier.

Inputs & tests from Ivo van der Sangen, tb@, gnezdo@, kn@

kettenis@ and tb@ agree with the direction, ok kn@

interting -> inserting

Sync some comments in order to reduce the difference with NetBSD.

No functionnal change.

ok kettenis@

Spell inline correctly.

Reduce differences with NetBSD.

ok mvs@, kettenis@

Include <sys/systm.h> directly instead of relying on uvm_map.h to pull it.

Avoid overflow in constraint computation; ok kettenis@ tb@

- Make rnd hints avoid the brk area. The rnd allocator refuses to allocate in
the brk area anyway.
- Use a larger hint bound to spread the allocations more for the 32-bit case
- Simplified the overy abstracted brs/stack allocator and switch of
guard pages for the brk case. This allows i386 some extra space,
depending on memory usage patterns.
- Reduce brk area on i386 to give the rnd space more room

ok stefan@ sthen@

Fix stop condition for linear search by taking into account the search
direction, otherwise we might break the loop prematurely; ok stefan@

Move static function to the bottom of the file, to the only user
of that function, to guard it with SMALL_KERNEL.

ok mpi@

Remove uaddr_hint allocator

The hint allocator would have to check that the
allocation does not overlap with brk, stack or text
areas. This would make the address selectors too
entagled. Just use the rnd allocator for hinted allocations
in case pivots are used. This also reduces the amount of code somewhat.

ok kettenis visa deraadt

fix spelling of RBT_NEXT in a comment

move uaddr_free_rbtree from RB macros to RBT functions

move the uvm_map_addr RB tree from RB macros to the RBT functions

this tree is interesting because it uses all the red black tree
features, specifically the augment callback thats called on tree
topology changes, and it poisons and checks entries as theyre removed
from and inserted back into the tree respectively.

ok stefan@

all pools have their ipl set via pool_setipl, so fold it into pool_init.

the ioff argument to pool_init() is unused and has been for many
years, so this replaces it with an ipl argument. because the ipl
will be set on init we no longer need pool_setipl.

most of these changes have been done with coccinelle using the spatch
below. cocci sucks at formatting code though, so i fixed that by hand.

the manpage and subr_pool.c bits i did myself.

ok tedu@ jmatthew@

@ipl@
expression pp;
expression ipl;
expression s, a, o, f, m, p;
@@
-pool_init(pp, s, a, o, f, m, p);
-pool_setipl(pp, ipl);
+pool_init(pp, s, a, ipl, f, m, p);

Mask out lower bits of randomly selected address

Fixes uvm pivots bug that would create non-page aligned addresses.
This fix is in code that's not yet enabled.

Add a few checks for potential integer overflow and underflow related to the
size of an address range.

ok deraadt@, tedu@

print the size when an unavailable address is returned. it is useful.
ok millert stefan

Sync no-argument function declaration and definition by adding (void).
ok mpi@ millert@

Release the kernel lock while tearing down the uvm map in the reaper. Speeds
up workloads that fork a lot of processes and, more importantly reduces
latency because it makes sure the reaper doesn't hold on to the kernel lock
for long periods of time.

This almost certainly breaks MP kernels on alpha, macppc, m88k and sgi;
hppa might work, but probably doesn't.

ok deraadt@, beck@

Extend uvm_map_hint() to get an address range as extra arguments, and make
sure it will return an address within that range.

Use this in uaddr_rnd_select() to make sure we will not attempt to pick
an address beyond what we are allowed to map.

In my trees for 9 months, blackmailed s2k15 attendees into agreeing now would
be a good time to commit.

#if 0 various unused definitions.

convert nointr pool_init argument to pr_waitok

move arc4random prototype to systm.h. more appropriate for most code
to include that than rdnvar.h. ok deraadt dlg

bzero -> memset

KNF

compress code by turning four line comments into one line comments.
emphatic ok usual suspects, grudging ok miod

reduce the length of some pool names. ok deraadt guenther mpi

comment typo; s/lineair/linear/

Fix address-space randomization that was accidentally disabled in
uvm_addr.c r1.3.

ok deraadt, tedu

vmmap: speed up allocations

Reduces O(n log n) allocations to O(log n).

ok deraadt, tedu

Reduce installmedia pressure from new vmmap.

Has less special allocators on install media (where they aren't required
anyway).
Bonus: makes the vmmap initialization code easier to read.

New vmmap implementation.

no oks (it is really a pain to review properly)
extensively tested, I'm confident it'll be stable
'now is the time' from several icb inhabitants

Diff provides:
- ability to specify different allocators for different regions/maps
- a simpler implementation of the current allocator
- currently in compatibility mode: it will generate similar addresses
as the old allocator

correct indentation

no functional change, found by smatch warnings
ok miod@ bluhm@

Assert the VM map lock is held in function used by mmap/mprotect/munmap.

Also grab the lock in uvm_map_teardown() and uvm_map_deallocate() to
satisfy the assertions. Grabbing the lock there shouldn't be strictly
necessary, because no other reference to the map should exist when the
reaper is holding it, but it doesn't hurt and makes our life easier.

Inputs & tests from Ivo van der Sangen, tb@, gnezdo@, kn@

kettenis@ and tb@ agree with the direction, ok kn@

interting -> inserting

Sync some comments in order to reduce the difference with NetBSD.

No functionnal change.

ok kettenis@

Spell inline correctly.

Reduce differences with NetBSD.

ok mvs@, kettenis@

Include <sys/systm.h> directly instead of relying on uvm_map.h to pull it.

Avoid overflow in constraint computation; ok kettenis@ tb@

- Make rnd hints avoid the brk area. The rnd allocator refuses to allocate in
the brk area anyway.
- Use a larger hint bound to spread the allocations more for the 32-bit case
- Simplified the overy abstracted brs/stack allocator and switch of
guard pages for the brk case. This allows i386 some extra space,
depending on memory usage patterns.
- Reduce brk area on i386 to give the rnd space more room

ok stefan@ sthen@

Fix stop condition for linear search by taking into account the search
direction, otherwise we might break the loop prematurely; ok stefan@

Move static function to the bottom of the file, to the only user
of that function, to guard it with SMALL_KERNEL.

ok mpi@

Remove uaddr_hint allocator

The hint allocator would have to check that the
allocation does not overlap with brk, stack or text
areas. This would make the address selectors too
entagled. Just use the rnd allocator for hinted allocations
in case pivots are used. This also reduces the amount of code somewhat.

ok kettenis visa deraadt

fix spelling of RBT_NEXT in a comment

move uaddr_free_rbtree from RB macros to RBT functions

move the uvm_map_addr RB tree from RB macros to the RBT functions

this tree is interesting because it uses all the red black tree
features, specifically the augment callback thats called on tree
topology changes, and it poisons and checks entries as theyre removed
from and inserted back into the tree respectively.

ok stefan@

all pools have their ipl set via pool_setipl, so fold it into pool_init.

the ioff argument to pool_init() is unused and has been for many
years, so this replaces it with an ipl argument. because the ipl
will be set on init we no longer need pool_setipl.

most of these changes have been done with coccinelle using the spatch
below. cocci sucks at formatting code though, so i fixed that by hand.

the manpage and subr_pool.c bits i did myself.

ok tedu@ jmatthew@

@ipl@
expression pp;
expression ipl;
expression s, a, o, f, m, p;
@@
-pool_init(pp, s, a, o, f, m, p);
-pool_setipl(pp, ipl);
+pool_init(pp, s, a, ipl, f, m, p);

Mask out lower bits of randomly selected address

Fixes uvm pivots bug that would create non-page aligned addresses.
This fix is in code that's not yet enabled.

Add a few checks for potential integer overflow and underflow related to the
size of an address range.

ok deraadt@, tedu@

print the size when an unavailable address is returned. it is useful.
ok millert stefan

Sync no-argument function declaration and definition by adding (void).
ok mpi@ millert@

Release the kernel lock while tearing down the uvm map in the reaper. Speeds
up workloads that fork a lot of processes and, more importantly reduces
latency because it makes sure the reaper doesn't hold on to the kernel lock
for long periods of time.

This almost certainly breaks MP kernels on alpha, macppc, m88k and sgi;
hppa might work, but probably doesn't.

ok deraadt@, beck@

Extend uvm_map_hint() to get an address range as extra arguments, and make
sure it will return an address within that range.

Use this in uaddr_rnd_select() to make sure we will not attempt to pick
an address beyond what we are allowed to map.

In my trees for 9 months, blackmailed s2k15 attendees into agreeing now would
be a good time to commit.

#if 0 various unused definitions.

convert nointr pool_init argument to pr_waitok

move arc4random prototype to systm.h. more appropriate for most code
to include that than rdnvar.h. ok deraadt dlg

bzero -> memset

KNF

compress code by turning four line comments into one line comments.
emphatic ok usual suspects, grudging ok miod

reduce the length of some pool names. ok deraadt guenther mpi

comment typo; s/lineair/linear/

Fix address-space randomization that was accidentally disabled in
uvm_addr.c r1.3.

ok deraadt, tedu

vmmap: speed up allocations

Reduces O(n log n) allocations to O(log n).

ok deraadt, tedu

Reduce installmedia pressure from new vmmap.

Has less special allocators on install media (where they aren't required
anyway).
Bonus: makes the vmmap initialization code easier to read.

New vmmap implementation.

no oks (it is really a pain to review properly)
extensively tested, I'm confident it'll be stable
'now is the time' from several icb inhabitants

Diff provides:
- ability to specify different allocators for different regions/maps
- a simpler implementation of the current allocator
- currently in compatibility mode: it will generate similar addresses
as the old allocator

Assert the VM map lock is held in function used by mmap/mprotect/munmap.

Also grab the lock in uvm_map_teardown() and uvm_map_deallocate() to
satisfy the assertions. Grabbing the lock there shouldn't be strictly
necessary, because no other reference to the map should exist when the
reaper is holding it, but it doesn't hurt and makes our life easier.

Inputs & tests from Ivo van der Sangen, tb@, gnezdo@, kn@

kettenis@ and tb@ agree with the direction, ok kn@

interting -> inserting

Sync some comments in order to reduce the difference with NetBSD.

No functionnal change.

ok kettenis@

Spell inline correctly.

Reduce differences with NetBSD.

ok mvs@, kettenis@

Include <sys/systm.h> directly instead of relying on uvm_map.h to pull it.

Avoid overflow in constraint computation; ok kettenis@ tb@

- Make rnd hints avoid the brk area. The rnd allocator refuses to allocate in
the brk area anyway.
- Use a larger hint bound to spread the allocations more for the 32-bit case
- Simplified the overy abstracted brs/stack allocator and switch of
guard pages for the brk case. This allows i386 some extra space,
depending on memory usage patterns.
- Reduce brk area on i386 to give the rnd space more room

ok stefan@ sthen@

Fix stop condition for linear search by taking into account the search
direction, otherwise we might break the loop prematurely; ok stefan@

Move static function to the bottom of the file, to the only user
of that function, to guard it with SMALL_KERNEL.

ok mpi@

Remove uaddr_hint allocator

The hint allocator would have to check that the
allocation does not overlap with brk, stack or text
areas. This would make the address selectors too
entagled. Just use the rnd allocator for hinted allocations
in case pivots are used. This also reduces the amount of code somewhat.

ok kettenis visa deraadt

fix spelling of RBT_NEXT in a comment

move uaddr_free_rbtree from RB macros to RBT functions

move the uvm_map_addr RB tree from RB macros to the RBT functions

this tree is interesting because it uses all the red black tree
features, specifically the augment callback thats called on tree
topology changes, and it poisons and checks entries as theyre removed
from and inserted back into the tree respectively.

ok stefan@

all pools have their ipl set via pool_setipl, so fold it into pool_init.

the ioff argument to pool_init() is unused and has been for many
years, so this replaces it with an ipl argument. because the ipl
will be set on init we no longer need pool_setipl.

most of these changes have been done with coccinelle using the spatch
below. cocci sucks at formatting code though, so i fixed that by hand.

the manpage and subr_pool.c bits i did myself.

ok tedu@ jmatthew@

@ipl@
expression pp;
expression ipl;
expression s, a, o, f, m, p;
@@
-pool_init(pp, s, a, o, f, m, p);
-pool_setipl(pp, ipl);
+pool_init(pp, s, a, ipl, f, m, p);

Mask out lower bits of randomly selected address

Fixes uvm pivots bug that would create non-page aligned addresses.
This fix is in code that's not yet enabled.

Add a few checks for potential integer overflow and underflow related to the
size of an address range.

ok deraadt@, tedu@

print the size when an unavailable address is returned. it is useful.
ok millert stefan

Sync no-argument function declaration and definition by adding (void).
ok mpi@ millert@

Release the kernel lock while tearing down the uvm map in the reaper. Speeds
up workloads that fork a lot of processes and, more importantly reduces
latency because it makes sure the reaper doesn't hold on to the kernel lock
for long periods of time.

This almost certainly breaks MP kernels on alpha, macppc, m88k and sgi;
hppa might work, but probably doesn't.

ok deraadt@, beck@

Extend uvm_map_hint() to get an address range as extra arguments, and make
sure it will return an address within that range.

Use this in uaddr_rnd_select() to make sure we will not attempt to pick
an address beyond what we are allowed to map.

In my trees for 9 months, blackmailed s2k15 attendees into agreeing now would
be a good time to commit.

#if 0 various unused definitions.

convert nointr pool_init argument to pr_waitok

move arc4random prototype to systm.h. more appropriate for most code
to include that than rdnvar.h. ok deraadt dlg

bzero -> memset

KNF

compress code by turning four line comments into one line comments.
emphatic ok usual suspects, grudging ok miod

reduce the length of some pool names. ok deraadt guenther mpi

comment typo; s/lineair/linear/

Fix address-space randomization that was accidentally disabled in
uvm_addr.c r1.3.

ok deraadt, tedu

vmmap: speed up allocations

Reduces O(n log n) allocations to O(log n).

ok deraadt, tedu

Reduce installmedia pressure from new vmmap.

Has less special allocators on install media (where they aren't required
anyway).
Bonus: makes the vmmap initialization code easier to read.

New vmmap implementation.

no oks (it is really a pain to review properly)
extensively tested, I'm confident it'll be stable
'now is the time' from several icb inhabitants

Diff provides:
- ability to specify different allocators for different regions/maps
- a simpler implementation of the current allocator
- currently in compatibility mode: it will generate similar addresses
as the old allocator

interting -> inserting

Sync some comments in order to reduce the difference with NetBSD.

No functionnal change.

ok kettenis@

Spell inline correctly.

Reduce differences with NetBSD.

ok mvs@, kettenis@

Include <sys/systm.h> directly instead of relying on uvm_map.h to pull it.

Avoid overflow in constraint computation; ok kettenis@ tb@

- Make rnd hints avoid the brk area. The rnd allocator refuses to allocate in
the brk area anyway.
- Use a larger hint bound to spread the allocations more for the 32-bit case
- Simplified the overy abstracted brs/stack allocator and switch of
guard pages for the brk case. This allows i386 some extra space,
depending on memory usage patterns.
- Reduce brk area on i386 to give the rnd space more room

ok stefan@ sthen@

Fix stop condition for linear search by taking into account the search
direction, otherwise we might break the loop prematurely; ok stefan@

Move static function to the bottom of the file, to the only user
of that function, to guard it with SMALL_KERNEL.

ok mpi@

Remove uaddr_hint allocator

The hint allocator would have to check that the
allocation does not overlap with brk, stack or text
areas. This would make the address selectors too
entagled. Just use the rnd allocator for hinted allocations
in case pivots are used. This also reduces the amount of code somewhat.

ok kettenis visa deraadt

fix spelling of RBT_NEXT in a comment

move uaddr_free_rbtree from RB macros to RBT functions

move the uvm_map_addr RB tree from RB macros to the RBT functions

this tree is interesting because it uses all the red black tree
features, specifically the augment callback thats called on tree
topology changes, and it poisons and checks entries as theyre removed
from and inserted back into the tree respectively.

ok stefan@

all pools have their ipl set via pool_setipl, so fold it into pool_init.

the ioff argument to pool_init() is unused and has been for many
years, so this replaces it with an ipl argument. because the ipl
will be set on init we no longer need pool_setipl.

most of these changes have been done with coccinelle using the spatch
below. cocci sucks at formatting code though, so i fixed that by hand.

the manpage and subr_pool.c bits i did myself.

ok tedu@ jmatthew@

@ipl@
expression pp;
expression ipl;
expression s, a, o, f, m, p;
@@
-pool_init(pp, s, a, o, f, m, p);
-pool_setipl(pp, ipl);
+pool_init(pp, s, a, ipl, f, m, p);

Mask out lower bits of randomly selected address

Fixes uvm pivots bug that would create non-page aligned addresses.
This fix is in code that's not yet enabled.

Add a few checks for potential integer overflow and underflow related to the
size of an address range.

ok deraadt@, tedu@

print the size when an unavailable address is returned. it is useful.
ok millert stefan

Sync no-argument function declaration and definition by adding (void).
ok mpi@ millert@

Release the kernel lock while tearing down the uvm map in the reaper. Speeds
up workloads that fork a lot of processes and, more importantly reduces
latency because it makes sure the reaper doesn't hold on to the kernel lock
for long periods of time.

This almost certainly breaks MP kernels on alpha, macppc, m88k and sgi;
hppa might work, but probably doesn't.

ok deraadt@, beck@

Extend uvm_map_hint() to get an address range as extra arguments, and make
sure it will return an address within that range.

Use this in uaddr_rnd_select() to make sure we will not attempt to pick
an address beyond what we are allowed to map.

In my trees for 9 months, blackmailed s2k15 attendees into agreeing now would
be a good time to commit.

#if 0 various unused definitions.

convert nointr pool_init argument to pr_waitok

move arc4random prototype to systm.h. more appropriate for most code
to include that than rdnvar.h. ok deraadt dlg

bzero -> memset

KNF

compress code by turning four line comments into one line comments.
emphatic ok usual suspects, grudging ok miod

reduce the length of some pool names. ok deraadt guenther mpi

comment typo; s/lineair/linear/

Fix address-space randomization that was accidentally disabled in
uvm_addr.c r1.3.

ok deraadt, tedu

vmmap: speed up allocations

Reduces O(n log n) allocations to O(log n).

ok deraadt, tedu

Reduce installmedia pressure from new vmmap.

Has less special allocators on install media (where they aren't required
anyway).
Bonus: makes the vmmap initialization code easier to read.

New vmmap implementation.

no oks (it is really a pain to review properly)
extensively tested, I'm confident it'll be stable
'now is the time' from several icb inhabitants

Diff provides:
- ability to specify different allocators for different regions/maps
- a simpler implementation of the current allocator
- currently in compatibility mode: it will generate similar addresses
as the old allocator

Sync some comments in order to reduce the difference with NetBSD.

No functionnal change.

ok kettenis@

Spell inline correctly.

Reduce differences with NetBSD.

ok mvs@, kettenis@

Include <sys/systm.h> directly instead of relying on uvm_map.h to pull it.

Avoid overflow in constraint computation; ok kettenis@ tb@

- Make rnd hints avoid the brk area. The rnd allocator refuses to allocate in
the brk area anyway.
- Use a larger hint bound to spread the allocations more for the 32-bit case
- Simplified the overy abstracted brs/stack allocator and switch of
guard pages for the brk case. This allows i386 some extra space,
depending on memory usage patterns.
- Reduce brk area on i386 to give the rnd space more room

ok stefan@ sthen@

Fix stop condition for linear search by taking into account the search
direction, otherwise we might break the loop prematurely; ok stefan@

Move static function to the bottom of the file, to the only user
of that function, to guard it with SMALL_KERNEL.

ok mpi@

Remove uaddr_hint allocator

The hint allocator would have to check that the
allocation does not overlap with brk, stack or text
areas. This would make the address selectors too
entagled. Just use the rnd allocator for hinted allocations
in case pivots are used. This also reduces the amount of code somewhat.

ok kettenis visa deraadt

fix spelling of RBT_NEXT in a comment

move uaddr_free_rbtree from RB macros to RBT functions

move the uvm_map_addr RB tree from RB macros to the RBT functions

this tree is interesting because it uses all the red black tree
features, specifically the augment callback thats called on tree
topology changes, and it poisons and checks entries as theyre removed
from and inserted back into the tree respectively.

ok stefan@

all pools have their ipl set via pool_setipl, so fold it into pool_init.

the ioff argument to pool_init() is unused and has been for many
years, so this replaces it with an ipl argument. because the ipl
will be set on init we no longer need pool_setipl.

most of these changes have been done with coccinelle using the spatch
below. cocci sucks at formatting code though, so i fixed that by hand.

the manpage and subr_pool.c bits i did myself.

ok tedu@ jmatthew@

@ipl@
expression pp;
expression ipl;
expression s, a, o, f, m, p;
@@
-pool_init(pp, s, a, o, f, m, p);
-pool_setipl(pp, ipl);
+pool_init(pp, s, a, ipl, f, m, p);

Mask out lower bits of randomly selected address

Fixes uvm pivots bug that would create non-page aligned addresses.
This fix is in code that's not yet enabled.

Add a few checks for potential integer overflow and underflow related to the
size of an address range.

ok deraadt@, tedu@

print the size when an unavailable address is returned. it is useful.
ok millert stefan

Sync no-argument function declaration and definition by adding (void).
ok mpi@ millert@

Release the kernel lock while tearing down the uvm map in the reaper. Speeds
up workloads that fork a lot of processes and, more importantly reduces
latency because it makes sure the reaper doesn't hold on to the kernel lock
for long periods of time.

This almost certainly breaks MP kernels on alpha, macppc, m88k and sgi;
hppa might work, but probably doesn't.

ok deraadt@, beck@

Extend uvm_map_hint() to get an address range as extra arguments, and make
sure it will return an address within that range.

Use this in uaddr_rnd_select() to make sure we will not attempt to pick
an address beyond what we are allowed to map.

In my trees for 9 months, blackmailed s2k15 attendees into agreeing now would
be a good time to commit.

#if 0 various unused definitions.

convert nointr pool_init argument to pr_waitok

move arc4random prototype to systm.h. more appropriate for most code
to include that than rdnvar.h. ok deraadt dlg

bzero -> memset

KNF

compress code by turning four line comments into one line comments.
emphatic ok usual suspects, grudging ok miod

reduce the length of some pool names. ok deraadt guenther mpi

comment typo; s/lineair/linear/

Fix address-space randomization that was accidentally disabled in
uvm_addr.c r1.3.

ok deraadt, tedu

vmmap: speed up allocations

Reduces O(n log n) allocations to O(log n).

ok deraadt, tedu

Reduce installmedia pressure from new vmmap.

Has less special allocators on install media (where they aren't required
anyway).
Bonus: makes the vmmap initialization code easier to read.

New vmmap implementation.

no oks (it is really a pain to review properly)
extensively tested, I'm confident it'll be stable
'now is the time' from several icb inhabitants

Diff provides:
- ability to specify different allocators for different regions/maps
- a simpler implementation of the current allocator
- currently in compatibility mode: it will generate similar addresses
as the old allocator

Spell inline correctly.

Reduce differences with NetBSD.

ok mvs@, kettenis@

Include <sys/systm.h> directly instead of relying on uvm_map.h to pull it.

Avoid overflow in constraint computation; ok kettenis@ tb@

- Make rnd hints avoid the brk area. The rnd allocator refuses to allocate in
the brk area anyway.
- Use a larger hint bound to spread the allocations more for the 32-bit case
- Simplified the overy abstracted brs/stack allocator and switch of
guard pages for the brk case. This allows i386 some extra space,
depending on memory usage patterns.
- Reduce brk area on i386 to give the rnd space more room

ok stefan@ sthen@

Fix stop condition for linear search by taking into account the search
direction, otherwise we might break the loop prematurely; ok stefan@

Move static function to the bottom of the file, to the only user
of that function, to guard it with SMALL_KERNEL.

ok mpi@

Remove uaddr_hint allocator

The hint allocator would have to check that the
allocation does not overlap with brk, stack or text
areas. This would make the address selectors too
entagled. Just use the rnd allocator for hinted allocations
in case pivots are used. This also reduces the amount of code somewhat.

ok kettenis visa deraadt

fix spelling of RBT_NEXT in a comment

move uaddr_free_rbtree from RB macros to RBT functions

move the uvm_map_addr RB tree from RB macros to the RBT functions

this tree is interesting because it uses all the red black tree
features, specifically the augment callback thats called on tree
topology changes, and it poisons and checks entries as theyre removed
from and inserted back into the tree respectively.

ok stefan@

all pools have their ipl set via pool_setipl, so fold it into pool_init.

the ioff argument to pool_init() is unused and has been for many
years, so this replaces it with an ipl argument. because the ipl
will be set on init we no longer need pool_setipl.

most of these changes have been done with coccinelle using the spatch
below. cocci sucks at formatting code though, so i fixed that by hand.

the manpage and subr_pool.c bits i did myself.

ok tedu@ jmatthew@

@ipl@
expression pp;
expression ipl;
expression s, a, o, f, m, p;
@@
-pool_init(pp, s, a, o, f, m, p);
-pool_setipl(pp, ipl);
+pool_init(pp, s, a, ipl, f, m, p);

Mask out lower bits of randomly selected address

Fixes uvm pivots bug that would create non-page aligned addresses.
This fix is in code that's not yet enabled.

Add a few checks for potential integer overflow and underflow related to the
size of an address range.

ok deraadt@, tedu@

print the size when an unavailable address is returned. it is useful.
ok millert stefan

Sync no-argument function declaration and definition by adding (void).
ok mpi@ millert@

Release the kernel lock while tearing down the uvm map in the reaper. Speeds
up workloads that fork a lot of processes and, more importantly reduces
latency because it makes sure the reaper doesn't hold on to the kernel lock
for long periods of time.

This almost certainly breaks MP kernels on alpha, macppc, m88k and sgi;
hppa might work, but probably doesn't.

ok deraadt@, beck@

Extend uvm_map_hint() to get an address range as extra arguments, and make
sure it will return an address within that range.

Use this in uaddr_rnd_select() to make sure we will not attempt to pick
an address beyond what we are allowed to map.

In my trees for 9 months, blackmailed s2k15 attendees into agreeing now would
be a good time to commit.

#if 0 various unused definitions.

convert nointr pool_init argument to pr_waitok

move arc4random prototype to systm.h. more appropriate for most code
to include that than rdnvar.h. ok deraadt dlg

bzero -> memset

KNF

compress code by turning four line comments into one line comments.
emphatic ok usual suspects, grudging ok miod

reduce the length of some pool names. ok deraadt guenther mpi

comment typo; s/lineair/linear/

Fix address-space randomization that was accidentally disabled in
uvm_addr.c r1.3.

ok deraadt, tedu

vmmap: speed up allocations

Reduces O(n log n) allocations to O(log n).

ok deraadt, tedu

Reduce installmedia pressure from new vmmap.

Has less special allocators on install media (where they aren't required
anyway).
Bonus: makes the vmmap initialization code easier to read.

New vmmap implementation.

no oks (it is really a pain to review properly)
extensively tested, I'm confident it'll be stable
'now is the time' from several icb inhabitants

Diff provides:
- ability to specify different allocators for different regions/maps
- a simpler implementation of the current allocator
- currently in compatibility mode: it will generate similar addresses
as the old allocator

Include <sys/systm.h> directly instead of relying on uvm_map.h to pull it.

Avoid overflow in constraint computation; ok kettenis@ tb@

- Make rnd hints avoid the brk area. The rnd allocator refuses to allocate in
the brk area anyway.
- Use a larger hint bound to spread the allocations more for the 32-bit case
- Simplified the overy abstracted brs/stack allocator and switch of
guard pages for the brk case. This allows i386 some extra space,
depending on memory usage patterns.
- Reduce brk area on i386 to give the rnd space more room

ok stefan@ sthen@

Fix stop condition for linear search by taking into account the search
direction, otherwise we might break the loop prematurely; ok stefan@

Move static function to the bottom of the file, to the only user
of that function, to guard it with SMALL_KERNEL.

ok mpi@

Remove uaddr_hint allocator

The hint allocator would have to check that the
allocation does not overlap with brk, stack or text
areas. This would make the address selectors too
entagled. Just use the rnd allocator for hinted allocations
in case pivots are used. This also reduces the amount of code somewhat.

ok kettenis visa deraadt

fix spelling of RBT_NEXT in a comment

move uaddr_free_rbtree from RB macros to RBT functions

move the uvm_map_addr RB tree from RB macros to the RBT functions

this tree is interesting because it uses all the red black tree
features, specifically the augment callback thats called on tree
topology changes, and it poisons and checks entries as theyre removed
from and inserted back into the tree respectively.

ok stefan@

all pools have their ipl set via pool_setipl, so fold it into pool_init.

the ioff argument to pool_init() is unused and has been for many
years, so this replaces it with an ipl argument. because the ipl
will be set on init we no longer need pool_setipl.

most of these changes have been done with coccinelle using the spatch
below. cocci sucks at formatting code though, so i fixed that by hand.

the manpage and subr_pool.c bits i did myself.

ok tedu@ jmatthew@

@ipl@
expression pp;
expression ipl;
expression s, a, o, f, m, p;
@@
-pool_init(pp, s, a, o, f, m, p);
-pool_setipl(pp, ipl);
+pool_init(pp, s, a, ipl, f, m, p);

Mask out lower bits of randomly selected address

Fixes uvm pivots bug that would create non-page aligned addresses.
This fix is in code that's not yet enabled.

Add a few checks for potential integer overflow and underflow related to the
size of an address range.

ok deraadt@, tedu@

print the size when an unavailable address is returned. it is useful.
ok millert stefan

Sync no-argument function declaration and definition by adding (void).
ok mpi@ millert@

Release the kernel lock while tearing down the uvm map in the reaper. Speeds
up workloads that fork a lot of processes and, more importantly reduces
latency because it makes sure the reaper doesn't hold on to the kernel lock
for long periods of time.

This almost certainly breaks MP kernels on alpha, macppc, m88k and sgi;
hppa might work, but probably doesn't.

ok deraadt@, beck@

Extend uvm_map_hint() to get an address range as extra arguments, and make
sure it will return an address within that range.

Use this in uaddr_rnd_select() to make sure we will not attempt to pick
an address beyond what we are allowed to map.

In my trees for 9 months, blackmailed s2k15 attendees into agreeing now would
be a good time to commit.

#if 0 various unused definitions.

convert nointr pool_init argument to pr_waitok

move arc4random prototype to systm.h. more appropriate for most code
to include that than rdnvar.h. ok deraadt dlg

bzero -> memset

KNF

compress code by turning four line comments into one line comments.
emphatic ok usual suspects, grudging ok miod

reduce the length of some pool names. ok deraadt guenther mpi

comment typo; s/lineair/linear/

Fix address-space randomization that was accidentally disabled in
uvm_addr.c r1.3.

ok deraadt, tedu

vmmap: speed up allocations

Reduces O(n log n) allocations to O(log n).

ok deraadt, tedu

Reduce installmedia pressure from new vmmap.

Has less special allocators on install media (where they aren't required
anyway).
Bonus: makes the vmmap initialization code easier to read.

New vmmap implementation.

no oks (it is really a pain to review properly)
extensively tested, I'm confident it'll be stable
'now is the time' from several icb inhabitants

Diff provides:
- ability to specify different allocators for different regions/maps
- a simpler implementation of the current allocator
- currently in compatibility mode: it will generate similar addresses
as the old allocator

Avoid overflow in constraint computation; ok kettenis@ tb@

- Make rnd hints avoid the brk area. The rnd allocator refuses to allocate in
the brk area anyway.
- Use a larger hint bound to spread the allocations more for the 32-bit case
- Simplified the overy abstracted brs/stack allocator and switch of
guard pages for the brk case. This allows i386 some extra space,
depending on memory usage patterns.
- Reduce brk area on i386 to give the rnd space more room

ok stefan@ sthen@

Fix stop condition for linear search by taking into account the search
direction, otherwise we might break the loop prematurely; ok stefan@

Move static function to the bottom of the file, to the only user
of that function, to guard it with SMALL_KERNEL.

ok mpi@

Remove uaddr_hint allocator

The hint allocator would have to check that the
allocation does not overlap with brk, stack or text
areas. This would make the address selectors too
entagled. Just use the rnd allocator for hinted allocations
in case pivots are used. This also reduces the amount of code somewhat.

ok kettenis visa deraadt

fix spelling of RBT_NEXT in a comment

move uaddr_free_rbtree from RB macros to RBT functions

move the uvm_map_addr RB tree from RB macros to the RBT functions

this tree is interesting because it uses all the red black tree
features, specifically the augment callback thats called on tree
topology changes, and it poisons and checks entries as theyre removed
from and inserted back into the tree respectively.

ok stefan@

all pools have their ipl set via pool_setipl, so fold it into pool_init.

the ioff argument to pool_init() is unused and has been for many
years, so this replaces it with an ipl argument. because the ipl
will be set on init we no longer need pool_setipl.

most of these changes have been done with coccinelle using the spatch
below. cocci sucks at formatting code though, so i fixed that by hand.

the manpage and subr_pool.c bits i did myself.

ok tedu@ jmatthew@

@ipl@
expression pp;
expression ipl;
expression s, a, o, f, m, p;
@@
-pool_init(pp, s, a, o, f, m, p);
-pool_setipl(pp, ipl);
+pool_init(pp, s, a, ipl, f, m, p);

Mask out lower bits of randomly selected address

Fixes uvm pivots bug that would create non-page aligned addresses.
This fix is in code that's not yet enabled.

Add a few checks for potential integer overflow and underflow related to the
size of an address range.

ok deraadt@, tedu@

print the size when an unavailable address is returned. it is useful.
ok millert stefan

Sync no-argument function declaration and definition by adding (void).
ok mpi@ millert@

Release the kernel lock while tearing down the uvm map in the reaper. Speeds
up workloads that fork a lot of processes and, more importantly reduces
latency because it makes sure the reaper doesn't hold on to the kernel lock
for long periods of time.

This almost certainly breaks MP kernels on alpha, macppc, m88k and sgi;
hppa might work, but probably doesn't.

ok deraadt@, beck@

Extend uvm_map_hint() to get an address range as extra arguments, and make
sure it will return an address within that range.

Use this in uaddr_rnd_select() to make sure we will not attempt to pick
an address beyond what we are allowed to map.

In my trees for 9 months, blackmailed s2k15 attendees into agreeing now would
be a good time to commit.

#if 0 various unused definitions.

convert nointr pool_init argument to pr_waitok

move arc4random prototype to systm.h. more appropriate for most code
to include that than rdnvar.h. ok deraadt dlg

bzero -> memset

KNF

compress code by turning four line comments into one line comments.
emphatic ok usual suspects, grudging ok miod

reduce the length of some pool names. ok deraadt guenther mpi

comment typo; s/lineair/linear/

Fix address-space randomization that was accidentally disabled in
uvm_addr.c r1.3.

ok deraadt, tedu

vmmap: speed up allocations

Reduces O(n log n) allocations to O(log n).

ok deraadt, tedu

Reduce installmedia pressure from new vmmap.

Has less special allocators on install media (where they aren't required
anyway).
Bonus: makes the vmmap initialization code easier to read.

New vmmap implementation.

no oks (it is really a pain to review properly)
extensively tested, I'm confident it'll be stable
'now is the time' from several icb inhabitants

Diff provides:
- ability to specify different allocators for different regions/maps
- a simpler implementation of the current allocator
- currently in compatibility mode: it will generate similar addresses
as the old allocator

- Make rnd hints avoid the brk area. The rnd allocator refuses to allocate in
the brk area anyway.
- Use a larger hint bound to spread the allocations more for the 32-bit case
- Simplified the overy abstracted brs/stack allocator and switch of
guard pages for the brk case. This allows i386 some extra space,
depending on memory usage patterns.
- Reduce brk area on i386 to give the rnd space more room

ok stefan@ sthen@

Fix stop condition for linear search by taking into account the search
direction, otherwise we might break the loop prematurely; ok stefan@

Move static function to the bottom of the file, to the only user
of that function, to guard it with SMALL_KERNEL.

ok mpi@

Remove uaddr_hint allocator

The hint allocator would have to check that the
allocation does not overlap with brk, stack or text
areas. This would make the address selectors too
entagled. Just use the rnd allocator for hinted allocations
in case pivots are used. This also reduces the amount of code somewhat.

ok kettenis visa deraadt

fix spelling of RBT_NEXT in a comment

move uaddr_free_rbtree from RB macros to RBT functions

move the uvm_map_addr RB tree from RB macros to the RBT functions

this tree is interesting because it uses all the red black tree
features, specifically the augment callback thats called on tree
topology changes, and it poisons and checks entries as theyre removed
from and inserted back into the tree respectively.

ok stefan@

all pools have their ipl set via pool_setipl, so fold it into pool_init.

the ioff argument to pool_init() is unused and has been for many
years, so this replaces it with an ipl argument. because the ipl
will be set on init we no longer need pool_setipl.

most of these changes have been done with coccinelle using the spatch
below. cocci sucks at formatting code though, so i fixed that by hand.

the manpage and subr_pool.c bits i did myself.

ok tedu@ jmatthew@

@ipl@
expression pp;
expression ipl;
expression s, a, o, f, m, p;
@@
-pool_init(pp, s, a, o, f, m, p);
-pool_setipl(pp, ipl);
+pool_init(pp, s, a, ipl, f, m, p);

Mask out lower bits of randomly selected address

Fixes uvm pivots bug that would create non-page aligned addresses.
This fix is in code that's not yet enabled.

Add a few checks for potential integer overflow and underflow related to the
size of an address range.

ok deraadt@, tedu@

print the size when an unavailable address is returned. it is useful.
ok millert stefan

Sync no-argument function declaration and definition by adding (void).
ok mpi@ millert@

Release the kernel lock while tearing down the uvm map in the reaper. Speeds
up workloads that fork a lot of processes and, more importantly reduces
latency because it makes sure the reaper doesn't hold on to the kernel lock
for long periods of time.

This almost certainly breaks MP kernels on alpha, macppc, m88k and sgi;
hppa might work, but probably doesn't.

ok deraadt@, beck@

Extend uvm_map_hint() to get an address range as extra arguments, and make
sure it will return an address within that range.

Use this in uaddr_rnd_select() to make sure we will not attempt to pick
an address beyond what we are allowed to map.

In my trees for 9 months, blackmailed s2k15 attendees into agreeing now would
be a good time to commit.

#if 0 various unused definitions.

convert nointr pool_init argument to pr_waitok

move arc4random prototype to systm.h. more appropriate for most code
to include that than rdnvar.h. ok deraadt dlg

bzero -> memset

KNF

compress code by turning four line comments into one line comments.
emphatic ok usual suspects, grudging ok miod

reduce the length of some pool names. ok deraadt guenther mpi

comment typo; s/lineair/linear/

Fix address-space randomization that was accidentally disabled in
uvm_addr.c r1.3.

ok deraadt, tedu

vmmap: speed up allocations

Reduces O(n log n) allocations to O(log n).

ok deraadt, tedu

Reduce installmedia pressure from new vmmap.

Has less special allocators on install media (where they aren't required
anyway).
Bonus: makes the vmmap initialization code easier to read.

New vmmap implementation.

no oks (it is really a pain to review properly)
extensively tested, I'm confident it'll be stable
'now is the time' from several icb inhabitants

Diff provides:
- ability to specify different allocators for different regions/maps
- a simpler implementation of the current allocator
- currently in compatibility mode: it will generate similar addresses
as the old allocator

Move static function to the bottom of the file, to the only user
of that function, to guard it with SMALL_KERNEL.

ok mpi@

Remove uaddr_hint allocator

The hint allocator would have to check that the
allocation does not overlap with brk, stack or text
areas. This would make the address selectors too
entagled. Just use the rnd allocator for hinted allocations
in case pivots are used. This also reduces the amount of code somewhat.

ok kettenis visa deraadt

fix spelling of RBT_NEXT in a comment

move uaddr_free_rbtree from RB macros to RBT functions

move the uvm_map_addr RB tree from RB macros to the RBT functions

this tree is interesting because it uses all the red black tree
features, specifically the augment callback thats called on tree
topology changes, and it poisons and checks entries as theyre removed
from and inserted back into the tree respectively.

ok stefan@

all pools have their ipl set via pool_setipl, so fold it into pool_init.

the ioff argument to pool_init() is unused and has been for many
years, so this replaces it with an ipl argument. because the ipl
will be set on init we no longer need pool_setipl.

most of these changes have been done with coccinelle using the spatch
below. cocci sucks at formatting code though, so i fixed that by hand.

the manpage and subr_pool.c bits i did myself.

ok tedu@ jmatthew@

@ipl@
expression pp;
expression ipl;
expression s, a, o, f, m, p;
@@
-pool_init(pp, s, a, o, f, m, p);
-pool_setipl(pp, ipl);
+pool_init(pp, s, a, ipl, f, m, p);

Mask out lower bits of randomly selected address

Fixes uvm pivots bug that would create non-page aligned addresses.
This fix is in code that's not yet enabled.

Add a few checks for potential integer overflow and underflow related to the
size of an address range.

ok deraadt@, tedu@

print the size when an unavailable address is returned. it is useful.
ok millert stefan

Sync no-argument function declaration and definition by adding (void).
ok mpi@ millert@

Release the kernel lock while tearing down the uvm map in the reaper. Speeds
up workloads that fork a lot of processes and, more importantly reduces
latency because it makes sure the reaper doesn't hold on to the kernel lock
for long periods of time.

This almost certainly breaks MP kernels on alpha, macppc, m88k and sgi;
hppa might work, but probably doesn't.

ok deraadt@, beck@

Extend uvm_map_hint() to get an address range as extra arguments, and make
sure it will return an address within that range.

Use this in uaddr_rnd_select() to make sure we will not attempt to pick
an address beyond what we are allowed to map.

In my trees for 9 months, blackmailed s2k15 attendees into agreeing now would
be a good time to commit.

#if 0 various unused definitions.

convert nointr pool_init argument to pr_waitok

move arc4random prototype to systm.h. more appropriate for most code
to include that than rdnvar.h. ok deraadt dlg

bzero -> memset

KNF

compress code by turning four line comments into one line comments.
emphatic ok usual suspects, grudging ok miod

reduce the length of some pool names. ok deraadt guenther mpi

comment typo; s/lineair/linear/

Fix address-space randomization that was accidentally disabled in
uvm_addr.c r1.3.

ok deraadt, tedu

vmmap: speed up allocations

Reduces O(n log n) allocations to O(log n).

ok deraadt, tedu

Reduce installmedia pressure from new vmmap.

Has less special allocators on install media (where they aren't required
anyway).
Bonus: makes the vmmap initialization code easier to read.

New vmmap implementation.

no oks (it is really a pain to review properly)
extensively tested, I'm confident it'll be stable
'now is the time' from several icb inhabitants

Diff provides:
- ability to specify different allocators for different regions/maps
- a simpler implementation of the current allocator
- currently in compatibility mode: it will generate similar addresses
as the old allocator