Convert all the NFS macros (in nfsm_subs.h) into inline functions with the
appropriate extra arguments.

This (hopefully) completes the unmessyfication work started by thib@ a long,
long time ago (in a galaxy far away).

The conversion logic has been:
- nfsm_dissect has been turned into an rvalue expression, leaving the
cast operation up to its caller.
- macros which had three different exit paths (return, goto nfsmout or
fallthrough) have been split so that no macros have more than two exit paths.
- then they have been modified to return a value, which lets the caller
figure out what exit path is needed.
- local variables abused by the macros are now local variables of the new
inline functions.

This single commit is the sum of 25 intermediate diffs, which have all been
carefully reviewed by (at least) jsg@ and semarie@.

Tested with v2 and v3 servers and clients.

ok jsg@ semarie@

Check for negative length in NFS strings. This affects both, the
client and server.
OK beck@

branches: 1.46.2;
Nuke unused define 'nfsm_writereply()'.

ok beck@ deraadt@ guenther@ mpi@

branches: 1.45.6;
fix ugly indents; no harmful macros harmed

delete a whole mess of unnecessary caddr_t casts

The only caller of NFSMSIZ got changed yesterday, so remove it.

High five from thib@

set the mrq pointer (request) in the nfsm_reply() macro, as we can return from it.
This can cause us to follow garbage in the nfsd loop, causing two kinds of hell.

problem noticed by nicm@. OK blambert@.

group all of the on-stack variables that are uses by the nfsm_macros
to keep the data munging "state" into an nfsm_info structure. Each
function now has this structure on its stack, and it and its members
are now passed around so that the macros/functions can work there magic.

this will make removing the nfsm_* macros way easier.

Idea/code picked up from DragonflyBSD.

Tested by krw@, jacekm@ and myself.

OK blambert@.

make sure we only ever try to read out post-op attributes
or wcc data if we have a proper reply.

found the hard way by ariane@, tested by ariane@.

OK blambert@

(struct foo *)0 -> NULL, every where I could find it.

OK blambert@

turdshine previous

- make this a lot more readable; no binary change

ok thib@

Demacro nfsm_lookup for great justice.

Thanks to ckuethe for saving much typing with a drive-by perl script.

ok thib@

Convert macros to functions to reduce kernel memory usage.

In snaps for a while (way too long, according to deraadt@)

Convert a sizeable macro to a much-leaner function. Saves (IIRC) 5k on i386.

In snaps for a while.

Use a timespec instead of a time_t for the clients nfsnode
mtime, gives us better granularity, helps with cache consistency.

Idea lifted from NetBSD.

OK blambert@

Low hanging macro fruit. Inline the nfsm_srvstrsiz macro since
its used only once and nuke its definition.

Stolen from blambert's bag'o'diffs.

OK blambert@.

unroll the NFSMADV() macro and nuke it

ok blambert@

Replace nfsm_build/bcopy with nfsm_{buf,str}tombuf functions in
filehandle -> mbuf write macros.

Removes `magic' variable cp which was used only in these macros,
and should lead to marginally better mbuf packing as well.

`slap it in' thib@

Kill one-liner macro which obfuscated mbuf pointer assignment.

Rescue nfsm_reqhead macro name and rename nfsm_reqh.

End of one-liners from nfsm_subs.h.

ok thib@

Replace one-line macro which only obfuscated the fact that
the function it was named after took 4 arguments instead of 2.

"get it in; get it in; get it in" thib@

Remove now-vestigial bpos pointer from NFS. For building outgoing
NFS mbufs, mbufs now contain all their internal buffer state internally,
the way god intended.

ok thib@

testing johan@ (and possibly merdely@; this diff's been around for a bit...)

Remove bloated and nasty nfsm_clget macro; while here, replace some
handrolled loops with nfsm_strtombuf and nfsm_buftombuf.

ok deraadt@ via thib@; ok 'nfs buddy' thib@
testing johan@, merdely@; thanks

Rework NFS mbuf write routines:

nfsm_uiotombuf():
- no meaningful return, function becomes void
- replace frankensteined uiomove/MGET with actual call to uiomove

nfsm_strtmbuf():
- no meaningful return, becomes void
- rename and reorder parameters to be consistent with other functions
- becomes wrapper to nfsm_uiotombuf

nfsm_buftombuf():
- new function; unused but slated for future use
- wrapper to nfsm_uiotombuf

As a bonus, making these functions void removes much unneeded code and
garbage collects `magic' variable t2 which was only used (invisibly)
by the macros from nfsm_subs.h

Preps the way for removing much more NFS goo...

testing by myself, thib@ and merdely@
ok thib@

More NFS-related kernel shrinkage...

When you use a macro ~200 times, it tends to bloat your code, so make a
function out of it.

Shaves ~8.5 kB from my kernel.

ok thib@, "looks good" krw@

In snaps for 1+ week with no negative reports.

convert massive (expanded to 150+ lines) nfsm_v3attr macro to a function

shaves an insane (~8K) amount from an i386 kernel

ok thib@

more low hanging fruit; Expand the nfsm_srvwcc_data() macro
and nuke it's definition.

OK krw@, blamers@

Expand the nfsm_srvfillattr() macro and
nuke it's definition.

OK krw@, blambert@

remove an unused macro, NFSMINOFF;

ok beck@, blambert@
"Kill it. Kill it dead." krw@

Remove the "frev" argument from nfs_rephead(); and clean up the "frev"
variables, that are declared all over, since they are passed via macros
to nfs_rephead(); which doesn't do anything with it.

OK krw@

nfsm_uiotom macro does nothing but hide error-handling code; replace
inline in the one place that it's called

ok thib@, weingart@
"I don't see why not" fgsch@

Replace nfsm_reqdone and nfsm_srvdone macros inline. No binary change.

ok thib@

When setting timestamps TOSERVER having write permissions is adaquate;
problem experienced by Han Boetes; fix with "nfs4" rick at snowhite
dot cis dot uoguelph dot ca. ok pedro@ tedu@

This moves access to wall and uptime variables in MI code,
encapsulating all such access into wall-defined functions
that makes sure locking is done as needed.

It also cleans up some uses of wall time vs. uptime some
places, but there is sure to be more of these needed as
well, particularily in MD code. Also, many current calls
to microtime() should probably be changed to getmicrotime(),
or to the {,get}microuptime() versions.

ok art@ deraadt@ aaron@ matthieu@ beck@ sturm@ millert@ others
"Oh, that is not your problem!" from miod@

First step towards more sane time handling in the kernel -- this changes
things such that code that only need a second-resolution uptime or wall
time, and used to get that from time.tv_secs or mono_time.tv_secs now get
this from separate time_t globals time_second and time_uptime.

ok art@ niklas@ nordin@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Remove unused function parameter 'cache' from nfs_rephead
ok costa@

branches: 1.11.2; 1.11.12;
In the NFSMSIZ macro, don't assume that m_ext.ext_size == MCLBYTES.
From NetBSD

Use bitwise operations to extract high and low words from the quad
in txdr_hyper. This should be more portable than casting to an array
of ints and pulling out the two 32-bit words (this produced incorrect
results on alpha for the high word for filesystems < 4gig). As a side
effect, txdr_hyper now takes a u_quad_t as its first arg, not u_quad_t *.

Fix for creating files on a Solaris 7 server with NFSv3 (the request was
slightly garbled but older servers seemed to understand it); dfr@freebsd.org

Change fxdr_hyper to return a u_quad_t. This minimizes the evil clobbering
of lvalues that ANSI abhors.

And it fixes df on NFS version 3 mounts on Sparcs.

OpenBSD tag

partial sync with netbsd 960418, more to come

Minor cleanups. Checked against Lite2.
(NetBSD's was really just a Lite2's, but w/ 64bit support)

From NetBSD: NFSv3 import (tomorrow's Net's kernel)
Open's patches kept in. i'll possibly take a look at Lite2 soon,
is there smth usefull ?..

From NetBSD: merge with 960217 (still NFSv2)

from cgd; handle 64-bit pointers and longs

branches: 1.1.1;
Initial revision

Check for negative length in NFS strings. This affects both, the
client and server.
OK beck@

Nuke unused define 'nfsm_writereply()'.

ok beck@ deraadt@ guenther@ mpi@

fix ugly indents; no harmful macros harmed

delete a whole mess of unnecessary caddr_t casts

The only caller of NFSMSIZ got changed yesterday, so remove it.

High five from thib@

set the mrq pointer (request) in the nfsm_reply() macro, as we can return from it.
This can cause us to follow garbage in the nfsd loop, causing two kinds of hell.

problem noticed by nicm@. OK blambert@.

group all of the on-stack variables that are uses by the nfsm_macros
to keep the data munging "state" into an nfsm_info structure. Each
function now has this structure on its stack, and it and its members
are now passed around so that the macros/functions can work there magic.

this will make removing the nfsm_* macros way easier.

Idea/code picked up from DragonflyBSD.

Tested by krw@, jacekm@ and myself.

OK blambert@.

make sure we only ever try to read out post-op attributes
or wcc data if we have a proper reply.

found the hard way by ariane@, tested by ariane@.

OK blambert@

(struct foo *)0 -> NULL, every where I could find it.

OK blambert@

turdshine previous

- make this a lot more readable; no binary change

ok thib@

Demacro nfsm_lookup for great justice.

Thanks to ckuethe for saving much typing with a drive-by perl script.

ok thib@

Convert macros to functions to reduce kernel memory usage.

In snaps for a while (way too long, according to deraadt@)

Convert a sizeable macro to a much-leaner function. Saves (IIRC) 5k on i386.

In snaps for a while.

Use a timespec instead of a time_t for the clients nfsnode
mtime, gives us better granularity, helps with cache consistency.

Idea lifted from NetBSD.

OK blambert@

Low hanging macro fruit. Inline the nfsm_srvstrsiz macro since
its used only once and nuke its definition.

Stolen from blambert's bag'o'diffs.

OK blambert@.

unroll the NFSMADV() macro and nuke it

ok blambert@

Replace nfsm_build/bcopy with nfsm_{buf,str}tombuf functions in
filehandle -> mbuf write macros.

Removes `magic' variable cp which was used only in these macros,
and should lead to marginally better mbuf packing as well.

`slap it in' thib@

Kill one-liner macro which obfuscated mbuf pointer assignment.

Rescue nfsm_reqhead macro name and rename nfsm_reqh.

End of one-liners from nfsm_subs.h.

ok thib@

Replace one-line macro which only obfuscated the fact that
the function it was named after took 4 arguments instead of 2.

"get it in; get it in; get it in" thib@

Remove now-vestigial bpos pointer from NFS. For building outgoing
NFS mbufs, mbufs now contain all their internal buffer state internally,
the way god intended.

ok thib@

testing johan@ (and possibly merdely@; this diff's been around for a bit...)

Remove bloated and nasty nfsm_clget macro; while here, replace some
handrolled loops with nfsm_strtombuf and nfsm_buftombuf.

ok deraadt@ via thib@; ok 'nfs buddy' thib@
testing johan@, merdely@; thanks

Rework NFS mbuf write routines:

nfsm_uiotombuf():
- no meaningful return, function becomes void
- replace frankensteined uiomove/MGET with actual call to uiomove

nfsm_strtmbuf():
- no meaningful return, becomes void
- rename and reorder parameters to be consistent with other functions
- becomes wrapper to nfsm_uiotombuf

nfsm_buftombuf():
- new function; unused but slated for future use
- wrapper to nfsm_uiotombuf

As a bonus, making these functions void removes much unneeded code and
garbage collects `magic' variable t2 which was only used (invisibly)
by the macros from nfsm_subs.h

Preps the way for removing much more NFS goo...

testing by myself, thib@ and merdely@
ok thib@

More NFS-related kernel shrinkage...

When you use a macro ~200 times, it tends to bloat your code, so make a
function out of it.

Shaves ~8.5 kB from my kernel.

ok thib@, "looks good" krw@

In snaps for 1+ week with no negative reports.

convert massive (expanded to 150+ lines) nfsm_v3attr macro to a function

shaves an insane (~8K) amount from an i386 kernel

ok thib@

more low hanging fruit; Expand the nfsm_srvwcc_data() macro
and nuke it's definition.

OK krw@, blamers@

Expand the nfsm_srvfillattr() macro and
nuke it's definition.

OK krw@, blambert@

remove an unused macro, NFSMINOFF;

ok beck@, blambert@
"Kill it. Kill it dead." krw@

Remove the "frev" argument from nfs_rephead(); and clean up the "frev"
variables, that are declared all over, since they are passed via macros
to nfs_rephead(); which doesn't do anything with it.

OK krw@

nfsm_uiotom macro does nothing but hide error-handling code; replace
inline in the one place that it's called

ok thib@, weingart@
"I don't see why not" fgsch@

Replace nfsm_reqdone and nfsm_srvdone macros inline. No binary change.

ok thib@

When setting timestamps TOSERVER having write permissions is adaquate;
problem experienced by Han Boetes; fix with "nfs4" rick at snowhite
dot cis dot uoguelph dot ca. ok pedro@ tedu@

This moves access to wall and uptime variables in MI code,
encapsulating all such access into wall-defined functions
that makes sure locking is done as needed.

It also cleans up some uses of wall time vs. uptime some
places, but there is sure to be more of these needed as
well, particularily in MD code. Also, many current calls
to microtime() should probably be changed to getmicrotime(),
or to the {,get}microuptime() versions.

ok art@ deraadt@ aaron@ matthieu@ beck@ sturm@ millert@ others
"Oh, that is not your problem!" from miod@

First step towards more sane time handling in the kernel -- this changes
things such that code that only need a second-resolution uptime or wall
time, and used to get that from time.tv_secs or mono_time.tv_secs now get
this from separate time_t globals time_second and time_uptime.

ok art@ niklas@ nordin@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Remove unused function parameter 'cache' from nfs_rephead
ok costa@

branches: 1.11.2; 1.11.12;
In the NFSMSIZ macro, don't assume that m_ext.ext_size == MCLBYTES.
From NetBSD

Use bitwise operations to extract high and low words from the quad
in txdr_hyper. This should be more portable than casting to an array
of ints and pulling out the two 32-bit words (this produced incorrect
results on alpha for the high word for filesystems < 4gig). As a side
effect, txdr_hyper now takes a u_quad_t as its first arg, not u_quad_t *.

Fix for creating files on a Solaris 7 server with NFSv3 (the request was
slightly garbled but older servers seemed to understand it); dfr@freebsd.org

Change fxdr_hyper to return a u_quad_t. This minimizes the evil clobbering
of lvalues that ANSI abhors.

And it fixes df on NFS version 3 mounts on Sparcs.

OpenBSD tag

partial sync with netbsd 960418, more to come

Minor cleanups. Checked against Lite2.
(NetBSD's was really just a Lite2's, but w/ 64bit support)

From NetBSD: NFSv3 import (tomorrow's Net's kernel)
Open's patches kept in. i'll possibly take a look at Lite2 soon,
is there smth usefull ?..

From NetBSD: merge with 960217 (still NFSv2)

from cgd; handle 64-bit pointers and longs

branches: 1.1.1;
Initial revision

Nuke unused define 'nfsm_writereply()'.

ok beck@ deraadt@ guenther@ mpi@

fix ugly indents; no harmful macros harmed

delete a whole mess of unnecessary caddr_t casts

The only caller of NFSMSIZ got changed yesterday, so remove it.

High five from thib@

set the mrq pointer (request) in the nfsm_reply() macro, as we can return from it.
This can cause us to follow garbage in the nfsd loop, causing two kinds of hell.

problem noticed by nicm@. OK blambert@.

group all of the on-stack variables that are uses by the nfsm_macros
to keep the data munging "state" into an nfsm_info structure. Each
function now has this structure on its stack, and it and its members
are now passed around so that the macros/functions can work there magic.

this will make removing the nfsm_* macros way easier.

Idea/code picked up from DragonflyBSD.

Tested by krw@, jacekm@ and myself.

OK blambert@.

make sure we only ever try to read out post-op attributes
or wcc data if we have a proper reply.

found the hard way by ariane@, tested by ariane@.

OK blambert@

(struct foo *)0 -> NULL, every where I could find it.

OK blambert@

turdshine previous

- make this a lot more readable; no binary change

ok thib@

Demacro nfsm_lookup for great justice.

Thanks to ckuethe for saving much typing with a drive-by perl script.

ok thib@

Convert macros to functions to reduce kernel memory usage.

In snaps for a while (way too long, according to deraadt@)

Convert a sizeable macro to a much-leaner function. Saves (IIRC) 5k on i386.

In snaps for a while.

Use a timespec instead of a time_t for the clients nfsnode
mtime, gives us better granularity, helps with cache consistency.

Idea lifted from NetBSD.

OK blambert@

Low hanging macro fruit. Inline the nfsm_srvstrsiz macro since
its used only once and nuke its definition.

Stolen from blambert's bag'o'diffs.

OK blambert@.

unroll the NFSMADV() macro and nuke it

ok blambert@

Replace nfsm_build/bcopy with nfsm_{buf,str}tombuf functions in
filehandle -> mbuf write macros.

Removes `magic' variable cp which was used only in these macros,
and should lead to marginally better mbuf packing as well.

`slap it in' thib@

Kill one-liner macro which obfuscated mbuf pointer assignment.

Rescue nfsm_reqhead macro name and rename nfsm_reqh.

End of one-liners from nfsm_subs.h.

ok thib@

Replace one-line macro which only obfuscated the fact that
the function it was named after took 4 arguments instead of 2.

"get it in; get it in; get it in" thib@

Remove now-vestigial bpos pointer from NFS. For building outgoing
NFS mbufs, mbufs now contain all their internal buffer state internally,
the way god intended.

ok thib@

testing johan@ (and possibly merdely@; this diff's been around for a bit...)

Remove bloated and nasty nfsm_clget macro; while here, replace some
handrolled loops with nfsm_strtombuf and nfsm_buftombuf.

ok deraadt@ via thib@; ok 'nfs buddy' thib@
testing johan@, merdely@; thanks

Rework NFS mbuf write routines:

nfsm_uiotombuf():
- no meaningful return, function becomes void
- replace frankensteined uiomove/MGET with actual call to uiomove

nfsm_strtmbuf():
- no meaningful return, becomes void
- rename and reorder parameters to be consistent with other functions
- becomes wrapper to nfsm_uiotombuf

nfsm_buftombuf():
- new function; unused but slated for future use
- wrapper to nfsm_uiotombuf

As a bonus, making these functions void removes much unneeded code and
garbage collects `magic' variable t2 which was only used (invisibly)
by the macros from nfsm_subs.h

Preps the way for removing much more NFS goo...

testing by myself, thib@ and merdely@
ok thib@

More NFS-related kernel shrinkage...

When you use a macro ~200 times, it tends to bloat your code, so make a
function out of it.

Shaves ~8.5 kB from my kernel.

ok thib@, "looks good" krw@

In snaps for 1+ week with no negative reports.

convert massive (expanded to 150+ lines) nfsm_v3attr macro to a function

shaves an insane (~8K) amount from an i386 kernel

ok thib@

more low hanging fruit; Expand the nfsm_srvwcc_data() macro
and nuke it's definition.

OK krw@, blamers@

Expand the nfsm_srvfillattr() macro and
nuke it's definition.

OK krw@, blambert@

remove an unused macro, NFSMINOFF;

ok beck@, blambert@
"Kill it. Kill it dead." krw@

Remove the "frev" argument from nfs_rephead(); and clean up the "frev"
variables, that are declared all over, since they are passed via macros
to nfs_rephead(); which doesn't do anything with it.

OK krw@

nfsm_uiotom macro does nothing but hide error-handling code; replace
inline in the one place that it's called

ok thib@, weingart@
"I don't see why not" fgsch@

Replace nfsm_reqdone and nfsm_srvdone macros inline. No binary change.

ok thib@

When setting timestamps TOSERVER having write permissions is adaquate;
problem experienced by Han Boetes; fix with "nfs4" rick at snowhite
dot cis dot uoguelph dot ca. ok pedro@ tedu@

This moves access to wall and uptime variables in MI code,
encapsulating all such access into wall-defined functions
that makes sure locking is done as needed.

It also cleans up some uses of wall time vs. uptime some
places, but there is sure to be more of these needed as
well, particularily in MD code. Also, many current calls
to microtime() should probably be changed to getmicrotime(),
or to the {,get}microuptime() versions.

ok art@ deraadt@ aaron@ matthieu@ beck@ sturm@ millert@ others
"Oh, that is not your problem!" from miod@

First step towards more sane time handling in the kernel -- this changes
things such that code that only need a second-resolution uptime or wall
time, and used to get that from time.tv_secs or mono_time.tv_secs now get
this from separate time_t globals time_second and time_uptime.

ok art@ niklas@ nordin@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Remove unused function parameter 'cache' from nfs_rephead
ok costa@

branches: 1.11.2; 1.11.12;
In the NFSMSIZ macro, don't assume that m_ext.ext_size == MCLBYTES.
From NetBSD

Use bitwise operations to extract high and low words from the quad
in txdr_hyper. This should be more portable than casting to an array
of ints and pulling out the two 32-bit words (this produced incorrect
results on alpha for the high word for filesystems < 4gig). As a side
effect, txdr_hyper now takes a u_quad_t as its first arg, not u_quad_t *.

Fix for creating files on a Solaris 7 server with NFSv3 (the request was
slightly garbled but older servers seemed to understand it); dfr@freebsd.org

Change fxdr_hyper to return a u_quad_t. This minimizes the evil clobbering
of lvalues that ANSI abhors.

And it fixes df on NFS version 3 mounts on Sparcs.

OpenBSD tag

partial sync with netbsd 960418, more to come

Minor cleanups. Checked against Lite2.
(NetBSD's was really just a Lite2's, but w/ 64bit support)

From NetBSD: NFSv3 import (tomorrow's Net's kernel)
Open's patches kept in. i'll possibly take a look at Lite2 soon,
is there smth usefull ?..

From NetBSD: merge with 960217 (still NFSv2)

from cgd; handle 64-bit pointers and longs

branches: 1.1.1;
Initial revision

fix ugly indents; no harmful macros harmed

delete a whole mess of unnecessary caddr_t casts

The only caller of NFSMSIZ got changed yesterday, so remove it.

High five from thib@

set the mrq pointer (request) in the nfsm_reply() macro, as we can return from it.
This can cause us to follow garbage in the nfsd loop, causing two kinds of hell.

problem noticed by nicm@. OK blambert@.

group all of the on-stack variables that are uses by the nfsm_macros
to keep the data munging "state" into an nfsm_info structure. Each
function now has this structure on its stack, and it and its members
are now passed around so that the macros/functions can work there magic.

this will make removing the nfsm_* macros way easier.

Idea/code picked up from DragonflyBSD.

Tested by krw@, jacekm@ and myself.

OK blambert@.

make sure we only ever try to read out post-op attributes
or wcc data if we have a proper reply.

found the hard way by ariane@, tested by ariane@.

OK blambert@

(struct foo *)0 -> NULL, every where I could find it.

OK blambert@

turdshine previous

- make this a lot more readable; no binary change

ok thib@

Demacro nfsm_lookup for great justice.

Thanks to ckuethe for saving much typing with a drive-by perl script.

ok thib@

Convert macros to functions to reduce kernel memory usage.

In snaps for a while (way too long, according to deraadt@)

Convert a sizeable macro to a much-leaner function. Saves (IIRC) 5k on i386.

In snaps for a while.

Use a timespec instead of a time_t for the clients nfsnode
mtime, gives us better granularity, helps with cache consistency.

Idea lifted from NetBSD.

OK blambert@

Low hanging macro fruit. Inline the nfsm_srvstrsiz macro since
its used only once and nuke its definition.

Stolen from blambert's bag'o'diffs.

OK blambert@.

unroll the NFSMADV() macro and nuke it

ok blambert@

Replace nfsm_build/bcopy with nfsm_{buf,str}tombuf functions in
filehandle -> mbuf write macros.

Removes `magic' variable cp which was used only in these macros,
and should lead to marginally better mbuf packing as well.

`slap it in' thib@

Kill one-liner macro which obfuscated mbuf pointer assignment.

Rescue nfsm_reqhead macro name and rename nfsm_reqh.

End of one-liners from nfsm_subs.h.

ok thib@

Replace one-line macro which only obfuscated the fact that
the function it was named after took 4 arguments instead of 2.

"get it in; get it in; get it in" thib@

Remove now-vestigial bpos pointer from NFS. For building outgoing
NFS mbufs, mbufs now contain all their internal buffer state internally,
the way god intended.

ok thib@

testing johan@ (and possibly merdely@; this diff's been around for a bit...)

Remove bloated and nasty nfsm_clget macro; while here, replace some
handrolled loops with nfsm_strtombuf and nfsm_buftombuf.

ok deraadt@ via thib@; ok 'nfs buddy' thib@
testing johan@, merdely@; thanks

Rework NFS mbuf write routines:

nfsm_uiotombuf():
- no meaningful return, function becomes void
- replace frankensteined uiomove/MGET with actual call to uiomove

nfsm_strtmbuf():
- no meaningful return, becomes void
- rename and reorder parameters to be consistent with other functions
- becomes wrapper to nfsm_uiotombuf

nfsm_buftombuf():
- new function; unused but slated for future use
- wrapper to nfsm_uiotombuf

As a bonus, making these functions void removes much unneeded code and
garbage collects `magic' variable t2 which was only used (invisibly)
by the macros from nfsm_subs.h

Preps the way for removing much more NFS goo...

testing by myself, thib@ and merdely@
ok thib@

More NFS-related kernel shrinkage...

When you use a macro ~200 times, it tends to bloat your code, so make a
function out of it.

Shaves ~8.5 kB from my kernel.

ok thib@, "looks good" krw@

In snaps for 1+ week with no negative reports.

convert massive (expanded to 150+ lines) nfsm_v3attr macro to a function

shaves an insane (~8K) amount from an i386 kernel

ok thib@

more low hanging fruit; Expand the nfsm_srvwcc_data() macro
and nuke it's definition.

OK krw@, blamers@

Expand the nfsm_srvfillattr() macro and
nuke it's definition.

OK krw@, blambert@

remove an unused macro, NFSMINOFF;

ok beck@, blambert@
"Kill it. Kill it dead." krw@

Remove the "frev" argument from nfs_rephead(); and clean up the "frev"
variables, that are declared all over, since they are passed via macros
to nfs_rephead(); which doesn't do anything with it.

OK krw@

nfsm_uiotom macro does nothing but hide error-handling code; replace
inline in the one place that it's called

ok thib@, weingart@
"I don't see why not" fgsch@

Replace nfsm_reqdone and nfsm_srvdone macros inline. No binary change.

ok thib@

When setting timestamps TOSERVER having write permissions is adaquate;
problem experienced by Han Boetes; fix with "nfs4" rick at snowhite
dot cis dot uoguelph dot ca. ok pedro@ tedu@

This moves access to wall and uptime variables in MI code,
encapsulating all such access into wall-defined functions
that makes sure locking is done as needed.

It also cleans up some uses of wall time vs. uptime some
places, but there is sure to be more of these needed as
well, particularily in MD code. Also, many current calls
to microtime() should probably be changed to getmicrotime(),
or to the {,get}microuptime() versions.

ok art@ deraadt@ aaron@ matthieu@ beck@ sturm@ millert@ others
"Oh, that is not your problem!" from miod@

First step towards more sane time handling in the kernel -- this changes
things such that code that only need a second-resolution uptime or wall
time, and used to get that from time.tv_secs or mono_time.tv_secs now get
this from separate time_t globals time_second and time_uptime.

ok art@ niklas@ nordin@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Remove unused function parameter 'cache' from nfs_rephead
ok costa@

branches: 1.11.2; 1.11.12;
In the NFSMSIZ macro, don't assume that m_ext.ext_size == MCLBYTES.
From NetBSD

Use bitwise operations to extract high and low words from the quad
in txdr_hyper. This should be more portable than casting to an array
of ints and pulling out the two 32-bit words (this produced incorrect
results on alpha for the high word for filesystems < 4gig). As a side
effect, txdr_hyper now takes a u_quad_t as its first arg, not u_quad_t *.

Fix for creating files on a Solaris 7 server with NFSv3 (the request was
slightly garbled but older servers seemed to understand it); dfr@freebsd.org

Change fxdr_hyper to return a u_quad_t. This minimizes the evil clobbering
of lvalues that ANSI abhors.

And it fixes df on NFS version 3 mounts on Sparcs.

OpenBSD tag

partial sync with netbsd 960418, more to come

Minor cleanups. Checked against Lite2.
(NetBSD's was really just a Lite2's, but w/ 64bit support)

From NetBSD: NFSv3 import (tomorrow's Net's kernel)
Open's patches kept in. i'll possibly take a look at Lite2 soon,
is there smth usefull ?..

From NetBSD: merge with 960217 (still NFSv2)

from cgd; handle 64-bit pointers and longs

branches: 1.1.1;
Initial revision