remove unneeded includes; ok miod@

Make ifq and ifiq interface MP safe.

Rename ifq_set_maxlen() to ifq_init_maxlen(). This function neither
uses WRITE_ONCE() nor a mutex and is called before the ifq mutex
is initialized. The new name expresses that it should be used only
during interface attach when there is no concurrency.

Protect ifq_len(), ifq_empty(), ifiq_len(), and ifiq_empty() with
READ_ONCE(). They can be used without lock as they only read a
single integer.

OK dlg@

Constify struct cfattach.

Delete unnecessary #includes of <sys/domain.h> and/or <sys/protosw.h>

net/if_pppx.c pointed out by jsg@
ok gnezdo@ deraadt@ jsg@ mpi@ millert@

Change users of IFQ_SET_MAXLEN() and IFQ_IS_EMPTY() to use the "new" API.

ok dlg@ tobhe@

Change users of IFQ_DEQUEUE(), IFQ_ENQUEUE() and IFQ_LEN() to use the
"new" API.

ok dlg@ tobhe@

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

ok mpi@ deraadt@

G/C IFQ_SET_READY().

replace IFF_OACTIVE manipulation with mpsafe operations.

there are two things shared between the network stack and drivers
in the send path: the send queue and the IFF_OACTIVE flag. the send
queue is now protected by a mutex. this diff makes the oactive
functionality mpsafe too.

IFF_OACTIVE is part of if_flags. there are two problems with that.
firstly, if_flags is a short and we dont have any MI atomic operations
to manipulate a short. secondly, while we could make the IFF_OACTIVE
operates mpsafe, all changes to other flags would have to be made
safe at the same time, otherwise a read-modify-write cycle on their
updates could clobber the oactive change.

instead, this moves the oactive mark into struct ifqueue and provides
an API for changing it. there's ifq_set_oactive, ifq_clr_oactive,
and ifq_is_oactive. these are modelled on ifsq_set_oactive,
ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.

this diff includes changes to all the drivers manipulating IFF_OACTIVE
to now use the ifsq_{set,clr_is}_oactive API too.

ok kettenis@ mpi@ jmatthew@ deraadt@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

The only network driver needing <net/if_types.h> is upl(4) for IFT_OTHER.

arp_ifinit() is no longer needed.

Increment if_ipackets in if_input().

Note that pseudo-drivers not using if_input() are not affected by this
conversion.

ok mikeb@, kettenis@, claudio@, dlg@

Convert to if_input().

ok dlg@

unifdef INET

Have foo_init() call foo_reset() to reset the chip to a known state
as is the case for a lot of the other drivers. Remove some redundant
calls to foo_stop() and foo_reset() before foo_init().

Tested with DP83815, 3c905C, 8139 and ST201.
Mostly from FreeBSD.

Fewer <netinet/in_systm.h>

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

- Remove return at the end of void functions
- Move the PCI devices table up to the top

Rewrite the receive filter handling code and cleanup the ioctl bits.

ok sthen@

Some corrections for D-Link device names.

ok jsing@

Remove setting an initial assumed baudrate upon driver attach which is not
necessarily correct, there might not even be a link when attaching.

ok mikeb@ reyk@

set ifp->if_baudrate with IF_Gbps() / IF_Mbps().

OK reyk@ sthen@

Convert a number of old private copies of code which predates
pci_set_powerstate() to using it instead. Many of these chunks of code had
bugs in them, especially missing delay() calls. Some of them were doing
things our PCI subsystem is now responsible for handling. If you have
any of the affected devices, please keep an eye out for regressions.
ok kettenis

kill a few more casts that aren't helpful. ok krw miod

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

- consistify cfdriver for the ethernet drivers (0 -> NULL)

ok dlg@

A few more simple cases of shutdown hooks which only call xxstop, when
we now know the interface has already been stopped

Eliminate the redundant bits of code for MTU and multicast handling
from the individual drivers now that ether_ioctl() handles this.

Shrinks the i386 kernels by..
RAMDISK - 2176 bytes
RAMDISKB - 1504 bytes
RAMDISKC - 736 bytes

Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users.
Build tested on almost all archs by todd@/brad@

ok naddy@

First step towards cleaning up the Ethernet driver ioctl handling.
Move calling ether_ioctl() from the top of the ioctl function, which
at the moment does absolutely nothing, to the default switch case.
Thus allowing drivers to define their own ioctl handlers and then
falling back on ether_ioctl(). The only functional change this results
in at the moment is having all Ethernet drivers returning the proper
errno of ENOTTY instead of EINVAL/ENXIO when encountering unknown
ioctl's.

Shrinks the i386 kernels by..
RAMDISK - 1024 bytes
RAMDISKB - 1120 bytes
RAMDISKC - 832 bytes

Tested by martin@/jsing@/todd@/brad@
Build tested on almost all archs by todd@/brad@

ok jsing@

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

Add missing '};' to end struct declaration. Compiles again.

ident/ansify/de-register

uncomment call to ste_miibus_statchg in ste_stats_update.

unknown ioctl is ENOTTY not EINVAL

add another PCI id to the ste(4) driver.

From the Sundance Linux driver.

allow bpf(4) to ignore packets based on their direction (inbound or
outbound), using a new BIOCSDIRFILT ioctl;
guidance, feedback and ok canacar@

- splimp -> splnet
- remove spl's from attach
- removing redundant checks before pci_mapreg_map()
- fix dmesg printing
- de-allocate resources on failure to attach
- remove unused VLAN input code from vge(4)

- a few fixes from the FreeBSD driver
- make use of pci_mapreg_map()
- ensure driver cleans after itself if ste_attach() fails

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

clear IFF_RUNNING & IFF_OACTIVE in foo_stop() before de-allocating resources.

o if the mac address cannot be read, just fail and disestablish the
irq (for shared irq's) on failure. (should other drivers do the same?)
o if it's a rev 0x12 card, only use the first phy as it reports a
non-existent one as well (From FreeBSD).
o remove splimp/splx from ste_attach().
o some cleanup.

thanks to matt at mattroberts dot org and paolo at actcom dot net dot il
for testing; commit deraadt@.

remove dmesg spewage when link changes, ok deraadt, brad, canacar

make sure interface is in RUNNING state before touching the multicast filters

From NetBSD

NetBSD PR 27678 for details

ok mcbride@

- Use ETHER_MAX_DIX_LEN.
- Accept VLAN sized frames. based on diff from canacar@

vaddr_t casts for vtophys, works on amd64, enabled in GENERIC
patch submitted and tested by Steffen Sch�tz, schuetz.steffen at melle de
ok tedu@

don't need to set ifp->if_mtu or ifp->if_output in each driver,
{ether,atm,fddi}_ifattach already does this.

ok mcbride@ markus@ henning@

Do check for STATS_OFLOW in interrupt handler. The overflow interrupt is
already disabled and the status update function fails to clear the overflow,
causing high interrupt load. Reported and tested by Arvid Gr�tting.
ok deraadt@

update ste(4) with stability and performance fixes from
FreeBSD if_ste.c revisions 1.28, 1.29, 1.38, 1.43, 1.63, 1.68, 1.70
ok henning@

Multicast cleanups
- make multicast ranges work
- replace handrolled crc code with ether_crc32_{be,le}()
- add missing calls to ether_{add,del}multi()

ok deraadt@

do not whine if we cannot get mbufs. the countless printfd makes the machine
crawl under mbuf starvation, making the situationmuch worse, and don't make
sense in the first place.
ok tdeval@ millert@ beck@ deraadt@

lose ste_unit; jason@ ok

another bad format string; %s->%d
ok tedu@

Get rid of the remaining vm_offset_t in pci drivers.

Add a simplistic table driven lookup routine and use it where appropriate.

First round of __P removal in sys

branches: 1.15.2;
Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

Change pci_intr_map to take pci_attach_args as an argument.
All callers actually took all arguments to pci_intr_map from pci_attach_args
structs, so this simplifies code.
This also allows more complicated interrupt assignment schemes like the one
on sparc64.

This makes sparc64 pci interrupts work.

Inspired by the same change in NetBSD.

remove redundant vm includes

ALTQ'ify network drivers.
- use the new queue macros.
- use IFQ_POLL() to peek at the next packet.
- use IFQ_IS_EMPTY() for empty check.
- drivers should always check if (m == NULL) after IFQ_DEQUEUE(),
since it could return NULL even when IFQ_IS_EMPTY() is FALSE
under rate-limiting.
- drivers are supposed to call if_start from tx complete interrupts
(in order to trigger the next dequeue under rate-limiting).

trivial ether_input_mbuf() conversion.

for ethernet ifaces attach bpf from ether_ifattach; jason@, aaron@, itojun@ ok

new timeouts

Use mii_attach() directly instead of mii_phy_probe().

Make this driver work. When I ported it from FreeBSD, somehow a line got left
out. :-( It was never noticed until now since I didn't have an actual D-Link
550TX card to test with. Thanks to Gardner Cohen for sending me one of these.

branches: 1.6.2;
make sure to call ether_{add,del}multi() as appropriate in xxx_ioctl()

branches: 1.5.2;
Remove unused #define cruft.

Whoops; forgot to bump FreeBSD version numbers.

Sync with FreeBSD:
- Use TX descriptor polling, similar to the xl driver, to reduce TX overhead.
- As in if_sf, reset PHY when switching modes.
- Remove unused code that was #ifdef foo'd out.

remove freebsd bridging stuff, and let ALL packets go to ether_input()

Driver for Sundance ST201 Ethernet; from FreeBSD.

Make ifq and ifiq interface MP safe.

Rename ifq_set_maxlen() to ifq_init_maxlen(). This function neither
uses WRITE_ONCE() nor a mutex and is called before the ifq mutex
is initialized. The new name expresses that it should be used only
during interface attach when there is no concurrency.

Protect ifq_len(), ifq_empty(), ifiq_len(), and ifiq_empty() with
READ_ONCE(). They can be used without lock as they only read a
single integer.

OK dlg@

Constify struct cfattach.

Delete unnecessary #includes of <sys/domain.h> and/or <sys/protosw.h>

net/if_pppx.c pointed out by jsg@
ok gnezdo@ deraadt@ jsg@ mpi@ millert@

Change users of IFQ_SET_MAXLEN() and IFQ_IS_EMPTY() to use the "new" API.

ok dlg@ tobhe@

Change users of IFQ_DEQUEUE(), IFQ_ENQUEUE() and IFQ_LEN() to use the
"new" API.

ok dlg@ tobhe@

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

ok mpi@ deraadt@

G/C IFQ_SET_READY().

replace IFF_OACTIVE manipulation with mpsafe operations.

there are two things shared between the network stack and drivers
in the send path: the send queue and the IFF_OACTIVE flag. the send
queue is now protected by a mutex. this diff makes the oactive
functionality mpsafe too.

IFF_OACTIVE is part of if_flags. there are two problems with that.
firstly, if_flags is a short and we dont have any MI atomic operations
to manipulate a short. secondly, while we could make the IFF_OACTIVE
operates mpsafe, all changes to other flags would have to be made
safe at the same time, otherwise a read-modify-write cycle on their
updates could clobber the oactive change.

instead, this moves the oactive mark into struct ifqueue and provides
an API for changing it. there's ifq_set_oactive, ifq_clr_oactive,
and ifq_is_oactive. these are modelled on ifsq_set_oactive,
ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.

this diff includes changes to all the drivers manipulating IFF_OACTIVE
to now use the ifsq_{set,clr_is}_oactive API too.

ok kettenis@ mpi@ jmatthew@ deraadt@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

The only network driver needing <net/if_types.h> is upl(4) for IFT_OTHER.

arp_ifinit() is no longer needed.

Increment if_ipackets in if_input().

Note that pseudo-drivers not using if_input() are not affected by this
conversion.

ok mikeb@, kettenis@, claudio@, dlg@

Convert to if_input().

ok dlg@

unifdef INET

Have foo_init() call foo_reset() to reset the chip to a known state
as is the case for a lot of the other drivers. Remove some redundant
calls to foo_stop() and foo_reset() before foo_init().

Tested with DP83815, 3c905C, 8139 and ST201.
Mostly from FreeBSD.

Fewer <netinet/in_systm.h>

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

- Remove return at the end of void functions
- Move the PCI devices table up to the top

Rewrite the receive filter handling code and cleanup the ioctl bits.

ok sthen@

Some corrections for D-Link device names.

ok jsing@

Remove setting an initial assumed baudrate upon driver attach which is not
necessarily correct, there might not even be a link when attaching.

ok mikeb@ reyk@

set ifp->if_baudrate with IF_Gbps() / IF_Mbps().

OK reyk@ sthen@

Convert a number of old private copies of code which predates
pci_set_powerstate() to using it instead. Many of these chunks of code had
bugs in them, especially missing delay() calls. Some of them were doing
things our PCI subsystem is now responsible for handling. If you have
any of the affected devices, please keep an eye out for regressions.
ok kettenis

kill a few more casts that aren't helpful. ok krw miod

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

- consistify cfdriver for the ethernet drivers (0 -> NULL)

ok dlg@

A few more simple cases of shutdown hooks which only call xxstop, when
we now know the interface has already been stopped

Eliminate the redundant bits of code for MTU and multicast handling
from the individual drivers now that ether_ioctl() handles this.

Shrinks the i386 kernels by..
RAMDISK - 2176 bytes
RAMDISKB - 1504 bytes
RAMDISKC - 736 bytes

Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users.
Build tested on almost all archs by todd@/brad@

ok naddy@

First step towards cleaning up the Ethernet driver ioctl handling.
Move calling ether_ioctl() from the top of the ioctl function, which
at the moment does absolutely nothing, to the default switch case.
Thus allowing drivers to define their own ioctl handlers and then
falling back on ether_ioctl(). The only functional change this results
in at the moment is having all Ethernet drivers returning the proper
errno of ENOTTY instead of EINVAL/ENXIO when encountering unknown
ioctl's.

Shrinks the i386 kernels by..
RAMDISK - 1024 bytes
RAMDISKB - 1120 bytes
RAMDISKC - 832 bytes

Tested by martin@/jsing@/todd@/brad@
Build tested on almost all archs by todd@/brad@

ok jsing@

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

Add missing '};' to end struct declaration. Compiles again.

ident/ansify/de-register

uncomment call to ste_miibus_statchg in ste_stats_update.

unknown ioctl is ENOTTY not EINVAL

add another PCI id to the ste(4) driver.

From the Sundance Linux driver.

allow bpf(4) to ignore packets based on their direction (inbound or
outbound), using a new BIOCSDIRFILT ioctl;
guidance, feedback and ok canacar@

- splimp -> splnet
- remove spl's from attach
- removing redundant checks before pci_mapreg_map()
- fix dmesg printing
- de-allocate resources on failure to attach
- remove unused VLAN input code from vge(4)

- a few fixes from the FreeBSD driver
- make use of pci_mapreg_map()
- ensure driver cleans after itself if ste_attach() fails

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

clear IFF_RUNNING & IFF_OACTIVE in foo_stop() before de-allocating resources.

o if the mac address cannot be read, just fail and disestablish the
irq (for shared irq's) on failure. (should other drivers do the same?)
o if it's a rev 0x12 card, only use the first phy as it reports a
non-existent one as well (From FreeBSD).
o remove splimp/splx from ste_attach().
o some cleanup.

thanks to matt at mattroberts dot org and paolo at actcom dot net dot il
for testing; commit deraadt@.

remove dmesg spewage when link changes, ok deraadt, brad, canacar

make sure interface is in RUNNING state before touching the multicast filters

From NetBSD

NetBSD PR 27678 for details

ok mcbride@

- Use ETHER_MAX_DIX_LEN.
- Accept VLAN sized frames. based on diff from canacar@

vaddr_t casts for vtophys, works on amd64, enabled in GENERIC
patch submitted and tested by Steffen Sch�tz, schuetz.steffen at melle de
ok tedu@

don't need to set ifp->if_mtu or ifp->if_output in each driver,
{ether,atm,fddi}_ifattach already does this.

ok mcbride@ markus@ henning@

Do check for STATS_OFLOW in interrupt handler. The overflow interrupt is
already disabled and the status update function fails to clear the overflow,
causing high interrupt load. Reported and tested by Arvid Gr�tting.
ok deraadt@

update ste(4) with stability and performance fixes from
FreeBSD if_ste.c revisions 1.28, 1.29, 1.38, 1.43, 1.63, 1.68, 1.70
ok henning@

Multicast cleanups
- make multicast ranges work
- replace handrolled crc code with ether_crc32_{be,le}()
- add missing calls to ether_{add,del}multi()

ok deraadt@

do not whine if we cannot get mbufs. the countless printfd makes the machine
crawl under mbuf starvation, making the situationmuch worse, and don't make
sense in the first place.
ok tdeval@ millert@ beck@ deraadt@

lose ste_unit; jason@ ok

another bad format string; %s->%d
ok tedu@

Get rid of the remaining vm_offset_t in pci drivers.

Add a simplistic table driven lookup routine and use it where appropriate.

First round of __P removal in sys

branches: 1.15.2;
Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

Change pci_intr_map to take pci_attach_args as an argument.
All callers actually took all arguments to pci_intr_map from pci_attach_args
structs, so this simplifies code.
This also allows more complicated interrupt assignment schemes like the one
on sparc64.

This makes sparc64 pci interrupts work.

Inspired by the same change in NetBSD.

remove redundant vm includes

ALTQ'ify network drivers.
- use the new queue macros.
- use IFQ_POLL() to peek at the next packet.
- use IFQ_IS_EMPTY() for empty check.
- drivers should always check if (m == NULL) after IFQ_DEQUEUE(),
since it could return NULL even when IFQ_IS_EMPTY() is FALSE
under rate-limiting.
- drivers are supposed to call if_start from tx complete interrupts
(in order to trigger the next dequeue under rate-limiting).

trivial ether_input_mbuf() conversion.

for ethernet ifaces attach bpf from ether_ifattach; jason@, aaron@, itojun@ ok

new timeouts

Use mii_attach() directly instead of mii_phy_probe().

Make this driver work. When I ported it from FreeBSD, somehow a line got left
out. :-( It was never noticed until now since I didn't have an actual D-Link
550TX card to test with. Thanks to Gardner Cohen for sending me one of these.

branches: 1.6.2;
make sure to call ether_{add,del}multi() as appropriate in xxx_ioctl()

branches: 1.5.2;
Remove unused #define cruft.

Whoops; forgot to bump FreeBSD version numbers.

Sync with FreeBSD:
- Use TX descriptor polling, similar to the xl driver, to reduce TX overhead.
- As in if_sf, reset PHY when switching modes.
- Remove unused code that was #ifdef foo'd out.

remove freebsd bridging stuff, and let ALL packets go to ether_input()

Driver for Sundance ST201 Ethernet; from FreeBSD.

Constify struct cfattach.

Delete unnecessary #includes of <sys/domain.h> and/or <sys/protosw.h>

net/if_pppx.c pointed out by jsg@
ok gnezdo@ deraadt@ jsg@ mpi@ millert@

Change users of IFQ_SET_MAXLEN() and IFQ_IS_EMPTY() to use the "new" API.

ok dlg@ tobhe@

Change users of IFQ_DEQUEUE(), IFQ_ENQUEUE() and IFQ_LEN() to use the
"new" API.

ok dlg@ tobhe@

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

ok mpi@ deraadt@

G/C IFQ_SET_READY().

replace IFF_OACTIVE manipulation with mpsafe operations.

there are two things shared between the network stack and drivers
in the send path: the send queue and the IFF_OACTIVE flag. the send
queue is now protected by a mutex. this diff makes the oactive
functionality mpsafe too.

IFF_OACTIVE is part of if_flags. there are two problems with that.
firstly, if_flags is a short and we dont have any MI atomic operations
to manipulate a short. secondly, while we could make the IFF_OACTIVE
operates mpsafe, all changes to other flags would have to be made
safe at the same time, otherwise a read-modify-write cycle on their
updates could clobber the oactive change.

instead, this moves the oactive mark into struct ifqueue and provides
an API for changing it. there's ifq_set_oactive, ifq_clr_oactive,
and ifq_is_oactive. these are modelled on ifsq_set_oactive,
ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.

this diff includes changes to all the drivers manipulating IFF_OACTIVE
to now use the ifsq_{set,clr_is}_oactive API too.

ok kettenis@ mpi@ jmatthew@ deraadt@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

The only network driver needing <net/if_types.h> is upl(4) for IFT_OTHER.

arp_ifinit() is no longer needed.

Increment if_ipackets in if_input().

Note that pseudo-drivers not using if_input() are not affected by this
conversion.

ok mikeb@, kettenis@, claudio@, dlg@

Convert to if_input().

ok dlg@

unifdef INET

Have foo_init() call foo_reset() to reset the chip to a known state
as is the case for a lot of the other drivers. Remove some redundant
calls to foo_stop() and foo_reset() before foo_init().

Tested with DP83815, 3c905C, 8139 and ST201.
Mostly from FreeBSD.

Fewer <netinet/in_systm.h>

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

- Remove return at the end of void functions
- Move the PCI devices table up to the top

Rewrite the receive filter handling code and cleanup the ioctl bits.

ok sthen@

Some corrections for D-Link device names.

ok jsing@

Remove setting an initial assumed baudrate upon driver attach which is not
necessarily correct, there might not even be a link when attaching.

ok mikeb@ reyk@

set ifp->if_baudrate with IF_Gbps() / IF_Mbps().

OK reyk@ sthen@

Convert a number of old private copies of code which predates
pci_set_powerstate() to using it instead. Many of these chunks of code had
bugs in them, especially missing delay() calls. Some of them were doing
things our PCI subsystem is now responsible for handling. If you have
any of the affected devices, please keep an eye out for regressions.
ok kettenis

kill a few more casts that aren't helpful. ok krw miod

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

- consistify cfdriver for the ethernet drivers (0 -> NULL)

ok dlg@

A few more simple cases of shutdown hooks which only call xxstop, when
we now know the interface has already been stopped

Eliminate the redundant bits of code for MTU and multicast handling
from the individual drivers now that ether_ioctl() handles this.

Shrinks the i386 kernels by..
RAMDISK - 2176 bytes
RAMDISKB - 1504 bytes
RAMDISKC - 736 bytes

Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users.
Build tested on almost all archs by todd@/brad@

ok naddy@

First step towards cleaning up the Ethernet driver ioctl handling.
Move calling ether_ioctl() from the top of the ioctl function, which
at the moment does absolutely nothing, to the default switch case.
Thus allowing drivers to define their own ioctl handlers and then
falling back on ether_ioctl(). The only functional change this results
in at the moment is having all Ethernet drivers returning the proper
errno of ENOTTY instead of EINVAL/ENXIO when encountering unknown
ioctl's.

Shrinks the i386 kernels by..
RAMDISK - 1024 bytes
RAMDISKB - 1120 bytes
RAMDISKC - 832 bytes

Tested by martin@/jsing@/todd@/brad@
Build tested on almost all archs by todd@/brad@

ok jsing@

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

Add missing '};' to end struct declaration. Compiles again.

ident/ansify/de-register

uncomment call to ste_miibus_statchg in ste_stats_update.

unknown ioctl is ENOTTY not EINVAL

add another PCI id to the ste(4) driver.

From the Sundance Linux driver.

allow bpf(4) to ignore packets based on their direction (inbound or
outbound), using a new BIOCSDIRFILT ioctl;
guidance, feedback and ok canacar@

- splimp -> splnet
- remove spl's from attach
- removing redundant checks before pci_mapreg_map()
- fix dmesg printing
- de-allocate resources on failure to attach
- remove unused VLAN input code from vge(4)

- a few fixes from the FreeBSD driver
- make use of pci_mapreg_map()
- ensure driver cleans after itself if ste_attach() fails

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

clear IFF_RUNNING & IFF_OACTIVE in foo_stop() before de-allocating resources.

o if the mac address cannot be read, just fail and disestablish the
irq (for shared irq's) on failure. (should other drivers do the same?)
o if it's a rev 0x12 card, only use the first phy as it reports a
non-existent one as well (From FreeBSD).
o remove splimp/splx from ste_attach().
o some cleanup.

thanks to matt at mattroberts dot org and paolo at actcom dot net dot il
for testing; commit deraadt@.

remove dmesg spewage when link changes, ok deraadt, brad, canacar

make sure interface is in RUNNING state before touching the multicast filters

From NetBSD

NetBSD PR 27678 for details

ok mcbride@

- Use ETHER_MAX_DIX_LEN.
- Accept VLAN sized frames. based on diff from canacar@

vaddr_t casts for vtophys, works on amd64, enabled in GENERIC
patch submitted and tested by Steffen Sch�tz, schuetz.steffen at melle de
ok tedu@

don't need to set ifp->if_mtu or ifp->if_output in each driver,
{ether,atm,fddi}_ifattach already does this.

ok mcbride@ markus@ henning@

Do check for STATS_OFLOW in interrupt handler. The overflow interrupt is
already disabled and the status update function fails to clear the overflow,
causing high interrupt load. Reported and tested by Arvid Gr�tting.
ok deraadt@

update ste(4) with stability and performance fixes from
FreeBSD if_ste.c revisions 1.28, 1.29, 1.38, 1.43, 1.63, 1.68, 1.70
ok henning@

Multicast cleanups
- make multicast ranges work
- replace handrolled crc code with ether_crc32_{be,le}()
- add missing calls to ether_{add,del}multi()

ok deraadt@

do not whine if we cannot get mbufs. the countless printfd makes the machine
crawl under mbuf starvation, making the situationmuch worse, and don't make
sense in the first place.
ok tdeval@ millert@ beck@ deraadt@

lose ste_unit; jason@ ok

another bad format string; %s->%d
ok tedu@

Get rid of the remaining vm_offset_t in pci drivers.

Add a simplistic table driven lookup routine and use it where appropriate.

First round of __P removal in sys

branches: 1.15.2;
Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

Change pci_intr_map to take pci_attach_args as an argument.
All callers actually took all arguments to pci_intr_map from pci_attach_args
structs, so this simplifies code.
This also allows more complicated interrupt assignment schemes like the one
on sparc64.

This makes sparc64 pci interrupts work.

Inspired by the same change in NetBSD.

remove redundant vm includes

ALTQ'ify network drivers.
- use the new queue macros.
- use IFQ_POLL() to peek at the next packet.
- use IFQ_IS_EMPTY() for empty check.
- drivers should always check if (m == NULL) after IFQ_DEQUEUE(),
since it could return NULL even when IFQ_IS_EMPTY() is FALSE
under rate-limiting.
- drivers are supposed to call if_start from tx complete interrupts
(in order to trigger the next dequeue under rate-limiting).

trivial ether_input_mbuf() conversion.

for ethernet ifaces attach bpf from ether_ifattach; jason@, aaron@, itojun@ ok

new timeouts

Use mii_attach() directly instead of mii_phy_probe().

Make this driver work. When I ported it from FreeBSD, somehow a line got left
out. :-( It was never noticed until now since I didn't have an actual D-Link
550TX card to test with. Thanks to Gardner Cohen for sending me one of these.

branches: 1.6.2;
make sure to call ether_{add,del}multi() as appropriate in xxx_ioctl()

branches: 1.5.2;
Remove unused #define cruft.

Whoops; forgot to bump FreeBSD version numbers.

Sync with FreeBSD:
- Use TX descriptor polling, similar to the xl driver, to reduce TX overhead.
- As in if_sf, reset PHY when switching modes.
- Remove unused code that was #ifdef foo'd out.

remove freebsd bridging stuff, and let ALL packets go to ether_input()

Driver for Sundance ST201 Ethernet; from FreeBSD.

Delete unnecessary #includes of <sys/domain.h> and/or <sys/protosw.h>

net/if_pppx.c pointed out by jsg@
ok gnezdo@ deraadt@ jsg@ mpi@ millert@

Change users of IFQ_SET_MAXLEN() and IFQ_IS_EMPTY() to use the "new" API.

ok dlg@ tobhe@

Change users of IFQ_DEQUEUE(), IFQ_ENQUEUE() and IFQ_LEN() to use the
"new" API.

ok dlg@ tobhe@

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

ok mpi@ deraadt@

G/C IFQ_SET_READY().

replace IFF_OACTIVE manipulation with mpsafe operations.

there are two things shared between the network stack and drivers
in the send path: the send queue and the IFF_OACTIVE flag. the send
queue is now protected by a mutex. this diff makes the oactive
functionality mpsafe too.

IFF_OACTIVE is part of if_flags. there are two problems with that.
firstly, if_flags is a short and we dont have any MI atomic operations
to manipulate a short. secondly, while we could make the IFF_OACTIVE
operates mpsafe, all changes to other flags would have to be made
safe at the same time, otherwise a read-modify-write cycle on their
updates could clobber the oactive change.

instead, this moves the oactive mark into struct ifqueue and provides
an API for changing it. there's ifq_set_oactive, ifq_clr_oactive,
and ifq_is_oactive. these are modelled on ifsq_set_oactive,
ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.

this diff includes changes to all the drivers manipulating IFF_OACTIVE
to now use the ifsq_{set,clr_is}_oactive API too.

ok kettenis@ mpi@ jmatthew@ deraadt@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

The only network driver needing <net/if_types.h> is upl(4) for IFT_OTHER.

arp_ifinit() is no longer needed.

Increment if_ipackets in if_input().

Note that pseudo-drivers not using if_input() are not affected by this
conversion.

ok mikeb@, kettenis@, claudio@, dlg@

Convert to if_input().

ok dlg@

unifdef INET

Have foo_init() call foo_reset() to reset the chip to a known state
as is the case for a lot of the other drivers. Remove some redundant
calls to foo_stop() and foo_reset() before foo_init().

Tested with DP83815, 3c905C, 8139 and ST201.
Mostly from FreeBSD.

Fewer <netinet/in_systm.h>

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

- Remove return at the end of void functions
- Move the PCI devices table up to the top

Rewrite the receive filter handling code and cleanup the ioctl bits.

ok sthen@

Some corrections for D-Link device names.

ok jsing@

Remove setting an initial assumed baudrate upon driver attach which is not
necessarily correct, there might not even be a link when attaching.

ok mikeb@ reyk@

set ifp->if_baudrate with IF_Gbps() / IF_Mbps().

OK reyk@ sthen@

Convert a number of old private copies of code which predates
pci_set_powerstate() to using it instead. Many of these chunks of code had
bugs in them, especially missing delay() calls. Some of them were doing
things our PCI subsystem is now responsible for handling. If you have
any of the affected devices, please keep an eye out for regressions.
ok kettenis

kill a few more casts that aren't helpful. ok krw miod

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

- consistify cfdriver for the ethernet drivers (0 -> NULL)

ok dlg@

A few more simple cases of shutdown hooks which only call xxstop, when
we now know the interface has already been stopped

Eliminate the redundant bits of code for MTU and multicast handling
from the individual drivers now that ether_ioctl() handles this.

Shrinks the i386 kernels by..
RAMDISK - 2176 bytes
RAMDISKB - 1504 bytes
RAMDISKC - 736 bytes

Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users.
Build tested on almost all archs by todd@/brad@

ok naddy@

First step towards cleaning up the Ethernet driver ioctl handling.
Move calling ether_ioctl() from the top of the ioctl function, which
at the moment does absolutely nothing, to the default switch case.
Thus allowing drivers to define their own ioctl handlers and then
falling back on ether_ioctl(). The only functional change this results
in at the moment is having all Ethernet drivers returning the proper
errno of ENOTTY instead of EINVAL/ENXIO when encountering unknown
ioctl's.

Shrinks the i386 kernels by..
RAMDISK - 1024 bytes
RAMDISKB - 1120 bytes
RAMDISKC - 832 bytes

Tested by martin@/jsing@/todd@/brad@
Build tested on almost all archs by todd@/brad@

ok jsing@

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

Add missing '};' to end struct declaration. Compiles again.

ident/ansify/de-register

uncomment call to ste_miibus_statchg in ste_stats_update.

unknown ioctl is ENOTTY not EINVAL

add another PCI id to the ste(4) driver.

From the Sundance Linux driver.

allow bpf(4) to ignore packets based on their direction (inbound or
outbound), using a new BIOCSDIRFILT ioctl;
guidance, feedback and ok canacar@

- splimp -> splnet
- remove spl's from attach
- removing redundant checks before pci_mapreg_map()
- fix dmesg printing
- de-allocate resources on failure to attach
- remove unused VLAN input code from vge(4)

- a few fixes from the FreeBSD driver
- make use of pci_mapreg_map()
- ensure driver cleans after itself if ste_attach() fails

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

clear IFF_RUNNING & IFF_OACTIVE in foo_stop() before de-allocating resources.

o if the mac address cannot be read, just fail and disestablish the
irq (for shared irq's) on failure. (should other drivers do the same?)
o if it's a rev 0x12 card, only use the first phy as it reports a
non-existent one as well (From FreeBSD).
o remove splimp/splx from ste_attach().
o some cleanup.

thanks to matt at mattroberts dot org and paolo at actcom dot net dot il
for testing; commit deraadt@.

remove dmesg spewage when link changes, ok deraadt, brad, canacar

make sure interface is in RUNNING state before touching the multicast filters

From NetBSD

NetBSD PR 27678 for details

ok mcbride@

- Use ETHER_MAX_DIX_LEN.
- Accept VLAN sized frames. based on diff from canacar@

vaddr_t casts for vtophys, works on amd64, enabled in GENERIC
patch submitted and tested by Steffen Sch�tz, schuetz.steffen at melle de
ok tedu@

don't need to set ifp->if_mtu or ifp->if_output in each driver,
{ether,atm,fddi}_ifattach already does this.

ok mcbride@ markus@ henning@

Do check for STATS_OFLOW in interrupt handler. The overflow interrupt is
already disabled and the status update function fails to clear the overflow,
causing high interrupt load. Reported and tested by Arvid Gr�tting.
ok deraadt@

update ste(4) with stability and performance fixes from
FreeBSD if_ste.c revisions 1.28, 1.29, 1.38, 1.43, 1.63, 1.68, 1.70
ok henning@

Multicast cleanups
- make multicast ranges work
- replace handrolled crc code with ether_crc32_{be,le}()
- add missing calls to ether_{add,del}multi()

ok deraadt@

do not whine if we cannot get mbufs. the countless printfd makes the machine
crawl under mbuf starvation, making the situationmuch worse, and don't make
sense in the first place.
ok tdeval@ millert@ beck@ deraadt@

lose ste_unit; jason@ ok

another bad format string; %s->%d
ok tedu@

Get rid of the remaining vm_offset_t in pci drivers.

Add a simplistic table driven lookup routine and use it where appropriate.

First round of __P removal in sys

branches: 1.15.2;
Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

Change pci_intr_map to take pci_attach_args as an argument.
All callers actually took all arguments to pci_intr_map from pci_attach_args
structs, so this simplifies code.
This also allows more complicated interrupt assignment schemes like the one
on sparc64.

This makes sparc64 pci interrupts work.

Inspired by the same change in NetBSD.

remove redundant vm includes

ALTQ'ify network drivers.
- use the new queue macros.
- use IFQ_POLL() to peek at the next packet.
- use IFQ_IS_EMPTY() for empty check.
- drivers should always check if (m == NULL) after IFQ_DEQUEUE(),
since it could return NULL even when IFQ_IS_EMPTY() is FALSE
under rate-limiting.
- drivers are supposed to call if_start from tx complete interrupts
(in order to trigger the next dequeue under rate-limiting).

trivial ether_input_mbuf() conversion.

for ethernet ifaces attach bpf from ether_ifattach; jason@, aaron@, itojun@ ok

new timeouts

Use mii_attach() directly instead of mii_phy_probe().

Make this driver work. When I ported it from FreeBSD, somehow a line got left
out. :-( It was never noticed until now since I didn't have an actual D-Link
550TX card to test with. Thanks to Gardner Cohen for sending me one of these.

branches: 1.6.2;
make sure to call ether_{add,del}multi() as appropriate in xxx_ioctl()

branches: 1.5.2;
Remove unused #define cruft.

Whoops; forgot to bump FreeBSD version numbers.

Sync with FreeBSD:
- Use TX descriptor polling, similar to the xl driver, to reduce TX overhead.
- As in if_sf, reset PHY when switching modes.
- Remove unused code that was #ifdef foo'd out.

remove freebsd bridging stuff, and let ALL packets go to ether_input()

Driver for Sundance ST201 Ethernet; from FreeBSD.

Change users of IFQ_SET_MAXLEN() and IFQ_IS_EMPTY() to use the "new" API.

ok dlg@ tobhe@

Change users of IFQ_DEQUEUE(), IFQ_ENQUEUE() and IFQ_LEN() to use the
"new" API.

ok dlg@ tobhe@

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

ok mpi@ deraadt@

G/C IFQ_SET_READY().

replace IFF_OACTIVE manipulation with mpsafe operations.

there are two things shared between the network stack and drivers
in the send path: the send queue and the IFF_OACTIVE flag. the send
queue is now protected by a mutex. this diff makes the oactive
functionality mpsafe too.

IFF_OACTIVE is part of if_flags. there are two problems with that.
firstly, if_flags is a short and we dont have any MI atomic operations
to manipulate a short. secondly, while we could make the IFF_OACTIVE
operates mpsafe, all changes to other flags would have to be made
safe at the same time, otherwise a read-modify-write cycle on their
updates could clobber the oactive change.

instead, this moves the oactive mark into struct ifqueue and provides
an API for changing it. there's ifq_set_oactive, ifq_clr_oactive,
and ifq_is_oactive. these are modelled on ifsq_set_oactive,
ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.

this diff includes changes to all the drivers manipulating IFF_OACTIVE
to now use the ifsq_{set,clr_is}_oactive API too.

ok kettenis@ mpi@ jmatthew@ deraadt@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

The only network driver needing <net/if_types.h> is upl(4) for IFT_OTHER.

arp_ifinit() is no longer needed.

Increment if_ipackets in if_input().

Note that pseudo-drivers not using if_input() are not affected by this
conversion.

ok mikeb@, kettenis@, claudio@, dlg@

Convert to if_input().

ok dlg@

unifdef INET

Have foo_init() call foo_reset() to reset the chip to a known state
as is the case for a lot of the other drivers. Remove some redundant
calls to foo_stop() and foo_reset() before foo_init().

Tested with DP83815, 3c905C, 8139 and ST201.
Mostly from FreeBSD.

Fewer <netinet/in_systm.h>

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

- Remove return at the end of void functions
- Move the PCI devices table up to the top

Rewrite the receive filter handling code and cleanup the ioctl bits.

ok sthen@

Some corrections for D-Link device names.

ok jsing@

Remove setting an initial assumed baudrate upon driver attach which is not
necessarily correct, there might not even be a link when attaching.

ok mikeb@ reyk@

set ifp->if_baudrate with IF_Gbps() / IF_Mbps().

OK reyk@ sthen@

Convert a number of old private copies of code which predates
pci_set_powerstate() to using it instead. Many of these chunks of code had
bugs in them, especially missing delay() calls. Some of them were doing
things our PCI subsystem is now responsible for handling. If you have
any of the affected devices, please keep an eye out for regressions.
ok kettenis

kill a few more casts that aren't helpful. ok krw miod

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

- consistify cfdriver for the ethernet drivers (0 -> NULL)

ok dlg@

A few more simple cases of shutdown hooks which only call xxstop, when
we now know the interface has already been stopped

Eliminate the redundant bits of code for MTU and multicast handling
from the individual drivers now that ether_ioctl() handles this.

Shrinks the i386 kernels by..
RAMDISK - 2176 bytes
RAMDISKB - 1504 bytes
RAMDISKC - 736 bytes

Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users.
Build tested on almost all archs by todd@/brad@

ok naddy@

First step towards cleaning up the Ethernet driver ioctl handling.
Move calling ether_ioctl() from the top of the ioctl function, which
at the moment does absolutely nothing, to the default switch case.
Thus allowing drivers to define their own ioctl handlers and then
falling back on ether_ioctl(). The only functional change this results
in at the moment is having all Ethernet drivers returning the proper
errno of ENOTTY instead of EINVAL/ENXIO when encountering unknown
ioctl's.

Shrinks the i386 kernels by..
RAMDISK - 1024 bytes
RAMDISKB - 1120 bytes
RAMDISKC - 832 bytes

Tested by martin@/jsing@/todd@/brad@
Build tested on almost all archs by todd@/brad@

ok jsing@

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

Add missing '};' to end struct declaration. Compiles again.

ident/ansify/de-register

uncomment call to ste_miibus_statchg in ste_stats_update.

unknown ioctl is ENOTTY not EINVAL

add another PCI id to the ste(4) driver.

From the Sundance Linux driver.

allow bpf(4) to ignore packets based on their direction (inbound or
outbound), using a new BIOCSDIRFILT ioctl;
guidance, feedback and ok canacar@

- splimp -> splnet
- remove spl's from attach
- removing redundant checks before pci_mapreg_map()
- fix dmesg printing
- de-allocate resources on failure to attach
- remove unused VLAN input code from vge(4)

- a few fixes from the FreeBSD driver
- make use of pci_mapreg_map()
- ensure driver cleans after itself if ste_attach() fails

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

clear IFF_RUNNING & IFF_OACTIVE in foo_stop() before de-allocating resources.

o if the mac address cannot be read, just fail and disestablish the
irq (for shared irq's) on failure. (should other drivers do the same?)
o if it's a rev 0x12 card, only use the first phy as it reports a
non-existent one as well (From FreeBSD).
o remove splimp/splx from ste_attach().
o some cleanup.

thanks to matt at mattroberts dot org and paolo at actcom dot net dot il
for testing; commit deraadt@.

remove dmesg spewage when link changes, ok deraadt, brad, canacar

make sure interface is in RUNNING state before touching the multicast filters

From NetBSD

NetBSD PR 27678 for details

ok mcbride@

- Use ETHER_MAX_DIX_LEN.
- Accept VLAN sized frames. based on diff from canacar@

vaddr_t casts for vtophys, works on amd64, enabled in GENERIC
patch submitted and tested by Steffen Sch�tz, schuetz.steffen at melle de
ok tedu@

don't need to set ifp->if_mtu or ifp->if_output in each driver,
{ether,atm,fddi}_ifattach already does this.

ok mcbride@ markus@ henning@

Do check for STATS_OFLOW in interrupt handler. The overflow interrupt is
already disabled and the status update function fails to clear the overflow,
causing high interrupt load. Reported and tested by Arvid Gr�tting.
ok deraadt@

update ste(4) with stability and performance fixes from
FreeBSD if_ste.c revisions 1.28, 1.29, 1.38, 1.43, 1.63, 1.68, 1.70
ok henning@

Multicast cleanups
- make multicast ranges work
- replace handrolled crc code with ether_crc32_{be,le}()
- add missing calls to ether_{add,del}multi()

ok deraadt@

do not whine if we cannot get mbufs. the countless printfd makes the machine
crawl under mbuf starvation, making the situationmuch worse, and don't make
sense in the first place.
ok tdeval@ millert@ beck@ deraadt@

lose ste_unit; jason@ ok

another bad format string; %s->%d
ok tedu@

Get rid of the remaining vm_offset_t in pci drivers.

Add a simplistic table driven lookup routine and use it where appropriate.

First round of __P removal in sys

branches: 1.15.2;
Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

Change pci_intr_map to take pci_attach_args as an argument.
All callers actually took all arguments to pci_intr_map from pci_attach_args
structs, so this simplifies code.
This also allows more complicated interrupt assignment schemes like the one
on sparc64.

This makes sparc64 pci interrupts work.

Inspired by the same change in NetBSD.

remove redundant vm includes

ALTQ'ify network drivers.
- use the new queue macros.
- use IFQ_POLL() to peek at the next packet.
- use IFQ_IS_EMPTY() for empty check.
- drivers should always check if (m == NULL) after IFQ_DEQUEUE(),
since it could return NULL even when IFQ_IS_EMPTY() is FALSE
under rate-limiting.
- drivers are supposed to call if_start from tx complete interrupts
(in order to trigger the next dequeue under rate-limiting).

trivial ether_input_mbuf() conversion.

for ethernet ifaces attach bpf from ether_ifattach; jason@, aaron@, itojun@ ok

new timeouts

Use mii_attach() directly instead of mii_phy_probe().

Make this driver work. When I ported it from FreeBSD, somehow a line got left
out. :-( It was never noticed until now since I didn't have an actual D-Link
550TX card to test with. Thanks to Gardner Cohen for sending me one of these.

branches: 1.6.2;
make sure to call ether_{add,del}multi() as appropriate in xxx_ioctl()

branches: 1.5.2;
Remove unused #define cruft.

Whoops; forgot to bump FreeBSD version numbers.

Sync with FreeBSD:
- Use TX descriptor polling, similar to the xl driver, to reduce TX overhead.
- As in if_sf, reset PHY when switching modes.
- Remove unused code that was #ifdef foo'd out.

remove freebsd bridging stuff, and let ALL packets go to ether_input()

Driver for Sundance ST201 Ethernet; from FreeBSD.

move counting if_opackets next to counting if_obytes in if_enqueue.

this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.

ok mpi@ deraadt@

G/C IFQ_SET_READY().

replace IFF_OACTIVE manipulation with mpsafe operations.

there are two things shared between the network stack and drivers
in the send path: the send queue and the IFF_OACTIVE flag. the send
queue is now protected by a mutex. this diff makes the oactive
functionality mpsafe too.

IFF_OACTIVE is part of if_flags. there are two problems with that.
firstly, if_flags is a short and we dont have any MI atomic operations
to manipulate a short. secondly, while we could make the IFF_OACTIVE
operates mpsafe, all changes to other flags would have to be made
safe at the same time, otherwise a read-modify-write cycle on their
updates could clobber the oactive change.

instead, this moves the oactive mark into struct ifqueue and provides
an API for changing it. there's ifq_set_oactive, ifq_clr_oactive,
and ifq_is_oactive. these are modelled on ifsq_set_oactive,
ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd.

this diff includes changes to all the drivers manipulating IFF_OACTIVE
to now use the ifsq_{set,clr_is}_oactive API too.

ok kettenis@ mpi@ jmatthew@ deraadt@

You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.

The only network driver needing <net/if_types.h> is upl(4) for IFT_OTHER.

arp_ifinit() is no longer needed.

Increment if_ipackets in if_input().

Note that pseudo-drivers not using if_input() are not affected by this
conversion.

ok mikeb@, kettenis@, claudio@, dlg@

Convert to if_input().

ok dlg@

unifdef INET

Have foo_init() call foo_reset() to reset the chip to a known state
as is the case for a lot of the other drivers. Remove some redundant
calls to foo_stop() and foo_reset() before foo_init().

Tested with DP83815, 3c905C, 8139 and ST201.
Mostly from FreeBSD.

Fewer <netinet/in_systm.h>

Most network drivers include netinet/in_var.h, but apparently they
don't have to. Just remove these include lines.
Compiled on amd64 i386 sparc64; OK henning@ mikeb@

- Remove return at the end of void functions
- Move the PCI devices table up to the top

Rewrite the receive filter handling code and cleanup the ioctl bits.

ok sthen@

Some corrections for D-Link device names.

ok jsing@

Remove setting an initial assumed baudrate upon driver attach which is not
necessarily correct, there might not even be a link when attaching.

ok mikeb@ reyk@

set ifp->if_baudrate with IF_Gbps() / IF_Mbps().

OK reyk@ sthen@

Convert a number of old private copies of code which predates
pci_set_powerstate() to using it instead. Many of these chunks of code had
bugs in them, especially missing delay() calls. Some of them were doing
things our PCI subsystem is now responsible for handling. If you have
any of the affected devices, please keep an eye out for regressions.
ok kettenis

kill a few more casts that aren't helpful. ok krw miod

use nitems(); no binary change for drivers that are compiled on amd64.

ok claudio@

- consistify cfdriver for the ethernet drivers (0 -> NULL)

ok dlg@

A few more simple cases of shutdown hooks which only call xxstop, when
we now know the interface has already been stopped

Eliminate the redundant bits of code for MTU and multicast handling
from the individual drivers now that ether_ioctl() handles this.

Shrinks the i386 kernels by..
RAMDISK - 2176 bytes
RAMDISKB - 1504 bytes
RAMDISKC - 736 bytes

Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users.
Build tested on almost all archs by todd@/brad@

ok naddy@

First step towards cleaning up the Ethernet driver ioctl handling.
Move calling ether_ioctl() from the top of the ioctl function, which
at the moment does absolutely nothing, to the default switch case.
Thus allowing drivers to define their own ioctl handlers and then
falling back on ether_ioctl(). The only functional change this results
in at the moment is having all Ethernet drivers returning the proper
errno of ENOTTY instead of EINVAL/ENXIO when encountering unknown
ioctl's.

Shrinks the i386 kernels by..
RAMDISK - 1024 bytes
RAMDISKB - 1120 bytes
RAMDISKC - 832 bytes

Tested by martin@/jsing@/todd@/brad@
Build tested on almost all archs by todd@/brad@

ok jsing@

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

Add missing '};' to end struct declaration. Compiles again.

ident/ansify/de-register

uncomment call to ste_miibus_statchg in ste_stats_update.

unknown ioctl is ENOTTY not EINVAL

add another PCI id to the ste(4) driver.

From the Sundance Linux driver.

allow bpf(4) to ignore packets based on their direction (inbound or
outbound), using a new BIOCSDIRFILT ioctl;
guidance, feedback and ok canacar@

- splimp -> splnet
- remove spl's from attach
- removing redundant checks before pci_mapreg_map()
- fix dmesg printing
- de-allocate resources on failure to attach
- remove unused VLAN input code from vge(4)

- a few fixes from the FreeBSD driver
- make use of pci_mapreg_map()
- ensure driver cleans after itself if ste_attach() fails

do not set PCI_COMMAND_MASTER_ENABLE explicitly as it's already set in pcisubmatch(); kettenis@ testing; brad@ ok

clear IFF_RUNNING & IFF_OACTIVE in foo_stop() before de-allocating resources.

o if the mac address cannot be read, just fail and disestablish the
irq (for shared irq's) on failure. (should other drivers do the same?)
o if it's a rev 0x12 card, only use the first phy as it reports a
non-existent one as well (From FreeBSD).
o remove splimp/splx from ste_attach().
o some cleanup.

thanks to matt at mattroberts dot org and paolo at actcom dot net dot il
for testing; commit deraadt@.

remove dmesg spewage when link changes, ok deraadt, brad, canacar

make sure interface is in RUNNING state before touching the multicast filters

From NetBSD

NetBSD PR 27678 for details

ok mcbride@

- Use ETHER_MAX_DIX_LEN.
- Accept VLAN sized frames. based on diff from canacar@

vaddr_t casts for vtophys, works on amd64, enabled in GENERIC
patch submitted and tested by Steffen Sch�tz, schuetz.steffen at melle de
ok tedu@

don't need to set ifp->if_mtu or ifp->if_output in each driver,
{ether,atm,fddi}_ifattach already does this.

ok mcbride@ markus@ henning@

Do check for STATS_OFLOW in interrupt handler. The overflow interrupt is
already disabled and the status update function fails to clear the overflow,
causing high interrupt load. Reported and tested by Arvid Gr�tting.
ok deraadt@

update ste(4) with stability and performance fixes from
FreeBSD if_ste.c revisions 1.28, 1.29, 1.38, 1.43, 1.63, 1.68, 1.70
ok henning@

Multicast cleanups
- make multicast ranges work
- replace handrolled crc code with ether_crc32_{be,le}()
- add missing calls to ether_{add,del}multi()

ok deraadt@

do not whine if we cannot get mbufs. the countless printfd makes the machine
crawl under mbuf starvation, making the situationmuch worse, and don't make
sense in the first place.
ok tdeval@ millert@ beck@ deraadt@

lose ste_unit; jason@ ok

another bad format string; %s->%d
ok tedu@

Get rid of the remaining vm_offset_t in pci drivers.

Add a simplistic table driven lookup routine and use it where appropriate.

First round of __P removal in sys

branches: 1.15.2;
Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

Change pci_intr_map to take pci_attach_args as an argument.
All callers actually took all arguments to pci_intr_map from pci_attach_args
structs, so this simplifies code.
This also allows more complicated interrupt assignment schemes like the one
on sparc64.

This makes sparc64 pci interrupts work.

Inspired by the same change in NetBSD.

remove redundant vm includes

ALTQ'ify network drivers.
- use the new queue macros.
- use IFQ_POLL() to peek at the next packet.
- use IFQ_IS_EMPTY() for empty check.
- drivers should always check if (m == NULL) after IFQ_DEQUEUE(),
since it could return NULL even when IFQ_IS_EMPTY() is FALSE
under rate-limiting.
- drivers are supposed to call if_start from tx complete interrupts
(in order to trigger the next dequeue under rate-limiting).

trivial ether_input_mbuf() conversion.

for ethernet ifaces attach bpf from ether_ifattach; jason@, aaron@, itojun@ ok

new timeouts

Use mii_attach() directly instead of mii_phy_probe().

Make this driver work. When I ported it from FreeBSD, somehow a line got left
out. :-( It was never noticed until now since I didn't have an actual D-Link
550TX card to test with. Thanks to Gardner Cohen for sending me one of these.

branches: 1.6.2;
make sure to call ether_{add,del}multi() as appropriate in xxx_ioctl()

branches: 1.5.2;
Remove unused #define cruft.

Whoops; forgot to bump FreeBSD version numbers.

Sync with FreeBSD:
- Use TX descriptor polling, similar to the xl driver, to reduce TX overhead.
- As in if_sf, reset PHY when switching modes.
- Remove unused code that was #ifdef foo'd out.

remove freebsd bridging stuff, and let ALL packets go to ether_input()

Driver for Sundance ST201 Ethernet; from FreeBSD.