libfuse: fix -Wunused-but-set-variable warning

ok tb@

Use memset(3) instead of bzero(3) for consistency and as per POSIX
recommendation.

Export only symbols to what's declared in fuse.h/fuse_opt.h

While here, use guenther's magic recipe to avoid the PLT when calling
exported symbols from within the library.

ok kettenis@ for v1, ok guenther@ helg@

fuse_opt_add_opt_escaped needs to allocate space for the terminating NUL

Spotted by malloc.conf -> S, ok helg@

If the list of templates 'o' passed to fuse_opt_parse(3) is NULL then
the processing function should be called in the same way as if no match
was found.

ok mpi@

sscanf(3) is now used to parse templates that contain format specifiers
(e.g. %u, %o) other than %s. This aligns libfuse with the Linux reference
implementation.


ok mpi@

Update to fuse_opt_parse(3) so that all option templates are now matched for
the supplied option. This allows the following templates to be supplied to set
multiple members of a struct at the same time. e.g.

#define FUSE_LIB_OPT(t, p, v) { t, offsetof(struct fuse_config, p), v }

static const struct fuse_opt fuse_lib_opts[] = {
FUSE_LIB_OPT("gid=", set_gid, 1),
FUSE_LIB_OPT("gid=%u", gid, 0),
FUSE_OPT_END
};

If "-ogid=1000" is passed to fuse_opt_parse(3) it will set both:

fuse_config.set_gid=1
fuse_config.gid=1000


ok mpi@

The fuse_opt_match(3) library function does not match options correctly.
libfuse supports option templates of the following form that can be used
to automatically parse arguments supplied on the command line.

"-p " argument that takes an option e.g -p 22 or -p22
"-p %x" argument that takes an option parsed like sscanf(3)
"cache=yes" matches -ocache=yes or -o cache=yes
"cache=%s" matches -ocache=<string> or -o cache=<string>
"cache=" matches same as above but value is passed to option proc
"noatime" matches -onoatime or -o atime

For example, it does not match options of the form "-p 22" or
"cache=yes" to the corresponding templates "-p " and "cache=yes". This
patch fixes that and updates the regression tests accordingly.

ok mpi@

Add support for:
multiple options after -o.
arguments that require options e.g. -p 22
%s, %lu, %u option templates

ok mpi@

Revert fuse_opt.c r1.17. It broke exfat-fuse and perhaps other plugins.
http://marc.info/?l=openbsd-ports&m=148170738917809&w=2
reported by yasuoka@

Empty strings are invalid arguments.

Fix a regression introduced when merging the two options parsers.

ok stsp@

NUL-terminate argv when parsing options, following other
implementations; fixes issue when exec*() is used for
fuse_args, notably in sshfs; from Hiltjo Posthuma and
reminded by ray.

ok mpi@

missing deref on char check. from David Binderman

When an option is not recognized call the processing function with
FUSE_OPT_KEY_OPT, while here fix the last argument of a call in
fuse_opt_parse().

Diff from Thi��baud Weksteen <thiebaud AT weksteen DOT fr>, thanks!

ok syl@, ajacoutot@

Unbreak option parsing:
fuse_opt_pase is called with an opaque void * and struct fuse_opt. If val has a
positive value and off != -1, we modify the opaque void * at the offset off to
put it val.
This matches what the GNU libfuse does.

fixes (at least) simple-mtpfs option parsing
diff from slacker syl@, thanks!

"it can't get worse than not working" mikeb@
ok miod@ sthen@

SIZE_MAX is standard, we should be using it in preference to the
obsolete SIZE_T_MAX. OK miod@ beck@

use reallocarray(); ok doug

Add support for -o XXX or -oXXX options in libfuse.

inputs from tedu@, ok tedu@

Init outargs only once, and fix a bad bzero().

Spotted by jsg@, ok jsg@

Mark fuse_opt_parse()'s third argument as a point to const, to match the
reference FUSE implementation. ok syl@

fuse_opt_insert_arg() can take empty string as argument.

unbreak ntfs-3g.
ok pirofti@

Update the fuse_opt to have option like -h working.

ok ajacoutot@

Merge fuse_opt code with stsp@ fuse_opt code.

ok tedu@

style for loops

correct realloc usage

style

fuse_opt support from Sylvestre

Use memset(3) instead of bzero(3) for consistency and as per POSIX
recommendation.

Export only symbols to what's declared in fuse.h/fuse_opt.h

While here, use guenther's magic recipe to avoid the PLT when calling
exported symbols from within the library.

ok kettenis@ for v1, ok guenther@ helg@

fuse_opt_add_opt_escaped needs to allocate space for the terminating NUL

Spotted by malloc.conf -> S, ok helg@

If the list of templates 'o' passed to fuse_opt_parse(3) is NULL then
the processing function should be called in the same way as if no match
was found.

ok mpi@

sscanf(3) is now used to parse templates that contain format specifiers
(e.g. %u, %o) other than %s. This aligns libfuse with the Linux reference
implementation.


ok mpi@

Update to fuse_opt_parse(3) so that all option templates are now matched for
the supplied option. This allows the following templates to be supplied to set
multiple members of a struct at the same time. e.g.

#define FUSE_LIB_OPT(t, p, v) { t, offsetof(struct fuse_config, p), v }

static const struct fuse_opt fuse_lib_opts[] = {
FUSE_LIB_OPT("gid=", set_gid, 1),
FUSE_LIB_OPT("gid=%u", gid, 0),
FUSE_OPT_END
};

If "-ogid=1000" is passed to fuse_opt_parse(3) it will set both:

fuse_config.set_gid=1
fuse_config.gid=1000


ok mpi@

The fuse_opt_match(3) library function does not match options correctly.
libfuse supports option templates of the following form that can be used
to automatically parse arguments supplied on the command line.

"-p " argument that takes an option e.g -p 22 or -p22
"-p %x" argument that takes an option parsed like sscanf(3)
"cache=yes" matches -ocache=yes or -o cache=yes
"cache=%s" matches -ocache=<string> or -o cache=<string>
"cache=" matches same as above but value is passed to option proc
"noatime" matches -onoatime or -o atime

For example, it does not match options of the form "-p 22" or
"cache=yes" to the corresponding templates "-p " and "cache=yes". This
patch fixes that and updates the regression tests accordingly.

ok mpi@

Add support for:
multiple options after -o.
arguments that require options e.g. -p 22
%s, %lu, %u option templates

ok mpi@

Revert fuse_opt.c r1.17. It broke exfat-fuse and perhaps other plugins.
http://marc.info/?l=openbsd-ports&m=148170738917809&w=2
reported by yasuoka@

Empty strings are invalid arguments.

Fix a regression introduced when merging the two options parsers.

ok stsp@

NUL-terminate argv when parsing options, following other
implementations; fixes issue when exec*() is used for
fuse_args, notably in sshfs; from Hiltjo Posthuma and
reminded by ray.

ok mpi@

missing deref on char check. from David Binderman

When an option is not recognized call the processing function with
FUSE_OPT_KEY_OPT, while here fix the last argument of a call in
fuse_opt_parse().

Diff from Thi��baud Weksteen <thiebaud AT weksteen DOT fr>, thanks!

ok syl@, ajacoutot@

Unbreak option parsing:
fuse_opt_pase is called with an opaque void * and struct fuse_opt. If val has a
positive value and off != -1, we modify the opaque void * at the offset off to
put it val.
This matches what the GNU libfuse does.

fixes (at least) simple-mtpfs option parsing
diff from slacker syl@, thanks!

"it can't get worse than not working" mikeb@
ok miod@ sthen@

SIZE_MAX is standard, we should be using it in preference to the
obsolete SIZE_T_MAX. OK miod@ beck@

use reallocarray(); ok doug

Add support for -o XXX or -oXXX options in libfuse.

inputs from tedu@, ok tedu@

Init outargs only once, and fix a bad bzero().

Spotted by jsg@, ok jsg@

Mark fuse_opt_parse()'s third argument as a point to const, to match the
reference FUSE implementation. ok syl@

fuse_opt_insert_arg() can take empty string as argument.

unbreak ntfs-3g.
ok pirofti@

Update the fuse_opt to have option like -h working.

ok ajacoutot@

Merge fuse_opt code with stsp@ fuse_opt code.

ok tedu@

style for loops

correct realloc usage

style

fuse_opt support from Sylvestre

Export only symbols to what's declared in fuse.h/fuse_opt.h

While here, use guenther's magic recipe to avoid the PLT when calling
exported symbols from within the library.

ok kettenis@ for v1, ok guenther@ helg@

fuse_opt_add_opt_escaped needs to allocate space for the terminating NUL

Spotted by malloc.conf -> S, ok helg@

If the list of templates 'o' passed to fuse_opt_parse(3) is NULL then
the processing function should be called in the same way as if no match
was found.

ok mpi@

sscanf(3) is now used to parse templates that contain format specifiers
(e.g. %u, %o) other than %s. This aligns libfuse with the Linux reference
implementation.


ok mpi@

Update to fuse_opt_parse(3) so that all option templates are now matched for
the supplied option. This allows the following templates to be supplied to set
multiple members of a struct at the same time. e.g.

#define FUSE_LIB_OPT(t, p, v) { t, offsetof(struct fuse_config, p), v }

static const struct fuse_opt fuse_lib_opts[] = {
FUSE_LIB_OPT("gid=", set_gid, 1),
FUSE_LIB_OPT("gid=%u", gid, 0),
FUSE_OPT_END
};

If "-ogid=1000" is passed to fuse_opt_parse(3) it will set both:

fuse_config.set_gid=1
fuse_config.gid=1000


ok mpi@

The fuse_opt_match(3) library function does not match options correctly.
libfuse supports option templates of the following form that can be used
to automatically parse arguments supplied on the command line.

"-p " argument that takes an option e.g -p 22 or -p22
"-p %x" argument that takes an option parsed like sscanf(3)
"cache=yes" matches -ocache=yes or -o cache=yes
"cache=%s" matches -ocache=<string> or -o cache=<string>
"cache=" matches same as above but value is passed to option proc
"noatime" matches -onoatime or -o atime

For example, it does not match options of the form "-p 22" or
"cache=yes" to the corresponding templates "-p " and "cache=yes". This
patch fixes that and updates the regression tests accordingly.

ok mpi@

Add support for:
multiple options after -o.
arguments that require options e.g. -p 22
%s, %lu, %u option templates

ok mpi@

Revert fuse_opt.c r1.17. It broke exfat-fuse and perhaps other plugins.
http://marc.info/?l=openbsd-ports&m=148170738917809&w=2
reported by yasuoka@

Empty strings are invalid arguments.

Fix a regression introduced when merging the two options parsers.

ok stsp@

NUL-terminate argv when parsing options, following other
implementations; fixes issue when exec*() is used for
fuse_args, notably in sshfs; from Hiltjo Posthuma and
reminded by ray.

ok mpi@

missing deref on char check. from David Binderman

When an option is not recognized call the processing function with
FUSE_OPT_KEY_OPT, while here fix the last argument of a call in
fuse_opt_parse().

Diff from Thi��baud Weksteen <thiebaud AT weksteen DOT fr>, thanks!

ok syl@, ajacoutot@

Unbreak option parsing:
fuse_opt_pase is called with an opaque void * and struct fuse_opt. If val has a
positive value and off != -1, we modify the opaque void * at the offset off to
put it val.
This matches what the GNU libfuse does.

fixes (at least) simple-mtpfs option parsing
diff from slacker syl@, thanks!

"it can't get worse than not working" mikeb@
ok miod@ sthen@

SIZE_MAX is standard, we should be using it in preference to the
obsolete SIZE_T_MAX. OK miod@ beck@

use reallocarray(); ok doug

Add support for -o XXX or -oXXX options in libfuse.

inputs from tedu@, ok tedu@

Init outargs only once, and fix a bad bzero().

Spotted by jsg@, ok jsg@

Mark fuse_opt_parse()'s third argument as a point to const, to match the
reference FUSE implementation. ok syl@

fuse_opt_insert_arg() can take empty string as argument.

unbreak ntfs-3g.
ok pirofti@

Update the fuse_opt to have option like -h working.

ok ajacoutot@

Merge fuse_opt code with stsp@ fuse_opt code.

ok tedu@

style for loops

correct realloc usage

style

fuse_opt support from Sylvestre