ksh: escape control chars when displaying file name completions.
If there are multiple matches when using autocomplete, the list of
matching file names was output as-is. However, for a single match,
control characters are escaped before the file name is displayed.
This makes the behavior more consistent by escaping control chars
in the list of matches too. Discussed with deraadt@, OK op@

Trigger ERR trap on permanent I/O redirection failure

The following three cases behave identical in bash(1), but our ksh
(ksh93 also) fails to run the trap in the last case:

(non-zero exit code is trigger, no redirection)
$ ksh -c 'trap "echo ERR" ERR ; false'
ERR

(failed redirection is trigger, 'echo' was not executed)
$ ksh -c 'trap "echo ERR" ERR ; echo >/'
ksh: cannot create /: Is a directory
ERR

(failed redirection, no execution, trap was NOT triggered)
$ ksh -c 'trap "echo ERR" ERR ; exec >/'
ksh: cannot create /: Is a directory


bash(1) prints "ERR" in all three cases, as expected.
ksh93 behaves like our ksh(1).

In ksh `exec' is a builtin (CSHELL), but also special (SPEC_BI):
$ type alias
alias is a shell builtin
$ type exec
exec is a special shell builtin

Without command and redirection alone, `exec' permanently redirects I/O for
the shell itself, not executing anything; it is the only (special) builtin
with such a special use-case, implemented as c_sh.c:c_exec().

This corner-case is overlooked in exec.c:execute() which handles iosetup()
failure for all commands, incl. builtins.

Exclude c_exec() from the rest of special builtins to ensure it runs the
ERR trap as expected:

$ ./obj/ksh -c 'trap "echo ERR" ERR ; exec >/'
ksh: cannot create /: Is a directory
ERR

Also add three new regress cases covering this; rest keep passing.

OK millert

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Favor usage of __func__ in warning/error messages. Some of them referred to the
wrong function and fix the rest for consistency.
Diff from Michael W. Bombardieri with some cosmetic cleanup applied.

ok benno@ tb@

Introduce internal_warningf() and mark internal_errorf() as noreturn

This helps tools like scan-build, and follows the example of warningf()
and errorf(). ok anton@

Stop pretending we support building ksh without EDIT/HISTORY support

ok anton@

Add -Wshadow to Makefile and fix the resulting warnings. Many of
the warnings are due to the use of globals with generic names,
specifically "options" and "path". I've renamed "options" to
"sh_options" since it holds the shell options and "path" to
"search_path". OK jca@ tb@

Get rid of a todo by stop declaring variable texec as static and instead zeroing
it out prior to continuing down the recursive call chain.

Initial diff from Michael W. Bombardieri, later tweaked; ok tb@

I missed a bit of the indentation fix from Kartik Agaram.

When ERREXIT (set -e) is in effect, don't disable it after a
short-circuited `&&` or `||` chain in later iterations of `for`
loops. It should be disabled after a short-circuited `&&` or `||`
chain only in the *final* iteration of loops (as well as in
conditionals, which was already working). From Kartik Agaram.

In execute() we assign xerrorok to a dummy value if it is NULL
so there is no need to check xerrorok for NULL after that.
From Kartik Agaram.

Fix for() loop indentation for TCASE in execute() and add some
braces for improved readability. Based on a diff from Kartik Agaram.

rename global "e" to genv to avoid accidental shadowing and aliasing.
ok millert nicm tb

Move system headers from sh.h to those files that actually need them.

ok mmcc@ a while ago

Add uses of areallocarray(). mksh and Bitrig ksh already have similar
functions. With help from Theo Buehler.

ok nicm@

Move string.h include from sh.h to the files that use it.

ok nicm@

Apply style(9) to header includes.

ok nicm@

Drop two useless defines.

ok nicm@

Move a system header include from the global header (sh.h) into the
files that need it. No binary change.

"This looks fine" -nicm@

Make errorf() and bi_errorf() handle a NULL argument.
From Michael McConville; OK nicm@

Last of the (thing *)0 -> NULL, from Michael McConville. No binary
change.

Remove unnecessary casts, from Michael McConville. No binary change.

correct spelling of NULL from (char *)0. from Michael McConville.
ok md5

Replace Tflag typedef with just int; ok tedu

Replace newline and space defines by "\n" and " " directly, from Michael
McConville. ok millert

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

POSIX specifies that for an AND/OR list, only the last command's
exit status matters for "set -e". Revert the part of revision 1.49
that always sets xerrok for AND/OR. This makes sh/ksh pass the
updated regress tests. OK espie@ jca@

pass "xerrok" status across the execution call stack to more closely
match what both POSIX and ksh.1 already describe in regards to set
-e/errexit's behavior in determining when to exit from nonzero return
values.

specifically, the truth values tested as operands to `&&' and `||', as
well as the resulting compound expression itself, along with the truth
value resulting from a negated command (i.e. a pipeline prefixed `!'),
should not make the shell exit when -e is in effect.

issue reported by matthieu.
testing matthieu, naddy.
ok miod (earlier version), otto.
man page ok jmc.

Call ERR trap _before_ doing exit handling. Otherwise it's too late
and the ERR trap won't get called at all. ok millert@

another memory leak fix found by coverity. from netbsd but modified.
millert@ ok.

fix lint comments, no functional changes; ok ray

Simplify savefd() by removing the "noclose" flag and make noclose
behavior the default. Almost all uses of savefd() are followed
by an implicit or explicit close. OK otto@

fix a few name clashes with libc; found by lint. ok deraadt@

remove unused variables and functions

Fix " handling in here documents. POSIX says they are not special, so
cat << EOF
\"
EOF
should print \"
Fixes PR 4472; testing jmc@ and Adam Montague. ok millert@

lots of indentation cleanup, now ksh is readable like our other code.
double checked to make sure no binaries change, and eyed by niallo

spacing

Fix a use-after-free, that causs core dumps if a shell is killed
running with strict malloc.conf options. Problem spotted by hshoexer@;
fix by me with some help from millert@.

ok millert@ hshoexer@ krw@ deraadt@

Use stdbool.h instead of rolling our own bools.

Ansification plus some minor knf. No binary change on i386 and
sparc64, binary change in lex.o on macppc due to introduction of
dopprompt() prototype. ok millert@

spacing

Replace fd_clexec() with calls to fcntl(fd, F_SETFD, FD_CLOEXEC)

deregister

Get rid of #ifdef KSH since we don't care about building a V7 style sh and
the #ifdef KSH code is required to make a POSIX sh. From Matthias Kilian

Remove unused OS dependent #ifdef blocks, #defines and macro abstraction.
First step in making the ksh code easier to read. From Matthias Kilian

Unbreak parameter assignment when calling bourne style functions;
resolves PR 2450.

ok deraadt@ millert@

If "from fd" == "to fd" don't call dup2() or close "from fd".

For the >& and <& operators, add a check for "dup from" == "dup to" and
just return success if they are the same. Fixes the "ls 2>&2" problem
miod@ found.

typos from Jared Yanovich;
ok deraadt@

typos; from Brian Poole

knf

Use the volatile specifier to fix warnings about variables being
clobbered by longjmp / vfork instead of the gcc "(void)&foo;" hack.

Back out last change, it caused problems with exit vals.

Merge in pdksh-5.2.14-patches.2 to fix some problems with propagated
return values in multi-command lines.

bash-like 'double-tab' completion

- bind TAB (^I) to complete-list by default
- complete-list now lists 'ls style' not 'menu style'
- complete-list first completes; if that does not work, it lists
- fix a memleak in emacs.c, do_complete
- completion now works after '=' (dd), and ':' (ssh) and ` (backtick)
- a command can now start with a subdir from the current dir

silence -Wall

Official fix for workaround in 1.18

pdksh-5.2.14

When redirecting to a file with stdout closed, don't blithely reuse
fd 1 since that will cause future output on stdout to go to the file
that was redirected. There is probably a better fix for this.

patches from pdksh 5.2.13.11

Updates from pdksh-unstable-5.2.13.7. Most notable change is:
trap: exit traps now executed in subshells (without explicit exit call).
See the Changelog for a full list of changes.

sync with pdksh-unstable-5.2.13.6

bug fixes from pdksh-unstable-5.2.13.5; some of which we already had.

Bug fixes from pdksh-unstable-5.2.13.4, including "official" versions of
some that we had already fixed locally.
o typeset -f FUNC doesn't print follows command (and expression) substitutions.
o when re-allocating memory, too much may be copied from old memory.
o set -o printed some options sans names.
o emacs mode: <esc>. in very fist command causes core dump.
o pdksh dumps core after a cd command.
o typeset -i reports on array elements that have no value
(at&t ksh reports on array base name - no index).
o ulimit -ctn unlimittttted kills shell (resource exceeded).
o ". /dev/null" says access denied.
o flag field in aliases incorrectly changed (all flags set instead of
clearing ISSET) in exec.c(flushcom).
o ${#array[*]} prints largest index instead of number of (set) elements
in an array (ksh88 does the former).
o sys_siglist[] doesn't always have NSIG non-null entries...

new ksh code stupidly did not permit ". /dev/null"; enable that again

pdksh-5.2.13 + local changes

Avoid longjmp/vfork clobbering.

back out

(foo *)0 -> NULL

After discussing $_ with the maintainer, revert ksh behaviour and completely
eliminate it from sh.

Add FSH (set -o sh), initialize it if we're /bin/sh, and add the first use:
don't set $_ if we're non-interactive.

Update to 5.2.12.

Integrate pdksh 5.2.9.

Fix problems with compiling without KSH defined, add NOEDIT override.

update to pdksh-5.2.8

branches: 1.1.1;
Initial revision

Trigger ERR trap on permanent I/O redirection failure

The following three cases behave identical in bash(1), but our ksh
(ksh93 also) fails to run the trap in the last case:

(non-zero exit code is trigger, no redirection)
$ ksh -c 'trap "echo ERR" ERR ; false'
ERR

(failed redirection is trigger, 'echo' was not executed)
$ ksh -c 'trap "echo ERR" ERR ; echo >/'
ksh: cannot create /: Is a directory
ERR

(failed redirection, no execution, trap was NOT triggered)
$ ksh -c 'trap "echo ERR" ERR ; exec >/'
ksh: cannot create /: Is a directory


bash(1) prints "ERR" in all three cases, as expected.
ksh93 behaves like our ksh(1).

In ksh `exec' is a builtin (CSHELL), but also special (SPEC_BI):
$ type alias
alias is a shell builtin
$ type exec
exec is a special shell builtin

Without command and redirection alone, `exec' permanently redirects I/O for
the shell itself, not executing anything; it is the only (special) builtin
with such a special use-case, implemented as c_sh.c:c_exec().

This corner-case is overlooked in exec.c:execute() which handles iosetup()
failure for all commands, incl. builtins.

Exclude c_exec() from the rest of special builtins to ensure it runs the
ERR trap as expected:

$ ./obj/ksh -c 'trap "echo ERR" ERR ; exec >/'
ksh: cannot create /: Is a directory
ERR

Also add three new regress cases covering this; rest keep passing.

OK millert

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Favor usage of __func__ in warning/error messages. Some of them referred to the
wrong function and fix the rest for consistency.
Diff from Michael W. Bombardieri with some cosmetic cleanup applied.

ok benno@ tb@

Introduce internal_warningf() and mark internal_errorf() as noreturn

This helps tools like scan-build, and follows the example of warningf()
and errorf(). ok anton@

Stop pretending we support building ksh without EDIT/HISTORY support

ok anton@

Add -Wshadow to Makefile and fix the resulting warnings. Many of
the warnings are due to the use of globals with generic names,
specifically "options" and "path". I've renamed "options" to
"sh_options" since it holds the shell options and "path" to
"search_path". OK jca@ tb@

Get rid of a todo by stop declaring variable texec as static and instead zeroing
it out prior to continuing down the recursive call chain.

Initial diff from Michael W. Bombardieri, later tweaked; ok tb@

I missed a bit of the indentation fix from Kartik Agaram.

When ERREXIT (set -e) is in effect, don't disable it after a
short-circuited `&&` or `||` chain in later iterations of `for`
loops. It should be disabled after a short-circuited `&&` or `||`
chain only in the *final* iteration of loops (as well as in
conditionals, which was already working). From Kartik Agaram.

In execute() we assign xerrorok to a dummy value if it is NULL
so there is no need to check xerrorok for NULL after that.
From Kartik Agaram.

Fix for() loop indentation for TCASE in execute() and add some
braces for improved readability. Based on a diff from Kartik Agaram.

rename global "e" to genv to avoid accidental shadowing and aliasing.
ok millert nicm tb

Move system headers from sh.h to those files that actually need them.

ok mmcc@ a while ago

Add uses of areallocarray(). mksh and Bitrig ksh already have similar
functions. With help from Theo Buehler.

ok nicm@

Move string.h include from sh.h to the files that use it.

ok nicm@

Apply style(9) to header includes.

ok nicm@

Drop two useless defines.

ok nicm@

Move a system header include from the global header (sh.h) into the
files that need it. No binary change.

"This looks fine" -nicm@

Make errorf() and bi_errorf() handle a NULL argument.
From Michael McConville; OK nicm@

Last of the (thing *)0 -> NULL, from Michael McConville. No binary
change.

Remove unnecessary casts, from Michael McConville. No binary change.

correct spelling of NULL from (char *)0. from Michael McConville.
ok md5

Replace Tflag typedef with just int; ok tedu

Replace newline and space defines by "\n" and " " directly, from Michael
McConville. ok millert

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

POSIX specifies that for an AND/OR list, only the last command's
exit status matters for "set -e". Revert the part of revision 1.49
that always sets xerrok for AND/OR. This makes sh/ksh pass the
updated regress tests. OK espie@ jca@

pass "xerrok" status across the execution call stack to more closely
match what both POSIX and ksh.1 already describe in regards to set
-e/errexit's behavior in determining when to exit from nonzero return
values.

specifically, the truth values tested as operands to `&&' and `||', as
well as the resulting compound expression itself, along with the truth
value resulting from a negated command (i.e. a pipeline prefixed `!'),
should not make the shell exit when -e is in effect.

issue reported by matthieu.
testing matthieu, naddy.
ok miod (earlier version), otto.
man page ok jmc.

Call ERR trap _before_ doing exit handling. Otherwise it's too late
and the ERR trap won't get called at all. ok millert@

another memory leak fix found by coverity. from netbsd but modified.
millert@ ok.

fix lint comments, no functional changes; ok ray

Simplify savefd() by removing the "noclose" flag and make noclose
behavior the default. Almost all uses of savefd() are followed
by an implicit or explicit close. OK otto@

fix a few name clashes with libc; found by lint. ok deraadt@

remove unused variables and functions

Fix " handling in here documents. POSIX says they are not special, so
cat << EOF
\"
EOF
should print \"
Fixes PR 4472; testing jmc@ and Adam Montague. ok millert@

lots of indentation cleanup, now ksh is readable like our other code.
double checked to make sure no binaries change, and eyed by niallo

spacing

Fix a use-after-free, that causs core dumps if a shell is killed
running with strict malloc.conf options. Problem spotted by hshoexer@;
fix by me with some help from millert@.

ok millert@ hshoexer@ krw@ deraadt@

Use stdbool.h instead of rolling our own bools.

Ansification plus some minor knf. No binary change on i386 and
sparc64, binary change in lex.o on macppc due to introduction of
dopprompt() prototype. ok millert@

spacing

Replace fd_clexec() with calls to fcntl(fd, F_SETFD, FD_CLOEXEC)

deregister

Get rid of #ifdef KSH since we don't care about building a V7 style sh and
the #ifdef KSH code is required to make a POSIX sh. From Matthias Kilian

Remove unused OS dependent #ifdef blocks, #defines and macro abstraction.
First step in making the ksh code easier to read. From Matthias Kilian

Unbreak parameter assignment when calling bourne style functions;
resolves PR 2450.

ok deraadt@ millert@

If "from fd" == "to fd" don't call dup2() or close "from fd".

For the >& and <& operators, add a check for "dup from" == "dup to" and
just return success if they are the same. Fixes the "ls 2>&2" problem
miod@ found.

typos from Jared Yanovich;
ok deraadt@

typos; from Brian Poole

knf

Use the volatile specifier to fix warnings about variables being
clobbered by longjmp / vfork instead of the gcc "(void)&foo;" hack.

Back out last change, it caused problems with exit vals.

Merge in pdksh-5.2.14-patches.2 to fix some problems with propagated
return values in multi-command lines.

bash-like 'double-tab' completion

- bind TAB (^I) to complete-list by default
- complete-list now lists 'ls style' not 'menu style'
- complete-list first completes; if that does not work, it lists
- fix a memleak in emacs.c, do_complete
- completion now works after '=' (dd), and ':' (ssh) and ` (backtick)
- a command can now start with a subdir from the current dir

silence -Wall

Official fix for workaround in 1.18

pdksh-5.2.14

When redirecting to a file with stdout closed, don't blithely reuse
fd 1 since that will cause future output on stdout to go to the file
that was redirected. There is probably a better fix for this.

patches from pdksh 5.2.13.11

Updates from pdksh-unstable-5.2.13.7. Most notable change is:
trap: exit traps now executed in subshells (without explicit exit call).
See the Changelog for a full list of changes.

sync with pdksh-unstable-5.2.13.6

bug fixes from pdksh-unstable-5.2.13.5; some of which we already had.

Bug fixes from pdksh-unstable-5.2.13.4, including "official" versions of
some that we had already fixed locally.
o typeset -f FUNC doesn't print follows command (and expression) substitutions.
o when re-allocating memory, too much may be copied from old memory.
o set -o printed some options sans names.
o emacs mode: <esc>. in very fist command causes core dump.
o pdksh dumps core after a cd command.
o typeset -i reports on array elements that have no value
(at&t ksh reports on array base name - no index).
o ulimit -ctn unlimittttted kills shell (resource exceeded).
o ". /dev/null" says access denied.
o flag field in aliases incorrectly changed (all flags set instead of
clearing ISSET) in exec.c(flushcom).
o ${#array[*]} prints largest index instead of number of (set) elements
in an array (ksh88 does the former).
o sys_siglist[] doesn't always have NSIG non-null entries...

new ksh code stupidly did not permit ". /dev/null"; enable that again

pdksh-5.2.13 + local changes

Avoid longjmp/vfork clobbering.

back out

(foo *)0 -> NULL

After discussing $_ with the maintainer, revert ksh behaviour and completely
eliminate it from sh.

Add FSH (set -o sh), initialize it if we're /bin/sh, and add the first use:
don't set $_ if we're non-interactive.

Update to 5.2.12.

Integrate pdksh 5.2.9.

Fix problems with compiling without KSH defined, add NOEDIT override.

update to pdksh-5.2.8

branches: 1.1.1;
Initial revision

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Favor usage of __func__ in warning/error messages. Some of them referred to the
wrong function and fix the rest for consistency.
Diff from Michael W. Bombardieri with some cosmetic cleanup applied.

ok benno@ tb@

Introduce internal_warningf() and mark internal_errorf() as noreturn

This helps tools like scan-build, and follows the example of warningf()
and errorf(). ok anton@

Stop pretending we support building ksh without EDIT/HISTORY support

ok anton@

Add -Wshadow to Makefile and fix the resulting warnings. Many of
the warnings are due to the use of globals with generic names,
specifically "options" and "path". I've renamed "options" to
"sh_options" since it holds the shell options and "path" to
"search_path". OK jca@ tb@

Get rid of a todo by stop declaring variable texec as static and instead zeroing
it out prior to continuing down the recursive call chain.

Initial diff from Michael W. Bombardieri, later tweaked; ok tb@

I missed a bit of the indentation fix from Kartik Agaram.

When ERREXIT (set -e) is in effect, don't disable it after a
short-circuited `&&` or `||` chain in later iterations of `for`
loops. It should be disabled after a short-circuited `&&` or `||`
chain only in the *final* iteration of loops (as well as in
conditionals, which was already working). From Kartik Agaram.

In execute() we assign xerrorok to a dummy value if it is NULL
so there is no need to check xerrorok for NULL after that.
From Kartik Agaram.

Fix for() loop indentation for TCASE in execute() and add some
braces for improved readability. Based on a diff from Kartik Agaram.

rename global "e" to genv to avoid accidental shadowing and aliasing.
ok millert nicm tb

Move system headers from sh.h to those files that actually need them.

ok mmcc@ a while ago

Add uses of areallocarray(). mksh and Bitrig ksh already have similar
functions. With help from Theo Buehler.

ok nicm@

Move string.h include from sh.h to the files that use it.

ok nicm@

Apply style(9) to header includes.

ok nicm@

Drop two useless defines.

ok nicm@

Move a system header include from the global header (sh.h) into the
files that need it. No binary change.

"This looks fine" -nicm@

Make errorf() and bi_errorf() handle a NULL argument.
From Michael McConville; OK nicm@

Last of the (thing *)0 -> NULL, from Michael McConville. No binary
change.

Remove unnecessary casts, from Michael McConville. No binary change.

correct spelling of NULL from (char *)0. from Michael McConville.
ok md5

Replace Tflag typedef with just int; ok tedu

Replace newline and space defines by "\n" and " " directly, from Michael
McConville. ok millert

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

POSIX specifies that for an AND/OR list, only the last command's
exit status matters for "set -e". Revert the part of revision 1.49
that always sets xerrok for AND/OR. This makes sh/ksh pass the
updated regress tests. OK espie@ jca@

pass "xerrok" status across the execution call stack to more closely
match what both POSIX and ksh.1 already describe in regards to set
-e/errexit's behavior in determining when to exit from nonzero return
values.

specifically, the truth values tested as operands to `&&' and `||', as
well as the resulting compound expression itself, along with the truth
value resulting from a negated command (i.e. a pipeline prefixed `!'),
should not make the shell exit when -e is in effect.

issue reported by matthieu.
testing matthieu, naddy.
ok miod (earlier version), otto.
man page ok jmc.

Call ERR trap _before_ doing exit handling. Otherwise it's too late
and the ERR trap won't get called at all. ok millert@

another memory leak fix found by coverity. from netbsd but modified.
millert@ ok.

fix lint comments, no functional changes; ok ray

Simplify savefd() by removing the "noclose" flag and make noclose
behavior the default. Almost all uses of savefd() are followed
by an implicit or explicit close. OK otto@

fix a few name clashes with libc; found by lint. ok deraadt@

remove unused variables and functions

Fix " handling in here documents. POSIX says they are not special, so
cat << EOF
\"
EOF
should print \"
Fixes PR 4472; testing jmc@ and Adam Montague. ok millert@

lots of indentation cleanup, now ksh is readable like our other code.
double checked to make sure no binaries change, and eyed by niallo

spacing

Fix a use-after-free, that causs core dumps if a shell is killed
running with strict malloc.conf options. Problem spotted by hshoexer@;
fix by me with some help from millert@.

ok millert@ hshoexer@ krw@ deraadt@

Use stdbool.h instead of rolling our own bools.

Ansification plus some minor knf. No binary change on i386 and
sparc64, binary change in lex.o on macppc due to introduction of
dopprompt() prototype. ok millert@

spacing

Replace fd_clexec() with calls to fcntl(fd, F_SETFD, FD_CLOEXEC)

deregister

Get rid of #ifdef KSH since we don't care about building a V7 style sh and
the #ifdef KSH code is required to make a POSIX sh. From Matthias Kilian

Remove unused OS dependent #ifdef blocks, #defines and macro abstraction.
First step in making the ksh code easier to read. From Matthias Kilian

Unbreak parameter assignment when calling bourne style functions;
resolves PR 2450.

ok deraadt@ millert@

If "from fd" == "to fd" don't call dup2() or close "from fd".

For the >& and <& operators, add a check for "dup from" == "dup to" and
just return success if they are the same. Fixes the "ls 2>&2" problem
miod@ found.

typos from Jared Yanovich;
ok deraadt@

typos; from Brian Poole

knf

Use the volatile specifier to fix warnings about variables being
clobbered by longjmp / vfork instead of the gcc "(void)&foo;" hack.

Back out last change, it caused problems with exit vals.

Merge in pdksh-5.2.14-patches.2 to fix some problems with propagated
return values in multi-command lines.

bash-like 'double-tab' completion

- bind TAB (^I) to complete-list by default
- complete-list now lists 'ls style' not 'menu style'
- complete-list first completes; if that does not work, it lists
- fix a memleak in emacs.c, do_complete
- completion now works after '=' (dd), and ':' (ssh) and ` (backtick)
- a command can now start with a subdir from the current dir

silence -Wall

Official fix for workaround in 1.18

pdksh-5.2.14

When redirecting to a file with stdout closed, don't blithely reuse
fd 1 since that will cause future output on stdout to go to the file
that was redirected. There is probably a better fix for this.

patches from pdksh 5.2.13.11

Updates from pdksh-unstable-5.2.13.7. Most notable change is:
trap: exit traps now executed in subshells (without explicit exit call).
See the Changelog for a full list of changes.

sync with pdksh-unstable-5.2.13.6

bug fixes from pdksh-unstable-5.2.13.5; some of which we already had.

Bug fixes from pdksh-unstable-5.2.13.4, including "official" versions of
some that we had already fixed locally.
o typeset -f FUNC doesn't print follows command (and expression) substitutions.
o when re-allocating memory, too much may be copied from old memory.
o set -o printed some options sans names.
o emacs mode: <esc>. in very fist command causes core dump.
o pdksh dumps core after a cd command.
o typeset -i reports on array elements that have no value
(at&t ksh reports on array base name - no index).
o ulimit -ctn unlimittttted kills shell (resource exceeded).
o ". /dev/null" says access denied.
o flag field in aliases incorrectly changed (all flags set instead of
clearing ISSET) in exec.c(flushcom).
o ${#array[*]} prints largest index instead of number of (set) elements
in an array (ksh88 does the former).
o sys_siglist[] doesn't always have NSIG non-null entries...

new ksh code stupidly did not permit ". /dev/null"; enable that again

pdksh-5.2.13 + local changes

Avoid longjmp/vfork clobbering.

back out

(foo *)0 -> NULL

After discussing $_ with the maintainer, revert ksh behaviour and completely
eliminate it from sh.

Add FSH (set -o sh), initialize it if we're /bin/sh, and add the first use:
don't set $_ if we're non-interactive.

Update to 5.2.12.

Integrate pdksh 5.2.9.

Fix problems with compiling without KSH defined, add NOEDIT override.

update to pdksh-5.2.8

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Favor usage of __func__ in warning/error messages. Some of them referred to the
wrong function and fix the rest for consistency.
Diff from Michael W. Bombardieri with some cosmetic cleanup applied.

ok benno@ tb@

Introduce internal_warningf() and mark internal_errorf() as noreturn

This helps tools like scan-build, and follows the example of warningf()
and errorf(). ok anton@

Stop pretending we support building ksh without EDIT/HISTORY support

ok anton@

Add -Wshadow to Makefile and fix the resulting warnings. Many of
the warnings are due to the use of globals with generic names,
specifically "options" and "path". I've renamed "options" to
"sh_options" since it holds the shell options and "path" to
"search_path". OK jca@ tb@

Get rid of a todo by stop declaring variable texec as static and instead zeroing
it out prior to continuing down the recursive call chain.

Initial diff from Michael W. Bombardieri, later tweaked; ok tb@

I missed a bit of the indentation fix from Kartik Agaram.

When ERREXIT (set -e) is in effect, don't disable it after a
short-circuited `&&` or `||` chain in later iterations of `for`
loops. It should be disabled after a short-circuited `&&` or `||`
chain only in the *final* iteration of loops (as well as in
conditionals, which was already working). From Kartik Agaram.

In execute() we assign xerrorok to a dummy value if it is NULL
so there is no need to check xerrorok for NULL after that.
From Kartik Agaram.

Fix for() loop indentation for TCASE in execute() and add some
braces for improved readability. Based on a diff from Kartik Agaram.

rename global "e" to genv to avoid accidental shadowing and aliasing.
ok millert nicm tb

Move system headers from sh.h to those files that actually need them.

ok mmcc@ a while ago

Add uses of areallocarray(). mksh and Bitrig ksh already have similar
functions. With help from Theo Buehler.

ok nicm@

Move string.h include from sh.h to the files that use it.

ok nicm@

Apply style(9) to header includes.

ok nicm@

Drop two useless defines.

ok nicm@

Move a system header include from the global header (sh.h) into the
files that need it. No binary change.

"This looks fine" -nicm@

Make errorf() and bi_errorf() handle a NULL argument.
From Michael McConville; OK nicm@

Last of the (thing *)0 -> NULL, from Michael McConville. No binary
change.

Remove unnecessary casts, from Michael McConville. No binary change.

correct spelling of NULL from (char *)0. from Michael McConville.
ok md5

Replace Tflag typedef with just int; ok tedu

Replace newline and space defines by "\n" and " " directly, from Michael
McConville. ok millert

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

POSIX specifies that for an AND/OR list, only the last command's
exit status matters for "set -e". Revert the part of revision 1.49
that always sets xerrok for AND/OR. This makes sh/ksh pass the
updated regress tests. OK espie@ jca@

pass "xerrok" status across the execution call stack to more closely
match what both POSIX and ksh.1 already describe in regards to set
-e/errexit's behavior in determining when to exit from nonzero return
values.

specifically, the truth values tested as operands to `&&' and `||', as
well as the resulting compound expression itself, along with the truth
value resulting from a negated command (i.e. a pipeline prefixed `!'),
should not make the shell exit when -e is in effect.

issue reported by matthieu.
testing matthieu, naddy.
ok miod (earlier version), otto.
man page ok jmc.

Call ERR trap _before_ doing exit handling. Otherwise it's too late
and the ERR trap won't get called at all. ok millert@

another memory leak fix found by coverity. from netbsd but modified.
millert@ ok.

fix lint comments, no functional changes; ok ray

Simplify savefd() by removing the "noclose" flag and make noclose
behavior the default. Almost all uses of savefd() are followed
by an implicit or explicit close. OK otto@

fix a few name clashes with libc; found by lint. ok deraadt@

remove unused variables and functions

Fix " handling in here documents. POSIX says they are not special, so
cat << EOF
\"
EOF
should print \"
Fixes PR 4472; testing jmc@ and Adam Montague. ok millert@

lots of indentation cleanup, now ksh is readable like our other code.
double checked to make sure no binaries change, and eyed by niallo

spacing

Fix a use-after-free, that causs core dumps if a shell is killed
running with strict malloc.conf options. Problem spotted by hshoexer@;
fix by me with some help from millert@.

ok millert@ hshoexer@ krw@ deraadt@

Use stdbool.h instead of rolling our own bools.

Ansification plus some minor knf. No binary change on i386 and
sparc64, binary change in lex.o on macppc due to introduction of
dopprompt() prototype. ok millert@

spacing

Replace fd_clexec() with calls to fcntl(fd, F_SETFD, FD_CLOEXEC)

deregister

Get rid of #ifdef KSH since we don't care about building a V7 style sh and
the #ifdef KSH code is required to make a POSIX sh. From Matthias Kilian

Remove unused OS dependent #ifdef blocks, #defines and macro abstraction.
First step in making the ksh code easier to read. From Matthias Kilian

Unbreak parameter assignment when calling bourne style functions;
resolves PR 2450.

ok deraadt@ millert@

If "from fd" == "to fd" don't call dup2() or close "from fd".

For the >& and <& operators, add a check for "dup from" == "dup to" and
just return success if they are the same. Fixes the "ls 2>&2" problem
miod@ found.

typos from Jared Yanovich;
ok deraadt@

typos; from Brian Poole

knf

Use the volatile specifier to fix warnings about variables being
clobbered by longjmp / vfork instead of the gcc "(void)&foo;" hack.

Back out last change, it caused problems with exit vals.

Merge in pdksh-5.2.14-patches.2 to fix some problems with propagated
return values in multi-command lines.

bash-like 'double-tab' completion

- bind TAB (^I) to complete-list by default
- complete-list now lists 'ls style' not 'menu style'
- complete-list first completes; if that does not work, it lists
- fix a memleak in emacs.c, do_complete
- completion now works after '=' (dd), and ':' (ssh) and ` (backtick)
- a command can now start with a subdir from the current dir

silence -Wall

Official fix for workaround in 1.18

pdksh-5.2.14

When redirecting to a file with stdout closed, don't blithely reuse
fd 1 since that will cause future output on stdout to go to the file
that was redirected. There is probably a better fix for this.

patches from pdksh 5.2.13.11

Updates from pdksh-unstable-5.2.13.7. Most notable change is:
trap: exit traps now executed in subshells (without explicit exit call).
See the Changelog for a full list of changes.

sync with pdksh-unstable-5.2.13.6

bug fixes from pdksh-unstable-5.2.13.5; some of which we already had.

Bug fixes from pdksh-unstable-5.2.13.4, including "official" versions of
some that we had already fixed locally.
o typeset -f FUNC doesn't print follows command (and expression) substitutions.
o when re-allocating memory, too much may be copied from old memory.
o set -o printed some options sans names.
o emacs mode: <esc>. in very fist command causes core dump.
o pdksh dumps core after a cd command.
o typeset -i reports on array elements that have no value
(at&t ksh reports on array base name - no index).
o ulimit -ctn unlimittttted kills shell (resource exceeded).
o ". /dev/null" says access denied.
o flag field in aliases incorrectly changed (all flags set instead of
clearing ISSET) in exec.c(flushcom).
o ${#array[*]} prints largest index instead of number of (set) elements
in an array (ksh88 does the former).
o sys_siglist[] doesn't always have NSIG non-null entries...

new ksh code stupidly did not permit ". /dev/null"; enable that again

pdksh-5.2.13 + local changes

Avoid longjmp/vfork clobbering.

back out

(foo *)0 -> NULL

After discussing $_ with the maintainer, revert ksh behaviour and completely
eliminate it from sh.

Add FSH (set -o sh), initialize it if we're /bin/sh, and add the first use:
don't set $_ if we're non-interactive.

Update to 5.2.12.

Integrate pdksh 5.2.9.

Fix problems with compiling without KSH defined, add NOEDIT override.

update to pdksh-5.2.8

branches: 1.1.1;
Initial revision

Favor usage of __func__ in warning/error messages. Some of them referred to the
wrong function and fix the rest for consistency.
Diff from Michael W. Bombardieri with some cosmetic cleanup applied.

ok benno@ tb@

Introduce internal_warningf() and mark internal_errorf() as noreturn

This helps tools like scan-build, and follows the example of warningf()
and errorf(). ok anton@

Stop pretending we support building ksh without EDIT/HISTORY support

ok anton@

Add -Wshadow to Makefile and fix the resulting warnings. Many of
the warnings are due to the use of globals with generic names,
specifically "options" and "path". I've renamed "options" to
"sh_options" since it holds the shell options and "path" to
"search_path". OK jca@ tb@

Get rid of a todo by stop declaring variable texec as static and instead zeroing
it out prior to continuing down the recursive call chain.

Initial diff from Michael W. Bombardieri, later tweaked; ok tb@

I missed a bit of the indentation fix from Kartik Agaram.

When ERREXIT (set -e) is in effect, don't disable it after a
short-circuited `&&` or `||` chain in later iterations of `for`
loops. It should be disabled after a short-circuited `&&` or `||`
chain only in the *final* iteration of loops (as well as in
conditionals, which was already working). From Kartik Agaram.

In execute() we assign xerrorok to a dummy value if it is NULL
so there is no need to check xerrorok for NULL after that.
From Kartik Agaram.

Fix for() loop indentation for TCASE in execute() and add some
braces for improved readability. Based on a diff from Kartik Agaram.

rename global "e" to genv to avoid accidental shadowing and aliasing.
ok millert nicm tb

Move system headers from sh.h to those files that actually need them.

ok mmcc@ a while ago

Add uses of areallocarray(). mksh and Bitrig ksh already have similar
functions. With help from Theo Buehler.

ok nicm@

Move string.h include from sh.h to the files that use it.

ok nicm@

Apply style(9) to header includes.

ok nicm@

Drop two useless defines.

ok nicm@

Move a system header include from the global header (sh.h) into the
files that need it. No binary change.

"This looks fine" -nicm@

Make errorf() and bi_errorf() handle a NULL argument.
From Michael McConville; OK nicm@

Last of the (thing *)0 -> NULL, from Michael McConville. No binary
change.

Remove unnecessary casts, from Michael McConville. No binary change.

correct spelling of NULL from (char *)0. from Michael McConville.
ok md5

Replace Tflag typedef with just int; ok tedu

Replace newline and space defines by "\n" and " " directly, from Michael
McConville. ok millert

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

POSIX specifies that for an AND/OR list, only the last command's
exit status matters for "set -e". Revert the part of revision 1.49
that always sets xerrok for AND/OR. This makes sh/ksh pass the
updated regress tests. OK espie@ jca@

pass "xerrok" status across the execution call stack to more closely
match what both POSIX and ksh.1 already describe in regards to set
-e/errexit's behavior in determining when to exit from nonzero return
values.

specifically, the truth values tested as operands to `&&' and `||', as
well as the resulting compound expression itself, along with the truth
value resulting from a negated command (i.e. a pipeline prefixed `!'),
should not make the shell exit when -e is in effect.

issue reported by matthieu.
testing matthieu, naddy.
ok miod (earlier version), otto.
man page ok jmc.

Call ERR trap _before_ doing exit handling. Otherwise it's too late
and the ERR trap won't get called at all. ok millert@

another memory leak fix found by coverity. from netbsd but modified.
millert@ ok.

fix lint comments, no functional changes; ok ray

Simplify savefd() by removing the "noclose" flag and make noclose
behavior the default. Almost all uses of savefd() are followed
by an implicit or explicit close. OK otto@

fix a few name clashes with libc; found by lint. ok deraadt@

remove unused variables and functions

Fix " handling in here documents. POSIX says they are not special, so
cat << EOF
\"
EOF
should print \"
Fixes PR 4472; testing jmc@ and Adam Montague. ok millert@

lots of indentation cleanup, now ksh is readable like our other code.
double checked to make sure no binaries change, and eyed by niallo

spacing

Fix a use-after-free, that causs core dumps if a shell is killed
running with strict malloc.conf options. Problem spotted by hshoexer@;
fix by me with some help from millert@.

ok millert@ hshoexer@ krw@ deraadt@

Use stdbool.h instead of rolling our own bools.

Ansification plus some minor knf. No binary change on i386 and
sparc64, binary change in lex.o on macppc due to introduction of
dopprompt() prototype. ok millert@

spacing

Replace fd_clexec() with calls to fcntl(fd, F_SETFD, FD_CLOEXEC)

deregister

Get rid of #ifdef KSH since we don't care about building a V7 style sh and
the #ifdef KSH code is required to make a POSIX sh. From Matthias Kilian

Remove unused OS dependent #ifdef blocks, #defines and macro abstraction.
First step in making the ksh code easier to read. From Matthias Kilian

Unbreak parameter assignment when calling bourne style functions;
resolves PR 2450.

ok deraadt@ millert@

If "from fd" == "to fd" don't call dup2() or close "from fd".

For the >& and <& operators, add a check for "dup from" == "dup to" and
just return success if they are the same. Fixes the "ls 2>&2" problem
miod@ found.

typos from Jared Yanovich;
ok deraadt@

typos; from Brian Poole

knf

Use the volatile specifier to fix warnings about variables being
clobbered by longjmp / vfork instead of the gcc "(void)&foo;" hack.

Back out last change, it caused problems with exit vals.

Merge in pdksh-5.2.14-patches.2 to fix some problems with propagated
return values in multi-command lines.

bash-like 'double-tab' completion

- bind TAB (^I) to complete-list by default
- complete-list now lists 'ls style' not 'menu style'
- complete-list first completes; if that does not work, it lists
- fix a memleak in emacs.c, do_complete
- completion now works after '=' (dd), and ':' (ssh) and ` (backtick)
- a command can now start with a subdir from the current dir

silence -Wall

Official fix for workaround in 1.18

pdksh-5.2.14

When redirecting to a file with stdout closed, don't blithely reuse
fd 1 since that will cause future output on stdout to go to the file
that was redirected. There is probably a better fix for this.

patches from pdksh 5.2.13.11

Updates from pdksh-unstable-5.2.13.7. Most notable change is:
trap: exit traps now executed in subshells (without explicit exit call).
See the Changelog for a full list of changes.

sync with pdksh-unstable-5.2.13.6

bug fixes from pdksh-unstable-5.2.13.5; some of which we already had.

Bug fixes from pdksh-unstable-5.2.13.4, including "official" versions of
some that we had already fixed locally.
o typeset -f FUNC doesn't print follows command (and expression) substitutions.
o when re-allocating memory, too much may be copied from old memory.
o set -o printed some options sans names.
o emacs mode: <esc>. in very fist command causes core dump.
o pdksh dumps core after a cd command.
o typeset -i reports on array elements that have no value
(at&t ksh reports on array base name - no index).
o ulimit -ctn unlimittttted kills shell (resource exceeded).
o ". /dev/null" says access denied.
o flag field in aliases incorrectly changed (all flags set instead of
clearing ISSET) in exec.c(flushcom).
o ${#array[*]} prints largest index instead of number of (set) elements
in an array (ksh88 does the former).
o sys_siglist[] doesn't always have NSIG non-null entries...

new ksh code stupidly did not permit ". /dev/null"; enable that again

pdksh-5.2.13 + local changes

Avoid longjmp/vfork clobbering.

back out

(foo *)0 -> NULL

After discussing $_ with the maintainer, revert ksh behaviour and completely
eliminate it from sh.

Add FSH (set -o sh), initialize it if we're /bin/sh, and add the first use:
don't set $_ if we're non-interactive.

Update to 5.2.12.

Integrate pdksh 5.2.9.

Fix problems with compiling without KSH defined, add NOEDIT override.

update to pdksh-5.2.8

branches: 1.1.1;
Initial revision

Introduce internal_warningf() and mark internal_errorf() as noreturn

This helps tools like scan-build, and follows the example of warningf()
and errorf(). ok anton@

Stop pretending we support building ksh without EDIT/HISTORY support

ok anton@

Add -Wshadow to Makefile and fix the resulting warnings. Many of
the warnings are due to the use of globals with generic names,
specifically "options" and "path". I've renamed "options" to
"sh_options" since it holds the shell options and "path" to
"search_path". OK jca@ tb@

Get rid of a todo by stop declaring variable texec as static and instead zeroing
it out prior to continuing down the recursive call chain.

Initial diff from Michael W. Bombardieri, later tweaked; ok tb@

I missed a bit of the indentation fix from Kartik Agaram.

When ERREXIT (set -e) is in effect, don't disable it after a
short-circuited `&&` or `||` chain in later iterations of `for`
loops. It should be disabled after a short-circuited `&&` or `||`
chain only in the *final* iteration of loops (as well as in
conditionals, which was already working). From Kartik Agaram.

In execute() we assign xerrorok to a dummy value if it is NULL
so there is no need to check xerrorok for NULL after that.
From Kartik Agaram.

Fix for() loop indentation for TCASE in execute() and add some
braces for improved readability. Based on a diff from Kartik Agaram.

rename global "e" to genv to avoid accidental shadowing and aliasing.
ok millert nicm tb

Move system headers from sh.h to those files that actually need them.

ok mmcc@ a while ago

Add uses of areallocarray(). mksh and Bitrig ksh already have similar
functions. With help from Theo Buehler.

ok nicm@

Move string.h include from sh.h to the files that use it.

ok nicm@

Apply style(9) to header includes.

ok nicm@

Drop two useless defines.

ok nicm@

Move a system header include from the global header (sh.h) into the
files that need it. No binary change.

"This looks fine" -nicm@

Make errorf() and bi_errorf() handle a NULL argument.
From Michael McConville; OK nicm@

Last of the (thing *)0 -> NULL, from Michael McConville. No binary
change.

Remove unnecessary casts, from Michael McConville. No binary change.

correct spelling of NULL from (char *)0. from Michael McConville.
ok md5

Replace Tflag typedef with just int; ok tedu

Replace newline and space defines by "\n" and " " directly, from Michael
McConville. ok millert

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

POSIX specifies that for an AND/OR list, only the last command's
exit status matters for "set -e". Revert the part of revision 1.49
that always sets xerrok for AND/OR. This makes sh/ksh pass the
updated regress tests. OK espie@ jca@

pass "xerrok" status across the execution call stack to more closely
match what both POSIX and ksh.1 already describe in regards to set
-e/errexit's behavior in determining when to exit from nonzero return
values.

specifically, the truth values tested as operands to `&&' and `||', as
well as the resulting compound expression itself, along with the truth
value resulting from a negated command (i.e. a pipeline prefixed `!'),
should not make the shell exit when -e is in effect.

issue reported by matthieu.
testing matthieu, naddy.
ok miod (earlier version), otto.
man page ok jmc.

Call ERR trap _before_ doing exit handling. Otherwise it's too late
and the ERR trap won't get called at all. ok millert@

another memory leak fix found by coverity. from netbsd but modified.
millert@ ok.

fix lint comments, no functional changes; ok ray

Simplify savefd() by removing the "noclose" flag and make noclose
behavior the default. Almost all uses of savefd() are followed
by an implicit or explicit close. OK otto@

fix a few name clashes with libc; found by lint. ok deraadt@

remove unused variables and functions

Fix " handling in here documents. POSIX says they are not special, so
cat << EOF
\"
EOF
should print \"
Fixes PR 4472; testing jmc@ and Adam Montague. ok millert@

lots of indentation cleanup, now ksh is readable like our other code.
double checked to make sure no binaries change, and eyed by niallo

spacing

Fix a use-after-free, that causs core dumps if a shell is killed
running with strict malloc.conf options. Problem spotted by hshoexer@;
fix by me with some help from millert@.

ok millert@ hshoexer@ krw@ deraadt@

Use stdbool.h instead of rolling our own bools.

Ansification plus some minor knf. No binary change on i386 and
sparc64, binary change in lex.o on macppc due to introduction of
dopprompt() prototype. ok millert@

spacing

Replace fd_clexec() with calls to fcntl(fd, F_SETFD, FD_CLOEXEC)

deregister

Get rid of #ifdef KSH since we don't care about building a V7 style sh and
the #ifdef KSH code is required to make a POSIX sh. From Matthias Kilian

Remove unused OS dependent #ifdef blocks, #defines and macro abstraction.
First step in making the ksh code easier to read. From Matthias Kilian

Unbreak parameter assignment when calling bourne style functions;
resolves PR 2450.

ok deraadt@ millert@

If "from fd" == "to fd" don't call dup2() or close "from fd".

For the >& and <& operators, add a check for "dup from" == "dup to" and
just return success if they are the same. Fixes the "ls 2>&2" problem
miod@ found.

typos from Jared Yanovich;
ok deraadt@

typos; from Brian Poole

knf

Use the volatile specifier to fix warnings about variables being
clobbered by longjmp / vfork instead of the gcc "(void)&foo;" hack.

Back out last change, it caused problems with exit vals.

Merge in pdksh-5.2.14-patches.2 to fix some problems with propagated
return values in multi-command lines.

bash-like 'double-tab' completion

- bind TAB (^I) to complete-list by default
- complete-list now lists 'ls style' not 'menu style'
- complete-list first completes; if that does not work, it lists
- fix a memleak in emacs.c, do_complete
- completion now works after '=' (dd), and ':' (ssh) and ` (backtick)
- a command can now start with a subdir from the current dir

silence -Wall

Official fix for workaround in 1.18

pdksh-5.2.14

When redirecting to a file with stdout closed, don't blithely reuse
fd 1 since that will cause future output on stdout to go to the file
that was redirected. There is probably a better fix for this.

patches from pdksh 5.2.13.11

Updates from pdksh-unstable-5.2.13.7. Most notable change is:
trap: exit traps now executed in subshells (without explicit exit call).
See the Changelog for a full list of changes.

sync with pdksh-unstable-5.2.13.6

bug fixes from pdksh-unstable-5.2.13.5; some of which we already had.

Bug fixes from pdksh-unstable-5.2.13.4, including "official" versions of
some that we had already fixed locally.
o typeset -f FUNC doesn't print follows command (and expression) substitutions.
o when re-allocating memory, too much may be copied from old memory.
o set -o printed some options sans names.
o emacs mode: <esc>. in very fist command causes core dump.
o pdksh dumps core after a cd command.
o typeset -i reports on array elements that have no value
(at&t ksh reports on array base name - no index).
o ulimit -ctn unlimittttted kills shell (resource exceeded).
o ". /dev/null" says access denied.
o flag field in aliases incorrectly changed (all flags set instead of
clearing ISSET) in exec.c(flushcom).
o ${#array[*]} prints largest index instead of number of (set) elements
in an array (ksh88 does the former).
o sys_siglist[] doesn't always have NSIG non-null entries...

new ksh code stupidly did not permit ". /dev/null"; enable that again

pdksh-5.2.13 + local changes

Avoid longjmp/vfork clobbering.