PR/57166: John Dundas: Correct error code byte order in error message

storage class first, *then* __dead

Remove K&R __P macros.
Remove main() function prototype if present.
Mark usage() as __dead if not already.
Binaries generated with & without these patches were compared with diff -r.

Undo the non-sharing of the "toplevel" jmp_buf between main.c and tftp.c,
so that we don't get a core dump if a transfer time-out is experienced.
Also, get rid of an extranous newline printed in the case of time-out.

Use C89 function definitions

branches: 1.32.2; 1.32.4;
ansify, const, knf

Use __dead

fix -Wsign-compare issues

- Malformed multicast option not being checked
for correctly. Could fault client.
- 'mc' (master client) field not being examined
properly. Actually looking at addr field so
proably always working out to non 0 (master).

sprinkle volatile.

Coverity CID 4119: Check negative returns (from Arnaud Lacombe)

Add support for the multicast TFTP option. Reviewed by Rui Paulo.

Pass lint.

Do not use %d for size_t!

PR/32680: Yves-Emmanuel JUTARD: Improve some error checking that causes
memory corruption on out of memory errors.
While I am here, remove some lint.

Fix old-style C code, update to WARNS=4.
Also, move file-scope .c extern decls to the .h file

appease gcc -Wuninitialized

Move declaration of local variables to start of function instead of
inside a block after code. Fixes build problem for vax, which still
uses gcc 2.95.3.

Make the extended options work on little endian machines.
Allow files smaller than 512 bytes to be received w/o a timeout.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Support negotiation and use of TFTP Option Extension (rfc 2347) for the
'blksize' option (rfc 2348) and the 'timeout' and 'tsize' options (rfc 2349).

Contributed by Wasabi Systems, Inc.

Fix sendto return value check (incomplete change in 1.14).
Noted by Brian Ginsbach in PR 19842.

branches: 1.15.2;
fix argument validation mistake in setpeer().
From: Hiroyuki YAMAMORI <h-yamamo@db3.so-net.ne.jp>

make sure we do not overrun tp->th_msg on ERROR packet.
correct ERROR length to include terminating \0 (RFC1350 page 8).

A too hasty checkin (and lack of -Wsign-compare) made send() never fail.
Newly added 'unsigned' removed from vars that shouldn't have had it.

defs had 'short block' for blocksize; changed defs to be unsigned.
added note to tftpd.8 that this bug hits multiple tftp clients.

branches: 1.11.4;
Nuke `extern int errno;' in code we compile with -Wstrict-prototypes. We get
the correct definition from errno.h.

IPv6 support.
clarify a bit (specifically, routines in tftp.c now does not
modify "peeraddr")

branches: 1.9.2;
char -> unsigned char
<fcntl.h> instead of <sys/file.h>
compensate for different types in th_stuff

const poisoning.

deprecate register, use err/warn, fix .Nm usage

WARNS?=1

needs string.h

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

Cleanup for GCC 2.

branches: 1.1.1;
Initial revision

storage class first, *then* __dead

Remove K&R __P macros.
Remove main() function prototype if present.
Mark usage() as __dead if not already.
Binaries generated with & without these patches were compared with diff -r.

Undo the non-sharing of the "toplevel" jmp_buf between main.c and tftp.c,
so that we don't get a core dump if a transfer time-out is experienced.
Also, get rid of an extranous newline printed in the case of time-out.

Use C89 function definitions

branches: 1.32.2; 1.32.4;
ansify, const, knf

Use __dead

fix -Wsign-compare issues

- Malformed multicast option not being checked
for correctly. Could fault client.
- 'mc' (master client) field not being examined
properly. Actually looking at addr field so
proably always working out to non 0 (master).

sprinkle volatile.

Coverity CID 4119: Check negative returns (from Arnaud Lacombe)

Add support for the multicast TFTP option. Reviewed by Rui Paulo.

Pass lint.

Do not use %d for size_t!

PR/32680: Yves-Emmanuel JUTARD: Improve some error checking that causes
memory corruption on out of memory errors.
While I am here, remove some lint.

Fix old-style C code, update to WARNS=4.
Also, move file-scope .c extern decls to the .h file

appease gcc -Wuninitialized

Move declaration of local variables to start of function instead of
inside a block after code. Fixes build problem for vax, which still
uses gcc 2.95.3.

Make the extended options work on little endian machines.
Allow files smaller than 512 bytes to be received w/o a timeout.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Support negotiation and use of TFTP Option Extension (rfc 2347) for the
'blksize' option (rfc 2348) and the 'timeout' and 'tsize' options (rfc 2349).

Contributed by Wasabi Systems, Inc.

Fix sendto return value check (incomplete change in 1.14).
Noted by Brian Ginsbach in PR 19842.

branches: 1.15.2;
fix argument validation mistake in setpeer().
From: Hiroyuki YAMAMORI <h-yamamo@db3.so-net.ne.jp>

make sure we do not overrun tp->th_msg on ERROR packet.
correct ERROR length to include terminating \0 (RFC1350 page 8).

A too hasty checkin (and lack of -Wsign-compare) made send() never fail.
Newly added 'unsigned' removed from vars that shouldn't have had it.

defs had 'short block' for blocksize; changed defs to be unsigned.
added note to tftpd.8 that this bug hits multiple tftp clients.

branches: 1.11.4;
Nuke `extern int errno;' in code we compile with -Wstrict-prototypes. We get
the correct definition from errno.h.

IPv6 support.
clarify a bit (specifically, routines in tftp.c now does not
modify "peeraddr")

branches: 1.9.2;
char -> unsigned char
<fcntl.h> instead of <sys/file.h>
compensate for different types in th_stuff

const poisoning.

deprecate register, use err/warn, fix .Nm usage

WARNS?=1

needs string.h

Merged with 4.4lite.
Changed to conform to NetBSD's new RCS Id convention.

Add RCS identifiers.

Cleanup for GCC 2.

branches: 1.1.1;
Initial revision