fixCMake: use double quotes in the sed command so that the variables are actually expanded

Add `cmd:find` to scriptletPrerequirements (needed by fixCMake). (#281)

Workaround for issue #207.

Remove the boot dir from the chroot, even if $buildOK is false.
This avoids that annoying "waiting for package to be activated".

Deleting just "boot/system/packages/administrative/activated_packages"
might be enough, but... this works well for me, and it's already how
it's done if $buildOK is true.

HaikuPorter: Make check for both static and shared more robust.

ShellScriptlets: Avoid interactivity in checkedUnmount.

Also, always fail builds when unmounting fails.

HaikuPorter ShellScriptlets: Validate there is only either a shared or a static library.

Having both should always be an error, we only want to provide one.

ShellScriptlets: Escape single quotes in variables.

Variables containing single quotes cause problems when imported by Bash.
This patch fixes the issue by replacing ' in these variables with '\''.

Fixes #145.

setupChrootScript: add font settings to the chroot

for fontconfig

ShellScriptlets: create shared_memory directory in chroot

ShellScriptlets: Pass --wrap-mode=nodownload to meson by default.

If strictly necessary, it can be overridden by passing --wrap-mode=default in a later argument, but this is probably what we want generally.

ShellScriptlets: cmake/meson wrappers require which

ShellScriptlets: Improve cmake/meson wrappers.

Thanks to comments from korli and tqh in cf896154441dc1722e5f442f02e875bc9206475b.

ShellScriptlets: Require CMAKE_BUILD_TYPE or meson --buildtype arguments.

Otherwise we get a debug, non-optimized build, which is almost certainly
not what we want to build recipies with.

ShellScriptlets: Add a fixCMake scriptlet.

Much like fixPkgconfig, but for CMake files. Not so useful yet because
of a CMake limitation; see comments in HaikuPorts commit

python3: Finish python3 change. python2 breaking

* Based on mmlr's 2017 work to use Python3 with
changes and adjustments for the current codebase

Convert an error to a warning, improve formatting

defineDebugInfoPackage now handles resources correctly.

Before this change, extractDebugInfo was calling:
* xres to make a backup of the resources,
* strip
* xres again, to restore the resources,
* objcopy --add-gnu-debuglink

But objcopy was dropping the resources again! Moving that call
right after the call to strip (and before the second call to
xres) allows to really keep the resources of the runtimes when
a recipe uses defineDebugInfoPackage.

ShellScriptlets: add quote (#155)

This fixes packageEntries for package with glob characters in their name

Cleanup: Whitespace and line length cleanup.

Replace sed with bash in defineDebugInfoPackage.

* Fixes #152.

Change dashes to underscores in debuginfo:.

* This allows to extract debug info from files with
dashes in names.

Fix defineDebugInfoPackage.

* It should always get a name with architecture suffix.
* This is consistent with other sections of the recipe.
* Previously it tried to get packageSuffix from packageName.
If that contained architecture suffix, it would end up
creating packages with x86_debuginfo suffix, instead of just
debuginfo.

Add a addAppletDeskbarSymlink function

Similar to addAppDeskbarSymlink.

Implement local builders.

* provide info(), warn() to be used instead of print. By default outputs to stdout.
For builders, outputs to files.
* replace most calls to check_call by check_output, and log with info(). Also outputs
the outputs an eventual CalledProcessError output attribute.
* add option --local-builders to be used with --build-master: indicates how many
local builders to use instead of remote builders. If paramiko isn't available,
defaults to 1, otherwise 0.
* rename Builder to RemoteBuilder.
* remove changes of current directory: this doesn't work in a
multithreaded environnement. Policy.py is the most affected as it
expected to run in the packaging directory.

ShellScriptlets.py: fix corner-case bug in fixLibtoolArchives.

* fixLibtoolArchives assumed each reference to an external lib*.la
file was followed by a white space or by an end of line, but this
is not true for the last lib*.la of the line because of the closing
single quote. The basename of the libtool file was therefore not
detected correctly, so the corresponding package-links directory
could not be found for the last lib*.la of the dependency_libs
parameter in the packages' libtool files. This is now fixed.
* Improve the substitution by using the dirnames of the libtool file
instead of its full path. This allows to also fix any paths passed
with -L.

Reminder: The call to the fixLibtoolArchives helper function takes no
arguments and should happen *before* the "packageEntries devel ..."

extractDebugInfo should preserve resources #70

ShellScriptlets: Don't mount the ports dir.

It allows to get at external files without referencing them in the
recipe, which is not desirable. This change requires ports to always
explicitly reference any additional files needed.

ShellScriptlets: Internalize parsing of scriptlet prerequires.

Reduces duplication and knowledge of the original format.

fixPkgconfig: add a "strict" mode.

This will prevent fixPkgconfig from blindly changing the
libdir variable in pkgconfig files, which has caused
problems with libqt4, for example.

This could do with further improvements to make it more
robust in the general case.

Revert "fixPkgconfig: don't mess with already functional pc files"

This reverts commit 39c4086bd53ce01cf263d77d4d317f4120daa6ab.

fixPkgconfig: don't mess with already functional pc files

fixLibtoolArchives scriptlet: continue on error

It's best effort here, sometimes we can't find a lib~ symlink
because we are referencing a lib inside our own package.

Like libexslt.la linking to libxslt.la.

Add FixLibtoolArchives function

Attempt to provide a way to fix the .la files.

We only fix the paths to other referenced .la files,
it seems to be sufficient.

Ideally we'd replace them with /packages/foo_devel-$ver/devel~libfoo/...

However most referenced libraries don't actually get a devel symlink,
so we use /packages/foo-$ver/lib~libfoo/

Tested on sdl_ttf and sdl_mixer.

Revert to tab spacing for Pe's sake.

Try again with whitespace.

Second attempt to fix whitespace. Options are different on OS X.

Convert tabs to spaces.

Fix handling of .so files

* Only search for readelf if there are actually .so files.
* Don't exit when grep does not find a match (disable set -e).

This makes HaikuPorter work on OS X (well enough to bootstrap, that is).

Provide default action for PATCH

This fixes patch being called on systems with case-insensitive file
system.

Add an addResourcesToBinaries() function

This allows adding an HVIF icon from an RDEF file directly
to binaries, without having to patch makefiles.

Fix #3: broken networking in chroot.

* Haikuporter now copies the network settings directory into the chroot,
such that networking should work just as usual.

Implement support for freestanding package names in recipes.

* Package names used to be linked to port names (they could only extend
it). Now, independent package names and versions can be set by means of
PACKAGE_NAME and PACKAGE_VERSION recipe attributes.

Ask user what to do if unmounting failed repeatedly.

* Instead of failing, give the user the option to force-unmount
the volume.

Improve user experience in chroot shell.

* Activate system inputrc in chroot for improved navigational features.
* Create basic profile in order to show the current dir in the prompt.

ShellScriptlets: Improve checkedUnmount()

* No need to wait after the last attempt.
* When we give up, let fdinfo print who has still open file descriptors
for the volume in question.

Remove leftover debug message.

prepareInstalledDevelLib: Also look for readelf.

prepareInstalledDevelLlib: check sed availability

This uses sed, which must be added to the BUILD_PREREQUIRES. However, it
was not checking for it, leading to silent failure (and waste of time).

ShellScriptlets: fix spaced entries for packageEntries

* bash will automatically parse quoted items using this method
* tested with a local shell script
* only requirement for this to work is a modern bash shell
* http://www.gnu.org/software/bash/manual/bashref.html#Looping-Constructs
* packageEntries blah_devel file/file file/file works as well as
packageEntires blah_devel file/file "file/my file" now
* solves #21, feel free to solve another way if needed

ShellScriptlets: Add --omit-buildspec argument to runConfigure.

When it is set, no --build=... argument will be passed to the configure
script and thus allows runConfigure to be used for scripts that don't
support this argument.

/boot/common has been removed

Mostly the changes are straight-forward (don't look in /boot/common,
adjust paths). A notable change concerns the resolution of port
dependencies: We no longer simply include all /boot/system packages in
the chroot, but only those that have to be pulled in according to the
dependency resolution. This may break some recipes that don't declare
all the things they actually require for building, but have worked
previously due to those dependencies living in /boot/system.

Fix location of libs and includes for pkg-config

* They were not right when building hybrid packages
* Hint: set PKG_CONFIG_LIBDIR=/boot/common/develop/lib/x86/pkgconfig
when using pkg-config to build hybrid software.

Don't explicitly set build-host when cross-building.

* cross-building was broken due to haikuporter automatically setting
the wrong build host (i.e. the effective target machine triple)

Let runConfigure() apply default for --build.

* Many ports have problems guessing the build type for newish
platforms (e.g. in our case 'x86_64-unknown-haiku'. Allow these ports
to get at least a bit further by explicitly setting the build type
to $effectiveTargetMachineTriple.

Improve robustness of unmounting subfolders in work-dir:

* add shell function checkedUnmount($mountPoint) which retries the
unmounting of the given mountpoint up to 5 times
* use checkedUnmount() during cleanup, in order to deal with the race
conditions between the packaging daemon having a FD for the
mountpoint and haikuporter trying to do the unmount

Bind-mount the correct dir to /port

Was broken since the recipeFile variable was changed to refer to the
copied recipe.

prepareInstalledDevelLib: secondary arch fix

Add shell function symlinkRelative

* Works similar to ln, but expects absolute paths (or paths relative to
the current directory) and creates relative symlinks. Comes in handy
when link source and/or target paths are based on shell variable
values.
* Use symlinkRelative in addAppDeskbarSymlink and
addPreferencesDeskbarSymlink. Not strictly necessary in this case, but
yields nicer results.

Support building secondary arch packages from regular recipes

* Add settings SECONDARY_CROSS_DEVEL_PACKAGES, SECONDARY_CROSS_TOOLS,
and SECONDARY_TARGET_ARCHITECTURES to config file and command line
option --secondary-cross-devel-packages, overriding the first.
SECONDARY_TARGET_ARCHITECTURES is the list of secondary target
architectures that ports may be built for (for a hybrid target).
SECONDARY_CROSS_TOOLS is the respectively matching list of cross
tools directories and SECONDARY_CROSS_DEVEL_PACKAGES the list of
Haiku cross development sysroot packages.
* Repository: For all configured secondary architectures add derived
ports.
* BuildPlatformUnix:
- setupNonChrootBuildEnvironment()/cleanNonChrootBuildEnvironment() do
now support an optional secondaryArchitecture parameter which is set
when building a port for a secondary architecture. The build
environment is set up using the respective cross tools and Haiku
cross devel package.
- Fix setting up the system include and library search paths for
gcc 4. It has other paths built in.
* Recipes can now set a SECONDARY_ARCHITECTURES (similar to
ARCHITECTURES) to indicate for which secondary architectures the port
can be built.
* Add new shell variables effectiveTargetArchitecture,
effectiveTargetMachineTriple, and effectiveTargetMachineTripleAsName
which are set to the values for the target architecture we are
actually building for (i.e. the primary or secondary architecture).
When cross-compiling the pre-existing target* variables continue to
correspond to the primary architecture.
* The variables binDir, sbinDir, libDir, includeDir, oldIncludeDir,
developLibDir are set to a respective subdirectory when building for
a secondary architecture.

Clean up trailing whitespace

fixPkgconfig(): fix overly enthusiastic use of installDestDir

Fix use of target architecture tools

Make several shell functions work for non-chroot builds

Call packageDebugInfos() automatically after INSTALL

No need to require the INSTALL() function calling it explicitly. That
it should be done has already been expressed by calling
defineDebugInfoPackage() earlier.

Add functions for building debug info packages

* Add python variable commonRecipeScriptHead, which is added as a
prefix to both configFileEvaluatorScript and recipeActionScript.
It contains common functionality (e.g. shared functions).
* Pull new function getPackagePrefix() out of packageEntries().
* Add defineDebugInfoPackage() which can be used to declare a
debug info package and the files from which the debug infos are
extracted. Used at top level in the recipe.
* Add packageDebugInfos() which processes all debug info packages
declared via defineDebugInfoPackage(), extracting the debug info
and moving them to the respective packaging dir. Used in INSTALL().
* Add extractDebugInfo() which extracts the debug info from a given
file to the given file.

Use shell variables for passing the wrapper script parameters

Using string formatting has the drawback that "%s" and friends actually
used in the shell script would have to be escaped to prevent
substitution (or an error).

Change the way variables are set for the shell scripts

* We no longer just set the variables in the environment we start the
shell with, as those are inherited by programs the shell starts and
may thus leak into build systems where they may have meaning. Instead
we just prepend setter instructions to the shell script we start.
* Remove the restriction that almost none of the absolute paths
variables can be used outside the action functions:
- Port._updateShellVariables() also sets the variables whose value
depends on the revision in "forParsing" mode, now. Instead of the
not-yet-known revision number it uses the placeholder "$REVISION"
in the value.
- We no longer source the recipe file directly, but copy it to the
work directory (was done already anyway) and inject a function call
to updateRevisionVariables() right after the REVISION variable is
set. In configFileEvaluatorScript that function reevaluates the
concerned variables, so that they get the correct value.

Cleanup handling of cross-sysroot directory.

* Instead of passing in $isCrossRepository, we now pass in
$crossSysrootDir into the chroot-setup/teardown scriptlets, such that
that path is only defined once (in HaikuPorter).

Add license header (MIT)

* additionally: uppercase copyright notices and separate them from the
top by a single line

Add addPreferencesDeskbarSymlink() shell function

Add addAppDeskbarSymlink() service function

It creates the Deskbar symlink for the given application executable.

prepareInstalledDevelLib(): Fix readline/readelf mixup

Rename cross-build sysroot folder and fix contents.

Use target-readline when preparing library of cross build.

Add support for cross-sysroot in /boot/cross/<target-arch>

* pass environment variables isCrossRepository and targetArchitecture
to scriptlets that set up / tear down the chroot
* extend chroot-setup scriptlet to symlink the sysroot package into
a separate packages folder under /boot/cross/<target-arch> and
mount that folder
* extend chroot-tear-down scriptlet to unmount /boot/cross/<target-arch>

Remove 'prereq-repository' in work-folder during cleanup.

Add support for making some scriplet prerequirements (i.e. readelf)
depend on the target architecture.

Ignore Ctrl-C in setup and teardown scriptlets.

Handle dependencies of chroot scriptlets

* define the dependencies of the scriptlets
* add the scriptlet dependencies as prerequirements when determining
the set of packages that are required in the chroot

Add shell function packageEntries()

Given the name suffix for a package and a list of entries, the function
moves the entries to the packaging directory of the respective package.

Add fixDevelopLibDirReferences() shell function

* It replaces $libDir by $developLibDir in the given files.
* Use it in prepareInstalledDevelLib() to fix *.la files.

Make prepareInstalledDevelLib[s] more flexible

Rename prepareInstalledDevelLibsHelper to prepareInstalledDevelLib and
allow two optional parameters, the glob patterns for the libraries.
This allows the function to be used for libraries with non-standard
naming.

Add optional recipe phase PATCH

* ConfigParser does now determine which phases are defined in the
recipe.
* Port.patchSource():
- Call the recipe's PATCH(), if defined.
- If an error occurred applying a patch or calling PATCH() after at
least one patch has already been applied, clear the
checkout/unpack flags.

Add fixPkgconfig() shell function

To be invoked at the end of the installation. It moves the pkgconfig
directory from lib/ to develop/lib and fixes the libdir and includedir
variables in the *.pc files.

prepareInstalledDevelLibsHelper(): Use pre-existing variables

Add prepareInstalledDevelLibs utility function for recipes

To be called at the end of the install phase. Given a list of basenames
of libraries, the function moves the respective library files and
symlinks that shouldn't be in lib/ to develop/lib/ and creates
additionally required symlinks there.

Add shell function runConfigure() that can be used in recipes

"runConfigure ./configure" is equivalent to
"./configure $configureDirArgs". The function supports an option
"--omit-dirs <dirs>" which allows to omit directories from
$configureDirArgs thus making it easier to invoke older configure
scripts. Theoretically the function could be made more intelligent,
running the configure script with "--help" to determine which options
are actually supported. Maybe some other day...

Bind-mount the port directory into the chroot

This allows the BUILD() and INSTALL() recipe functions to access
additional files. E.g. in case of Vision there's a settings file
that shall be included in the package.

Improve cleanup of work directory in case of success.

Refactoring: rip haikuporter apart into separate modules

fixPkgconfig: add a "strict" mode.

This will prevent fixPkgconfig from blindly changing the
libdir variable in pkgconfig files, which has caused
problems with libqt4, for example.

This could do with further improvements to make it more
robust in the general case.

Revert "fixPkgconfig: don't mess with already functional pc files"

This reverts commit 39c4086bd53ce01cf263d77d4d317f4120daa6ab.

fixPkgconfig: don't mess with already functional pc files

fixLibtoolArchives scriptlet: continue on error

It's best effort here, sometimes we can't find a lib~ symlink
because we are referencing a lib inside our own package.

Like libexslt.la linking to libxslt.la.

Add FixLibtoolArchives function

Attempt to provide a way to fix the .la files.

We only fix the paths to other referenced .la files,
it seems to be sufficient.

Ideally we'd replace them with /packages/foo_devel-$ver/devel~libfoo/...

However most referenced libraries don't actually get a devel symlink,
so we use /packages/foo-$ver/lib~libfoo/

Tested on sdl_ttf and sdl_mixer.

Revert to tab spacing for Pe's sake.

Try again with whitespace.

Second attempt to fix whitespace. Options are different on OS X.

Convert tabs to spaces.

Fix handling of .so files

* Only search for readelf if there are actually .so files.
* Don't exit when grep does not find a match (disable set -e).

This makes HaikuPorter work on OS X (well enough to bootstrap, that is).

Provide default action for PATCH

This fixes patch being called on systems with case-insensitive file
system.

Add an addResourcesToBinaries() function

This allows adding an HVIF icon from an RDEF file directly
to binaries, without having to patch makefiles.

Fix #3: broken networking in chroot.

* Haikuporter now copies the network settings directory into the chroot,
such that networking should work just as usual.

Implement support for freestanding package names in recipes.

* Package names used to be linked to port names (they could only extend
it). Now, independent package names and versions can be set by means of
PACKAGE_NAME and PACKAGE_VERSION recipe attributes.

Ask user what to do if unmounting failed repeatedly.

* Instead of failing, give the user the option to force-unmount
the volume.

Improve user experience in chroot shell.

* Activate system inputrc in chroot for improved navigational features.
* Create basic profile in order to show the current dir in the prompt.

ShellScriptlets: Improve checkedUnmount()

* No need to wait after the last attempt.
* When we give up, let fdinfo print who has still open file descriptors
for the volume in question.

Remove leftover debug message.

prepareInstalledDevelLib: Also look for readelf.

prepareInstalledDevelLlib: check sed availability

This uses sed, which must be added to the BUILD_PREREQUIRES. However, it
was not checking for it, leading to silent failure (and waste of time).

ShellScriptlets: fix spaced entries for packageEntries

* bash will automatically parse quoted items using this method
* tested with a local shell script
* only requirement for this to work is a modern bash shell
* http://www.gnu.org/software/bash/manual/bashref.html#Looping-Constructs
* packageEntries blah_devel file/file file/file works as well as
packageEntires blah_devel file/file "file/my file" now
* solves #21, feel free to solve another way if needed

ShellScriptlets: Add --omit-buildspec argument to runConfigure.

When it is set, no --build=... argument will be passed to the configure
script and thus allows runConfigure to be used for scripts that don't
support this argument.

/boot/common has been removed

Mostly the changes are straight-forward (don't look in /boot/common,
adjust paths). A notable change concerns the resolution of port
dependencies: We no longer simply include all /boot/system packages in
the chroot, but only those that have to be pulled in according to the
dependency resolution. This may break some recipes that don't declare
all the things they actually require for building, but have worked
previously due to those dependencies living in /boot/system.

Fix location of libs and includes for pkg-config

* They were not right when building hybrid packages
* Hint: set PKG_CONFIG_LIBDIR=/boot/common/develop/lib/x86/pkgconfig
when using pkg-config to build hybrid software.

Don't explicitly set build-host when cross-building.

* cross-building was broken due to haikuporter automatically setting
the wrong build host (i.e. the effective target machine triple)

Let runConfigure() apply default for --build.

* Many ports have problems guessing the build type for newish
platforms (e.g. in our case 'x86_64-unknown-haiku'. Allow these ports
to get at least a bit further by explicitly setting the build type
to $effectiveTargetMachineTriple.

Improve robustness of unmounting subfolders in work-dir:

* add shell function checkedUnmount($mountPoint) which retries the
unmounting of the given mountpoint up to 5 times
* use checkedUnmount() during cleanup, in order to deal with the race
conditions between the packaging daemon having a FD for the
mountpoint and haikuporter trying to do the unmount

Bind-mount the correct dir to /port

Was broken since the recipeFile variable was changed to refer to the
copied recipe.

prepareInstalledDevelLib: secondary arch fix

Add shell function symlinkRelative

* Works similar to ln, but expects absolute paths (or paths relative to
the current directory) and creates relative symlinks. Comes in handy
when link source and/or target paths are based on shell variable
values.
* Use symlinkRelative in addAppDeskbarSymlink and
addPreferencesDeskbarSymlink. Not strictly necessary in this case, but
yields nicer results.

Support building secondary arch packages from regular recipes

* Add settings SECONDARY_CROSS_DEVEL_PACKAGES, SECONDARY_CROSS_TOOLS,
and SECONDARY_TARGET_ARCHITECTURES to config file and command line
option --secondary-cross-devel-packages, overriding the first.
SECONDARY_TARGET_ARCHITECTURES is the list of secondary target
architectures that ports may be built for (for a hybrid target).
SECONDARY_CROSS_TOOLS is the respectively matching list of cross
tools directories and SECONDARY_CROSS_DEVEL_PACKAGES the list of
Haiku cross development sysroot packages.
* Repository: For all configured secondary architectures add derived
ports.
* BuildPlatformUnix:
- setupNonChrootBuildEnvironment()/cleanNonChrootBuildEnvironment() do
now support an optional secondaryArchitecture parameter which is set
when building a port for a secondary architecture. The build
environment is set up using the respective cross tools and Haiku
cross devel package.
- Fix setting up the system include and library search paths for
gcc 4. It has other paths built in.
* Recipes can now set a SECONDARY_ARCHITECTURES (similar to
ARCHITECTURES) to indicate for which secondary architectures the port
can be built.
* Add new shell variables effectiveTargetArchitecture,
effectiveTargetMachineTriple, and effectiveTargetMachineTripleAsName
which are set to the values for the target architecture we are
actually building for (i.e. the primary or secondary architecture).
When cross-compiling the pre-existing target* variables continue to
correspond to the primary architecture.
* The variables binDir, sbinDir, libDir, includeDir, oldIncludeDir,
developLibDir are set to a respective subdirectory when building for
a secondary architecture.

Clean up trailing whitespace

fixPkgconfig(): fix overly enthusiastic use of installDestDir

Fix use of target architecture tools

Make several shell functions work for non-chroot builds

Call packageDebugInfos() automatically after INSTALL

No need to require the INSTALL() function calling it explicitly. That
it should be done has already been expressed by calling
defineDebugInfoPackage() earlier.

Add functions for building debug info packages

* Add python variable commonRecipeScriptHead, which is added as a
prefix to both configFileEvaluatorScript and recipeActionScript.
It contains common functionality (e.g. shared functions).
* Pull new function getPackagePrefix() out of packageEntries().
* Add defineDebugInfoPackage() which can be used to declare a
debug info package and the files from which the debug infos are
extracted. Used at top level in the recipe.
* Add packageDebugInfos() which processes all debug info packages
declared via defineDebugInfoPackage(), extracting the debug info
and moving them to the respective packaging dir. Used in INSTALL().
* Add extractDebugInfo() which extracts the debug info from a given
file to the given file.

Use shell variables for passing the wrapper script parameters

Using string formatting has the drawback that "%s" and friends actually
used in the shell script would have to be escaped to prevent
substitution (or an error).

Change the way variables are set for the shell scripts

* We no longer just set the variables in the environment we start the
shell with, as those are inherited by programs the shell starts and
may thus leak into build systems where they may have meaning. Instead
we just prepend setter instructions to the shell script we start.
* Remove the restriction that almost none of the absolute paths
variables can be used outside the action functions:
- Port._updateShellVariables() also sets the variables whose value
depends on the revision in "forParsing" mode, now. Instead of the
not-yet-known revision number it uses the placeholder "$REVISION"
in the value.
- We no longer source the recipe file directly, but copy it to the
work directory (was done already anyway) and inject a function call
to updateRevisionVariables() right after the REVISION variable is
set. In configFileEvaluatorScript that function reevaluates the
concerned variables, so that they get the correct value.

Cleanup handling of cross-sysroot directory.

* Instead of passing in $isCrossRepository, we now pass in
$crossSysrootDir into the chroot-setup/teardown scriptlets, such that
that path is only defined once (in HaikuPorter).

Add license header (MIT)

* additionally: uppercase copyright notices and separate them from the
top by a single line

Add addPreferencesDeskbarSymlink() shell function

Add addAppDeskbarSymlink() service function

It creates the Deskbar symlink for the given application executable.

prepareInstalledDevelLib(): Fix readline/readelf mixup

Rename cross-build sysroot folder and fix contents.

Use target-readline when preparing library of cross build.

Add support for cross-sysroot in /boot/cross/<target-arch>

* pass environment variables isCrossRepository and targetArchitecture
to scriptlets that set up / tear down the chroot
* extend chroot-setup scriptlet to symlink the sysroot package into
a separate packages folder under /boot/cross/<target-arch> and
mount that folder
* extend chroot-tear-down scriptlet to unmount /boot/cross/<target-arch>

Remove 'prereq-repository' in work-folder during cleanup.

Add support for making some scriplet prerequirements (i.e. readelf)
depend on the target architecture.

Ignore Ctrl-C in setup and teardown scriptlets.

Handle dependencies of chroot scriptlets

* define the dependencies of the scriptlets
* add the scriptlet dependencies as prerequirements when determining
the set of packages that are required in the chroot

Add shell function packageEntries()

Given the name suffix for a package and a list of entries, the function
moves the entries to the packaging directory of the respective package.

Add fixDevelopLibDirReferences() shell function

* It replaces $libDir by $developLibDir in the given files.
* Use it in prepareInstalledDevelLib() to fix *.la files.

Make prepareInstalledDevelLib[s] more flexible

Rename prepareInstalledDevelLibsHelper to prepareInstalledDevelLib and
allow two optional parameters, the glob patterns for the libraries.
This allows the function to be used for libraries with non-standard
naming.

Add optional recipe phase PATCH

* ConfigParser does now determine which phases are defined in the
recipe.
* Port.patchSource():
- Call the recipe's PATCH(), if defined.
- If an error occurred applying a patch or calling PATCH() after at
least one patch has already been applied, clear the
checkout/unpack flags.

Add fixPkgconfig() shell function

To be invoked at the end of the installation. It moves the pkgconfig
directory from lib/ to develop/lib and fixes the libdir and includedir
variables in the *.pc files.

prepareInstalledDevelLibsHelper(): Use pre-existing variables

Add prepareInstalledDevelLibs utility function for recipes

To be called at the end of the install phase. Given a list of basenames
of libraries, the function moves the respective library files and
symlinks that shouldn't be in lib/ to develop/lib/ and creates
additionally required symlinks there.

Add shell function runConfigure() that can be used in recipes

"runConfigure ./configure" is equivalent to
"./configure $configureDirArgs". The function supports an option
"--omit-dirs <dirs>" which allows to omit directories from
$configureDirArgs thus making it easier to invoke older configure
scripts. Theoretically the function could be made more intelligent,
running the configure script with "--help" to determine which options
are actually supported. Maybe some other day...

Bind-mount the port directory into the chroot

This allows the BUILD() and INSTALL() recipe functions to access
additional files. E.g. in case of Vision there's a settings file
that shall be included in the package.

Improve cleanup of work directory in case of success.

Refactoring: rip haikuporter apart into separate modules