Import statements sorted with isort and fixed MockBuilder.py (#266)

* Fixed missing closing bracket in the MockBuilder.py

* Import statements sorted with isort

Policy: improve needed library check.

* Also checks for versioned libraries, as these satisfy the
binary requirements.
* Fixes policy warnings for packages that don't provided
non-versioned shared libraries (e.g. krb5)

Policy: check if a package provides itself (#209)

This is a common mistake, like when the package name is different
than the provided command, it just happened to me again on hteditor.

python3: Finish python3 change. python2 breaking

* Based on mmlr's 2017 work to use Python3 with
changes and adjustments for the current codebase

Cleanup: Make some constructs more idiomatic.

* Change 'not x in y' to 'x not in y'.
* Use 'is' to compare None singleton.
* Use 'instanceof(x, y)' instead of 'type(x) == y'.
* Replace map builtin with list comprehension.
* Rename self argument to cls for static method.

Cleanup: Add missing raw string prefix to regex patterns.

Cleanup: Whitespace and line length cleanup.

Allow packages to provides servers.

Because, why not?

Policy: split RPATH, support relative rpaths.

* also checks whether a library is in the same directory or a 'lib' subdirectory.

Policy: skip _APP_ dependencies.

Policy: checks files in apps/.

* also checks files in subdirs of apps/ and lib/.

Policy: check RPATH when searching libs in the package.

Implement local builders.

* provide info(), warn() to be used instead of print. By default outputs to stdout.
For builders, outputs to files.
* replace most calls to check_call by check_output, and log with info(). Also outputs
the outputs an eventual CalledProcessError output attribute.
* add option --local-builders to be used with --build-master: indicates how many
local builders to use instead of remote builders. If paramiko isn't available,
defaults to 1, otherwise 0.
* rename Builder to RemoteBuilder.
* remove changes of current directory: this doesn't work in a
multithreaded environnement. Policy.py is the most affected as it
expected to run in the packaging directory.

Use Unicode strings for warn() & sysExit().

Fix policy error for libraries with uppercase name

The package requires are always converted to lowercase, but it was
compared with an uppercase name in the policy checks, leading to an
erroneous warning (or error in strict mode).

Policy: Also make devel provides lowercase before checking it.

This applies the logic from 54619e to devel provides.

Policy: Make provides lowercase before checking it.

Policy: Ignore missing REQUIREs for syslibs.

Remove local check_output, we're now using Python 2.7.

Fix false POLICY ERROR when readelf returned a library with an
absolute path

Cleanup imports.

Refactoring: fix use of reserved keywords.

* Apparently, we were using reserved keywords as variable names, which
didn't seem to cause any problems, but could have done so in future
versions of Python.

Refactoring: use properties where it seems fit.

* Trying to be somewhat more Pythonic.

Revert to tab spacing for Pe's sake.

Try again with whitespace.

Second attempt to fix whitespace. Options are different on OS X.

Convert tabs to spaces.

Shutup policy warning for cross-builds.

* Only show a warning about Haiku-libraries not being found in
/boot/system/lib/ when we are actually building on Haiku.

Policy: Adjust to renamed SYS:PACKAGE attribute

/boot/common has been removed

Mostly the changes are straight-forward (don't look in /boot/common,
adjust paths). A notable change concerns the resolution of port
dependencies: We no longer simply include all /boot/system packages in
the chroot, but only those that have to be pulled in according to the
dependency resolution. This may break some recipes that don't declare
all the things they actually require for building, but have worked
previously due to those dependencies living in /boot/system.

Print summary for policy violations when done.

Policy: support secondary architecture library checks

Policy: ignore bin/<arch> for secondary architecture

Unifiy the Options and GlobalConfig somewhat

* Module GlobalConfig is replaced with new module Configuration. The
global variable globalConfiguration is gone. Instead Configuration
provides getter methods.
* For several of the (newer) command line options there are now optional
configuration file entries. If given the command line values override
the configuration file values. Configuration also provides getter
methods for these options, which should be used instead of
getOption().

Add option '--command-package' to specify the package command

Fix incorrect post-install directory path

Policy: add checks for post-install scripts

Add license header (MIT)

* additionally: uppercase copyright notices and separate them from the
top by a single line

Policy: Detect misplaced lib*.a/la files

Policy: allow "non-packaged" as writable directory

Policy: warn, when a used library couldn't be found

Policy: Also use provides of sibling packages for library checks

When verifying whether a needed library is also referred to by the
requires, we need to consider the sibling packages of the checked
package as possible providers of the library as well.

Policy: check existence of devel:lib* provides

Policy: Get rid of _has{Provides,Requires}Entry()

Introduce _normalizeResolvableName() instead. By using it explicitly
we also make sure that the resolvable name printed in a warning is
correct.

Policy: Handle global writable/user settings directories

Follow renaming of global-settings-files attribute

Policy: Handle policy violations more intelligently

* Get rid of _severeViolation(). Now all violations are just warnings
in non-strict mode.
* Even in strict mode, just don't bail out when encountering the first
violation. Perform all checks first.

Policy: Remove setPort()

The port wasn't used yet and the method was invoked from the wrong
place (Port.__init__()) anyway.

Fix dictionary access with potentially missing key

Squash TODO about policy-checking source packages

Policy: Check declared user settings files

Policy: Check global settings files

Policy: Don't check source packages

Their directory layout is invalid ATM, as it consists of a source/ top
level directory and the recipe file also at the top level. Both should
probably end up in develop/source instead.

Policy: Fix _severeViolation() invocation

Policy: Fix _checkLibraryDependencies() dir iteration

Policy: make sure bin/ exists before getting a listing

Policy: Implement checking for required libraries

Determine which libraries are needed by executables/libraries in bin/
respectively lib/ and check whether the respective requires are
declared. Doesn't account for transitive requires (yet). Though maybe
that isn't even desirable.

Beginning of packaging policy checking

* Add class Policy which contains the checks. Currently only a few.
* Add command line option -S/--strict-policy to enable strict policy
checking. Instead of printing warnings, the packaging will be
aborted.

Cleanup imports.

Refactoring: fix use of reserved keywords.

* Apparently, we were using reserved keywords as variable names, which
didn't seem to cause any problems, but could have done so in future
versions of Python.

Refactoring: use properties where it seems fit.

* Trying to be somewhat more Pythonic.

Revert to tab spacing for Pe's sake.

Try again with whitespace.

Second attempt to fix whitespace. Options are different on OS X.

Convert tabs to spaces.

Shutup policy warning for cross-builds.

* Only show a warning about Haiku-libraries not being found in
/boot/system/lib/ when we are actually building on Haiku.

Policy: Adjust to renamed SYS:PACKAGE attribute

/boot/common has been removed

Mostly the changes are straight-forward (don't look in /boot/common,
adjust paths). A notable change concerns the resolution of port
dependencies: We no longer simply include all /boot/system packages in
the chroot, but only those that have to be pulled in according to the
dependency resolution. This may break some recipes that don't declare
all the things they actually require for building, but have worked
previously due to those dependencies living in /boot/system.

Print summary for policy violations when done.

Policy: support secondary architecture library checks

Policy: ignore bin/<arch> for secondary architecture

Unifiy the Options and GlobalConfig somewhat

* Module GlobalConfig is replaced with new module Configuration. The
global variable globalConfiguration is gone. Instead Configuration
provides getter methods.
* For several of the (newer) command line options there are now optional
configuration file entries. If given the command line values override
the configuration file values. Configuration also provides getter
methods for these options, which should be used instead of
getOption().

Add option '--command-package' to specify the package command

Fix incorrect post-install directory path

Policy: add checks for post-install scripts

Add license header (MIT)

* additionally: uppercase copyright notices and separate them from the
top by a single line

Policy: Detect misplaced lib*.a/la files

Policy: allow "non-packaged" as writable directory

Policy: warn, when a used library couldn't be found

Policy: Also use provides of sibling packages for library checks

When verifying whether a needed library is also referred to by the
requires, we need to consider the sibling packages of the checked
package as possible providers of the library as well.

Policy: check existence of devel:lib* provides

Policy: Get rid of _has{Provides,Requires}Entry()

Introduce _normalizeResolvableName() instead. By using it explicitly
we also make sure that the resolvable name printed in a warning is
correct.

Policy: Handle global writable/user settings directories

Follow renaming of global-settings-files attribute

Policy: Handle policy violations more intelligently

* Get rid of _severeViolation(). Now all violations are just warnings
in non-strict mode.
* Even in strict mode, just don't bail out when encountering the first
violation. Perform all checks first.

Policy: Remove setPort()

The port wasn't used yet and the method was invoked from the wrong
place (Port.__init__()) anyway.

Fix dictionary access with potentially missing key

Squash TODO about policy-checking source packages

Policy: Check declared user settings files

Policy: Check global settings files

Policy: Don't check source packages

Their directory layout is invalid ATM, as it consists of a source/ top
level directory and the recipe file also at the top level. Both should
probably end up in develop/source instead.

Policy: Fix _severeViolation() invocation

Policy: Fix _checkLibraryDependencies() dir iteration

Policy: make sure bin/ exists before getting a listing

Policy: Implement checking for required libraries

Determine which libraries are needed by executables/libraries in bin/
respectively lib/ and check whether the respective requires are
declared. Doesn't account for transitive requires (yet). Though maybe
that isn't even desirable.

Beginning of packaging policy checking

* Add class Policy which contains the checks. Currently only a few.
* Add command line option -S/--strict-policy to enable strict policy
checking. Instead of printing warnings, the packaging will be
aborted.