History log of /haiku/src/preferences/shortcuts/ShortcutsSpec.h
Revision Date Author Comments
# 149ce46d 09-Jan-2015 Adrien Destugues <pulkomandy@gmail.com>

Update Shortcuts to use standard ColumnListView

Patch by atalax (GCI2014)

There are some useability changes because our CLV isn't as flexible as
the Santa's Gift Bag one.

Fixes #11007.


# b42302c5 20-Jan-2014 John Scipione <jscipione@gmail.com>

Shortcuts: Big style refactor

Update the style of this preference app to match Haiku’s coding guidelines.
Since this app used a completely different style this is a big commit, but,
there should be no behavioral changes.

Style changes include but are not limited to:
* private member variables use fMemberVariable style
* local variables and public member variables use camelCase style
* compare pointers to NULL explicitly
* compare integers against 0 explicitly
* always flank binary operators with spaces such as + - , / *
* pointer goes with type, not value or flanked by spaces
* lots of variable renaming especially for abbreviations
* comments start with a leading space, prefer lowercase unless full sentence
* space after keywords such as if and for and { and } on same line
* multi-line if statement style fixes
* remove trailing spaces
* 80 char fixes
* ... and many more, and I'm sure I missed some.

Add/update copyright headers giving credit where due, obviously this code
can’t be copyright Haiku, Inc. from 1999 since Haiku, Inc. didn’t exist
so this change attributes copyright to Jeremy Friesner from 1999-2009 and
Haiku, Inc. from 2009 onwards matching the long description of the rdef file.

Added myself to the authors section of the files in the clv directory.


# 3672a07e 16-May-2010 Stephan Aßmus <superstippi@gmx.de>

Localization of Shortcuts based on a patch by Jorma Karvonen (ticket #5857),
thanks! I've tested the application, and it works (as bad) as before. To note
would be the possibility that custom actions may stop working when switching
the system to another language after configuring them. Don't know if I
concluded this potential problem from the code correctly, or if translated
strings are actually not stored with a KeySet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36840 a95241bf-73f2-0310-859d-f6bbb57e9c96


# fa1ee6d4 15-Nov-2009 Jonas Sundström <jonas@kirilla.com>

Clean-up

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34059 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 6c333678 30-Oct-2009 Fredrik Modeen <fredrik@modeen.se>

So here it goes..
I hope I have fixed all parts that don't follow our guidelines. (that python script was good start)
This are the app, I havn't change the file in clv those are from Santa gift bag

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33848 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 149ce46d14fb60917b78e8f02343112f0ba96978 09-Jan-2015 Adrien Destugues <pulkomandy@gmail.com>

Update Shortcuts to use standard ColumnListView

Patch by atalax (GCI2014)

There are some useability changes because our CLV isn't as flexible as
the Santa's Gift Bag one.

Fixes #11007.


# b42302c5d343ffce4d7ed87bed26e7ffcabce1ae 20-Jan-2014 John Scipione <jscipione@gmail.com>

Shortcuts: Big style refactor

Update the style of this preference app to match Haiku’s coding guidelines.
Since this app used a completely different style this is a big commit, but,
there should be no behavioral changes.

Style changes include but are not limited to:
* private member variables use fMemberVariable style
* local variables and public member variables use camelCase style
* compare pointers to NULL explicitly
* compare integers against 0 explicitly
* always flank binary operators with spaces such as + - , / *
* pointer goes with type, not value or flanked by spaces
* lots of variable renaming especially for abbreviations
* comments start with a leading space, prefer lowercase unless full sentence
* space after keywords such as if and for and { and } on same line
* multi-line if statement style fixes
* remove trailing spaces
* 80 char fixes
* ... and many more, and I'm sure I missed some.

Add/update copyright headers giving credit where due, obviously this code
can’t be copyright Haiku, Inc. from 1999 since Haiku, Inc. didn’t exist
so this change attributes copyright to Jeremy Friesner from 1999-2009 and
Haiku, Inc. from 2009 onwards matching the long description of the rdef file.

Added myself to the authors section of the files in the clv directory.


# 3672a07ec16784e41fe56eeaa558095bc2befc02 16-May-2010 Stephan Aßmus <superstippi@gmx.de>

Localization of Shortcuts based on a patch by Jorma Karvonen (ticket #5857),
thanks! I've tested the application, and it works (as bad) as before. To note
would be the possibility that custom actions may stop working when switching
the system to another language after configuring them. Don't know if I
concluded this potential problem from the code correctly, or if translated
strings are actually not stored with a KeySet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36840 a95241bf-73f2-0310-859d-f6bbb57e9c96


# fa1ee6d4d1c15a655d7d5877f88f7e397be16bb7 15-Nov-2009 Jonas Sundström <jonas@kirilla.com>

Clean-up

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34059 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 6c3336782537a5618a4234cfb56e3b17dfee0f72 30-Oct-2009 Fredrik Modeen <fredrik@modeen.se>

So here it goes..
I hope I have fixed all parts that don't follow our guidelines. (that python script was good start)
This are the app, I havn't change the file in clv those are from Santa gift bag

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33848 a95241bf-73f2-0310-859d-f6bbb57e9c96