History log of /haiku/src/preferences/shortcuts/ShortcutsApp.cpp
Revision Date Author Comments
# b42302c5 20-Jan-2014 John Scipione <jscipione@gmail.com>

Shortcuts: Big style refactor

Update the style of this preference app to match Haiku’s coding guidelines.
Since this app used a completely different style this is a big commit, but,
there should be no behavioral changes.

Style changes include but are not limited to:
* private member variables use fMemberVariable style
* local variables and public member variables use camelCase style
* compare pointers to NULL explicitly
* compare integers against 0 explicitly
* always flank binary operators with spaces such as + - , / *
* pointer goes with type, not value or flanked by spaces
* lots of variable renaming especially for abbreviations
* comments start with a leading space, prefer lowercase unless full sentence
* space after keywords such as if and for and { and } on same line
* multi-line if statement style fixes
* remove trailing spaces
* 80 char fixes
* ... and many more, and I'm sure I missed some.

Add/update copyright headers giving credit where due, obviously this code
can’t be copyright Haiku, Inc. from 1999 since Haiku, Inc. didn’t exist
so this change attributes copyright to Jeremy Friesner from 1999-2009 and
Haiku, Inc. from 2009 onwards matching the long description of the rdef file.

Added myself to the authors section of the files in the clv directory.


# 546208a5 16-Apr-2012 Oliver Tappe <zooey@hirschkaefer.de>

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.


# 62769fc6 26-Mar-2011 Jonas Sundström <jonas@kirilla.com>

Follow-up on r41108. Removal of About-windows and menu items.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41115 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 3672a07e 16-May-2010 Stephan Aßmus <superstippi@gmx.de>

Localization of Shortcuts based on a patch by Jorma Karvonen (ticket #5857),
thanks! I've tested the application, and it works (as bad) as before. To note
would be the possibility that custom actions may stop working when switching
the system to another language after configuring them. Don't know if I
concluded this potential problem from the code correctly, or if translated
strings are actually not stored with a KeySet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36840 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 0b2fbbfa 24-Dec-2009 Adrien Destugues <pulkomandy@pulkomandy.ath.cx>

Patch by Humdinger to convert all the preference panels to sentance case.
Also update the localization catalogs as needed.
CPUFrequency localization is broken : the current code works, but the DoCatalogs jamrule is not powerful enough to properly extract the catkeys.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34767 a95241bf-73f2-0310-859d-f6bbb57e9c96


# fa1ee6d4 15-Nov-2009 Jonas Sundström <jonas@kirilla.com>

Clean-up

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34059 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 6c333678 30-Oct-2009 Fredrik Modeen <fredrik@modeen.se>

So here it goes..
I hope I have fixed all parts that don't follow our guidelines. (that python script was good start)
This are the app, I havn't change the file in clv those are from Santa gift bag

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33848 a95241bf-73f2-0310-859d-f6bbb57e9c96


# b42302c5d343ffce4d7ed87bed26e7ffcabce1ae 20-Jan-2014 John Scipione <jscipione@gmail.com>

Shortcuts: Big style refactor

Update the style of this preference app to match Haiku’s coding guidelines.
Since this app used a completely different style this is a big commit, but,
there should be no behavioral changes.

Style changes include but are not limited to:
* private member variables use fMemberVariable style
* local variables and public member variables use camelCase style
* compare pointers to NULL explicitly
* compare integers against 0 explicitly
* always flank binary operators with spaces such as + - , / *
* pointer goes with type, not value or flanked by spaces
* lots of variable renaming especially for abbreviations
* comments start with a leading space, prefer lowercase unless full sentence
* space after keywords such as if and for and { and } on same line
* multi-line if statement style fixes
* remove trailing spaces
* 80 char fixes
* ... and many more, and I'm sure I missed some.

Add/update copyright headers giving credit where due, obviously this code
can’t be copyright Haiku, Inc. from 1999 since Haiku, Inc. didn’t exist
so this change attributes copyright to Jeremy Friesner from 1999-2009 and
Haiku, Inc. from 2009 onwards matching the long description of the rdef file.

Added myself to the authors section of the files in the clv directory.


# 546208a53940a26c6379c48a7854ade1a8250fc5 16-Apr-2012 Oliver Tappe <zooey@hirschkaefer.de>

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.


# 62769fc6d5b7ee60cea4d6e289316a5e20e0c5d4 26-Mar-2011 Jonas Sundström <jonas@kirilla.com>

Follow-up on r41108. Removal of About-windows and menu items.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41115 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 3672a07ec16784e41fe56eeaa558095bc2befc02 16-May-2010 Stephan Aßmus <superstippi@gmx.de>

Localization of Shortcuts based on a patch by Jorma Karvonen (ticket #5857),
thanks! I've tested the application, and it works (as bad) as before. To note
would be the possibility that custom actions may stop working when switching
the system to another language after configuring them. Don't know if I
concluded this potential problem from the code correctly, or if translated
strings are actually not stored with a KeySet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36840 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 0b2fbbfaa9d35d304991f3543276c8e46f155460 24-Dec-2009 Adrien Destugues <pulkomandy@pulkomandy.ath.cx>

Patch by Humdinger to convert all the preference panels to sentance case.
Also update the localization catalogs as needed.
CPUFrequency localization is broken : the current code works, but the DoCatalogs jamrule is not powerful enough to properly extract the catkeys.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34767 a95241bf-73f2-0310-859d-f6bbb57e9c96


# fa1ee6d4d1c15a655d7d5877f88f7e397be16bb7 15-Nov-2009 Jonas Sundström <jonas@kirilla.com>

Clean-up

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34059 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 6c3336782537a5618a4234cfb56e3b17dfee0f72 30-Oct-2009 Fredrik Modeen <fredrik@modeen.se>

So here it goes..
I hope I have fixed all parts that don't follow our guidelines. (that python script was good start)
This are the app, I havn't change the file in clv those are from Santa gift bag

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33848 a95241bf-73f2-0310-859d-f6bbb57e9c96