#
6307bc57 |
|
09-Dec-2023 |
John Scipione <jscipione@gmail.com> |
Tracker: Refactor Default settings to be in one place Create TrackerDefaults.h to share default setting values between TrackerSettings.cpp and SettingsView.cpp instead of duplicating the default value in both places. There is now one source of truth if we ever want to change a setting it won't cause regressions to the Defaults and Revert button state. TODO Does not yet include Disk auto-mount settings. Add HideDotFiles to the defaultable list for Windows settings and make its default false (was true in some places). Fix issues with the Defaults button not enabling Enable type- ahead filtering and Generate image thumbnails as it should. Move default color constants to TrackerDefaults.h, remove TODO. Rename kSpaceBarAlpha to kDefaultSpaceBarAlpha matching rest. Create RGBTOHEX(c) macro to convert rgb_color to a (hex) number for HexScalarValue to set the default space bar colors. Saving these old hex values in the commit message: UsedSpaceColor: 0xc000cb00 FreeSpaceColor: 0xc0ffffff WarningSpaceColor: 0xc0cb0000 Reorder setting to match display order. I've gone way over 80 in TrackerSettings and SettingsViews due to long variable names. Change-Id: Iafd6dfc5e738562d73967558e1f151fc7fed5866 Reviewed-on: https://review.haiku-os.org/c/haiku/+/7196 Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org> Reviewed-by: waddlesplash <waddlesplash@gmail.com>
|