Terminal: graphical settings for configuring themes.

Implements #16835: Make colour schemes modular.
Implements #15936: Terminal settings should allow to drop a colour.

Change-Id: I1071c9285ba887e734af47b724f9de7f6c660581
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5950
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>

Terminal: load themes from data and settings folders.

* Uses the same format as the Terminal settings file
* Adds an additional key, "Theme name", to settings for themes,
which needs to be present for a theme to be loaded, else it
will be skipped
* Loads themes from Terminal/Themes in the data and settings
directories, searching data first, then settings second,
allowing a theme to be tweaked by putting a copy in a
settings folder

Change-Id: I8cadf98151459c1ae6098c38481b16eb3f2cf952

Minor Terminal fixes

In the Terminal settings window, the pop-up help text for
"Tab title:" had two entries for "%% - The character '%'.".
Removed one of the entries.

Fixed the spelling of some constants: kTooTip* vs kToolTip*

Changing the window title and tab title directly will now
show the same tool-tips as the Terminal settings window.

Change-Id: Ic36cc1f8af0305b757105a229203115efee870c8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4989
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Máximo Castañeda <antiswen@yahoo.es>

Terminal: add support for per-theme custom ANSI colours.

* Updates the colour palette for Solarized
* Adds new colour palette, Relaxed (MIT License) [1]

[1]: https://github.com/Relaxed-Theme/relaxed-terminal-themes

Change-Id: Ia81120cd983b9c3b935f8a990867ee4b7c35b6d2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4196
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: John Scipione <jscipione@gmail.com>
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>

Terminal: Allow use of Option as Meta key

Add a configuration setting that allows the left Option key to be used as a
Meta key, and add support for the Escape sequences that control the Meta key's
behaviour.

TermWindow now maintains a copy, shared by all its component TermViews, of the
current key map, and updates this copy automatically when notified by the Input
Server a new key map has been loaded.

The Meta key was an extra modifier key present on early UNIX workstations that
provided access to the "extended" portion of the ASCII character set. Although
it has vanished from modern keyboards certain UNIX software still relies on the
key, most notably GNU Emacs and the GNU readline library, the latter of which
is used by bash and a wide variety of other software that reads input from a
terminal. (Python's interactive mode uses readline, for instance.)

With this patch applied and the new setting enabled, the left Option key can be
used to access additional editing and navigation features at the command line.
It also makes usable the port of GNU Emacs currently available from HaikuDepot.

Fixes #15294.

Change-Id: I150b640b7b18384d56ab2fb017bf16ce8bdbdd78
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1727
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

Terminal: Implement a few cursor CSI commands.

* Cursor back tab, cursor forward tab.
* Cursor next line, cursor previous line.
* also add size 13 to the list of font sizes.

Terminal: always use bright for bold text.

* "Allow bold font" now enables the use of the bold font for bold text.
* so one can now see bold text in black on black.

Moved IsFontUsable() to Globals.h/cpp

Terminal: added basic conditional title patterns.

* You can now insert arbitrary text only if the following or previous
placeholder does not resolve to an empty value using the %<, %> and
%- placeholders.
* Additionally, any non-alpha numeric character between % and the
placeholder character will only be displayed if the placeholder does
not resolve to an empty value, too.
* All of this allows you to get rid of the extra space between
"Terminal" and ":" before the current path -- which is now the
default.

Terminal: use BPopUpMenu in BMenuFields.

Using a BMenu works, but it doesn't look as good.
Thanks to Diver for noticing this.

add window size and encoding to terminal prefs

* The menu items now only set the values for the current window without
saving,
* The settings in the preference window are persistent,
* The "save as defaults" menu item is removed.

Fixes #5030.

Terminal Prefs: replace "OK" with "Defaults"

Again, this is the more standard way to do things in Haiku.

Terminal preferences: replace "Cancel" with "Revert"

This is the standard way in Haiku preference panels.

Terminal: Add option to use bright instead of bold text

A saturated add was chosen instead of tint_color, as the results of
tint_color were too extreme.

Temrinal Prefs: update color control on scheme change

Update the color control state on the scheme change event
Fixes #9864.

Fix CID991252: Possible NULL dereference on scheme name

The color scheme name pointer is dereferenced but was not checked for
NULL value.

Keep color control enabled after color scheme change

Fixes #9532

Fix Terminal localization issues in Custom color scheme

* Localized Label of the colors menu entry was used as the key
during loading corresponding color value from the preferences file.
It was obviously observed only on non-English locales;
* Fixes #7209 #8256.

Renamed cusor colour settings.

"Cursor text" and "Cursor background" in the Color popup menu are
a bit unintuitive. Changed to "Text under cursor" and "Cursor".

Increase the font size options in Terminal

Sizes range from 8 to 36 but not all sizes are represented. The
progression is not linear, the font size increases first by 1,
then 2, and finally by 4.

Works by keying command-(plus)/command-(minus) or selecting
from Font size menu, or from selecting from Font menu in Terminal
settings. If you alter the settings file to put in some other font
size it should still work, but the menu item won't be checked.

Fixes #8849

Unify the Font menu and Font size menu into one.

The Font size menu becomes a submenu of Font so that you can set
both the font and font size at once.

This fixes #4198

Make font size dropdown in settings windows work again

Add font sizes to Font Size menu in addition to in settings

Remove ugly const_cast, thanks Ingo

Style fixes only, no functional changes intended

including converting a while loop into a for loop.

Style fix: compare to 0 in strcmp() explicitly.

Change schema in Terminal to color scheme.

Love this feature, but, color schema is not a thing, it is a color
scheme. Change both the display text and the variable names.

Also changed "Retro Terminal" color scheme to just "Retro". Terminal
is redundant.

Terminal: Ensure changing color schema modifies cursor

* Really fixes #8256

Improved string of new Terminal setting.

Terminal: Make the cursor color configurable.

Signed-off-by: Adrien Destugues - PulkoMandy <pulkomandy@pulkomandy.tk>

Terminal: Make cursor blinking an option.

Signed-off-by: Rene Gollent <anevilyak@gmail.com>

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Some fixes for GCC 4.6 warning: variable set but not used

[Coverity] Fixed some uninit fields and return values checks

* Fixed CID2398, CID9945, CID9943, CID4215

* Applied patch by 'mt' that fixes ticket #6275 - thanks a lot!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42968 a95241bf-73f2-0310-859d-f6bbb57e9c96

Can't use static const PREF_*_COLOR keys for translation.
Revert to literals for color menu items which needs, them, being localized.
Add missing source files to DoCatalogs.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39749 a95241bf-73f2-0310-859d-f6bbb57e9c96

Localize some forgotten strings spotted by diver.
Fix #6375.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39748 a95241bf-73f2-0310-859d-f6bbb57e9c96

Moved the reusable part of the tab/window title prefs tool tips to
TermConst.h/cpp.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39496 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented support for dynamic tab and window titles:
* Added settings for tab and window titles. Both are strings with optional
placeholders for tab/terminal index, currently active process name and
current directory.
* Added a generic utility class PatternEvaluator that allows to expand this
kind of pattern strings and callback classes
[Tab,Window]TitlePlaceholderMapper that provide the specific expansion for
the tab and window title placeholders.
* TermWindow:
- Separated the notions of session (== tab) and window titles. The tty
clients no longer set the window, but the session title.
- Use the patterns instead of the hard-coded window/tab titles.
- Recompute all titles once a second, so changes of running programs are
reflected.
* The default patterns for tab and window titles are "%1d: %p" (last CWD
component and name of the running process) and "Terminal %i: %t" (Terminal
ID and active tab title). Unfortunately the space on the tabs is seriously
limited, so that the tab title is virtually always truncated. Ideas welcome.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39473 a95241bf-73f2-0310-859d-f6bbb57e9c96

Style cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39464 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Remove the setting for a fixed cursor color. Instead, the cursor now inverts the colors of the char below it.
* This allows getting a cursor well visible both on black and white backgrouds.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39183 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix style violations I've commited in r38207 and r38251, the first pointed out by Ingo <- thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38252 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix regression caused by me in r38207, pointed out by diver in #6407, thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38251 a95241bf-73f2-0310-859d-f6bbb57e9c96

Update some apps/add-ons/preflets for impending changes to the layout API, specifically the layout builders. Also do a bit of style and layout cleanup in some places. This is part of #6407. Everything I've updated should look and function the same as it did before.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38064 a95241bf-73f2-0310-859d-f6bbb57e9c96

Better wording.
The colors don't need to be public.
Style.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37759 a95241bf-73f2-0310-859d-f6bbb57e9c96

Terminal will issue an alert, if there are active processes and the
user closes the window (doesn't work if the user closes only a tab, yet).
Active by default but can be disabled by a checkbox.
- The preference window needs to be reworked.
- Wording of the alert and the option can be improved (I accept advices).



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37754 a95241bf-73f2-0310-859d-f6bbb57e9c96

Style.
Add NULL guard to the color schemes struct, although the code was safe
neverthless (for now)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37575 a95241bf-73f2-0310-859d-f6bbb57e9c96

Add a menufield to select color combinations, and add obvious
"white on black" and "black on white". For some reason these aren't
applied live, like when you chose a custom combo.
I'm not really fond of the code, and will rework it in the next few days.
But at least it works!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37535 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed spelling in the TR_CONTEXT macro. BTW this macro should be renamed
as well. Maybe B_TRANSLATION_CONTEXT?
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36710 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36675 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Jorma Karvonen: Localization of the Terminal application. Thanks a lot.
Closes ticket #5850.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36640 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by mt (ticket #5149): Applied BGridLayout to BMenuFields in the
preferences window. Thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34734 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed dependency to the global gMouseClipboard from TermView. Now there's
a SetMouseClipboard() method to set one (defaults to be_clipboard, maybe
it's not a good idea and should default to NULL instead).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34178 a95241bf-73f2-0310-859d-f6bbb57e9c96

Made the Find Window a bit wider by default, moved some functions around,
got rid of MenuUtil.h/cpp.
Some style change.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34173 a95241bf-73f2-0310-859d-f6bbb57e9c96

Tweak a bit the layout of the preference window.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34168 a95241bf-73f2-0310-859d-f6bbb57e9c96

Cleanup: removed unused messages constant and classes, merged AppearPrefView
with PrefView, moved main from Terminal.cpp to TermApp.cpp.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34163 a95241bf-73f2-0310-859d-f6bbb57e9c96

Renamed the BMessengers to make clearer to which messengers they
refer to. Made some parameters const references. Removed leftovers.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34162 a95241bf-73f2-0310-859d-f6bbb57e9c96

Work in progress: converting the terminal preference window to the layout api


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34160 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added TODO comment, removed leftover.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34020 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added a check which makes WebDings fail the IsFontUsable() check.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34019 a95241bf-73f2-0310-859d-f6bbb57e9c96

If no item is selected, select the first item.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33948 a95241bf-73f2-0310-859d-f6bbb57e9c96

Also set a default style in the preferences. Mark the menuitem with the
default family/style.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33947 a95241bf-73f2-0310-859d-f6bbb57e9c96

When building the font menu, also include font styles.
Now it's possible to select bold or oblique font styles.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33946 a95241bf-73f2-0310-859d-f6bbb57e9c96

A patch from Caitlin Shaw (aka rogueeve) to fix #4715, some Terminal
improvements:

* fixed text for "Use Text" radio button in Find dialog being cut off
* more user friendly error messages for Find dialog:
"no search string" becomes "No search string was entered.", or "Nothing is
selected." as appropriate.
* Preferences dialog opens unacceptably slow when a larger number of fonts are
installed due to AppearPrefView's "IsFontUsuable" routine. But was able to
cut opening time by about half with a minor optimization to the loop.

* Fixed an ugly word-wrap of Takashi Murai's name in About dialog


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33428 a95241bf-73f2-0310-859d-f6bbb57e9c96

Preference panel : Reverted some of my "optimizations" since Ingo (correctly) points out that:
* they (the way I did it) can do more worse than good in some case
* they (the way I did it) are generally against our coding-style

Sorry about that. (ticket #4245)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32439 a95241bf-73f2-0310-859d-f6bbb57e9c96

Further optimization in the construction time of the Preference Panel (ticket #4245).
Indentation fix.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32435 a95241bf-73f2-0310-859d-f6bbb57e9c96

Preference panel: Optimizations to make the window appear faster.

* In most case, the font size will already have been found with the regular check, move the extra check at the end if really it's needed.
* Some variables were declared inside loops (BTW, is that more conform to our coding style? It does feel faster if I declare them outside of the loop)
* The alignment was simplified (without visual difference).

In answer to ticket #4245.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32434 a95241bf-73f2-0310-859d-f6bbb57e9c96

Preferences Panel : Check if the font, size or color was indeed changed before setting it as modified, avoiding unneeded "Save/Cancel" dialog.
This fixes ticket #3348.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32421 a95241bf-73f2-0310-859d-f6bbb57e9c96

Terminal's preferences window :
* Align the controls
* Remove a bit of gray space that was superflous
* Size dropdown menu now includes sizes of 13, 15 or 17, if needed, avoiding the case where is shown the word "size".
Basically, it doesn't show them unless you got at that value by using the menu entries.

Also disables the Increase/Decrease text size menu entries if you reach the upper or lower bounds.

Partly fixes ticket #4198.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32225 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied old patch by Urias (see #3209) improving strings in Terminal's preferences. Added a few more tidbits.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32205 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Messed up IsFontUsable(), this closed bug #3895 if I understand diver
correctly.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30670 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed warnings.
* Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30267 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied patch by h.z. (slightly modified by myself) included in bug #2715. I tested it briefly with Konatu Tohaba font and it seems to work correctly. Please review.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29129 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Changed BColorControl cellsize to account for the fixes in BColorControl. A rounding error gave the right appearance. see r23671 and r23680. Also, we might want to check the minimum cellsize in R5 and use the same for compatibility.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25931 a95241bf-73f2-0310-859d-f6bbb57e9c96

- MakeMenu() now adds a separator for empty strings.
- add pref names for ANSI colors, for later...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25387 a95241bf-73f2-0310-859d-f6bbb57e9c96

AppearPrefView was mixing up flags and resizing mode. Fixed.
Also set the flag B_PULSE_NEEDED (for the blinking cursor) in TermView.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23911 a95241bf-73f2-0310-859d-f6bbb57e9c96

And of course, actually save the font size selected via shortcut.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23862 a95241bf-73f2-0310-859d-f6bbb57e9c96

more renaming


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23695 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed support for "Full font", which wasn't used anyway. Since
our Terminal only works correctly with fixed width fonts, now the font
menu filters out variable width ones. For some reason, though, Konatu
Tohaba isn't recognized as fixed. Various other changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23591 a95241bf-73f2-0310-859d-f6bbb57e9c96

Got rid of gTermPref by adding some static methods to PrefHandler.
The font size menu wasn't up to date with the current settings. Fixed.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21630 a95241bf-73f2-0310-859d-f6bbb57e9c96

Another patch by Vasilis Kaoutsis: Replaced pointer use with a
BMessenger


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20238 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed "full font" vs. "half font" setting (in the GUI only for now) - this
should better be handled by the app_server (ie. via font overlays).
* Fixed compilation under Dano.
* Fixed some broken headers.
* Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14861 a95241bf-73f2-0310-859d-f6bbb57e9c96

Moved the files out of the MYOB folder into the main folder.
There are some double entries (like TermApp.cpp and TerminalApp.cpp, so
it still needs a further cleanup).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13734 a95241bf-73f2-0310-859d-f6bbb57e9c96

Moved IsFontUsable() to Globals.h/cpp

Terminal: added basic conditional title patterns.

* You can now insert arbitrary text only if the following or previous
placeholder does not resolve to an empty value using the %<, %> and
%- placeholders.
* Additionally, any non-alpha numeric character between % and the
placeholder character will only be displayed if the placeholder does
not resolve to an empty value, too.
* All of this allows you to get rid of the extra space between
"Terminal" and ":" before the current path -- which is now the
default.

Terminal: use BPopUpMenu in BMenuFields.

Using a BMenu works, but it doesn't look as good.
Thanks to Diver for noticing this.

add window size and encoding to terminal prefs

* The menu items now only set the values for the current window without
saving,
* The settings in the preference window are persistent,
* The "save as defaults" menu item is removed.

Fixes #5030.

Terminal Prefs: replace "OK" with "Defaults"

Again, this is the more standard way to do things in Haiku.

Terminal preferences: replace "Cancel" with "Revert"

This is the standard way in Haiku preference panels.

Terminal: Add option to use bright instead of bold text

A saturated add was chosen instead of tint_color, as the results of
tint_color were too extreme.

Temrinal Prefs: update color control on scheme change

Update the color control state on the scheme change event
Fixes #9864.

Fix CID991252: Possible NULL dereference on scheme name

The color scheme name pointer is dereferenced but was not checked for
NULL value.

Keep color control enabled after color scheme change

Fixes #9532

Fix Terminal localization issues in Custom color scheme

* Localized Label of the colors menu entry was used as the key
during loading corresponding color value from the preferences file.
It was obviously observed only on non-English locales;
* Fixes #7209 #8256.

Renamed cusor colour settings.

"Cursor text" and "Cursor background" in the Color popup menu are
a bit unintuitive. Changed to "Text under cursor" and "Cursor".

Increase the font size options in Terminal

Sizes range from 8 to 36 but not all sizes are represented. The
progression is not linear, the font size increases first by 1,
then 2, and finally by 4.

Works by keying command-(plus)/command-(minus) or selecting
from Font size menu, or from selecting from Font menu in Terminal
settings. If you alter the settings file to put in some other font
size it should still work, but the menu item won't be checked.

Fixes #8849

Unify the Font menu and Font size menu into one.

The Font size menu becomes a submenu of Font so that you can set
both the font and font size at once.

This fixes #4198

Make font size dropdown in settings windows work again

Add font sizes to Font Size menu in addition to in settings

Remove ugly const_cast, thanks Ingo

Style fixes only, no functional changes intended

including converting a while loop into a for loop.

Style fix: compare to 0 in strcmp() explicitly.

Change schema in Terminal to color scheme.

Love this feature, but, color schema is not a thing, it is a color
scheme. Change both the display text and the variable names.

Also changed "Retro Terminal" color scheme to just "Retro". Terminal
is redundant.

Terminal: Ensure changing color schema modifies cursor

* Really fixes #8256

Improved string of new Terminal setting.

Terminal: Make the cursor color configurable.

Signed-off-by: Adrien Destugues - PulkoMandy <pulkomandy@pulkomandy.tk>

Terminal: Make cursor blinking an option.

Signed-off-by: Rene Gollent <anevilyak@gmail.com>

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Some fixes for GCC 4.6 warning: variable set but not used

[Coverity] Fixed some uninit fields and return values checks

* Fixed CID2398, CID9945, CID9943, CID4215

* Applied patch by 'mt' that fixes ticket #6275 - thanks a lot!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42968 a95241bf-73f2-0310-859d-f6bbb57e9c96

Can't use static const PREF_*_COLOR keys for translation.
Revert to literals for color menu items which needs, them, being localized.
Add missing source files to DoCatalogs.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39749 a95241bf-73f2-0310-859d-f6bbb57e9c96

Localize some forgotten strings spotted by diver.
Fix #6375.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39748 a95241bf-73f2-0310-859d-f6bbb57e9c96

Moved the reusable part of the tab/window title prefs tool tips to
TermConst.h/cpp.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39496 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented support for dynamic tab and window titles:
* Added settings for tab and window titles. Both are strings with optional
placeholders for tab/terminal index, currently active process name and
current directory.
* Added a generic utility class PatternEvaluator that allows to expand this
kind of pattern strings and callback classes
[Tab,Window]TitlePlaceholderMapper that provide the specific expansion for
the tab and window title placeholders.
* TermWindow:
- Separated the notions of session (== tab) and window titles. The tty
clients no longer set the window, but the session title.
- Use the patterns instead of the hard-coded window/tab titles.
- Recompute all titles once a second, so changes of running programs are
reflected.
* The default patterns for tab and window titles are "%1d: %p" (last CWD
component and name of the running process) and "Terminal %i: %t" (Terminal
ID and active tab title). Unfortunately the space on the tabs is seriously
limited, so that the tab title is virtually always truncated. Ideas welcome.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39473 a95241bf-73f2-0310-859d-f6bbb57e9c96

Style cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39464 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Remove the setting for a fixed cursor color. Instead, the cursor now inverts the colors of the char below it.
* This allows getting a cursor well visible both on black and white backgrouds.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39183 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix style violations I've commited in r38207 and r38251, the first pointed out by Ingo <- thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38252 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix regression caused by me in r38207, pointed out by diver in #6407, thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38251 a95241bf-73f2-0310-859d-f6bbb57e9c96

Update some apps/add-ons/preflets for impending changes to the layout API, specifically the layout builders. Also do a bit of style and layout cleanup in some places. This is part of #6407. Everything I've updated should look and function the same as it did before.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38064 a95241bf-73f2-0310-859d-f6bbb57e9c96

Better wording.
The colors don't need to be public.
Style.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37759 a95241bf-73f2-0310-859d-f6bbb57e9c96

Terminal will issue an alert, if there are active processes and the
user closes the window (doesn't work if the user closes only a tab, yet).
Active by default but can be disabled by a checkbox.
- The preference window needs to be reworked.
- Wording of the alert and the option can be improved (I accept advices).



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37754 a95241bf-73f2-0310-859d-f6bbb57e9c96

Style.
Add NULL guard to the color schemes struct, although the code was safe
neverthless (for now)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37575 a95241bf-73f2-0310-859d-f6bbb57e9c96

Add a menufield to select color combinations, and add obvious
"white on black" and "black on white". For some reason these aren't
applied live, like when you chose a custom combo.
I'm not really fond of the code, and will rework it in the next few days.
But at least it works!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37535 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed spelling in the TR_CONTEXT macro. BTW this macro should be renamed
as well. Maybe B_TRANSLATION_CONTEXT?
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36710 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36675 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Jorma Karvonen: Localization of the Terminal application. Thanks a lot.
Closes ticket #5850.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36640 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by mt (ticket #5149): Applied BGridLayout to BMenuFields in the
preferences window. Thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34734 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed dependency to the global gMouseClipboard from TermView. Now there's
a SetMouseClipboard() method to set one (defaults to be_clipboard, maybe
it's not a good idea and should default to NULL instead).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34178 a95241bf-73f2-0310-859d-f6bbb57e9c96

Made the Find Window a bit wider by default, moved some functions around,
got rid of MenuUtil.h/cpp.
Some style change.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34173 a95241bf-73f2-0310-859d-f6bbb57e9c96

Tweak a bit the layout of the preference window.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34168 a95241bf-73f2-0310-859d-f6bbb57e9c96

Cleanup: removed unused messages constant and classes, merged AppearPrefView
with PrefView, moved main from Terminal.cpp to TermApp.cpp.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34163 a95241bf-73f2-0310-859d-f6bbb57e9c96

Renamed the BMessengers to make clearer to which messengers they
refer to. Made some parameters const references. Removed leftovers.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34162 a95241bf-73f2-0310-859d-f6bbb57e9c96

Work in progress: converting the terminal preference window to the layout api


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34160 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added TODO comment, removed leftover.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34020 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added a check which makes WebDings fail the IsFontUsable() check.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34019 a95241bf-73f2-0310-859d-f6bbb57e9c96

If no item is selected, select the first item.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33948 a95241bf-73f2-0310-859d-f6bbb57e9c96

Also set a default style in the preferences. Mark the menuitem with the
default family/style.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33947 a95241bf-73f2-0310-859d-f6bbb57e9c96

When building the font menu, also include font styles.
Now it's possible to select bold or oblique font styles.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33946 a95241bf-73f2-0310-859d-f6bbb57e9c96

A patch from Caitlin Shaw (aka rogueeve) to fix #4715, some Terminal
improvements:

* fixed text for "Use Text" radio button in Find dialog being cut off
* more user friendly error messages for Find dialog:
"no search string" becomes "No search string was entered.", or "Nothing is
selected." as appropriate.
* Preferences dialog opens unacceptably slow when a larger number of fonts are
installed due to AppearPrefView's "IsFontUsuable" routine. But was able to
cut opening time by about half with a minor optimization to the loop.

* Fixed an ugly word-wrap of Takashi Murai's name in About dialog


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33428 a95241bf-73f2-0310-859d-f6bbb57e9c96

Preference panel : Reverted some of my "optimizations" since Ingo (correctly) points out that:
* they (the way I did it) can do more worse than good in some case
* they (the way I did it) are generally against our coding-style

Sorry about that. (ticket #4245)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32439 a95241bf-73f2-0310-859d-f6bbb57e9c96

Further optimization in the construction time of the Preference Panel (ticket #4245).
Indentation fix.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32435 a95241bf-73f2-0310-859d-f6bbb57e9c96

Preference panel: Optimizations to make the window appear faster.

* In most case, the font size will already have been found with the regular check, move the extra check at the end if really it's needed.
* Some variables were declared inside loops (BTW, is that more conform to our coding style? It does feel faster if I declare them outside of the loop)
* The alignment was simplified (without visual difference).

In answer to ticket #4245.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32434 a95241bf-73f2-0310-859d-f6bbb57e9c96

Preferences Panel : Check if the font, size or color was indeed changed before setting it as modified, avoiding unneeded "Save/Cancel" dialog.
This fixes ticket #3348.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32421 a95241bf-73f2-0310-859d-f6bbb57e9c96

Terminal's preferences window :
* Align the controls
* Remove a bit of gray space that was superflous
* Size dropdown menu now includes sizes of 13, 15 or 17, if needed, avoiding the case where is shown the word "size".
Basically, it doesn't show them unless you got at that value by using the menu entries.

Also disables the Increase/Decrease text size menu entries if you reach the upper or lower bounds.

Partly fixes ticket #4198.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32225 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied old patch by Urias (see #3209) improving strings in Terminal's preferences. Added a few more tidbits.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32205 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Messed up IsFontUsable(), this closed bug #3895 if I understand diver
correctly.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30670 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed warnings.
* Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30267 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied patch by h.z. (slightly modified by myself) included in bug #2715. I tested it briefly with Konatu Tohaba font and it seems to work correctly. Please review.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29129 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Changed BColorControl cellsize to account for the fixes in BColorControl. A rounding error gave the right appearance. see r23671 and r23680. Also, we might want to check the minimum cellsize in R5 and use the same for compatibility.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25931 a95241bf-73f2-0310-859d-f6bbb57e9c96

- MakeMenu() now adds a separator for empty strings.
- add pref names for ANSI colors, for later...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25387 a95241bf-73f2-0310-859d-f6bbb57e9c96

AppearPrefView was mixing up flags and resizing mode. Fixed.
Also set the flag B_PULSE_NEEDED (for the blinking cursor) in TermView.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23911 a95241bf-73f2-0310-859d-f6bbb57e9c96

And of course, actually save the font size selected via shortcut.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23862 a95241bf-73f2-0310-859d-f6bbb57e9c96

more renaming


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23695 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed support for "Full font", which wasn't used anyway. Since
our Terminal only works correctly with fixed width fonts, now the font
menu filters out variable width ones. For some reason, though, Konatu
Tohaba isn't recognized as fixed. Various other changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23591 a95241bf-73f2-0310-859d-f6bbb57e9c96

Got rid of gTermPref by adding some static methods to PrefHandler.
The font size menu wasn't up to date with the current settings. Fixed.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21630 a95241bf-73f2-0310-859d-f6bbb57e9c96

Another patch by Vasilis Kaoutsis: Replaced pointer use with a
BMessenger


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20238 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed "full font" vs. "half font" setting (in the GUI only for now) - this
should better be handled by the app_server (ie. via font overlays).
* Fixed compilation under Dano.
* Fixed some broken headers.
* Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14861 a95241bf-73f2-0310-859d-f6bbb57e9c96

Moved the files out of the MYOB folder into the main folder.
There are some double entries (like TermApp.cpp and TerminalApp.cpp, so
it still needs a further cleanup).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13734 a95241bf-73f2-0310-859d-f6bbb57e9c96