DiskProbe: Coding style cleanup

* Not complete, no functional changes intended.

Finally implemented BWindow::CenterOnScreen, with associated CenterIn(BRect)
methods as well as Size(). To avoid the problem of centering the window before
it has been resized by the layout system, I force the resizing early. If there
is a better way to do this or some way to avoid doing it repeatedly, let me
know. But I figure the Center* methods should not be called that often.

Updated Screenshot and DiskProbe to use this new method as a test. It certainly
cleaned up DiskProbe. I will update other code over the next few days (if
anyone wants to help, please do :)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32612 a95241bf-73f2-0310-859d-f6bbb57e9c96

Center the OpenWindow. The problem is that we cannot get the real size of the window before it's actually shown on screen.. the trick I did was to show it offscreen, get the real size and move the window.

Fixes ticket #4236


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32410 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Ankur Sethi: Use layout-management in the OpenWindow of DiskProbe.
Works around the issue from ticket #1809.

Thanks a lot! Please note some changes I have made:
* When using layout management, use the contructors that don't take BRects
and "follow modes". (You forgot that for the BButtons.)
* You reversed the button order.
* I found it more convenient to use a BGridLayoutBuilder. And it seemed odd
to only add the menu bar layout item, not also the label item.
* Finally, to create a patch, cd into the Haiku root folder and use "svn diff",
like "svn diff src/apps/diskprobe/ > patch.diff". I had to apply your patch
manually line by line, I am not very firm with "patch", although I am sure
there would have been a way to do it... :-)

Nice work!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30174 a95241bf-73f2-0310-859d-f6bbb57e9c96

Build fixes for the R5/Dano target, no longer relies on the COMPILE_FOR_R5 macro.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16887 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented the document handling foundation for DiskProbe.
Does not yet maintain the window position on disk (nor any other settings).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6549 a95241bf-73f2-0310-859d-f6bbb57e9c96

Finally implemented BWindow::CenterOnScreen, with associated CenterIn(BRect)
methods as well as Size(). To avoid the problem of centering the window before
it has been resized by the layout system, I force the resizing early. If there
is a better way to do this or some way to avoid doing it repeatedly, let me
know. But I figure the Center* methods should not be called that often.

Updated Screenshot and DiskProbe to use this new method as a test. It certainly
cleaned up DiskProbe. I will update other code over the next few days (if
anyone wants to help, please do :)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32612 a95241bf-73f2-0310-859d-f6bbb57e9c96

Center the OpenWindow. The problem is that we cannot get the real size of the window before it's actually shown on screen.. the trick I did was to show it offscreen, get the real size and move the window.

Fixes ticket #4236


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32410 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Ankur Sethi: Use layout-management in the OpenWindow of DiskProbe.
Works around the issue from ticket #1809.

Thanks a lot! Please note some changes I have made:
* When using layout management, use the contructors that don't take BRects
and "follow modes". (You forgot that for the BButtons.)
* You reversed the button order.
* I found it more convenient to use a BGridLayoutBuilder. And it seemed odd
to only add the menu bar layout item, not also the label item.
* Finally, to create a patch, cd into the Haiku root folder and use "svn diff",
like "svn diff src/apps/diskprobe/ > patch.diff". I had to apply your patch
manually line by line, I am not very firm with "patch", although I am sure
there would have been a way to do it... :-)

Nice work!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30174 a95241bf-73f2-0310-859d-f6bbb57e9c96

Build fixes for the R5/Dano target, no longer relies on the COMPILE_FOR_R5 macro.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16887 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented the document handling foundation for DiskProbe.
Does not yet maintain the window position on disk (nor any other settings).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6549 a95241bf-73f2-0310-859d-f6bbb57e9c96