Shortcuts: fix node monitoring of settings file. Fixes #6278.

The initial checks for the settings path were unnecessary, and
prevented node monitoring from starting when the settings file
didn't exist.

Replace FindFirst() == 0 with StartsWith()

Thanks PulkoMandy.

shortcut_catcher: Add Jessica Hamilton to authors

... with permission to recognize her contributions here.

shortcut_catcher: Small refactor to FindPaths()

Should be functionally identical.

* Removed / after Tracker, thanks Axel.
* BString::FindFirst() returns an index not a status_t so check that
it finds the path at the start of the string (index 0).
* Put paths.CountStrings() in a count variable.

I wanted to clean this code up because I use it as a reference.

shortcut_catcher: tiny style fix

shortcut_catcher: rename a couple variables

Fix build, msg => message

Fix warning use int32, not uint32

Also do a bit of refactoring.

shortcut_catcher: A few 80 char limit fixes

Shortcuts: use BPathFinder instead of find_directory. Fixes #9958.

* Previously, BPath::Append() would return an empty path if the
path didn't exist (and an error); in a nightly image, the
B_USER_ADDONS_DIRECTORY didn't exist, triggering the bug.
* Replaced the code with calls to BPathFinder instead, which takes
care of the empty path automatically.

Revert "shortcut_catcher: Fix KeyCommandMap::_DeleteHKSList()"

This reverts commit cb3243fbbd1f06f5c205c7cbc3a6911586d6cf9e.

Sorry, this might do bad things.

shortcut_catcher: style overhaul

shortcut_catcher: Fix KeyCommandMap::_DeleteHKSList()

You can't increment the list item counter as you delete because the count
decreases as you go. Instead delete the first item until there are no more
items, then delete the list.

Remove B_COMMON*_DIRECTORY and kCommon*Directory constants

* This does intentionally break source compatibility, so that a review
of concerned code is forced.
* Binary compatibility should be maintained in most cases. The values
of the constants for the writable directories are now used for the
writable system directories. The values for the non-writable
directories are mapped to "/boot/system/data/empty/...", an empty or
non-existent directory, so that they will simply be skipped in search
paths. Only code that explicitly expects to find something in a
B_COMMON_* directory, will fail.

Shortcut catcher: crash fix, better monitoring of setting file

* Fix bad memory cleaning I introduced in earlier commit, causing crash in add-on
* Upon detecting the deletion of setting file, shortcuts weren't properly removed
* The node monitoring would not filter the right file on every case

Thanks Diver.

Shortcut add-on: change to accomodate tracker add-ons

* Ignore shortcuts regardings tracker add-ons. Its settings file is now shared
with Tracker, and those are now handled by Tracker.
* Use a BPathMonitor as specified in a TODO to check the presence and changes on
the settings file. (#6278)
* Use a message to ask Tracker to launch/open folders as specified in TODO

Add TODO about the Shortcuts settings file management.

Now we can close #6278.

Correction of code style.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39158 a95241bf-73f2-0310-859d-f6bbb57e9c96

Create settings file if missing, so shortcut_catchers node monitoring works. Prior to this change, the add-on would not sense the Shortcuts preferences creating the file, and it wouldn't work right away but only after a reboot. This improves first boot, first use.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39148 a95241bf-73f2-0310-859d-f6bbb57e9c96

Give a better name than the default "user thread" to Shortcuts's
input_server filter BLoopers, too.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39038 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Cleanup, no functional change.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33958 a95241bf-73f2-0310-859d-f6bbb57e9c96

So here it goes..
I hope I have fixed all parts that don't follow our guidelines. (that python script was good start)
This is the filter..

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33847 a95241bf-73f2-0310-859d-f6bbb57e9c96

Shortcuts: fix node monitoring of settings file. Fixes #6278.

The initial checks for the settings path were unnecessary, and
prevented node monitoring from starting when the settings file
didn't exist.

Replace FindFirst() == 0 with StartsWith()

Thanks PulkoMandy.

shortcut_catcher: Add Jessica Hamilton to authors

... with permission to recognize her contributions here.

shortcut_catcher: Small refactor to FindPaths()

Should be functionally identical.

* Removed / after Tracker, thanks Axel.
* BString::FindFirst() returns an index not a status_t so check that
it finds the path at the start of the string (index 0).
* Put paths.CountStrings() in a count variable.

I wanted to clean this code up because I use it as a reference.

shortcut_catcher: tiny style fix

shortcut_catcher: rename a couple variables

Fix build, msg => message

Fix warning use int32, not uint32

Also do a bit of refactoring.

shortcut_catcher: A few 80 char limit fixes

Shortcuts: use BPathFinder instead of find_directory. Fixes #9958.

* Previously, BPath::Append() would return an empty path if the
path didn't exist (and an error); in a nightly image, the
B_USER_ADDONS_DIRECTORY didn't exist, triggering the bug.
* Replaced the code with calls to BPathFinder instead, which takes
care of the empty path automatically.

Revert "shortcut_catcher: Fix KeyCommandMap::_DeleteHKSList()"

This reverts commit cb3243fbbd1f06f5c205c7cbc3a6911586d6cf9e.

Sorry, this might do bad things.

shortcut_catcher: style overhaul

shortcut_catcher: Fix KeyCommandMap::_DeleteHKSList()

You can't increment the list item counter as you delete because the count
decreases as you go. Instead delete the first item until there are no more
items, then delete the list.

Remove B_COMMON*_DIRECTORY and kCommon*Directory constants

* This does intentionally break source compatibility, so that a review
of concerned code is forced.
* Binary compatibility should be maintained in most cases. The values
of the constants for the writable directories are now used for the
writable system directories. The values for the non-writable
directories are mapped to "/boot/system/data/empty/...", an empty or
non-existent directory, so that they will simply be skipped in search
paths. Only code that explicitly expects to find something in a
B_COMMON_* directory, will fail.

Shortcut catcher: crash fix, better monitoring of setting file

* Fix bad memory cleaning I introduced in earlier commit, causing crash in add-on
* Upon detecting the deletion of setting file, shortcuts weren't properly removed
* The node monitoring would not filter the right file on every case

Thanks Diver.

Shortcut add-on: change to accomodate tracker add-ons

* Ignore shortcuts regardings tracker add-ons. Its settings file is now shared
with Tracker, and those are now handled by Tracker.
* Use a BPathMonitor as specified in a TODO to check the presence and changes on
the settings file. (#6278)
* Use a message to ask Tracker to launch/open folders as specified in TODO

Add TODO about the Shortcuts settings file management.

Now we can close #6278.

Correction of code style.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39158 a95241bf-73f2-0310-859d-f6bbb57e9c96

Create settings file if missing, so shortcut_catchers node monitoring works. Prior to this change, the add-on would not sense the Shortcuts preferences creating the file, and it wouldn't work right away but only after a reboot. This improves first boot, first use.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39148 a95241bf-73f2-0310-859d-f6bbb57e9c96

Give a better name than the default "user thread" to Shortcuts's
input_server filter BLoopers, too.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39038 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Cleanup, no functional change.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33958 a95241bf-73f2-0310-859d-f6bbb57e9c96

So here it goes..
I hope I have fixed all parts that don't follow our guidelines. (that python script was good start)
This is the filter..

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33847 a95241bf-73f2-0310-859d-f6bbb57e9c96