#
b3e76948 |
|
16-Aug-2023 |
Warner Losh <imp@FreeBSD.org> |
Remove $FreeBSD$: two-line .h pattern Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/
|
#
4d846d26 |
|
10-May-2023 |
Warner Losh <imp@FreeBSD.org> |
spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch up to that fact and revert to their recommended match of BSD-2-Clause. Discussed with: pfg MFC After: 3 days Sponsored by: Netflix
|
#
7b02c1e8 |
|
18-Apr-2022 |
John Baldwin <jhb@FreeBSD.org> |
iscsi: Fetch limits based on a socket rather than assuming global limits. cxgbei needs the ability to return different limits based on the connection (e.g. if the connection is over a T5 adapter or a T6 adapter as well as factoring in the MTU). This change plumbs through the changes in the ioctls without changing any of the backends. The limits callback passed to icl_register now accepts a second socket argument which holds the integer file descriptor. To support ABI compatiblity for old binaries, the callback should return "global" values if the socket fd is zero. The CTL_ISCSI_LIMITS argument used with CTL_ISCSI by ctld(8) now accepts the socket fd in a field that was previously part of a reserved spare field. Old binaries zero this request which results in passing a socket fd of 0 to the limits callback. The ISCSIDREQUEST ioctl no longer returns limits. Instead, iscsid(8) invokes a new ISCSIDLIMITS ioctl after establishing the connection via connect(2). For ABI compat, if the old ISCSIDREQUEST is invoked, the global limits are still fetched (with a socket fd of 0) and returned. Reviewed by: mav Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D34928
|
#
63783933 |
|
22-Dec-2021 |
John Baldwin <jhb@FreeBSD.org> |
Add an internal libiscsiutil library. Move some of the code duplicated between ctld(8) and iscsid(8) into a libiscsiutil library. Sharing the low-level PDU code did require having a 'struct connection' base class with a method table to permit separate initiator vs target behavior (e.g. in handling proxy PDUs). Reviewed by: mav, emaste Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D33544
|
#
bdbc2a6f |
|
29-Dec-2020 |
Alexander Motin <mav@FreeBSD.org> |
Fix typo in an_initator_name. MFC after: 1 week
|
#
a3434cdc |
|
29-Dec-2020 |
Alexander Motin <mav@FreeBSD.org> |
Fix typo in ap_initator_portal. MFC after: 1 week
|
#
bce7ee9d |
|
28-Oct-2020 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Drop "All rights reserved" from all my stuff. This includes Foundation copyrights, approved by emaste@. It does not include files which carry other people's copyrights; if you're one of those people, feel free to make similar change. Reviewed by: emaste, imp, gbe (manpages) Differential Revision: https://reviews.freebsd.org/D26980
|
#
ea8f1280 |
|
24-Oct-2020 |
Richard Scheffenegger <rscheff@FreeBSD.org> |
Add network QoS support for PCP to iscsi target. Mak the Ethernet PCP codepoint configurable for L2 local traffic, to allow lower latency for iSCSI block IO. This addresses the target side only. Reviewed by: mav, trasz, bcr Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D26740
|
#
64ffe6d4 |
|
27-Sep-2020 |
Richard Scheffenegger <rscheff@FreeBSD.org> |
Add DSCP support for network QoS to iscsi target. In order to prioritize iSCSI traffic across a network, DSCP can be used. In order not to rely on "ipfw setdscp" or in-network reclassification, this adds the dscp value directly to the portal group (where TCP sessions are accepted). The incoming iSCSI session is first handled by ctld for any CHAP authentication and the socket is then handed off to the in-kernel iscsi driver without modification of the socket parameters. Simply setting up the socket in ctld is sufficient to keep sending outgoing iSCSI related traffic with the configured DSCP value. Reviewed by: mav, trasz MFC after: 2 weeks Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D26385
|
#
8951f055 |
|
09-May-2018 |
Marcelo Araujo <araujo@FreeBSD.org> |
Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports. This revision introduces two changes to CTL: - Changes the way options are passed to CTL_LUN_REQ and CTL_PORT_REQ ioctls. Removes ctl_be_arg structure and associated logic and replaces it with nv(3)-based logic for passing in and out arguments. - Allows creating multiple ioctl frontend ports using either ctladm(8) or ctld(8). New frontend ports are represented by /dev/cam/ctl<pp>.<vp> nodes, eg /dev/cam/ctl5.3. Those device nodes respond only to CTL_IO ioctl. New command-line options for ctladm: # creates new ioctl frontend port with using free pp and vp=0 ctladm port -c # creates new ioctl frontend port with pp=10 and vp=0 ctladm port -c -O pp=10 # creates new ioctl frontend port with pp=11 and vp=12 ctladm port -c -O pp=11 -O vp=12 # removes port with number 4 (it's a "targ_port" number, not pp number) ctladm port -r -p 4 New syntax for ctl.conf: target ... { port ioctl/<pp> ... } target ... { port ioctl/<pp>/<vp> ... Note: Most of this work was made by jceel@, thank you. Submitted by: jceel Reworked by: myself Reviewed by: mav (earlier versions and recently during the rework) Obtained from: FreeNAS and TrueOS Relnotes: Yes Sponsored by: iXsystems Inc. Differential Revision: https://reviews.freebsd.org/D9299
|
#
1de7b4b8 |
|
27-Nov-2017 |
Pedro F. Giffuni <pfg@FreeBSD.org> |
various: general adoption of SPDX licensing ID tags. Mainly focus on files that use BSD 2-Clause license, however the tool I was using misidentified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. No functional change intended.
|
#
9215e501 |
|
10-Apr-2017 |
Alexander Motin <mav@FreeBSD.org> |
Do not register in CTL portal groups without portals. From config synthax point of view such portal groups are not incorrect, but they are useless since can not receive any connection. And since CTL port resource is very limited, it is good to save it. MFC after: 2 weeks
|
#
59c6e3a5 |
|
14-Jan-2017 |
Alexander Motin <mav@FreeBSD.org> |
Decouple iSCSI connection limits from defaults. If initiator does not negotiate some parameter, it expects one to get default value, not some unknown remote hardware limit. On the side side, if some parameter is negotiated, its default value from RFC should not be used for anything.
|
#
97b84d34 |
|
24-Aug-2016 |
Navdeep Parhar <np@FreeBSD.org> |
Make the iSCSI parameter negotiation more flexible. Decouple the send and receive limits on the amount of data in a single iSCSI PDU. MaxRecvDataSegmentLength is declarative, not negotiated, and is direction-specific so there is no reason for both ends to limit themselves to the same min(initiator, target) value in both directions. Allow iSCSI drivers to report their send, receive, first burst, and max burst limits explicitly instead of using hardcoded values or trying to derive all of them from the receive limit (which was the only limit reported by the drivers prior to this change). Display the send and receive limits separately in the userspace iSCSI utilities. Reviewed by: jpaetzel@ (earlier version), trasz@ Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D7279
|
#
2317fdfa |
|
09-Jun-2016 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Don't cap FirstBurstLength to maximum MaxRecvDataSegmentLength claimed by the offload driver; there is no reason to do so, and it actually harms performance. MFC after: 1 month
|
#
4e5408f1 |
|
05-Jun-2016 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Report negotiated MaxBurstLength and FirstBurstLength in "iscsictl -v" and "ctladm islist -v" outputs. MFC after: 1 month
|
#
5c734b04 |
|
03-Feb-2016 |
Jakub Wojciech Klama <jceel@FreeBSD.org> |
Add an additional, libucl-based configuration file parser to ctld. Default ctld behavior remains unchanged - libucl parser can be selected explicitly by adding -u switch to ctld command line. Reviewed by: trasz Approved by: trasz (mentor) MFC after: 1 month Relnotes: yes Sponsored by: iXsystems, Inc. Differential Revision: https://reviews.freebsd.org/D4534
|
#
398290f2 |
|
09-Nov-2015 |
Alexander Motin <mav@FreeBSD.org> |
Introduce portal group options in ctl.conf. While CTL has concept of port options, used at least for iSCSI ports now, before this change it was impossible to set them manually. There still no user-configurable port options now, but I am planning to change that.
|
#
6f2f92a5 |
|
02-Oct-2015 |
Alexander Motin <mav@FreeBSD.org> |
Set default block size for CD to expected 2048 bytes.
|
#
91be33dc |
|
27-Sep-2015 |
Alexander Motin <mav@FreeBSD.org> |
Add to CTL initial support for CDROMs and removable devices. Relnotes: yes
|
#
828524c1 |
|
13-Sep-2015 |
Alexander Motin <mav@FreeBSD.org> |
When updating port, apply only change of LUN map, not whole.
|
#
db7bf2ba |
|
07-Sep-2015 |
Alexander Motin <mav@FreeBSD.org> |
Add two new portal group options "tag" and "foreign". They are going to be useful in clustered setups.
|
#
a3977bea |
|
06-Sep-2015 |
Alexander Motin <mav@FreeBSD.org> |
Allow LUN options modification via CTL_LUNREQ_MODIFY. Not all changes take effect, but that is a different question.
|
#
424a3f57 |
|
03-Jul-2015 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Remove OpenSSL dependency from iscsid(8) and ctld(8). Differential Revision: https://reviews.freebsd.org/D2866 Submitted by: Tony Morlan <tony at scroner.com> (earlier version) Reviewed by: bapt@, delphij@ MFC after: 1 month Sponsored by: The FreeBSD Foundation
|
#
a9d78210 |
|
27-Feb-2015 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Move the "offload" clause from the target section to portal-group section; it makes more sense there. MFC after: 1 month Sponsored by: The FreeBSD Foundation
|
#
c700f14c |
|
12-Feb-2015 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Remove unused code. MFC after: 1 month Sponsored by: The FreeBSD Foundation
|
#
057abcb0 |
|
07-Feb-2015 |
Alexander Motin <mav@FreeBSD.org> |
Teach ctld(8) to control non-iSCSI CTL ports. This change introduces new target option "port", that assigns current target to specified CTL port. On config application ctld(8) will apply LUN mapping according to target configuration to specified port and bring the port up. On shutdown cltd(8) will remove the mapping and put the port down. This change allows to configure both iSCSI and FibreChannel targets in the same configuration file in alike way. Kernel side support was added earlier at r278037. MFC after: 2 weeks Relnotes: yes Sponsored by: iXsystems, Inc.
|
#
07b49a3e |
|
06-Feb-2015 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Make it possible to set (via ctl.conf(5)) and query (via ctladm islist -v) target iSCSI offload. Add mechanism to query maximum receive data segment size supported by chosen hardware offload module, and use it in ctld(8) to determine the value to advertise to the other side. MFC after: 1 month Sponsored by: The FreeBSD Foundation
|
#
92847ee1 |
|
06-Feb-2015 |
Alexander Motin <mav@FreeBSD.org> |
Add support for multiple portal groups per target. This change allows multiple "portal-group" options to be specified per target. Each of them may include new optional auth-group name parameter to override per-target auth parameters for specific portal group. Kernel side support was added earlier at r278161. MFC after: 2 weeks Sponsored by: iXsystems, Inc.
|
#
6b31e130 |
|
03-Feb-2015 |
Alexander Motin <mav@FreeBSD.org> |
Bring some more order into iSCSI portal group tags support. While ctld(8) still does not allow multiple portal groups per target to be configured, kernel should now be able to handle it. MFC after: 2 weeks Sponsored by: iXsystems, Inc.
|
#
920c6cba |
|
01-Feb-2015 |
Alexander Motin <mav@FreeBSD.org> |
CTL LUN mapping rewrite. Replace iSCSI-specific LUN mapping mechanism with new one, working for any ports. By default all ports are created without LUN mapping, exposing all CTL LUNs as before. But, if needed, LUN mapping can be manually set on per-port basis via ctladm. For its iSCSI ports ctld does it via ioctl(2). The next step will be to teach ctld to work with FibreChannel ports also. Respecting additional flexibility of the new mechanism, ctl.conf now allows alternative syntax for LUN definition. LUNs can now be defined in global context, and then referenced from targets by unique name, as needed. It allows same LUN to be exposed several times via multiple targets. While there, increase limit for LUNs per target in ctld from 256 to 1024. Some initiators do not support LUNs above 255, but that is not our problem. Discussed with: trasz MFC after: 2 weeks Relnotes: yes Sponsored by: iXsystems, Inc.
|
#
8b94b583 |
|
22-Nov-2014 |
Alexander Motin <mav@FreeBSD.org> |
For both iSCSI initiator and target increase socket buffer sizes before establishing connection. This is a workaround for Chelsio TOE driver, that does not update socket buffer size in hardware after connection established, and unless that is done beforehand, kernel code will stuck, attempting to send/receive full PDU at once. MFC after: 1 week
|
#
6dbdbf82 |
|
09-Nov-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Add support for sending redirections to iSCSI target. MFC after: 1 month Sponsored by: The FreeBSD Foundation
|
#
bd833b11 |
|
29-Oct-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Simplify code; no functional changes. MFC after: 1 month Sponsored by: The FreeBSD Foundation
|
#
05374883 |
|
29-Oct-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Add discovery-filter. This makes it possible to restrict which targets are returned during discovery based on initiator portal, name, and CHAP credentials. Reviewed by: mav@ MFC after: 1 month Sponsored by: The FreeBSD Foundation
|
#
829603e2 |
|
24-Oct-2014 |
Alexander Motin <mav@FreeBSD.org> |
Add basic iSNS client to the iSCSI target. This makes ctld(8) register its iSCSI targets and portals on configured iSNS servers to allow initiators find them without active discovery. Fetching of allowed initiators from iSNS is not implemented now, so target ACLs still should be configured manually. Reviewed by: trasz@ MFC after: 1 month Sponsored by: iXsystems, Inc.
|
#
e867e162 |
|
24-Oct-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Make the initiator-name and initiator-portal checks a little nicer. MFC after: 1 month Sponsored by: The FreeBSD Foundation
|
#
45078155 |
|
22-Oct-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Untangle iSCSI authentication code by splitting off the CHAP implementation. Reviewed by: mav@ MFC after: 1 month Sponsored by: The FreeBSD Foundation
|
#
073edb1c |
|
27-Jul-2014 |
Alexander Motin <mav@FreeBSD.org> |
Add netmasks support to initiator-portal option. MFC after: 2 weeks
|
#
6d81c129 |
|
05-Jul-2014 |
Alexander Motin <mav@FreeBSD.org> |
Pass through iSCSI session ISID from LOGIN request to the CTL frontend. ISID is an important part of initiator transport ID for iSCSI. It is not used now, but should be to properly implement persistent reservation.
|
#
917d38fb |
|
05-Jul-2014 |
Alexander Motin <mav@FreeBSD.org> |
Create separate CTL port for every iSCSI target (and maybe portal group). Having single port for all iSCSI connections makes problematic implementing some more advanced SCSI functionality in CTL, that require proper ports enumeration and identification. This change extends CTL iSCSI API, making ctld daemon to control list of iSCSI ports in CTL. When new target is defined in config fine, ctld will create respective port in CTL. When target is removed -- port will be also removed after all active commands through that port properly aborted. This change require ctld to be rebuilt to match the kernel. As a minor side effect, this allows to have iSCSI targets without LUNs. While that may look odd and not very useful, that is not incorrect.
|
#
d6093026 |
|
16-Apr-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Constify. Sponsored by: The FreeBSD Foundation
|
#
8eab95d6 |
|
16-Apr-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Properly pass the initiator address when running in proxy mode. Sponsored by: The FreeBSD Foundation
|
#
a113ac05 |
|
16-Apr-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Rework the way we enable CTL iSCSI port. Previously conf_apply() needed it to be already enabled, because listening in proxy mode requires it; however, it's conf_apply() that opens pidfiles, so it resulted in port being enabled before pidfile was opened. This was not so bad, but it was also disabled when pidfile couldn't be opened due to ctld already running; this means that starting second ctld instance screwed up the first. Sponsored by: The FreeBSD Foundation
|
#
8cab2ed4 |
|
16-Apr-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Properly identify target portal when running in proxy mode. While here, remove CTL_ISCSI_CLOSE, it wasn't used or implemented anyway. Sponsored by: The FreeBSD Foundation
|
#
e76ce448 |
|
11-Feb-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Use new auth-type "deny" instead of using "chap" with no chap entries; it's cleaner this way, and gives better feedback to the user. Sponsored by: The FreeBSD Foundation
|
#
252d941c |
|
11-Feb-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Make it possible to redefine portal-group "default". Sponsored by: The FreeBSD Foundation
|
#
df9900fb |
|
11-Feb-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Add auth-type. Sponsored by: The FreeBSD Foundation
|
#
f7ae5bf8 |
|
11-Feb-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Rename a variable, no functional changes. Sponsored by: The FreeBSD Foundation
|
#
8cb2e958 |
|
11-Feb-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Implement initiator-name and initiator-portal restrictions. Sponsored by: The FreeBSD Foundation
|
#
1885dba7 |
|
11-Feb-2014 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
The log_whatever() routines don't accept NULL for format strings, so mark them as __printflike instead of__printf0like. Sponsored by: The FreeBSD Foundation
|
#
009ea47e |
|
14-Sep-2013 |
Edward Tomasz Napierala <trasz@FreeBSD.org> |
Bring in the new iSCSI target and initiator. Reviewed by: ken (parts) Approved by: re (delphij) Sponsored by: FreeBSD Foundation
|