History log of /freebsd-current/usr.bin/top/utils.h
Revision Date Author Comments
# 42b38843 16-Aug-2023 Warner Losh <imp@FreeBSD.org>

Remove $FreeBSD$: one-line .h pattern

Remove /^\s*\*+\s*\$FreeBSD\$.*$\n/


# d0f687d3 10-Feb-2019 Dimitry Andric <dim@FreeBSD.org>

Fix multiple warnings in usr.bin/top about discarded qualifiers from
both clang and gcc, by either constifying variables, or when that is not
possible, using __DECONST.

MFC after: 1 week


# cfb27362 26-Jul-2018 Daichi GOTO <daichi@FreeBSD.org>

top(1): forgot in r336160

Approved by: gnn (mentor)
Differential Revision: https://reviews.freebsd.org/D16452


# 4417ed2d 30-Jun-2018 Daichi GOTO <daichi@FreeBSD.org>

top(1) - support UTF-8 display

Reviewed by: eadler
Approved by: gnn (mentor)
Differential Revision: https://reviews.freebsd.org/D16006


# 8e4b205e 13-Jun-2018 Eitan Adler <eadler@FreeBSD.org>

top(1): format_time, format_k, etc.

- Use humanize_number for format_k and format_k2
- Fix some style nits in format_time


# ccf22059 12-Jun-2018 Eitan Adler <eadler@FreeBSD.org>

top(1): style and related

- style(9)
- remove now-defunct comments
- remove getuid check for low delay
- expand range of format_k


# a9a99372 03-Jun-2018 Eitan Adler <eadler@FreeBSD.org>

top(1): Use strsep instead of homegrown alternative

This replaces some complex, and not quite correct logic, with a more
common strsep pattern.

Reviewed by: mmacy (older version)


# eae589f1 03-Jun-2018 Eitan Adler <eadler@FreeBSD.org>

top(1): another pass of cleanup

- avoid the need to call a function to get size of known array. I'll
likely re-arrange some of the indirect in a later to avoid the magic
constants.
- use correct type
- add const
- replace caddr_t with void*. This corrects an alignment warning.
- remove duplicated include from immediately prior commit

Under base clang we're now down to:
- 3 warning in top.c, 1 warning in mahcine.c, 4 warning in display.c,
- 1 warning in utils.c

Tested with base clang, gcc7, gcc9, base gcc (mips)


# 01a55f00 02-Jun-2018 Eitan Adler <eadler@FreeBSD.org>

top(1): partial revert of r334517

In fixing issues with uid > INT_MAX, I broke the uid without username
case. The latter is more important so return the old state.

Discussed with: allanjude


# 51b29cb7 02-Jun-2018 Roman Bogorodskiy <novel@FreeBSD.org>

top: add -p option and p command to only show a single process

Allow to show only a single process specified by PID. This could
be done either by running top like 'top -p PID' or using the 'p' command
inside top.

Reviewed by: eadler
Approved by: eadler
Obtained from: OpenBSD
Differential Revision: https://reviews.freebsd.org/D15501


# b274c68a 02-Jun-2018 Eitan Adler <eadler@FreeBSD.org>

Use stpcpy instead of home grown solution


# 66b3f031 01-Jun-2018 Eitan Adler <eadler@FreeBSD.org>

top(1): const poison

top(1) has a number of issues with writing to const strings. Begin
helping this along by marking easy cases as const.


# 19789395 01-Jun-2018 Eitan Adler <eadler@FreeBSD.org>

top(1): Use uid_t for uid rather than 'int'

Remove unneeded define while here.


# b3c88c28 19-May-2018 Eitan Adler <eadler@FreeBSD.org>

top(1): Quiesce several warnings

This is all warnings at level six (6) that are not
char-subscripts, incompatible-pointer-types,
sign-compare, switch, int-conversion,
missing-variable-declarations, cast-qual, cast-align

Some warnings that are fixed by this commit are:
shadow, strict-prototypes, missing-prototypes, pointer-arith,
unused-parameter, unused-const-variable, and several others


# 3be6ef06 19-May-2018 Eitan Adler <eadler@FreeBSD.org>

top(1): Migrate top to usr.bin

We've been maintaining top(1) for a long time, and the upstream
hasn't existed/been used in similarly as long. Make it clear that we own
top(1)

Tested with 'make universe'. Everything passed except MIPS which failed
for unrelated reasons. Install also tested for amd64.

Reviewed by: sbruno
No objections: imp, mmacy
Differential Revision: https://reviews.freebsd.org/D15387