#
b67716dd |
|
10-May-2024 |
Michael Tuexen <tuexen@FreeBSD.org> |
sctp: store heartbeat creation time as time_t Reported by: Coverity Scan CID: 1493087 MFC after: 3 days
|
#
c3179e66 |
|
18-Aug-2023 |
Michael Tuexen <tuexen@FreeBSD.org> |
sctp: cleanup cdefs.h include
|
#
685dc743 |
|
16-Aug-2023 |
Warner Losh <imp@FreeBSD.org> |
sys: Remove $FreeBSD$: one-line .c pattern Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
|
#
52640d61 |
|
22-Jul-2023 |
Michael Tuexen <tuexen@FreeBSD.org> |
sctp: update zero checksum support Implement support for the error detection method identifier. MFC after: 2 weeks
|
#
6026b45a |
|
15-Mar-2023 |
Michael Tuexen <tuexen@FreeBSD.org> |
sctp: improve negotiation of zero checksum feature Enforce consistency between announcing 0-cksum support and actually using it in the association. The value from the inp when the INIT ACK is sent must be used, not the one from the inp when the cookie is received.
|
#
b6db274d |
|
23-Sep-2020 |
Michael Tuexen <tuexen@FreeBSD.org> |
Whitespace changes. MFC after: 3 days
|
#
662c1305 |
|
01-Sep-2020 |
Mateusz Guzik <mjg@FreeBSD.org> |
net: clean up empty lines in .c and .h files
|
#
0053ed28 |
|
19-Jul-2018 |
Michael Tuexen <tuexen@FreeBSD.org> |
Whitespace changes due to changes in ident.
|
#
b0471b4b |
|
19-Jul-2018 |
Michael Tuexen <tuexen@FreeBSD.org> |
Revert https://svnweb.freebsd.org/changeset/base/336503 since I also ran the export script with different parameters.
|
#
7679e49d |
|
19-Jul-2018 |
Michael Tuexen <tuexen@FreeBSD.org> |
Whitespace changes due to change if ident.
|
#
51369649 |
|
20-Nov-2017 |
Pedro F. Giffuni <pfg@FreeBSD.org> |
sys: further adoption of SPDX licensing ID tags. Mainly focus on files that use BSD 3-Clause license. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. Special thanks to Wind River for providing access to "The Duke of Highlander" tool: an older (2014) run over FreeBSD tree was useful as a starting point.
|
#
49656eef |
|
07-Dec-2016 |
Michael Tuexen <tuexen@FreeBSD.org> |
Cleanup the names of SSN, SID, TSN, FSN, PPID and MID. This made a couple of bugs visible in handling SSN wrap-arounds when using DATA chunks. Now bulk transfer seems to work fine... This fixes the issue reported in https://github.com/sctplab/usrsctp/issues/111 MFC after: 1 week
|
#
5b495f17 |
|
06-Dec-2016 |
Michael Tuexen <tuexen@FreeBSD.org> |
Whitespace changes. The tools using to generate the sources has been updated and produces different whitespaces. Commit this seperately to avoid intermixing these with real code changes. MFC after: 3 days
|
#
8e1b295f |
|
17-Jul-2016 |
Michael Tuexen <tuexen@FreeBSD.org> |
Fix the PR-SCTP behaviour. This is done by rrs@. MFC after: 3 days
|
#
e187bac2 |
|
18-Apr-2016 |
Michael Tuexen <tuexen@FreeBSD.org> |
Don't use anonymous unions.
|
#
44249214 |
|
07-Apr-2016 |
Randall Stewart <rrs@FreeBSD.org> |
This is work done by Michael Tuexen and myself at the IETF. This adds the new I-Data (Interleaved Data) message. This allows a user to be able to have complete freedom from Head Of Line blocking that was previously there due to the in-ability to send multiple large messages without the TSN's being in sequence. The code as been tested with Michaels various packet drill scripts as well as inter-networking between the IETF's location in Argentina and Germany.
|
#
86eda749 |
|
12-Sep-2015 |
Michael Tuexen <tuexen@FreeBSD.org> |
Cleanup the handling of error causes for ERROR chunks. This fixes an inconsistency of the padding handling. The final padding is now considered to be a chunk padding. MFC after: 1 week
|
#
84f3b49a |
|
16-Oct-2014 |
Michael Tuexen <tuexen@FreeBSD.org> |
Fix the reported streams in a SCTP_STREAM_RESET_EVENT, if a sent incoming stream reset request was responded with failed or denied. Thanks to Peter Bostroem from Google for reporting the issue. MFC after: 3 days
|
#
ce11b842 |
|
31-Jul-2014 |
Michael Tuexen <tuexen@FreeBSD.org> |
Cleanup sctp_send_initiate() and sctp_send_initiate_ack() to be in sync as much as possible. This simplifies upcoming changes.
|
#
a169d6ec |
|
07-Sep-2012 |
Michael Tuexen <tuexen@FreeBSD.org> |
Don't include a structure containing a flexible array in another structure. MFC after: 10 days
|
#
807aad63 |
|
23-May-2012 |
Michael Tuexen <tuexen@FreeBSD.org> |
Use consistent text at the begining of the files. MFC after: 3 days
|
#
f3ebe64c |
|
05-May-2012 |
Michael Tuexen <tuexen@FreeBSD.org> |
Honor SCTP_ENABLE_STREAM_RESET socket option when processing incoming requests. Fix also the provided result in the response and use names as specified in RFC 6525. MFC after: 3 days
|
#
c4e848b7 |
|
29-Mar-2012 |
Randall Stewart <rrs@FreeBSD.org> |
Make stream our stream reset implementation compliant to RFC6525. MFC after: 1 month
|
#
7215cc1b |
|
17-Dec-2011 |
Michael Tuexen <tuexen@FreeBSD.org> |
Fix unused parameter warnings. While there, fix some whitespace issues. MFC after: 3 months.
|
#
70acddf1 |
|
27-Nov-2011 |
Michael Tuexen <tuexen@FreeBSD.org> |
Fix a warning reported by arundel@. Fix a bug where the parameter length of a supported address types parameter is set to a wrong value if the kernel is built with with either INET or INET6, but not both. MFC after: 3 days.
|
#
ca85e948 |
|
03-Aug-2011 |
Michael Tuexen <tuexen@FreeBSD.org> |
The result of a joint work between rrs@ and myself at the IETF: * Decouple the path supervision using a separate HB timer per path. * Add support for potentially failed state. * Bring back RTO.min to 1 second. * Accept packets on IP-addresses already announced via an ASCONF * While there: do some cleanups. Approved by: re@ MFC after: 2 months.
|
#
5d40cf5d |
|
04-Feb-2011 |
Randall Stewart <rrs@FreeBSD.org> |
1) Typo correction in comments and one spacing change. 2) Mass update to all copyrights. MFC after: 3 Months
|
#
493d8e5a |
|
31-Jan-2011 |
Randall Stewart <rrs@FreeBSD.org> |
More ECN fixes: 1) We now remove ECN-Nonce since it will no longer continue as a I-D 2) Eliminate last_tsn_echo, this tied us to an assoc not the net and thus we were not doing m-homing on the ECN-Echo senders side right. 3) Increment the count going out even if the TSN in lower in the pending ECN-Echo, this way the receiver knows exactly how many packets were marked even with network re-ordering 4) Fix so we DO NOT stop doing delayed sack if a ECN Echo is in queue MFC after: 1 month
|
#
a21779f0 |
|
29-Jan-2011 |
Randall Stewart <rrs@FreeBSD.org> |
Fixes to ECN in SCTP. 1) ECN was on an association basis, this is incorrect and will not work with CMT or for that matter if the user is sending to multiple addresses. This commit makes ECN on a per path basis. 2) Adopt the new format for the ECN internet draft. This also maintains compatability with old format chunks as well. 3) Keep track of the real time of a RTT down to micro seconds. For some future conditional features (for like a data center this is good information to have). MFC after: 1 month
|
#
a7d5f7eb |
|
19-Oct-2010 |
Jamie Gritton <jamie@FreeBSD.org> |
A new jail(8) with a configuration file, to replace the work currently done by /etc/rc.d/jail.
|
#
ec15b656 |
|
16-Apr-2010 |
Randall Stewart <rrs@FreeBSD.org> |
MFC of 203847 Puts in missing packed declarations (from Michael). It worked only because it was properly aligned anyway ;-)
|
#
3c9d6800 |
|
16-Apr-2010 |
Randall Stewart <rrs@FreeBSD.org> |
MFC of 202782 Michaels changes that took out [0] -> for []
|
#
535f992c |
|
16-Apr-2010 |
Randall Stewart <rrs@FreeBSD.org> |
MFC of 202526 The first round of some of Michael's changes to get the sack processing in better shape.
|
#
8d9d0613 |
|
13-Feb-2010 |
Michael Tuexen <tuexen@FreeBSD.org> |
Add missing SCTP_PACKED. Spotted by Irene Ruengeler. MFC after: 1 week
|
#
663fdad8 |
|
22-Jan-2010 |
Michael Tuexen <tuexen@FreeBSD.org> |
Use [] instead of [0] for flexible arrays. Obtained from: Bruce Cran MFC after: 1 week
|
#
cd554309 |
|
17-Jan-2010 |
Michael Tuexen <tuexen@FreeBSD.org> |
Get rid of a lot of duplicated code for NR-SACK handle. Generalize the SACK to code handle also NR-SACKs.
|
#
ea44232b |
|
20-Feb-2009 |
Randall Stewart <rrs@FreeBSD.org> |
Add the add-stream capability. Still needs more testing.. MFC after: 1 month
|
#
830d754d |
|
06-Dec-2008 |
Randall Stewart <rrs@FreeBSD.org> |
Code from the hack-session known as the IETF (and a bit of debugging afterwards): - Fix protection code for notification generation. - Decouple associd from vtag - Allow vtags to have less strigent requirements in non-uniqueness. o don't pre-hash them when you issue one in a cookie. o Allow duplicates and use addresses and ports to discriminate amongst the duplicates during lookup. - Add support for the NAT draft draft-ietf-behave-sctpnat-00, this is still experimental and needs more extensive testing with the Jason Butt ipfw changes. - Support for the SENDER_DRY event to get DTLS in OpenSSL working with a set of patches from Michael Tuexen (hopefully heading to OpenSSL soon). - Update the support of SCTP-AUTH by Peter Lei. - Use macros for refcounting. - Fix MTU for UDP encapsulation. - Fix reporting back of unsent data. - Update assoc send counter handling to be consistent with endpoint sent counter. - Fix a bug in PR-SCTP. - Fix so we only send another FWD-TSN when a SACK arrives IF and only if the adv-peer-ack point progressed. However we still make sure a timer is running if we do have an adv_peer_ack point. - Fix PR-SCTP bug where chunks were retransmitted if they are sent unreliable but not abandoned yet. With the help of: Michael Teuxen and Peter Lei :-) MFC after: 4 weeks
|
#
d7f03759 |
|
19-Oct-2008 |
Ulf Lilleengen <lulf@FreeBSD.org> |
- Import the HEAD csup code which is the basis for the cvsmode work.
|
#
b3f1ea41 |
|
14-Jun-2008 |
Randall Stewart <rrs@FreeBSD.org> |
- Macro-izes the packed declaration in all headers. - Vimage prep - these are major restructures to move all global variables to be accessed via a macro or two. The variables all go into a single structure. - Asconf address addition tweaks (add_or_del Interfaces) - Fix rwnd calcualtion to be more conservative. - Support SACK_IMMEDIATE flag to skip delayed sack by demand of peer. - Comment updates in the sack mapping calculations - Invarients panic added. - Pre-support for UDP tunneling (we can do this on MAC but will need added support from UDP to get a "pipe" of UDP packets in. - clear trace buffer sysctl added when local tracing on. Note the majority of this huge patch is all the vimage prep stuff :-)
|
#
c4739e2f |
|
23-Aug-2007 |
Randall Stewart <rrs@FreeBSD.org> |
- Fix address add handling to clear cached routes and source addresses when peer acks the add in case the routing table changes. - Fix sctp_lower_sosend to send shutdown chunk for mbuf send case when sndlen = 0 and sinfoflag = SCTP_EOF - Fix sctp_lower_sosend for SCTP_ABORT mbuf send case with null data, So that it does not send the "null" data mbuf out and cause it to get freed twice. - Fix so auto-asconf sysctl actually effect the socket's asconf state. - Do not allow SCTP_AUTO_ASCONF option to be used on subset bound sockets. - Memset bug in sctp_output.c (arguments were reversed) submitted found and reported by Dave Jones (davej@codemonkey.org.uk). - PD-API point needs to be invoked >= not just > to conform to socket api draft this fixes sctp_indata.c in the two places need to be >=. - move M_NOTIFICATION to use M_PROTO5. - PEER_ADDR_PARAMS did not fail properly if you specify an address that is not in the association with a valid assoc_id. This meant you got or set the stcb level values instead of the destination you thought you were going to get/set. Now validate if the stcb is non-null and the net is NULL that the sa_family is set and the address is unspecified otherwise return an error. - The thread based iterator could crash if associations were freed at the exact time it was running. rework the worker thread to use the increment/decrement to prevent this and no longer use the markers that the timer based iterator uses. - Fix the memleak in sctp_add_addr_to_vrf() for the case when it is detected that ifa is already pointing to a ifn. - Fix it so that if someone is so insane that they drop the send window below the minimal add mark, they still can send. - Changed all state for associations to use mask safe macro. - During front states in association freeing in sctp_inpcbfree, we had a locking problem where locks were not in place where they should have been. - Free association calls were not testing the return value in sctp_inpcb_free() properly... others should be cast void returns where we don't care about the return value. - If a reference count is held on an assoc, even from the "force free" we should not do the actual free.. but instead let the timer free it. - When we enter sctp_input(), if the SCTP_ASOC_ABOUT_TO_BE_FREED flag is set, we must NOT process the packet but handle it like ootb. This is because while freeing an assoc we release the locks to get all the higher order locks so we can purge all the hash tables. This leaves a hole if a packet comes in just at that point. Now sctp_common_input_processing() will call the ootb code in such a case. - Change MBUF M_NOTIFICATION to use M_PROTO5 (per Sam L). This makes it so we don't have a conflict (I think this is a covertity change). We made this change AFTER some conversation and looking to make sure that M_PROTO5 does not have a problem between SCTP and the 802.11 stuff (which is the only other place its used). - Fixed lock order reversal and missing atomic protection around locked_tcb during association lookup and the 1-2-1 model. - Added debug to source address selection. - V6 output must always do checksum even for loopback. - Remove more locks around inp that are not needed for an atomically added/subtracted ref count. - slight optimization in the way we zero the array in sctp_sack_check() - It was possible to respond to a ABORT() with bad checksum with a PKT-DROP. This lead to a PKT-DROP/ABORT war. Add code to NOT send a PKT-DROP to any ABORT(). - Add an option for local logging (useful for macintosh or when you need better performing during debugging). Note no commands are here to get the log info, you must just use kgdb. - The timer code needs to be aware of if it needs to call sctp_sack_check() to slide the maps and adjust the cum-ack. This is because it may be out of sync cum-ack wise. - Added threshold managment logging. - If the user picked just the right size, that just filled the send window minus one mtu, we would enter a forever loop not copying and at the same time not blocking. Change from < to <= solves this. - Sysctl added to control the fragment interleave level which defaults to 1. - My rwnd control was not being used to control the rwnd properly (we did not add and subtract to it :-() this is now fixed so we handle small messages (1 byte etc) better to bring our rwnd down more slowly. Approved by: re@freebsd.org (Bruce Mah)
|
#
35918f85 |
|
12-Jun-2007 |
Randall Stewart <rrs@FreeBSD.org> |
- Restructure so bindx functions are not done inline to socket option but are a seperate call that can be re-used if needed. - 64 bit issues o re-arrange cookie so it is better 64 bit aligned o For wire level things we need the packed attribute.
|
#
b1006367 |
|
08-May-2007 |
Randall Stewart <rrs@FreeBSD.org> |
- Copyright change, cisco's silly tool wants it to say: "Copyright (c) 2001-2007, by Cisco Systems," instead of *Copyright (c) 2001-2007, Cisco Systems," - Also fix a few straglers that were still in 2006.
|
#
d06c82f1 |
|
01-May-2007 |
Randall Stewart <rrs@FreeBSD.org> |
- Somehow the disable fragment option got lost. We could set/clear it but would not do it. Now we will. - Moved to latest socket api for extended sndrcv info struct. - Moved to support all new levels of fragment interleave (0-2). - Codenomicon security test updates - length checks and such. - Bug in stream reset (2 actually). - setpeerprimary could unlock a null pointer, fixed. - Added a flag in the pcb so netstat can see if we are listening easier. Obtained from: (some of the Listen changes from Weongyo Jeong)
|
#
42551e99 |
|
15-Mar-2007 |
Randall Stewart <rrs@FreeBSD.org> |
- Sysctl's move to seperate file - moved away from ifn/ifa access to sctp_ifa/sctp_ifn built and managed by the add-ip code. - cleaned up add-ip code to use the iterator - made iterator be a thread, which enables auto-asconf now. - rewrote and cleaned up source address selection (also made it use new structures). - Fixed a couple of memory leaks. - DACK now settable as to how many packets to delay as well as time. - connectx() to latest socket API, new associd arg. - Fixed issue with revoking and loosing potential to send when we inflate the flight size. We now inflate the cwnd too and deflate it later when the revoked chunk is sent or acked. - Got rid of some temp debug code - src addr selection moved to a common file (sctp_output.c) - Support for simple VRF's (we have support for multi-vfr via compile switch that is scrubbed from BSD but we won't need multi-vrf until we first get VRF :-D) - Rest of mib work for address information now done - Limit number of addresses in INIT/INIT-ACK to a #def (30). Reviewed by: gnn
|
#
f8829a4a |
|
03-Nov-2006 |
Randall Stewart <rrs@FreeBSD.org> |
Ok, here it is, we finally add SCTP to current. Note that this work is not just mine, but it is also the works of Peter Lei and Michael Tuexen. They both are my two key other developers working on the project.. and they need ata-boy's too: **** peterlei@cisco.com tuexen@fh-muenster.de **** I did do a make sysent which updated the syscall's and sysproto.. I hope that is correct... without it you don't build since we have new syscalls for SCTP :-0 So go out and look at the NOTES, add option SCTP (make sure inet and inet6 are present too) and play with SCTP. I will see about comitting some test tools I have after I figure out where I should place them. I also have a lib (libsctp.a) that adds some of the missing socketapi functions that I need to put into lib's.. I will talk to George about this :-) There may still be some 64 bit issues in here, none of us have a 64 bit processor to test with yet.. Michael may have a MAC but thats another beast too.. If you have a mac and want to use SCTP contact Michael he maintains a web site with a loadable module with this code :-) Reviewed by: gnn Approved by: gnn
|