HACKS revision 1.102.2.1
1# $NetBSD: HACKS,v 1.102.2.1 2008/06/23 04:29:01 wrstuden Exp $ 2# 3# This file is intended to document workarounds for currently unsolved 4# (mostly) compiler bugs. 5# 6# Format: 7# hack title 8# cdate creation date 9# mdate mod date 10# who responsible developer 11# port ... 12# affected ports, space separated, if not "all" 13# file affected file : revision : line from : line to 14# affected files and revision and line numbers describing hack 15# multiple lines if necessary. 16# pr NNNN ... 17# problem reports this hack works around, if known. Space 18# separated. 19# regress src/regress/directory/where/test/found 20# regression test directories, if available. 21# descr 22# insert short informal description (multi-line). (Longer ones 23# should be in the PR database. More formal descriptions might 24# be in the regress tree. See above). 25# kcah 26# closing bracket. 27# 28# this is a comment. 29 30hack netstat ieee1394 address printing. 31mdate 14 Nov 2000 32who matt 33file lib/libc/net/getnameinfo.c : 1.32 : 497 : 503 34descr 35 Because the current implementation of IP over IEEE1394, the 36 fw device address contains more than just the IEEE1394 EUI-64. 37 So when printing out IEEE1394 addresses, ignore the extra stuff. 38kcah 39 40hack xterm vs. libterm 41mdate 01 Aug 2000 42who jdc 43file xsrc/xc/programs/xterm/main.c : 1.2 : 3609 : 3614 44pr 10383 45descr 46 In order to extend the termcap string over 1023 bytes, a ZZ entry was 47 introduced to point to a memory location containing the full entry. 48 Without this hack, xterm will export a termcap containing the ZZ 49 entry, which will then be ignored by libterm. As xterm modifies the 50 exported termcap, this would cause those modifications to be ignored. 51kcah 52 53hack wi-at-big-endian-bus 54cdate 15 Mar 2002 55who martin 56file dev/ic/wireg.h 57descr Add an option to access the underlying bus in big endian byte order 58 to work around deficiencies in bus_space_{read,write}_* macros. 59 Those don't allow the implementation of a proper pcmcia bus space 60 tag. 61kcah 62 63hack specific knowledge of colours in curses code 64cdate Sun Apr 6 11:05:24 BST 2003 65who jdc 66file lib/libcurses/color.c : r1.24 67descr 68 Swap red/blue and yellow/cyan colours for COLOR_OTHER. 69 Fix is to enhance libtermcap to understand terminfo-style % sequences. 70 See also: 71 http://mail-index.NetBSD.org/tech-userlevel/2003/04/06/0000.html 72kcah 73 74hack Compensation for differing types of LINUX_USRSTACK and USRSTACK 75cdate 21 Aug 2003 76who he 77file sys/miscfs/procfs/procfs_linux.c : 1.14 78descr 79 Not all ports have LINUX_USRSTACK and/or USRSTACK defined as 80 literals/constants, but refer to variables of a type which is 81 not "unsigned long", causing compilation of procfs_linux.c to 82 fail with "makes integer from pointer without a cast". This 83 is observed on e.g. the sun3 port. Ideally the "types" for 84 symbols should be consistent across all ports. 85kcah 86 87hack gcc-strict-aliasing 88cdate 6 August 2004 89who junyoung 90pr 26516 91file src/usr.sbin/racoon/racoon/Makefile : 1.21 92descr 93 GCC issues a warning "dereferencing type-punned pointer will break 94 strict-aliasing rules" when compiling 95 crypto/dist/kame/racoon/crypto/openssl.c with -O[23s]. Note that this 96 is due to use of type casting in a non-standard way in the code and 97 not a compiler bug. Once a new release of KAME with a proper fix 98 applied is imported this should be backed out. 99kcah 100 101hack gcc4 wrong uninitialized variable 102mdate 10 May 2006 103who mrg 104file bin/ksh/eval.c : 1.6 105file bin/sh/histedit.c : 1.39 106file bin/sh/parser.c : 1.60 107file crypto/dist/heimdal/kdc/524.c : 1.10 108file crypto/dist/ssh/sftp.c : 1.20 109file crypto/dist/ssh/ssh-keysign.c : 1.11 110file dist/ipf/lib/hostname.c : 1.2 111file dist/ipf/tools/ipmon.c : 1.8 112file dist/ntp/ntpd/ntp_request.c : 1.4 113file dist/ntp/ntpd/refclock_shm.c : 1.4 114file dist/ntp/sntp/timing.c : 1.3 115file dist/pppd/pppstats/pppstats.c : 1.3 116file dist/smbfs/lib/smb/rap.c : 1.6 117file dist/tcpdump/print-zephyr.c : 1.5 118file distrib/utils/sysinst/aout2elf.c : 1.12 119file gnu/libexec/uucp/uucico/uucico.c : 1.6 120file lib/libc/citrus/citrus_csmapper.c : 1.6 121file lib/libc/citrus/citrus_pivot_factory.c : 1.5 122file lib/libc/inet/inet_cidr_ntop.c : 1.3 123file lib/libc/inet/inet_ntop.c : 1.3 124file lib/libc/stdio/vfwprintf.c : 1.8 125file libexec/ld.elf_so/arch/m68k/mdreloc.c : 1.20 126file libexec/ld.elf_so/arch/powerpc/ppc_reloc.c : 1.40 127file libexec/ld.elf_so/arch/sh3/mdreloc.c : 1.22 128file libexec/ld.elf_so/arch/sparc/mdreloc.c : 1.39 129file libexec/ld.elf_so/arch/sparc64/mdreloc.c : 1.39 130file libexec/ld.elf_so/arch/vax/mdreloc.c : 1.21 131file libexec/ld.elf_so/arch/x86_64/mdreloc.c : 1.27 132file sbin/fsck_ext2fs/dir.c : 1.19 133file sbin/routed/rtquery/rtquery.c : 1.18 134file sys/arch/amd64/amd64/pmap.c : 1.26 135file sys/arch/i386/pci/piixpcib.c : 1.4 136file sys/arch/m68k/m68k/pmap_motorola.c : 1.4 137file sys/crypto/cast128/cast128.c : 1.9 138file sys/ddb/db_command.c : 1.86 139file sys/dev/cardbus/cardbus_map.c : 1.21 140file sys/dev/fss.c : 1.25 141file sys/dev/ic/igsfb.c : 1.39 142file sys/dev/ic/mb86950.c : 1.5 143file sys/dev/ic/midway.c : 1.71 144file sys/dev/kttcp.c : 1.18 145file sys/dev/rasops/rasops_bitops.h : 1.9 146file sys/dev/pci/cmpci.c : 1.31 147file sys/dev/pci/machfb.c : 1.45 148file sys/dev/usb/ohci.c : 1.174 149file sys/dev/usb/uhci.c : 1.196 150file sys/dev/rasops/rasops_bitops.h : 1.9 151file sys/dist/ipf/netinet/ip_nat.c : 1.10 152file sys/dist/ipf/netinet/ip_rpcb_pxy.c : 1.8 153file sys/dist/pf/net/pf.c : 1.22 154file sys/fs/udf/udf_vnops.c : 1.4 155file sys/kern/kern_sig.c : 1.219 156file sys/kern/tty.c : 1.181 157file sys/net/bpf.c : 1.116 158file sys/net/zlib.c : 1.26 159file sys/netccitt/if_x25subr.c : 1.37 160file sys/netinet/in.c : 1.107 161file sys/netsmb/smb_smb.c : 1.27 162file sys/netsmb/smb_trantcp.c : 1.22 163file sys/nfs/nfs_serv.c : 1.108 164file sys/nfs/nfs_socket.c : 1.129 165file sys/nfs/nfs_syscalls.c : 1.91 166file sys/ufs/lfs/lfs_vfsops.c : 1.207 [also (char *)] 167file usr.bin/ftp/ftp.c : 1.140 168file usr.bin/find/function.c : 1.54 169file usr.bin/mail/tty.c : 1.20 170file usr.bin/msgc/msg_sys.def : 1.33-1.34 171file usr.bin/nl/nl.c : 1.7 172file usr.bin/systat/keyboard.c : 1.23 173file usr.bin/usbhidctl/usbhid.c : 1.29 174file usr.bin/vi/cl/cl_read.c : 1.5 175file usr.bin/vi/ex/ex_cscope.c : 1.12 176file usr.bin/vi/ex/ex_tag.c : 1.19 177file usr.bin/vi/vi/v_txt.c : 1.15 178file usr.sbin/altq/altqstat/qdisc_rio.c : 1.4 179file usr.sbin/cron/do_command.c : 1.19 180file usr.sbin/timed/timed/slave.c : 1.15 181descr 182 GCC 4.1 gets many uninitialised variable warnings wrong. We should 183 really audit all the old hacks like this when older compilers are 184 removed from the tree, as many are probably no longer required. 185 The problem is that it does not recognize initialization via function 186 call pointer. I.e. 187 int p; 188 foo(&p); 189 does not mark p as initialized. 190kcah 191 192hack gcc4 pointer sign and strict aliasing problems 193mdate 10 May 2006 194who mrg 195file bin/ed/Makefile : 1.33 196file distrib/utils/sysinst/Makefile.inc : 1.44 197file distrib/utils/x_dhclient/Makefile : 1.15 198file games/bcd/Makefile : 1.5 199file games/dab/Makefile : 1.5 200file games/larn/Makefile : 1.17 201file games/pom/Makefile : 1.5 202file lib/libasn1/Makefile : 1.26 203file lib/libcrypt/Makefile : 1.17 204file lib/libgssapi/Makefile : 1.16 205file lib/libhdb/Makefile : 1.20 206file lib/libkadm5clnt/Makefile : 1.21 207file lib/libkadm5srv/Makefile : 1.25 208file lib/libkrb5/Makefile : 1.35 209file lib/libssh/Makefile : 1.6 210file lib/libtelnet/Makefile : 1.26 211file libexec/getty/Makefile : 1.14 212file libexec/kadmind/Makefile : 1.19 213file libexec/kpasswdd/Makefile : 1.14 214file sbin/atactl/Makefile : 1.3 215file sbin/cgdconfig/Makefile : 1.7 216file sbin/clri/Makefile : 1.13 217file sbin/dkctl/Makefile : 1.4 218file sbin/dump/Makefile : 1.33 219file sbin/fdisk/Makefile : 1.35 220file sbin/fsck_ext2fs/Makefile : 1.11 221file sbin/fsck_ffs/Makefile : 1.29 222file sbin/fsdb/Makefile : 1.18 223file sbin/mount_smbfs/Makefile : 1.4 224file sbin/newfs/Makefile : 1.30 225file sbin/newfs_sysvbfs/Makefile : 1.2 226file sbin/restore/Makefile : 1.23 227file sbin/veriexecctl/Makefile : 1.11 228file sys/lib/libsa/Makefile : 1.59 229file sys/arch/evbarm/adi_brh/brh_machdep.c : 1.24 230file usr.bin/awk/Makefile : 1.9 231file usr.bin/crontab/Makefile : 1.24 232file usr.bin/ctags/Makefile : 1.8 233file usr.bin/gzip/Makefile : 1.10 234file usr.bin/ssh/sftp/Makefile : 1.10 235file usr.bin/ssh/ssh/Makefile : 1.25 236file usr.bin/vi/build/Makefile : 1.26 237file usr.bin/telnet/Makefile : 1.40 238file usr.bin/tn3270/tn3270/Makefile : 1.36 239file usr.bin/tr/Makefile : 1.4 240file usr.sbin/amd/amd/Makefile : 1.27 241file usr.sbin/amd/amq/Makefile : 1.14 242file usr.sbin/amd/libamu/Makefile : 1.20 243file usr.sbin/amd/pawd/Makefile : 1.5 244file usr.sbin/bind/Makefile.inc : 1.22 245file usr.sbin/bind/libdns/Makefile : 1.3 246file usr.sbin/bind/named/Makefile : 1.17 247file usr.sbin/bootp/bootptest/Makefile : 1.2 248file usr.sbin/chrtbl/Makefile : 1.6 249file usr.sbin/cron/Makefile : 1.12 250file usr.sbin/dhcp/Makefile.inc : 1.20 251file usr.sbin/dumplfs/Makefile : 1.11 252file usr.sbin/hprop/Makefile : 1.13 253file usr.sbin/installboot/Makefile : 1.35 254file usr.sbin/ipf/ipftest/Makefile : 1.32 255file usr.sbin/isdn/isdnd/Makefile : 1.6 256file usr.sbin/isdn/isdnmonitor/Makefile : 1.3 257file usr.sbin/isdn/isdntel/Makefile : 1.2 258file usr.sbin/isdn/isdntrace/Makefile : 126 259file usr.sbin/mopd/common/Makefile : 1.10 260file usr.sbin/mopd/mopd/Makefile : 1.9 261file usr.sbin/mopd/mopprobe/Makefile : 1.7 262file usr.sbin/makefs/Makefile : 1.17 263file usr.sbin/mscdlabel/Makefile : 1.5 264file usr.sbin/pkg_install/add/Makefile : 1.7 265file usr.sbin/pkg_install/create/Makefile : 1.5 266file usr.sbin/pkg_install/lib/Makefile : 1.28 267file usr.sbin/ntp/ntpd/Makefile : 1.10/1.11 268file usr.sbin/ntp/ntptime/Makefile : 1.4/1.5 269file usr.sbin/pppd/Makefile.inc : 1.3 270file usr.sbin/pppd/pppd/Makefile : 1.38 271file usr.sbin/rarpd/Makefile : 1.10 272file usr.sbin/rbootd/Makefile : 1.10 273file usr.sbin/rpc.pcnfsd/Makefile : 1.17 274file usr.sbin/rtadvd/Makefile : 1.9 275file usr.sbin/tcpdump/Makefile : 1.42 276file usr.sbin/wiconfig/Makefile : 1.3 277descr 278 GCC 4.1 warns on pointer sign comparision/assignments and lots of 279 code does not conform. For now we use -Wno-pointer-sign and 280 -fno-strict-aliasing. 281kcah 282 283port vax 284 285 hack gcc4/vax ICE 286 cdate 287 who tsutsui 288 file sys/arch/vax/conf/Makefile.vax 289 descr 290 GCC4 on vax gets ICE on compiling sys/ddb/db_command.c. 291 -fno-tree-ter prevents it so add it to COPTS. 292 kcah 293 294 hack gcc4/vax compiler crash 295 cdate Fri Jun 30 22:39:12 PDT 2006 296 who mrg 297 file bin/csh/Makefile : 1.27 298 file lib/i18n_module/UTF7/Makefile : 1.2 299 descr 300 GCC4 on vax crashes. -O0 stops it happening so far... 301 kcah 302 303 hack gcc 2.95/vax doesn't like abort being used as function pointer 304 cdate Tue Dec 13 05:54:50 GMT 2005 305 who jmc 306 file lib/libc/rpc/svc_vc.c 1.15 307 descr 308 Provide a local definition for abort which doesn't include 309 the noreturn attribute which trips up gcc 2.95 on vax. 310 kcah 311 312 hack gcc 2.95/vax doesn't have stdbool.h and gettext needs it 313 cdate Mon May 9 12:16:22 CDT 2005 314 who jmc 315 file gnu/usr.bin/gettext/Makefile.inc.prog 1.5 316 gnu/usr.bin/gettext/libgrep/Makefile 1.3 317 gnu/usr.bin/gettext/libnlspr/Makefile 1.5 318 gnu/usr.bin/gettext/libnlsut/Makefile 1.3 319 descr 320 The latest gettext assumes a C99 environment or at least 321 configure checks to work around this. As we don't use configure 322 provide a stdbool.h for vax builds locally in directories from 323 the template provided by the gettext code. 324 kcah 325 326 hack gcc 2.95/vax cannot handle __builtin_ffs() 327 cdate Fri Aug 23 21:31:15 CEST 2002 328 who ragge 329 file sys/lib/libkern/libkern.h : 1.42 330 descr 331 __builtin_ffs() is ifdef'd away if __vax__. Matt Thomas has 332 added this feature to GCC 3 so it can be removed when switching. 333 kcah 334 335 hack gcc 2.95/vax libbz2 336 mdate 27 Jun 2002 337 who thorpej 338 file lib/libbz2/Makefile 339 descr 340 libbz2 is mis-compiled with optimization with GCC 2.95.3 341 on VAX. -O0 works around this problem. 342 kcah 343 344 hack vax Toolchain bug 345 cdate 28 Mar 2003 346 who he 347 file sys/arch/vax/vax/intvec.S : 1.5 348 descr 349 Workaround for PR toolchain/20924. The assembler apparently 350 tries to range-check byte offsets when it doesn't have 351 sufficient information to make that decision. 352 Workaround uses `brw' instead of `brb' instruction. 353 kcah 354 355 hack vax gcc 2.95.3 -Wuninitialized workarounds 356 cdate 6 Nov 2003 357 who he 358 file sys/dev/bi/if_ni.c : 1.22 359 file sys/arch/vax/vax/ctu.c : 1.20 360 descr 361 Workaround for gcc 2.95.3 failing to detect that certain 362 variables will be initialized; so that this code compiles 363 with -Wuninitialized. Should be reviewed and possibly 364 reverted when gcc 3.3.2 is ready for vax. 365 kcah 366 367 hack vax gcc 2.95.3 structure initialization 368 cdat 13 May 2004 369 who cl 370 file sys/miscfs/kernfs/kernfs_vnops.c : 1.104 371 descr 372 Workaround for gcc 2.95.3 failing to initialize structures 373 and/or unions inside structures using nested designators. 374 Should be reverted when gcc >=3.3.3 is ready for vax. 375 kcah 376 377 hack vax gcc 2.95.3 needs -I. to build nslexer.c 378 cdat 6 Jun 2004 379 who mhitch 380 file lib/libc/arch/vax/Makefile.inc : 1.6 381 descr 382 It appears necessary to add -I. to CPPFLAGS when building 383 nslesxer.c. This may be caused by gcc 2.95.3 being used. 384 Should be reverted when a newer gcc is ready for vax. 385 kcah 386 387 hack vax gcc 2.95.3 doesn't understand "-std=c99" 388 cdat 5 April 2005 389 who tron 390 file src/share/mk/bsd.sys.mk 391 descr 392 We cannot use "-std=c99" for compiler warning level 4 and above 393 because gcc 2.95.3 doesn't support that option. 394 kcah 395 396 hack declare boolean_t in two IPF user-mode programs 397 cdate Tue Mar 7 19:19:20 CET 2006 398 who he 399 file dist/ipf/ipsend/iptests.c : 1.8 400 dist/ipf/ipsend/sock.c : 1.7 401 descr 402 The IPF user-mode programs ipsend and iptest first 403 include <sys/types.h> without _KERNEL defined, and 404 later include <sys/file.h> with _KERNEL defined. 405 This causes a build failure when building for vax, 406 since <sys/device.h> ends up being included without 407 bollean_t being defined by <sys/types.h>. 408 Build failure and further details documented in 409 PR#32907. 410 kcah 411 412port arm 413 414 hack gcc-unsigned-compare 415 cdate 09 Mar 2002 416 mdate 18 Mar 2002 417 who bjh21 418 file dist/bind/lib/nameser/ns_parse.c : 1.3 419 file dist/dhcp/minires/ns_parse.c : 1.3 420 file dist/dhcp/omapip/result.c : 1.2 421 file dist/dhcp/server/failover.c : 1.3 422 file gnu/dist/toolchain/bfd/bfd.c : 1.2 423 file gnu/dist/toolchain/bfd/format.c : 1.2 424 file gnu/dist/toolchain/gdb/target.c : 1.2 425 file sys/kern/vfs_subr.c : 1.172 426 descr When checking that a potentially-unsigned enum is >= 0, assign 427 it to an int first. This is necessary to avoid "comparison is 428 always true" warnings with -fshort-enums. Casting to an int 429 really should be enough, but turns out not to be. 430 kcah 431 432 433port sh3 434 435 hack gcc4-sh3-bz2 436 cdate Sun May 21 03:34:57 UTC 2006 437 mdate Fri May 16 13:13:00 UTC 2008 438 who mrg, tsutsui 439 file lib/libbz2/Makefile : 1.10 440 descr 441 The in-tree GCC 4.1-based compiler generated too-far 442 pc-relative addresses. Hack is to build with 443 -fno-loop-optimize. 444 kcah 445 446 447port m68000 448 449 hack gcc4-m68000 450 cdate Fri Feb 8 10:29:37 PST 2008 451 mdate Sun May 4 15:37:19 UTC 2008 452 who mrg, tsutsui 453 file rescue/Makefile : 1.21 454 file sbin/dump_lfs/Makefile : 1.9 455 file sbin/fsck_ffs/Makefile : 1.35 456 file sbin/fsdb/Makefile : 1.22 457 file share/mk/sys.mk : 1.96 458 file usr.sbin/ndbootd/Makefile : 1.5 459 descr 460 Several internal compiler errors with gcc -O1 461 around 64bit integer arithmetic. 462 This hack uses -O1 and adds some -fno-tree-foo options 463 to avoid the problem. 464 This might be related with GCC Bugzilla Bug 32424. 465 kcah 466 467 468port sparc64 469 470 hack disable optimzations for uvm_bio.c on 32 bit kernels 471 cdate Sun Mar 21 14:14:04 MET 2004 472 who martin 473 file sys/arch/sparc64/conf/Makefile.sparc64 : 1.53-1.54 474 file sys/arch/sparc64/conf/files.sparc64 : 1.93 475 descr 476 The sparc compiler miscompiles uvm_bio.c when using 477 any optimization. This results in ubc_release panics. 478 kcah 479 480port mips 481 482 hack mips-shared-linker-load-address 483 cdate Fri Oct 7 08:33:10 UTC 2005 484 who simonb 485 file src/sys/kern/exec_elf32.c : 1.107 486 descr 487 With COMPAT_16 or previous enabled (which enables 488 ELF_INTERP_NON_RELOCATABLE) a recent ld.elf_so will 489 load and run at address 0. The check to fix this in 490 rev 1.107 only checks the first psection of the ELF 491 executable, which may not be loadable. A more correct 492 fix is to check the first loadable psection instead of 493 just the first psection. 494 kcah 495 496 hack mips-duplicate-ras-end-label 497 cdate Sat Sep 2 23:29:42 2006 498 who martin 499 file src/regress/sys/kern/ras/ras3/Makefile : 1.3 500 descr 501 Add -fno-reorder-blocks to CFLAGS to avoid duplicate 502 labels by duplicated __asm output from RAS_END() 503 macro. 504 kcah 505 506port i386 507 508 hack use volatile intermediate variable to enforce rounding 509 cdate Tue Aug 1 22:15:55 MEST 2006 510 who drochner 511 file src/lib/libm/src/lrintf.c : 1.4 512 file src/lib/libm/src/s_rintf.c : 1.8 513 descr 514 gcc-4 does subsequent operations on "float" values within 515 the i387 FPU without rounding the intermediate results 516 kcah 517