1137587Snik$FreeBSD$ 2137587Snik--- 3137587Snik 4137587SnikA lot of the tests written in C use assert(), only printing 'ok' at the end 5137587Snikof the program if none of the assert()s fired. 6137587Snik 7137587SnikThis is wrong. They should do the test outside of an assert(), and print 8137587Snik'ok' or 'not ok' as appropriate, instead of bailing out part way through. 9137587SnikThat way if a test starts failing we'll know exactly which one failed, and 10137587Snikthe other tests can continue. 11137587Snik 12137587SnikThis probably means a simple libtest.so that they can link against to 13137587Snikprovide an ok() function (the non-fatal assert), probably with some helper 14137587Snikfunctions to keep track of test numbers and so on. 15137587Snik 16137587Snik--- 17137587Snik 18137587SnikAny of the tests written in C should link against the libraries under 19137587Snik/usr/obj rather than using the system libraries. 20137587Snik 21137587Snik--- 22137587Snik 23137587SnikNot everything's been converted to the new style. In particular; 24137587Snik 25137587Snik atm/ 26137587Snik ccd/ 27137587Snik some of geom_*/ 28137587Snik some of netinet/ 29137587Snik nfsmmap/ 30137587Snik p1003_1b/ 31137587Snik some of pipe/ 32137587Snik security/ 33137587Snik some of sockets/ 34137587Snik tls/ 35137587Snik 36137587Snikneeds to be converted. And fsx/ and gaithrstress/ are (I think) standalone 37137587Snikprograms rather than individual tests, so aren't amenable to this sort of 38137587Snikconversion. 39