History log of /freebsd-10.0-release/usr.sbin/pmcstat/
Revision Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
259065 07-Dec-2013 gjb

- Copy stable/10 (r259064) to releng/10.0 as part of the
10.0-RELEASE cycle.
- Update __FreeBSD_version [1]
- Set branch name to -RC1

[1] 10.0-CURRENT __FreeBSD_version value ended at '55', so
start releng/10.0 at '100' so the branch is started with
a value ending in zero.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

256281 10-Oct-2013 gjb

Copy head (r256279) to stable/10 as part of the 10.0-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation


241737 19-Oct-2012 ed

More -Wmissing-variable-declarations fixes.

In addition to adding `static' where possible:

- bin/date: Move `retval' into extern.h to make it visible to date.c.
- bin/ed: Move globally used variables into ed.h.
- sbin/camcontrol: Move `verbose' into camcontrol.h and fix shadow warnings.
- usr.bin/calendar: Remove unneeded variables.
- usr.bin/chat: Make `line' local instead of global.
- usr.bin/elfdump: Comment out unneeded function.
- usr.bin/rlogin: Use _Noreturn instead of __dead2.
- usr.bin/tset: Pull `Ospeed' into extern.h.
- usr.sbin/mfiutil: Put global variables in mfiutil.h.
- usr.sbin/pkg: Remove unused `os_corres'.
- usr.sbin/quotaon, usr.sbin/repquota: Remove unused `qfname'.


239571 22-Aug-2012 jimharris

Add -m option (for printing sampled PCs to a file) to pmcstat usage
message.

Sponsored by: Intel
MFC after: 3 days


236669 06-Jun-2012 fabient

Remove spurious ARM symbols from lookup table.

MFC after: 3 days


236634 05-Jun-2012 glebius

Don't crash trying to load symbols from striped file.

PR: bin/167361
Submitted by: Slawa Olhovchenkov <slw zxy.spb.ru>
Silence from: jkoshy


236509 03-Jun-2012 joel

Minor spelling fixes.


233628 28-Mar-2012 fabient

Add software PMC support.

New kernel events can be added at various location for sampling or counting.
This will for example allow easy system profiling whatever the processor is
with known tools like pmcstat(8).

Simultaneous usage of software PMC and hardware PMC is possible, for example
looking at the lock acquire failure, page fault while sampling on
instructions.

Sponsored by: NETASQ
MFC after: 1 month


233611 28-Mar-2012 fabient

- Support inlined location in calltree output.
In case of multiple level of inlining all the locations are flattened.
Require recent binutils/addr2line (head works or binutils from ports
with the right $PATH order).
- Multiple fixes in the calltree output (recursion case, ...)
- Fix the calltree top view that previously hide some shared nodes.

Tested with Kcachegrind(kdesdk4)/qcachegrind(head).

Sponsored by: NETASQ


233522 26-Mar-2012 joel

mdoc: correct .Bd/.Bl arguments.

Reviewed by: brueffer


233317 22-Mar-2012 gonzo

Fix base vaddr detection for ELF binaries. PT_LOAD with offset 0 is not
mandatory for ELF binaries so we'll use the segment with offset less then
alignment and align it appropriately (which covers pt_offset == 0 case)


230350 20-Jan-2012 eadler

Fix warning when compiling with gcc46:
error: variable 'current_cpu' set but not used

Approved by: dim, cperciva (mentor, blanket for pre-mentorship already-approved commits)
MFC after: 3 days


228990 30-Dec-2011 uqs

Spelling fixes for usr.sbin/


227526 15-Nov-2011 obrien

KNF


227524 15-Nov-2011 obrien

Improve the chances of matching an outputted string with the line of code.


227489 13-Nov-2011 eadler

- fix duplicate "a a" in some comments

Submitted by: eadler
Approved by: simon
MFC after: 3 days


226986 01-Nov-2011 fabient

Two bugs fixed:
- Do not close stdout or stderr when redirecting to file.
- Correctly handle error code to detect when no buffer available.

MFC after: 1 month


226514 18-Oct-2011 fabient

Add a flush of the current PMC log buffer before displaying the next top.

As the underlying block is 4KB if the PMC throughput is low the measurement
will be reported on the next tick. pmcstat(8) use the modified flush API to
reclaim current buffer before displaying next top.

MFC after: 1 month


224698 07-Aug-2011 attilio

Convert pmcstat about using cpuset_t rather than relying on plain 32 bit
ints. That fixes a first bug where pmcstat wasn't using the old
cpumask_t interface and now also brings the full support for more
than 32 cpus.

While here, make the functions pmcstat_clone_event_descriptor() and
pmcstat_get_cpumask() private to pmcstat.

The problem of assuming cpu dense masks still persists and should be
eventually fixed, as reported by avg.

Tested by: pluknet
Reviewed by: gnn
Approved by: re (kib)


224057 15-Jul-2011 avg

pmcstat, pmccontrol: catch up with removal of machdep.hlt_cpus sysctl

Reported by: Pan Tsu <inyaoo@gmail.com>
Reviewed by: attilio
No objections: gnn


223492 24-Jun-2011 kevlo

Remove duplicated header files


212176 03-Sep-2010 fabient

When an asm location cannot be resolved to a function the cost
will be spread as small value and then filtered by the threshold.
As a first step solution display the number of event that cannot
be resolved as a valid function location.

MFC after: 1week


210797 03-Aug-2010 fabient

- Do not use the runtime mask when logfile is specified.
- Revert the fix on rtld path that is not necessary.

MFC after: 1 week


210794 03-Aug-2010 fabient

Allow file as a top source, it works with socket now.
This will allow top monitoring using socket/ssh tunnelling
of system without local symbols.

client:
pmcstat -R <ip>:<port> -T -r <symbolspath>
monitored device:
pmcstat -Sinstructions -O <ip>:<port>

- Move the file read in the event loop
- Initialize and clean log in all cases
- Preserve global stats value during top refresh
- Fix the rtld/line resolver that ignore '-r' prefix
- Support socket for '-R' (server mode)
- Display the statistics when exiting top mode


210766 02-Aug-2010 fabient

Fix the calltree top view that incorrectly filter out some nodes.

MFC after: 1 week


208858 05-Jun-2010 fabient

Fix warnings found by Coverity.

Found with: Coverity Prevent(tm)
MFC after: 1 month


207755 07-May-2010 fabient

Rework the calltree top view by critical callchain.
The percentage show is the sum of the cost for the codepath.

MFC after: 1 week


207731 06-May-2010 fabient

Exclude undefined symbol from ELF file when doing function resolve.

MFC after: 3 days


206994 21-Apr-2010 fabient

Apply threshold filter to root node in calltree view.

MFC after: 3days


206635 14-Apr-2010 fabient

Move fatal error at the right place.
Fix exit from top mode when checking if PMC is available.

MFC after: 3 days


206622 14-Apr-2010 uqs

mdoc: order prologue macros consistently by Dd/Dt/Os

Although groff_mdoc(7) gives another impression, this is the ordering
most widely used and also required by mdocml/mandoc.

Reviewed by: ru
Approved by: philip, ed (mentors)


206090 02-Apr-2010 fabient

Improve "top" header by:
- Display sample received per PMCs (or merged PMCs).
- Display percentage vs all samples


205809 28-Mar-2010 fabient

Wait for pmc name in the log before displaying data.
This will solve an abort in case of low throughput PMCs.

MFC after: 3days


205693 26-Mar-2010 fabient

Do not overflow the term in the case of multi-line display.

MFC after: 3days


204878 08-Mar-2010 fabient

Change the way shutdown is handled for log file.

pmc_flush_logfile is now non-blocking and just ask the kernel
to shutdown the file. From that point, no more data is
accepted by the log thread and when the last buffer is flushed
the file is closed.

This will remove a deadlock between pmcstat asking for
flush while it cannot flush the pipe itself.

MFC after: 3 days


204783 05-Mar-2010 fabient

Bug fixed:
- no display on serial terminal in top mode.
- display alignment for continuation string.
- correct invalid value used for display limit.

MFC after: 3 days


204329 25-Feb-2010 ru

Fixed dependencies (make checkdpadd).


203790 11-Feb-2010 fabient

- Reorganize code in 'plugin' to share log processing.
- Kcachegrind (calltree) support with assembly/source
code mapping and call count estimator (-F).
- Top mode for calltree and callgraph plugin (-T).

MFC after: 1 month


201390 02-Jan-2010 ed

The last big commit: let usr.sbin/ use WARNS=6 by default.


201145 28-Dec-2009 antoine

(S)LIST_HEAD_INITIALIZER takes a (S)LIST_HEAD as an argument.
Fix some wrong usages.
Note: this does not affect generated binaries as this argument is not used.

PR: 137213
Submitted by: Eygene Ryabinkin (initial version)
MFC after: 1 month


193296 02-Jun-2009 jkoshy

Catch up with the times: "mozilla" -> "firefox".


186425 23-Dec-2008 jkoshy

Close the read side of the pipe to self when exiting.


185322 25-Nov-2008 attilio

Add the -m option to pmcstat.
This option prints the list of sampled PCs along with the function name,
the start and end addresses of this where their live within.

Reviewed by: jkoshy
Tested by: gnn
Sponsored by: Nokia


185079 19-Nov-2008 jkoshy

As a matter of good programming style, stop PMCs before releasing
them.


183672 07-Oct-2008 jkoshy

- Avoid a spurious error when a command line is specified without
any process scope PMCs.
- Change the -c '*' option to denote non-halted CPUs.


183186 19-Sep-2008 jkoshy

Bring the usage message in sync with the manual page.


183183 19-Sep-2008 jkoshy

Add an example illustrating the use sleep(1) for performing timed
measurements.


180148 01-Jul-2008 jkoshy

Fix a regression: attach process PMCs to the process created when
a command line is specified.


180091 29-Jun-2008 jkoshy

Document messages printed in verbose mode.

Requested by: Fabien Thomas <fabien.thomas at netasq dot com>


176452 22-Feb-2008 jkoshy

Fix 'make checkdpadd'.


175215 10-Jan-2008 jkim

Fix non-SMP kernel regression introduced in the previous commit.

Reviewed by: jkoshy


174396 07-Dec-2007 jkoshy

Introduce pmcstat(8) changes for summarizing hwpmc(4) callchain records in
in textual form and in gmon.out format.

Update manual page.

Sponsored by: FreeBSD Foundation and Google Inc.


174209 03-Dec-2007 jkoshy

When printing the contents of a HWPMC log in human readable form:
- Print a warning if the version number recorded in the log is not what the
tool expects.
- Print a tidier error message when an unrecognized event is encountered
in the log.
- Don't print a spurious 'Unknown error: 0' when exiting after a parse
error.


172401 01-Oct-2007 ru

Fixed "make checkdpadd" (missing library dependencies).

Approved by: re (kensmith)


169069 27-Apr-2007 jkoshy

MFP4: Enhancements to pmcstat(8):

- Allow the "-t" option to take a regular expression naming command
line processes to attach process PMCs to.

- Update the manual page and add an example showing the use of the
new functionality.

- Update the (c) year on the affected source files.


168949 22-Apr-2007 jkoshy

MFP4: Enhancements and bug-fixes to pmcstat(8):

- The '-c' option now takes a comma-separated list of CPU
numbers, or a literal '*' denoting all CPUs in the system.
Subsequent system PMCs are allocated on the CPUs so specified.

Change the default behaviour to allocate system PMCs on all CPUs,
not just CPU 0.

Update the manual page and add an example of how to use the new
functionality.

- Attach PMCs to a (commandline) child process more reliably. This
fixes a long standing bug in counting events incurred by short-lived
processes.


168927 21-Apr-2007 jkoshy

Correct a sanity check.


162806 29-Sep-2006 ru

Markup fixes.


162804 29-Sep-2006 ru

Line up usage output.


157536 05-Apr-2006 jkoshy

When printing a map, print the number of samples recorded by each gmon.out file.

MFC after: 1 week


157406 02-Apr-2006 jkoshy

- Teach pmcstat(8) to log over the network; the -O option now
takes a host:port specification.
- Update the manual page and add an example showing how log
over the network using pmcstat(8) and nc(1). Document the
current inability to process logs in cross-platform manner.
- Have pmcstat_open_log() call err(3) directly in case
of an error; this simplifies error handling in its caller.

MFC after: 1 week


157144 26-Mar-2006 jkoshy

MFP4: Support for profiling dynamically loaded objects.

Kernel changes:

Inform hwpmc of executable objects brought into the system by
kldload() and mmap(), and of their removal by kldunload() and
munmap(). A helper function linker_hwpmc_list_objects() has been
added to "sys/kern/kern_linker.c" and is used by hwpmc to retrieve
the list of currently loaded kernel modules.

The unused `MAPPINGCHANGE' event has been deprecated in favour
of separate `MAP_IN' and `MAP_OUT' events; this change reduces
space wastage in the log.

Bump the hwpmc's ABI version to "2.0.00". Teach hwpmc(4) to
handle the map change callbacks.

Change the default per-cpu sample buffer size to hold
32 samples (up from 16).

Increment __FreeBSD_version.

libpmc(3) changes:

Update libpmc(3) to deal with the new events in the log file; bring
the pmclog(3) manual page in sync with the code.

pmcstat(8) changes:

Introduce new options to pmcstat(8): "-r" (root fs path), "-M"
(mapfile name), "-q"/"-v" (verbosity control). Option "-k" now
takes a kernel directory as its argument but will also work with
the older invocation syntax.

Rework string handling in pmcstat(8) to use an opaque type for
interned strings. Clean up ELF parsing code and add support for
tracking dynamic object mappings reported by a v2.0.00 hwpmc(4).

Report statistics at the end of a log conversion run depending
on the requested verbosity level.

Reviewed by: jhb, dds (kernel parts of an earlier patch)
Tested by: gallatin (earlier patch)


153710 25-Dec-2005 jkoshy

When generating profiles (-g) warn about shared objects that were
not found.


153704 24-Dec-2005 jkoshy

- Don't print an errno string when reporting dropped samples.
- Prevent an unsuccessful exec() of a target program from triggering
a false 'dropped samples' message.


151542 21-Oct-2005 jkoshy

Warn the user if the kernel driver dropped samples or ran out of event buffers
during a data collection run.


151434 18-Oct-2005 jkoshy

Handle 32 bit executables better on AMD64 platforms.


151433 18-Oct-2005 jkoshy

Document pmcstat's inability to handle 32 bit executables on the
AMD64 while I work on a fix.

Noticed by: ps


150139 14-Sep-2005 jkoshy

Determine where the runtime loader got mapped to when a dynamically
linked process was exec()'ed, and map samples in that address range
into the appropriate buckets in the runtime loader's profile.
Improve a few comments.

MFC after: 3 days


150069 13-Sep-2005 jkoshy

Fix a bug that caused generated gmon.out profiles to be out of
whack. Use saturating arithmetic when incrementing a bucket.
Improve a few comments.

MFC after: 3 days


149805 05-Sep-2005 jkoshy

Improve an error message.

MFC after: 3 days


148688 04-Aug-2005 jkoshy

Correctly print system-wide PMC counts for short-lived command lines.

Reported by: cracauer
MFC after: 3 days


148329 23-Jul-2005 jkoshy

Sync usage message with the code and manual page.

Submitted by: maxim


147953 13-Jul-2005 rwatson

Fix spelling error in sample command.

MFC after: 3 days


147863 09-Jul-2005 jkoshy

Fix a bug that affected on-the-fly gmon.out file generation.

Approved by: re (scottl)


147713 01-Jul-2005 jkoshy

Add examples illustrating how to record system-wide profiles and
how to convert these to gprof(1) flat profiles. Augment description
for the '-g' option.

Remove superfluous quotes around a macro argument, bump document date [1].

Reminded by: ru [1]
Approved by: re (blanket hwpmc)


147712 01-Jul-2005 jkoshy

Unbreak tinderbox builds. Remove a debug printf.

Approved by: re (blanket hwpmc)


147708 30-Jun-2005 jkoshy

MFP4:

- pmcstat(8) gprof output mode fixes:

lib/libpmc/pmclog.{c,h}, sys/sys/pmclog.h:
+ Add a 'is_usermode' field to the PMCLOG_PCSAMPLE event
+ Add an 'entryaddr' field to the PMCLOG_PROCEXEC event,
so that pmcstat(8) can determine where the runtime loader
/libexec/ld-elf.so.1 is getting loaded.

sys/kern/kern_exec.c:
+ Use a local struct to group the entry address of the image being
exec()'ed and the process credential changed flag to the exec
handling hook inside hwpmc(4).

usr.sbin/pmcstat/*:
+ Support "-k kernelpath", "-D sampledir".
+ Implement the ELF bits of 'gmon.out' profile generation in a new
file "pmcstat_log.c". Move all log related functions to this
file.
+ Move local definitions and prototypes to "pmcstat.h"

- Other bug fixes:
+ lib/libpmc/pmclog.c: correctly handle EOF in pmclog_read().
+ sys/dev/hwpmc_mod.c: unconditionally log a PROCEXIT event to all
attached PMCs when a process exits.
+ sys/sys/pmc.h: correct a function prototype.
+ Improve usage checks in pmcstat(8).

Approved by: re (blanket hwpmc)


147587 24-Jun-2005 jkoshy

- Tidy markup. [1]
- Remove mention of an unimplemented option.
- Clarify the behavior of pmcstat when logging PMCs are
requested, but no log output file is specified.
- Add a cross-reference to pmclog(3).
- Bump document date.

Reviewed by: ru
Submitted by: ru [1]
Approved by: re (blanket hwpmc)


147191 09-Jun-2005 jkoshy

MFP4:

- Implement sampling modes and logging support in hwpmc(4).

- Separate MI and MD parts of hwpmc(4) and allow sharing of
PMC implementations across different architectures.
Add support for P4 (EMT64) style PMCs to the amd64 code.

- New pmcstat(8) options: -E (exit time counts) -W (counts
every context switch), -R (print log file).

- pmc(3) API changes, improve our ability to keep ABI compatibility
in the future. Add more 'alias' names for commonly used events.

- bug fixes & documentation.


145796 02-May-2005 jkoshy

Neaten usage message.


145774 01-May-2005 jkoshy

Add convenience APIs pmc_width() and pmc_capabilities() to -lpmc.
Have pmcstat(8) and pmccontrol(8) use these APIs.

Return PMC class-related constants (PMC widths and capabilities)
with the OP GETCPUINFO call leaving OP PMCINFO to return only the
dynamic information associated with a PMC (i.e., whether enabled,
owner pid, reload count etc.).

Allow pmc_read() (i.e., OPS PMCRW) on active self-attached PMCs to
get upto-date values from hardware since we can guarantee that the
hardware is running the correct PMC at the time of the call.

Bug fixes:
- (x86 class processors) Fix a bug that prevented an RDPMC
instruction from being recognized as permitted till after the
attached process had context switched out and back in again after
a pmc_start() call.

Tighten the rules for using RDPMC class instructions: a GETMSR
OP is now allowed only after an OP ATTACH has been done by the
PMC's owner to itself. OP GETMSR is not allowed for PMCs that
track descendants, for PMCs attached to processes other than
their owner processes.

- (P4/HTT processors only) Fix a bug that caused the MI and MD
layers to get out of sync. Add a new MD operation 'get_config()'
as part of this fix.

- Allow multiple system-mode PMCs at the same row-index but on
different CPUs to be allocated.

- Reject allocation of an administratively disabled PMC.

Misc. code cleanups and refactoring. Improve a few comments.


145278 19-Apr-2005 jkoshy

Remove superfluous CFLAGS additions. Make 'make checkdpadd' work.
Use '?=' for the WARNS line.

Submitted by: ru


145256 19-Apr-2005 jkoshy

Bring a working snapshot of hwpmc(4), its associated libraries, userland utilities
and documentation into -CURRENT.

Bump FreeBSD_version.

Reviewed by: alc, jhb (kernel changes)