- Copy stable/10 (r259064) to releng/10.0 as part of the
10.0-RELEASE cycle.
- Update __FreeBSD_version [1]
- Set branch name to -RC1

[1] 10.0-CURRENT __FreeBSD_version value ended at '55', so
start releng/10.0 at '100' so the branch is started with
a value ending in zero.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Copy head (r256279) to stable/10 as part of the 10.0-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Add entry for packages-9.2-release directory.

Approved by: re (implicit)

sysconf(3) returns a long, not an int.

sysconf(3) returns a long, not an int.

Update location to ports INDEX file.

PR: bin/164561
Approved by: bapt

Fix compilation errors.

Use snprintf instead of strc* functions and add bounds checking when creating
pkgngpath

Submitted by: sbz, gahr

Provide an option to users to shoot themselves in the foot.

Reviewed by: bapt
Approved by: cperciva
MFC after: 1 month

Use modern license instead of being consistent with the other pkg_ tools
Use a more informative message
Fix some style(9) nits.
Bump version number
In pkg_add only warn users after the chroot is performed.

Submitted by: gavin, jilles
Reviewed by: beat, bapt
Approved by: cperciva
MFC after: 1 month

Add the release package directory for 9.1-RELEASE.

Warn users when using pkg tools if it looks like they
be be pkgng users.

Reviewed by: bapt (earlier version)
Reviewed by: kwm
Approved by: cperciva
MFC after: 3 days

More -Wmissing-variable-declarations fixes.

In addition to adding `static' where possible:

- bin/date: Move `retval' into extern.h to make it visible to date.c.
- bin/ed: Move globally used variables into ed.h.
- sbin/camcontrol: Move `verbose' into camcontrol.h and fix shadow warnings.
- usr.bin/calendar: Remove unneeded variables.
- usr.bin/chat: Make `line' local instead of global.
- usr.bin/elfdump: Comment out unneeded function.
- usr.bin/rlogin: Use _Noreturn instead of __dead2.
- usr.bin/tset: Pull `Ospeed' into extern.h.
- usr.sbin/mfiutil: Put global variables in mfiutil.h.
- usr.sbin/pkg: Remove unused `os_corres'.
- usr.sbin/quotaon, usr.sbin/repquota: Remove unused `qfname'.

Make sure that each va_start has one and only one matching va_end,
especially in error cases.

if a file in plist starts with / then do not prefix it with "prefix" [1]
pkg info -g returns 1 if a file mismatch [2]
flush stdout in pkg info -g [3]
clean up quiet mode (-q | --quiet) output of pkg_version(1) [4]
fix missing error call in uname check added to pkg_version(1) [5]
fix pkg_add(1) fails to install with -C from bad path [6]
only resolve path from pkg_add(1) -p if the given prefix do not start with a '/' [7]

PR: bin/13128 [1]
bin/139015 [2]
bin/113702 [3]
bin/142570 [4]
bin/146857 [5]
bin/157543 [6]
Submitted by: cy [1]
Anton Yuzhaninov <citrin@citrin.ru> [2]
Ighighi <ighighi@gmail.com> [3]
"N.J. Mann" <njm@njm.me.uk> [4]
gcooper [5]
David Naylor <naylor.b.david@gmail.com> [6]
netchild [7]
MFC after: 2 weeks

Do not change owner, group, or mode when package database directory and
its contents are created with pkg_add(1). It may happen when the packing
list contains @owner, @group, or @mode.

Reported by: Donald Bostrom (dbostrom at niksun dot com)
Reviewed by: portmgr (bapt)

Bump PKG_INSTALL_VERSION which should've been done in r236233

MFC after: 3 days
Pointed out by: bapt

Let pkg_add use the ENV variable PACKAGESUFFIX. This
can be used to override the default .tbz package extension to
.txz .tgz or .tar

Submitted by: kmoore
Obtained from: PC-BSD
Sponsored by: iXsystems
MFC after: 3 days

Make sure that each va_start has one and only one matching va_end,
especially in error cases.

- Print package name in case an empty pkgdep line is found.

PR: bin/164378
Submitted by: Yuri <yuri AT tsoft.com> and many others
Approved by: flz
MFC after: 2 weeks

General mdoc(7) and typo fixes.

PR: 167696
Submitted by: Nobuyuki Koganemaru (kogane!jp.freebsd.org)
MFC after: 3 days

Remove trailing whitespace per mdoc lint warning

Disussed with: gavin
No objection from: doc
Approved by: joel
MFC after: 3 days

Add entry for packages-8.3-release directory.

Fix r231300: Use correct test so we only bail out on error instead of on non-error.
Also, fix a style bug.

Submitted by: ache
Approved by: cperciva
MFC after: 1 month

Permit the use of relative paths for the prefix argument.
Remove an unnecessary cwd from created plists when -p is specified

PR: bin/145000
Submitted by: gcooper
Approved by: portmgr (flo)
MFC after: 1 month

X11BASE has been deprecated for a long time and will die soon

Approved by: x11 (eadler)
Approved by: brucec
MFC after: 1 week

Touch up some more small typos missed in the previous round.

Reported by: Ben Kaduk <minimarmot@gmail.com> et al.

Spelling fixes for usr.sbin/

Reencode files to UTF-8. Drop CP1252 em-dash.

In usr.sbin/pkg_install/updating/main.c, use the size of the destination
buffer as size argument to strlcpy(), not the length of the source.

MFC after: 1 week

- add a missing "be" and "in"
- fix other errors introduced when committing r226436
- add 'function' to a sentence where it makes sense

Submitted by: delphij
Submitted by: dougb
Submitted by: jhb
Approved by: dougb
Approved by: jhb

Staticify elide_root() for now to fix build.

Avoid printing // for packages that install to /

I have some packages that install to / (for whatever reason). Right now we
print entries of the form //path/to/file when listing files (pkg_info -L,
pkg_info -g etc.) This change avoids printing the redundant / .

- change "is is" to "is" or "it is"
- change "the the" to "the"

Approved by: lstewart
Approved by: sahil (mentor)
MFC after: 3 days

Shift head from 9.0-CURRENT to 10.0-CURRENT in preparation for releasing
it from the 9.0-RELEASE release cycle code freeze.

Approved by: re (implicit)

Print the package name on deletion errors.

It appears this was already done in NetBSD a decade ago, hence
I just reuse the change (except our code is bad styled).

PR: bin/160516
Approved by: portmgr
Approved by: re (kib)
Obtained from: NetBSD

Backout libinstall.a -> libpkg commit.

Discussed with: erwin, brooks, bapt

Remove $Log$ keyword and associated history, which can cause annoyance in
diffs in some cases. Revision control tools have a history command to
obtain this information.

Add package directories used for the upcoming 8.2 and 7.4 releases,
and catch up on a few from previous releases.

- Add support for xz compression to pkg_create, bzip2 remains the default
compression algorithm.
- Bump PKG_INSTALL_VERSION to 20101012.

Submitted by: mm
MFC after: 1 month

Use MACHINE_ARCH instead of MACHINE as the directory to fetch packages
from. Packages are architecture dependent, not machine dependent.

mdoc: use mdoc spelling of Umlauts

mdoc: move remaining sections into consistent order

This pertains mostly to FILES, HISTORY, EXIT STATUS and AUTHORS sections.

Found by: mdocml lint run
Reviewed by: ru

- Take libinstall.a out of pkg_install and make it a proper shared library.
- Rework the wrapper support to check libpkg version as well as pkg_install
version.
- Add libfetch to _prebuild_libs.
- There are no new features introduced.

Notes: the API is not stable, so basically, do not use libpkg in your
projects for now. Also there's no manpage for libpkg yet, because the API
will change drastically. I repeat, do not use libpkg for now.

Bump PKG_INSTALL_VERSION to 20100403.

Fix pkg_delete, check if the file we're trying to delete is a
symlink before complaining that it doesn't exist. Typical case
would be a leftover library symlink that's left over after the
actual library has been removed.

Reported by: tabthorpe

Various fixes.

- Replace hardcoded INDEX version. [1]
- Fix a buffer overlap. [2]
- Remove empty package when fetching fails and -K is used. [3]
- Remove useless chmod2() after mkdtemp(3). [4]
- Replace mkdir(1) call with mkdir(2). [5]
- Get rid of some vsystem() calls.
- Switch from lstat(2) to open(2) in fexists().
- Try rename(2) in move_file() first.
- Bump PKG_INSTALL_VERSION to 20100401.

PR: bin/145101 [1], bin/139492 [2], bin/144919 [3]
bin/144920 [4], bin/144921 [5]
Submitted by: gcooper [1,2,3,4,5]

Fix several typos in macros or macro misusage.

Found by: make manlint
Reviewed by: ru
Approved by: philip (mentor)

- Add support for UPDATING remote fetching.
- Reorganize EXAMPLES section in pkg_updating(1).
- Style fixes.
- Bump PKG_INSTALL_VERSION to 20100122.

Submitted by: beat
MFC after: 1 week

The last big commit: let usr.sbin/ use WARNS=6 by default.

Add missing `void' keywords.

- Bump PKG_INSTALL_VERSION to 20090902 after dougb's changes.
- Change the comment to say that version must be changed when a
non-cosmetic change is made.

Add support for INDEX-9 [1]

While I'm here, strip off support for FreeBSD 5.x.

Submitted by: Alexey Shuvaev <shuvaev@physik.uni-wuerzburg.de> [1]

Oops. Needed to adjust a little bit more of the line for packages-8-stable
now that we're prepping for 8.0's release.

Submitted by: pluknet at gmail dot com
Pointy hat: kensmith

Make head 9.0-CURRENT in preparation for lifting code freeze.

Approved by: re (implicit)

Disable r194497 for now. It doesn't work well with ports-mgmt/tinderbox.

Approved by: re (ken)

Don't imply that only FTP urls are supported when we can't fetch
a package.

Approved by: re (kib)
MFC after: 3 weeks

When running pkg_add -r, check & install our dependencies for each
package rather than expecting our top level package to get all of
the dependencies correct.

Previously, the code depended on the top level package having all
of the pkgdep lines in +CONTENTS correct and in the right order,
but that doesn't always happen due to code such as this (in
security/gnutls/Makefile):

.if (defined(WITH_LZO) || exists(${LOCALBASE}/lib/liblzo2.so)) && !defined(WITHOUT_LZO)
LIB_DEPENDS+= lzo2:${PORTSDIR}/archivers/lzo2
....

With such conditional dependencies, my 'sophox-packages' package won't
install. The dependency tree looks like this:

sophox-packages
...
x11/gnome2
x11/gnome-applets
net/libgweather
devel/libsoup
security/gnutls
security/libgcrypt
security/libgpg-error
...
x11/gnome2
archivers/file-roller
archivers/gtar
archivers/lzop
archivers/lzo2
...

gnutls doesn't depend on lzo2 initially, but lzo2 is dragged into the
mix via other dependencies and is built by the initial 'make'. The
subsequent package generation for gnutls adds a pkgdep line for lzo2
to gnutls' +CONTENTS but the pkgdeps in sophox-packages' +CONTENTS
has gnutls *before* lzo2.

As a result, sophox-packages cannot install; gnutls fails because lzo2
is missing, 82 more packages fail because gnutls is missing and the
whole thing spirals into a super-confusing mess!

MFC after: 3 weeks

Fix segfault when giving invalid long option to pkg_info.

PR: bin/133473
Submitted by: Rafal Grodzinski
Approved by: ed (mentor)
MFC after: 1 week

Skip @pkgdep if there's no argument.

Submitted by: pav
MFC after: 1 week

Add release package directories for 6.4 and 7.2.

Use full name (noticed by: ru@

- Backout latest changes (follow symlinks: r186496, r186518).
- Bump PKG_INSTALL_VER to 20090106.

- s/no-scripts/no-script/

PR: docs/127732
Submitted by: TerryP <BigBoss1964@gmail.com>
MFC after: 3 days

Fix memory leaks introduced in last commit.
Bump version to 20081227.

Reported by: gcooper
Submitted by: Andrea Barberio <insomniac@slackware.it>
MFC after: 1 month

Follow symlinks when deleting directories.
Bump PKG_INSTALL_VER to 20081225 (Merry Christmas \o/).

PR: bin/54446
Submitted by: Andrea Barberio <insomniac@slackware.it>
MFC after: 1 month

Add package directory for 7.1-RELEASE in head as well as stable/7.

Display usage when pkg_add is called with no arguments.

PR: bin/121093
Submitted by: volker
Approved by: portmgr (linimon)
MFC after: 3 days

Use humanize_number to report pen-sizes so people don't have to count
the digits when trying to install openoffice.

Enable the -n option of pkg_create(1).

The changes to make the option work are already in place, but I missed
the patch hunk that adds it to the getopt() option-handling loop.

Pointy hat: keramida
Approved by: flz
MFC after: 1 week

Remove support for RELENG_4 (__FreeBSD_version < 500039).

MFC after: 1 day

Style fix (use naked commands).

Reported by: obrien

- add: Keep dependent packages too if -K is specified.
- updating: terminating '\n' is not part of the package origin.
- bump PKG_INSTALL_VERSION to 20080612.

PR: bin/119368 [1], bin/124459 [2]
Submitted by: gcooper [1], Beat Gatzi <beat@chruetertee.ch> [2]
MFC after: 3 days

Exclude .svn directories from generated distfile.

- Add long options to pkg_install.
- Remove check for '-?' as it's not listed in authorized options.
- Bump PKG_INSTALL_VERSION to 20080530.

Use PKG_INSTALL_VERSION for the distfile name instead of current date.

X-MFC after: pkg_install sync on -STABLE branches

Bump PKG_INSTALL_VERSION to 20080528.

X-MFC after: latest HEAD changes have been MFC'ed to RELENG_[67]

Update usage strings to add a missing -n option.

Noticed by: Matthias Apitz, matthias.apitz at oclc.org

Add a -n option to pkg_create(1), to inhibit duplicate work.

When run without this option, multiple runs of `pkg_create -Rb' will
recreate common packages multiple times. This can take a lot of time
for large packages. With the -n option `pkg_create -b' checks with
stat(2) and skips packages that already exist.

Note that this may *not* be safe of the existing output file is not
really a package, or if it has been corrupted, modified or otherwise
tinkered with between subsequent pkg_create runs. For this and POLA
reasons, the default behavior is to *rebuild* the packages, and the -n
option can be used when we know it is `safe' to run in no-regenerate
mode.

Inspired by: A post to freebsd-questions
by Matthias Apitz &lt; matthias.apitz at oclc.org &gt;
Reviewed by: marcus, flz
Approved by: marcus
MFC after: 2 weeks

- Backout 1.15, it was committed by accident

Pointy hat to: pav

- Restore functionality broken in previous commit; we need to be able to report
multiple installed packages with the same PKGORIGIN.

Reported by: marcus
MFC after: 1 month

Fix pkg_info when specifying a remote package.

MFC after: 1 week

Optimize package registration/deregistration. Previously, when looking up the
package name for the origin of a dependency, all entries in /var/db/pkg were
traversed for each dependency of added/removed package. Now, gather all the
origins first, then do the lookup in a single pass over /var/db/pkg.

This should provide a major speedup for packages with hundreds of dependencies.

Submitted by: rdivacky (earlier version)
MFC after: 1 month

Add a distfile target to generate a distfile to be used by the
ports-mgmt/pkg_install port.

Retire pkg_sign. It was used to embed signatures in gzip'ed packages.
It's not relevant since we've changed to bzip2 compression.

MFC after: 1 week

Improve style a little and remove one always-true condition.

Approved by: portmgr (pav)
Approved by: kib (mentor)

Sync list of directories to look for packages in to current releases
available.

MFC after: 3 days

Introduce -i to SYNOPSIS, forgotten by krion@.

Revise the TECHNICAL DETAILS section.

Reviewed by: skv

- Adjust INDEX file name to INDEX-8 so that it matches the major FreeBSD
version number, as it is named after that

PR: docs/118053
Submitted by: Michael Plass <mfp49_freebsd@plass-family.net>

Backout previous commit, since it's done without maintainers
approval. These changes were approved by adding it as port to
ports/ tree, but not for src/. I talked to PR submitter and miwi@
some days ago and explained the reasons for it, the both were agree
to add it to ports/ only.

Add the 'pkg_search' script.
This makes it easier to figure what packages you want to install.

Submitted by: Matthias Schmidt <schmidtm @ mathematik . uni-marburg . de>

Fix segfault while running with -a option and deinstalling broken
packages with incorrect plists.

PR: bin/115327
Submitted by: Michael Zhilin <mizhka@gmail.com>
MFC after: 3 days

Some code cleanups, including removing of stale getopt argument and
hardcoded +CONTENTS defines.

PR: bin/117855
Submitted by: Beat Gaetzi <beat@chruetertee.ch>
MFC after: 14 days

Add -i option for package installation without fetching and
installing its dependencies.

PR: bin/117065
Submitted by: Vladimir Ermakov <samflanker@gmail.com>
MFC after: 14 days

Cleanup of userland __P use

Introduce pkg_updating(1) which scans for installed ports and shows
all ports/UPDATING entries that affect one of the installed ports,
and are relevant on the given machine.

PR: bin/117564
Submitted by: Beat Gaetzi <beat@chruetertee.ch>
MFC after: 14 days

Momoize the results of isinstalledpkg()

PR: bin/116452
Submitted by: wollmann
MFC after: 7 days

If the INDEX file cannot be opened, print the actual filename / path
pkg_version tried to open instead of just "INDEX" to make the actual
problem more clear (e.g. missing INDEX-8).

MFC after: 3 days
Reviewed by: portmgr (pav)

Add whitespace.

Update for INDEX-8 support.

To honor the birth of RELENG_7 bump HEAD to 8.0-CURRENT.

Approved by: re (implicit)

Fix pkg_add behaviour to preserve pathnames.

PR: bin/93915 bin/109134
Submitted by: Jason Heiss <heissj@yahoo-inc.com>, Constantin Stefanov<cstef@mail.ru>
Approved by: re@ (kensmith)
MFC after: 7 days

- Replace rather inefficient bubble sort with a recursive depth-first search.
This speeds up registration of packages considerably.
- style(9) police welcome!

PR: bin/112630
Submitted by: Stephen Montgomery-Smith <stephen@cauchy.math.missouri.edu>
Tested by: bento i386 experimental run
MFC after: 14 days

Make consistent with style(msmith). 4 spaces indent, tab for each 2 indents.

Invoke tar(1) with the -p option when installing a package
from an URL (i.e., do it the same way as when installing
from a file). This fixes the lossage of the setuid bits.
It wasn't a problem before because GNU tar(1) implied the
-p option for root, but BSD tar(1) doesn't do that.

Discussed with: tobez and some advanced users :)

The use of predefined strings such as \*[Ge] can be harmful here,
as some fonts (e.g., KOI8-R) have special symbols for displaying
them, and we want symbols ">=" literally here.

Fix markup and clean up some of the wording.

(This English was hard to translate as it uses a language that is
far from a pure technical. It would definitely benefit from a
revision.)

Clarify the meaning information printed by the -o option.
Clean up grammar, adding articles.

Fix a bug in 1.40 - it missed three occurences in pkg_info which leads to
(null)/file output.

MFC after: 1 week

Fix previous rev.: don't step behind the end of memory we allocate

Remove hard-coded limit (200) on maximum number of packages that can be
added with a single invocation of pkg_add, replacing it with something
rather more dynamic.

Approved by: portmgr (pav)
Tested by: full pointyhat package run
MFC after: 1 week

Fix the logic bug that caused the custom versions of warn(3) and
warnx(3) to be compiled on systems that have it (e.g. FreeBSD),
while the intention was opposite, i.e., compile them on systems
that don't have them. Also fixes static linkage of pkg_sign(1).

Markup fixes.

Fix usage().

Sync usage() with manpage's SYNOPSIS.

Oops. Catch up on the last couple of releases and prepare for the next
one.

Fix "pkg_version -Io" coredump, if some packages have no origin at
all.

PR: bin/101932
Submitted by: novel, sat
MFC after: 5 days

Cosmetic: fix indentation.

Turn on libfetch debugging if -v was specified on the command line.

MFC after: 2 weeks

Allow variable amounts of verbosity.

Add INDEX-7 and remove trailing spaces.

MFC after: 5 days

Use bzip2(1) by default to compress package tarball on
__FreeBSD_version >= 500039.

Submitted by: Alex Lyashkov <umka@sevcity.net>
MFC after: 5 days

Reimplementation of world/kernel build options. For details, see:

http://lists.freebsd.org/pipermail/freebsd-current/2006-March/061725.html

The src.conf(5) manpage is to follow in a few days.

Brought to you by: imp, jhb, kris, phk, ru (all bugs are mine)

Close descriptor in retrieve_x509_marker function.

PR: bin/71594
Submitted by: Dan Lukes <dan@obluda.cz>

Add -F option to not fail on already installed packages.

Submitted by: Eugene Grosbein <eugen@grosbein.pp.ru>

Fix pkg_version with the -o argument to print the origin.

Submitted by: Sebastian Stach <sebsta AT t-online DOT de>
MFC after: 3 days

Fix typo.

Add -K option to pkg_add and pkg_info.
This option saves packages to PKGDIR (if defined or current directory by default)
as they are downloaded.
Silent a warning when -n is used and package has a +DISPLAY file.

Approved by: krion
MFC after: 1 week

When using @cwd %%FOO%%, we must ensure to return in the original
prefix later, but doing so with @cwd %%OLDPREFIX%% (having
PLIST_SUB+="OLDPREFIX=${PREFIX}") hardcodes the value in the packing
list. That's not really a problem when dealing with ports but that's
a problem with packages since pkg_add -p option only overrides the
first @cwd occurrence.

This patch allow us to use @cwd without any argument. If no
directory argument is given, it will set current working directory
to the first prefix given by the @cwd command.

PR: bin/77212
Submitted by: flz

Document PKG_PATH enviroment variable.

Prodded by: Mark Andrews <Mark_Andrews AT isc DOT org>
MFC after: 2 days

-mdoc sweep.

Add -P flag, it does the same as the -p option, except that the
given prefix is also used recursively for the dependency packages,
if any. If the -P flag appears after any -p flag on the
command line, it overrides it's effect, causing pkg_add to use the
given prefix recursively.

PR: bin/75742
Submitted by: Frerich Raabe <raabe AT kde DOT org>
MFC after: 3 days

Introduce 3 new options for pkg_create(1), -x for using basic
regular expressions for pkg-name, -E for extended regexps and -G for
exact matching.

Submitted by: mux
MFC after: 3 days

Look for packages in packages-6.0-release or packages-6-stable, as
appropriate.

Approved by: re (scottl@)
Reviewed by: portmgr (kris@)

* pkg_version(1) exits if INDEX files is not found and -I is not
specified. The result is that the package will be listed with a '?'
as if it was not found within the INDEX file, so fix this behaviour.
* Remove trailing spaces.

PR: bin/87136
Submitted by: Sean Farley <sean-freebsd at farley dot org>
MFC after: 3 days

Fix pkg_info(1) and pkg_delete(1) to handle properly packages which
names start with a digit.

PR: bin/76858
Submitted by: Matthew D. Fuller <fullermd@over-yonder dot net>
MFC after: 3 days

Do not bitch about bsdpan modules not having origin.

Based on PR: bin/82269
Submitted by: Steven Hartland <killing at multiplay dot co dot uk>
MFC after: 3 days

Remove '\n' since it's redundant in case if file doesn't exist while
running 'pkg_info -g'

Based on PR: bin/42609
Submitted by: Jeff King <peff-freebsd at peff dot net>
MFC after: 3 days

Add -o/-O options to pkg_version:

-o Show the origin recorded on package generation instead of the
package name.

-O Only list packages whose registered origin is origin.

Based on PR: bin/78640
Submitted by: Marcus Grando <marcus at corp dot grupos.com.br>, flz

Fix an oops on FBSD-version for packages-5-stable I made in previous
commit.

Pointy hat: kensmith
Approved by: re (implicit)

Prepare for packages-7-current. While here retro-fit packages-5.4-release
which probably should have been done a while ago.

Approved by: re (implicit)

remove a few uses of the word `really'

Reviewed by: hrs
Approved by: re (scottl)
MFC after: 1 week

Fix last commit.

Approved by: re (blanket)

Implement @noinst field which has at the moment the same meaning and
function as @comment has. But will be valid only for files and not
for md5 sums, rcsid's and comments in the future.

Submitted by: flz
Approved by: re@ (scottl)

Markup fixes.

Approved by: re (blanket)

Remove kludges intended to support src trees with partial obj trees.

Discussed with: ru

Add -R modifier for the mode when pkg_create(8) creates package file
from the locally installed package. When this modifier is specified
pkg_create(8) will also create package files for all packages on
which that locally installed package depends.

MFC after: 5 days

Add an -I option to pkg_version:

-I Use only the index file for determining if a package is out of
date. This is much faster than using the version number from a
port's Makefile, at the expense of potentially giving an incor-
rect result if the index file is out of date.

Without this option, the index file is only consulted if "make -V PKGNAME"
cannot be used.

Approved by: portmgr (krion)

Change the PATH for pkg_add to be the same used for pointyhat package builds.
This will give our users and porters a more consistent experience between
installing ports and installing packages.

Discussed with: portmgr

Expand contractions.

Expand *n't contractions.

Sort sections.

Added the EXIT STATUS section where appropriate.

Scheduled mdoc(7) sweep.

Add -q to usage() and mark the "index" argument as optional.

Update the INDEX file to INDEX-6

Use INDEX-6 for versions of FreeBSD > 600000

NOCRYPT -> NO_CRYPT

For variables that are only checked with defined(), don't provide
any fake value.

Add a -q flag to pkg_version. It suppresses the output of <,=,>.
This makes it possible to "portupgrade `pkg_version -q -l '<'`".

Set the real limits on 5-current, add 5-stable, add 6-current.

Don't put DEBUG to CFLAGS, we have the standard DEBUG_FLAGS for this.

typo

Approved by: ru

FWIIW, make the `test' target in pkg_install/version actually work.

Join the 21st century: Cryptography is no longer an optional component
of releases. The -DNOCRYPT build option still exists for anyone who
really wants to build non-cryptographic binaries, but the "crypto"
release distribution is now part of "base", and anyone installing from a
release will get cryptographic binaries.

Approved by: re (scottl), markm
Discussed on: freebsd-current, in late April 2004

Use the length modifier 'll' instead of 'q' to print long longs.

Downgrade WARNS level to more tolerable value. Attempt to fix
casts as lvalue usage whenever possible.

Eliminated double whitespace.

Mechanically kill hard sentence breaks.

- pkg_add spawns itself as argv[0] when installing dependent packages, to
enable the use as a port on older systems

- use absolute paths in all calls to external programs, to account for strange
PATH settings

- use INDEX or INDEX-5 depending on FreeBSD version, to enable the use on
FreeBSD 4.x as a port.

- conditionalize all 4.x/5.x differences on __FreeBSD_version, so that the
pkg_install tools can be kept in sync on 4.x and 5.x

- Bump PKG_INSTALL_VERSION

Reviewed by: portmgr (bento run)
MFC after: 4 weeks

- pkg_info: flag -r: (show packages this packages depends on (documentation change))

- pkg_info: new flag -j (show the requirements script)

- pkg_info: fix verbose output when used on packages

- better handling of corrupt entries in /var/db/pkg

- differ between corrupt entires and packages not installed

- various small fixes

PR: 56989, 57016, 57029, 26468

- pkg_create: new flag -S (clean room installation)

- pkg_create: checksum meta files too

PR: 66032

- match package version numbers with relational operators

- use glob patterns when matching packages by origin

- csh-style {...} choices in glob matching

- pkg_info: new flag -E (list matching package names only)

- pkg_version: new flag -T (test if a given name matches a pattern)

- new flag -X (interpret pattern as an extended regular expression)

PR: 56961

- complete rewrite of the version number parsing code, restoring compatibiliy of 5.x with 4.x and portupgrade

- parse version numbers of ports containing an underscore followed by a number correctly

- handle special strings pl, alpha, beta, pre and rc

PR: 56961

Markup and punctuation nits.

Add 4.10 and 5.2.1 entries so that pkg_add -r fetches from the right
package sets.

PR: 66251
Submitted by: eik

When invoking tar, make sure the mode option (-x) is first.

Synopsis fixes:
* `pkg_info -flags' needs either `-a' or a package name. [1]
* Add -Q option to manual page.
* Update `usage:' to match the manual page.

PR: misc/64786 [1]
Reviewed by: ru
MFC after: 3 days

Add command line option for chrootdir, all pkg_add(8) operations will be
done inside of chroot(2) to chrootdir. Added to help with sysinstall(8)
support of install to alternate root but possibly useful for setting up
jails, etc.

No objection from: portmgr@
Style(9) abuse due to: entire program violates style(9)
Approved by: rwatson (mentor)

This is an initial whitespace cleanup commit, new content to follow.
Adding hard line breaks at the end of sentences.

Approved by: rwatson (mentor)

Instead of bogusly complaining about odd file names, handle them properly
by escaping all suspicious characters.

MFC after: 3 days

Try to apply consistent indentation.

- Properly build both crypto and non-crypto versions of the
package management tools.

- Drop redundant dependency of pkg_create(1) and pkg_delete(1)
on crypto libraries now that they do not link with libfetch.

Replaced black magic with white magic.

Catch up with reality with respect to the location of 4.8, 4.9,
5.0, 5.1, 5.2, and CURRENT packages.

Fix a case of undefined behavior due to overlapping buf objects in
snprintf (buf, size, fmt, buf, etc). This only works by chance with our
libc, but fails (with a truncated string) on e.g. glibc.

Okayed by: sobomax
MFC after: 1 week

Correct truncation detection after use of snprintf: The case where
exactly one character was truncated was not detected.

Clarify the order of arguments passed to the pre-/post-install script
in the description of the pkg_create -i command-line option.

PR: 55477
Submitted by: Eric van Gyzen <vangyzen@stat.duke.edu>
MFC after: 5 weeks

Backout 1.14, it seems to be causing problems with libxml build
and I don't have time to investigate this code in much detail right
now.

Use strncmp() and not strcmp() here to properly match
installed ports.

Submitted by: Harold Gutch <logix@foobar.franken.de>

The .Xr utility

pkg_create incorrectly does not add trailing '\n' when it receives
either COMMENT or DESCR from the command line. When a port is
installed, one gets both +COMMENT and +DESCR files with a trailing
'\n' character. However, +COMMENT does not contain a trailing '\n'
when it is installed from a package due to this behavior of pkg_create.

Therefore, make sure it behaves exactly the same regardless of
where got its information; either command line or files. The modified
functions are used by pkg_create.

PR: 52097
Reviewed by: bento, kris,
portmgr, re,
Michael Nottebrock <michaelnottebrock@gmx.net>,
Martin Horcicka <horcicka@FreeBSD.cz>
Approved by: re (scottl)
MFC after: 1 week

Add a trailing '\n' character if none is found in the information
obtained from a package. Patch show_file() [1] and show_index() [2]
functions.

PR: 52097
Reviewed by: bento, kris,
portmgr, re,
Michael Nottebrock <michaelnottebrock@gmx.net>,
Martin Horcicka <horcicka@FreeBSD.cz>
Approved by: re (scottl)
Obtained from: NetBSD [1],
OpenBSD [2]
MFC after: 1 week

Erase whitespace at EOL.

Approved by: re (blanket)

Retire the useless NOSECURE knob.

Approved by: re (scottl)

Fixed troff(1) and mdoc(7) warnings.

Approved by: re (blanket)

* Add explicit conflict-checking to the package tools. Packages can
register a list of other packages with which they conflict (via the
-C option to pkg_create), and they will refuse to install (unless -f is
specified) if one of the listed packages is already present.

* Update documentation for the new feature as well as fleshing out some
existing documentation.

* Bump PKG_INSTALL_VERSION so this feature can be tested for.

Submitted by: Sergey Matveychuk <sem@ciam.ru>
PR: bin/47145
MFC after: 2 weeks

Revert url.c:1.2: there was a race condition between when I produced
the fix and when I committed it -- in between the two, DES committed
a different fix, rendering this fix unneeded.

Requested by: des

- Print out an error message instead of dereferencing a NULL pointer
if matchinstalled() found no packages, which happens to be the
case after fresh installations.
- Instead of using strstr(3) to match the package name, depend on
matchinstalled()'s MATCH_REGEX package matching.

PR: bin/50384
MFC after: 2 weeks

Don't pass NULL in as a flags argument to libfetch's fetchGetURL()
as this can result in a NULL pointer deference when parsing the
flags later. This change fixes "pkg_add -r" on 5.0-CURRENT for
me; not quite clear how the problem was introduced.

- Add the 'b' option which causes BLOCKSIZE to be hornored when
the 'q' or 'Q' options are present.
- Document BLOCKSIZE.

Implement the 'Q' option which is like 'q' (quiet output) except
that it prefaces the output with the package name.

This is useful for things like this:

# pkg_info -Qsa | awk -F : '{print $2 "\t" $1}' | sort -rn | expand -t 10

Fix a long-standing bug where if the package being deleted had no
post-deinstall script, the variable intended to hold the name of that
script would be used uninitialized. In some cases, fexists() would
succeed, causing pkg_delete to try to chmod +x it, then execute it,
resulting in bizarre error messages such as:

.//: Permission denied

This bug would normally only occur when multiple packages were
specified on the command line; otherwise post_script would be located
in a previously unused part of the stack, and implicitly (but quite
accidentally) initialized to all-zeros.

MFC after: 3 days

Initialize sign to NULL so that we don't attempt to free() it in case
of failure.

MFC after: 1 week

even the default case in a switch requires some action (add break;)

EVP_sha1() returns a const EVP_MD *, so reflect that in the variable
we store its return value in.

No need for the OPENSSL_NO_KRB5 switch anymore.

Fixed by: nectar

iAdjust for OpenSSL 0.9.7.

Note that -c is no longer supported. This was requested by a few users and
we even have a PR about it.

PR: 47388
Discussed with: bmah
Requested by: many

Actually, the canonical way would be syntactically correct.

Canonical way of determining whether or not to use crypto.

Prevent buffer overflow in format_cmd() by properly tracking maximum
buffer size.
Reported by: Lionnel CHAPTAL <Lionnel.Chaptal@IPricot.com>
MFC after: 1 week

Correct typos, mostly s/ a / an / where appropriate. Some whitespace cleanup,
especially in troff files.

Back out rev 1.33; getbsize(3)'s original interface has been restored.

Approved by: markm

english(4) police.

Uniformly refer to a file system as "file system".

Approved by: re

Minimal change to cause pkg_version to examine the new INDEX-5 file
instead of INDEX. This should be done better since this file name will
depend on the FreeBSD major version.

Assume that packages passed on stdin are in bzip2 format, not gzip.
(sysinstall depends on this feature for package addition.)

Comment on hard-coded bzip2 usage in the spirit of rev. 1.58.

Clean up a little. Don't need to include fetch.h any more, and I can't
find any consumers of HOSTNAME_MAX.

Break fileGetURL() out into its own file so that pkg_install/lib consumers
pkg_{create,delete} don't need to needlessly link with libfetch.

Whitespace cleanup

getbsize() now takes a pointer to a size_t as its first arg. A pointer
to an int no longer works on an LP64 platform...

Teach pkg_add -r how to find 4.7-RELEASE packages with an appropriate
osreldate.

(Actually, due to differences in package compression formats, I'm
not sure that a -CURRENT pkg_add -r will do the right thing in
this case, once it finds them.)

Make the threatened fts(3) ABI fix. FTSENT now avoids the use of the struct
hack, thereby allowing future extensions to the structure (e.g., for extended
attributes) without rebreaking the ABI. FTSENT now contains a pointer to the
parent stream, which fts_compar() can then take advantage of, avoiding the
undefined behavior previously warned about. As a consequence of this change,
the prototype of the comparison function passed to fts_open() has changed
to reflect the required amount of constness for its use. All callers in the
tree are updated to use the correct prototype.

Comparison functions can now make use of the new parent pointer to access
the new stream-specific private data pointer, which is intended to assist
creation of reentrant library routines which use fts(3) internally.

Not objected to in spirit by: -arch

Update to use *.tbz suffix, also update example URL.

While I'm here, fix a gramm-o.

PR: 42576
Submitted by: Jeff Ito <jeffi@rcn.com>
MFC after: 1 day

Sigh, finally activate pkgwrap.c.

Big pointy hat to: sobomax (who apparently needs some sleep)
Submitted by: walt <wa1ter@hotmail.com>

Fix minor off-by-one error.

Submitted by: jhb

Make pkg_install go to the right place for 4.6-RELEASE and 4.6.2-RELEASE
packages.

Pointed out by: obrien
Reviewed by: jhb

Introduce notion of the package tools revision and allow to wrap all tools
included into pkg_install according to the content of /var/db/pkg_install.conf
file, which specifies version and alternative location of the tools. Format
of the said file is very simple: one line which specifies revision of the
alternative version of the tools and their location separated by space,
i.e.:

20030102 /usr/local/sbin

This would allow bsd.port.mk to install and use up to date version of tools
on older system from ports.

Also add new `-P' flag to pkg_info, which causes it to report currently
installed version of package tools.

Discussed with: will

Kill debugging line occasionally slipped into rev.1.3.

Submitted by: reg

Vastly decrease amount of memory comsumed in the case when we have to read
ports/INDEX, by allocating eactly amount of memory necessary for storing
each particular entry, insdead of 4K per entry (more than 7000 entries -
go figure). Memory consumption went down to some 500K from some 30M.

Use --fast-read mode to extract metadata from package file. Since metadata
files are located at the very beginning of the package, this patch in
conjuction with latest tar(1) --fast-mode fix greatly speeds up pkg_info(1)
operation on package files.

MFC after: 1 week

When installing package from a local file assume that all subsequent
autoinstalled dependencies will have the same extension, not just
".tbz".

Pointy hat to: obrien
X-MFC after: -1 day

Don't treat unknown commands as fatal errors: they are probably just
the signature of out-of-date pkg_tools and newer packages.

Reviewed by: jkh
MFC after: 3 days

Don't dump core on packages with an invalid or empty PLIST.

Reviewed by: markm

Grrr.... mumble.... a linger gzip'ism still existed.

Submitted by: Craig Rodrigues <rodrigc@attbi.com>

Reorg just a tad to better express our bzip intentions.

Find remaining hardcoded gzip bits and change to bzip2 bits.
Mark with XXX so someone that cares about being able to handle either
bziped or gziped packages knows where the remaining nits are.

Preserve suid/gid permissions when extracting packages remotelly
fetched with -r option

Reviewed by: will
Approved by: will

Ensure that origin field in the packing list structure is initialised. This
fixes problem when there are origin-less packages installed on a system

Reported by: Mark Knight <markk@knigma.org>
MFC after: 3 days

Fix typos; each file has at least one s/seperat/separat/
(I skipped those in contrib/, gnu/ and crypto/)
While I was at it, fixed a lot more found by ispell that I
could identify with certainty to be errors. All of these
were in comments or text, not in actual code.

Suggested by: bde
MFC after: 3 days

Another .tbz2 -> .tbz leftover. Properly look for pkgname.tbz.

MFC after: 1 day

Drop support for the .tbz2 suffix. One would not want pkg_create(1)
to create "pkgname.tbz" when one specifies "pkgname.tbz2".

MFC after: 1 week

Use an 8.3 friendly extension when compressing with bzip2.

When extracting package pass `-p' option to tar(1), so that files are
extracted with correct permissions.

C replacement for the Perl5 code.

Submitted by: reg

Reorder libraries to fix static linking (libssl depends on libcrypto, so
it must come before libcrypto in LDADD)

Reviewed by: bde

libfetch now depends on libcrypto and libssl.

Grammar nit.

Submitted by: keramida

pkg_version was incorrectly claiming that 1.5 == 1.5.0.1, because
we weren't properly checking for the case that the two version strings
being compared had different numbers of components. This has been
fixed.

Pointed out by: sobomax
Reviewed by: silence on -ports

mdoc(7) police: markup nits.

MFS: two more testcases highlighting recently discovered problem with version
comparison routine.

Eliminate free'ing already freed chunks.

MFC after: 1 week

MFS: silence compiler warnings.

Remove cross reference to pkg_update(1).

Submitted by: dd

Consistancy check: s/file system/filesystem/g

- Make use of DEPOROGINs (if there are any) when installing package;
- fix few bogosities here and there;
- move some common routines into the library.

MFC after: 2 weeks

Mark all internal libraries with INTERNALLIB.

Remove cross reference to pkg_update(1).

replace __FUNCTION__ with standardized __func__.

Requested by: jhb

fix build:
you may not use string concatination with __FUNCTION__, replace all occurances
of:
__FUNCTION__ ": error string"
with:
"%s: error string"

When packing installed package into a file (pkg_create -b) make sure to
include all package files into resulting tarball.

PR: 34007
Submitted by: olgeni

While I here:

- Remove bogus comment;
- ensure that we return the proper exit code in the case of -b failure.

MFC after: 5 days

Do my bit for the Perl removal team and shoot my own, rather mangy
looking, dog.

New feature: allow origins of all dependencies be recorded into package list
using new `@comment DEPORIGIN:...' directive. This would allow us to make
many neat things including:

- easier binary upgrades;
- source upgrades without using external tools by simply extending
bsd.port.mk and pkg_install tools;
- mixed-mode upgrades (source + binary);
- depreciate and deorbit silly +REQUIRED_BY files in the near future.

This feature is no-op until appropriate bsd.port.mk patch is committed, and
even when it is already committed packages generated will remain 100%
compatible with old set of pkg_install tools (module all those neat
features, of course).

MFC after: 6 days

In a origin lookup mode (-O) don't bail out when encountering empty package
directory, because this prevent this option from being used from the
package-depends target of bsd.port.mk since it creates such empty dir
during its normal operation.

MFC after: 6 days

Update usage() and manpage to match reality (add -O into usage and adjust
both to make clear that -W and -O are stand-alone options).

MFC after: 6 days

Use PLIST_ORIGIN instead of rolling own version using PLIST_COMMENT.

MFC after: 6 days

Handle PLIST_ORIGIN properly.

Poked by: kris
Pointy hat grabbed by: sobomax
MFC after: 6 days

Add ability to query installed packages based on origin.

Make pkg_info working again when argument is a file not in the current
directory.

PR: 37571
Submitted by: Dirk Meyer <dirk.meyer@dinoex.sub.org>
MFC after: 1 week

Make `-g' working for symlinks.

PR: 33857
Submitted by: darren <igla@batterybackups.net>
MFC after: 1 week

Kill local variable which shadows global one. This fixes creation of bzip2
compressed packages broken in the previous commit.

Pointy hat to: obrien

Improve the Bzip2 handling.

Sponsored by: FreeBSD Mall, Inc.

Use `The .Nm utility'

DTRT for packages read from STDIN:

$ cat pkg.tgz | pkg_add -

The above command line will fail on -CURRENT or -STABLE, and
therefore, so will sysinstall if you try to install additional
packages through the network (FTP) from a multiuser system. Because
of the different environment during installation (wrt the playpen),
this bug does not manifest itself during initial installs, and users
may install packages from the network just fine at that time.

This bug was fixed in OpenBSD 4 years ago.

----------------------------
revision 1.4
date: 1998/04/07 05:56:13; author: marc; state: Exp; lines: +13 -8
fix package input from standard input -- the program tried to process
stdin twice. Note: it assumes stdin is a compressed tar file.
----------------------------

PR: conf/36606
Obtained from: OpenBSD
MFC after: 2 weeks

Fix SCM ID's.

Use some black make(1) magic to make pkg_install build even without
Makefile.inc in parent directory (e.g. when checked out from cvs as a module).

MFC after: 2 weeks

Make sortdeps() working with dependency lists containing one or no elements.

Submitted by: roam
MFC in: 1 week

Provide protection against incorrect input (dependency list).

Submitted by: roam

Pass `-9' flag to gzip(1), so that package is compressed using maximum
compression. Usually this gives gives extra 1-1.5%.

MFC after: 1 day

Add pkg_update to the SEE_ALSO manpage of pkg_create.

PR: docs/33666
Submitted by: Tom Rhodes <darklogik@pittgoth.com>

Choose more paranoid modes for the temporary directory so the user can't
easily browse its contents.

Noted by: Antoine

Improve recently committed fix for -t bug.

Submitted by: "Andrew L. Neporada" <andr@dgap.mipt.ru>
MFC after: 3 days

Make `-b' option actually work as advertised.

Increase the number of packages that can be installed by an order of
magnitude. Geez, this is Unix, what is with the arbitrary needless
constants.

Fix "off by 1" error introduced in the previous commit by replacing strncpy(3)
with strlcpy(3).

MFC after: 2 weeks

Use strncpy(3) instead of strcpy(3) to copy optarg into a fixed-sized buffer.

Prompted by: dd
MFC after: 2 weeks

The user wants to ensure, not insure, that the package isn't going to
damage their system.

Make `-t' flag in pkg_*(1) tools actually working.

PR: 30843
Submitted by: Vladimir B. Grebenschikov <vova@express.ru>
MFC after: 2 weeks

- Introduce a notion of `packing list format version'. This allows making
non-backward compatible changes in the format of packing list and handle
them gracefully;
- fix a longstanding issue with symlinks handling. Instead of recording
checksum for the file symlink points to, record checksum for the value
returned by readlink(2). For backward compatibility increase packing list
format minor version number and provide a fallback to a previous behaviour,
if package in question was created with older version of pkg_* tools;

Submitted by: Alec Wolman <wolman@cs.washington.edu>, sobomax

- don't record MD5 checksum for device nodes, fifo's and other non-regular
files.

Submitted by: nbm
MFC in: 2 weeks

WARNS=2 cleanup.

Tested on: i386, alpha
MFC after: 2 weeks

OOPS, delete some commented out debugging code committed along with r.1.25.

MFC after: 2 weeks

- Allow package archive to be created from a locally installed package. This
allows for an easy way to backup old version of port prior to installing
a new one;
- silence compiler warnings by killing some unused variables and adding
all includes necessary.

MFC after: 2 weeks

Various fixes and improvements:
- fix harmless compiler's warnings (unused variables and missed prototype);
- before refusing to delete package because "there are packages installed
that require this package" check that packages in question is actually
installed;
- add new `-r' option to pkg_delete(8), which instructs it to delete not only
packages specified at command line, but all packages that depend on
specified packages as well.

MFC after: 2 weeks

Drop maintainership.

Support the use of ${PORTSDIR} to find a ports tree INDEX file in
an other-than-default location.

PR: bin/30350
Submitted by: "NINOMIYA Hideyuki <NINOMIYA Hideyuki" <nin@jp.FreeBSD.org>
MFC after: 3 days

Fix segfault introduced in previous commit (when adding local packages).

Use a colon to separate the user and group when executing chown(1).
Periods aren't supported anymore.

PR: 30507
Submitted by: Georg-W. Koltermann <gwk@sgi.com>

Fixes problem with pkg_add -r when adding multiple pkgs.

Reviewed by: chris

Handle snprintf() returning < 0 (not just -1)

MFC after: 2 weeks

Handle snprintf() returning -1.

MFC after: 2 weeks

Remove duplicate umask(2) call.

PR: dusty/7998
Submitted by: Stefan Eggers <seggers@semyam.dinoco.de>
MFC after: 2 weeks

Spell "FreeBSD" with "F" and "BSD" in uppercase.

Reduce private "lesser known" function redirection to improve clarity.

Approved by: jkh

mdoc(7) police: protect trailing full stops of abbreviations
with a trailing zero-width space: `e.g.\&'.

Recognise @option directives instead of falling through to the default
"unknown command" clause.

PR: 29262

exists(../../crypto) --> exists(${.CURDIR}/../../crypto)

MFC after: 1 month

fix for pkg_add to symlinked prefix directories that are more than 1 link deep.

PR: bin/28274
Submitted by: John Hein <jhein@timing.com>
MFC after: 1 month

Cosmetics: replace dozen instances of "(tmp = getenv(PKG_DBDIR) ? tmp : DEF_LOG_DIR)"
with macro.

MFC after: 1 month

Cosmetics: kill blank lines at the end of file.

MFC after: 1 month

Usability tweak:

Use '' quotes instead of `' to delimit names of files and packages in
warning and error messages, because it is easier to cut-n-paste name in
question that way (single click) without confusing the shell. And yes,
I know that it is less eye-candy...

MFC after: 1 month

When there is a file that can't be deleted due to checksum mismatch print name
of that file to stdout to simplify debugging. IMO it was a mistake to print
this warning only when `verbose' mode is on.

MFC after: 1 month

The security officer requested this be backed out for discussion.

Remove s_strl*(). I am not sure what was thought they accomplished.

When reading the code I had to stop, say "ok, what does *these*
modifications of strl*() do? Pull out grep. Oh, not in add/, maybe above
in ../lib/? Yep. So what do they do? Comments above them are misleading,
guess I'll have to read the code. Oh, they just test strl* against the
size and return the result of the test. Now I can continue to read the
code I was.

The uses of s_strl*() then test that result and errx()'s.
Lets think about the "optimized" code I am removing:

In general the compiler pushes the three args to strl* onto the stack and calls
s_strl*. s_strl* has to indirectly access 3 args from the stack. Then push
them on the stack a 2nd time for the real strl* call. s_strl* then pops the
return from strl* off the stack; or moves it from the register it was returned
in, to the register where tests can happen. s_strl* then pops the three
arguments to strl*. Perform the test, push the result of the test, or move it
from the result register to the return value register. The caller to s_strl*
now has to either pop the return value of s_strl* or move it from the return
value register to the test register. The caller then pops the three args to
s_strl* off the stack (the same args that s_strl* itself had to pop off after
the real call to strl*). The s_strl* caller then performs a simular test to
what has already been done, and conditionally jumps. By doing things this way, we've given the compiler optimizer less to work with.

Also, please don't forget the that call to s_strl* has possibly jumped to code
not in the cache due to being far away from the calling code, thus causing a
pipeline stall.

So where is the "optimization" from s_strl*?
It isn't code clarity.
It isn't code execution speed. It isn't code size either.

Only match the first osreldate date range for constructing the FTP URL,
not all of them.

Noticed by: obrien

Use reallocf(3) to increase size of malloc'ed buffer instead of
malloc()+memcpy()+free().

Perform a major cleanup of the usr.sbin Makefiles.
These are not perfectly in agreement with each other style-wise, but they
are orders of orders of magnitude more consistent style-wise than before.

Correct a reversion in r1.39 which introduced a new instance of strcpy()
after r1.38 had attempted to remove them all.

Remove whitespace at EOL.

mdoc(7) police: removed HISTORY info from the .Os call.

bzip2(1) is in the base system - we don't need /usr/local/bin in the PATH
anymore.

mdoc(7) police: remove extraneous .Pp before and/or after .Sh.

Fix the type of the NULL arg to execl()

Idea from: Theo de Raadt <deraadt@openbsd.org>

Fix usage bogon (-d doesn't take any arguments).

MFC after: 3 days

Add a -s option to pkg_version, which limits output to packages
matching a given string.

PR: 26114
Submitted by: edwin@mavetju.org (with modifications and manpage update)
MFC after: 3 days

Use getdtablesize() instead of OPEN_MAX.

Submitted by: bde

Properly quote recursive pkg_add operations so that filenames with
spaces or special characters in them won't barf.

Check for the existence of the Makefile in the port skeleton directory
before running make. If the package origin points to a non-existent or
stale port, report this package as orphaned, instead of producing more
general `unknown in index' message.

PR: 27707
Submitted by: myself, roamer
Approved by: bmah, markm

Pass on the verbose option to fetchGetURL().
In the child that's set up to run tar(1), close all file descriptors except
stdin, stdout and stderr.

PR: bin/27760

Fixed pkg_add so when it does not find a package, it returns != 0.

PR: bin/23083
Submitted by: Patch submitted by Maxime Henrion <mux@qualys.com>
MFC after: 2 weeks

Cross reference pkg_update(1).

Approved by: murray

Style policy: reformat multiline comments to conform to style(9).

Print longer package names. Some of them were running off the right
edge of Perl field specifications.

PR: bin/26664
Submitted by: philip@eilio.com
MFC after: 3 days

Fixed a missing library in DPADD.

Fixed some style bugs.

Clean up some of the evil string handling in this code, replace
warnx()+exit() with errx() and replace a big if..then..else construct
to determine the package download directory with a lookup table.

Reviewed by: jkh
MFC after: 2 weeks

rcsid style fix.

A WIP snuck in the rev 1.34 commit.

The pkg_version -c output will now call for a "make clean" before and
after the port build/install. The former cleans up "dirty" port work
directories that happen to be lying around, and the latter cleans up
after we're done so that they won't trip up someone else.

PR: ports/25106
Submitted by: tim@bishnet.net, nik, mwm@mired.org

Fix typo in prev commit - add missing comma

Add /usr/X11R6/bin to the exported PATH. If /usr/local/bin is there,
/usr/X11R6/bin should be there. This helps all the ports that need to
run `mkfontdir' and error out as many port maintainers do not realize
`mkfontdir' isn't in the path.

Prompted by: pkg_add pcemu

Don't build pkg_sign tools if crypto is not installed, or is not
being built.

Reviewed by: kkenn

Fix a problem with tests of the form "1.0" vs. "1.0a".
MFC candidate.

Pointed out by: knu

beforeinstall -> SCRIPTS.

mdoc(7) police: .Nm remembers its argument on the first call.

Implement a package number comparison routine for pkg_version(1)
that actually conforms to the Porters Handbook.

Add a -t option to pkg_version(1) for doing comparison testing.

Add a script (and make test target) to do some regression tests on
the package number comparison routine, to help debug future revisions.

Submitted by: knu
Procrastination by: bmah

- Backout botched attempt to introduce MANSECT feature.
- MAN[1-9] -> MAN.

Decapitalise first letter of warning message.

In which(1) mode resolve "/../", "/./" in arguments and PLIST contents. This
is done without realpath() to avoid symlinks resolving.

Submitted by: sobomax, Garrett Rooney <rooneg@electricjellyfish.net>

- Add which(1)-like functionality into pkg_info;
- fix a harmless bug in match_installed() function introduced in my last
commit;
- uniformely reorder includes across files.

Submitted by: Garrett Rooney <rooneg@electricjellyfish.net>
Not objected by: jkh, -ports

Set the default manual section for usr.sbin/ to 8.

When creating a package sort dependencies in such a way that if dependency
A depends on dependency B then dependency A will be in all cases listed
before B, so ``pkg_add -r'' will fetch/install packages in the correct order.

Previously dependencies were sorted just by its names, which is why
``pkg_add -r'' never actually worked properly.

To be usefull, hovewer, this fix requires that all packages have been
rebuilt, so it will take some time until users would be able to feel
posititive improvements. For the same reasons it is desirable to propagate
these changes to the 4-stable package building cluster *before* 4.3 ports
freeze, so packages for 4.3-RELEASE would be properly prepared.

Prompted by: kris
Insanely appreciated by: obrien
Silently approved by: jkh, -ports

When matching installed packages against glob keep track of which patterns
actually triggered a match and which did not, and add patterns that didn't
into resulting list, so caller will have a chance to notify user that package
isn't installed. This should fix current, POLA-breaking behaviour when user
doesn't receive a notification if he specifies several packages, some of which
aren't installed.

Change check_sign to proper "pkg_sign" reference.

Noted by: Andrew Hesford <ajh3@chmod.ath.cx>

mdoc(7) police: misc markup fixes.

Build package signing tools if OpenSSL is included in the build.

Prodded-by: kkenn, this time.

When called with the "-n" command line argument, pkg_delete
is supposed to inform the user of all steps it would take.

The current code does not issue any messages regarding actions
that would be performed by delete_package (removing files and
executing @unexec commands), because when the Fake variable
is 1, delete_package (which itself respects Fake and prints
messages rather than taking action when it is 1) is not called
at all.

Fix this.

PR: bin/24971
Submitted by: Thomas Quinot <thomas@cuivre.fr.eu.org>

Put back several lines that I erroneously deleted in my previous commit. This
should fix recent segfault of `pkg_info -e'.

Submitted by: Garrett Rooney <rooneg@electricjellyfish.net>, knu

Eliminate mdocNG warnings caused by misplaced or extraneous macro calls.

Properly detect and report malloc(3) failures.

- Merge recently added into pkg_info(1) regex/glob matching functionality into
pkg_delete(1) as well;
- add a new `-a' option for pkg_delete(1) to delete all installed packages;
- add a new `-i' option for pkg_delete(1) to request simple rm(1)-like
interactive confirmation before attempting to delete each package.

Silently approved by: jkh, -ports

Add two missed modifiers into usage message (`-G' and `-x').

Fix a typo, that in some cases may lead to incorrect packages reordering.

Use the more logical author syntax from pkg_version and quote
email addresses properly.

Improve pkg_delete(1) behaviour when deleting several packages at once.

Instead of trying to delete packages in the same order as they were specified
in the command line, reorder deletion in such a way that if package A depends
on package B then package A will be deleted before B no matter in which order
they were specified in the command line.

Reviewed by: jkh, will
Approved by: jkh

MFS: getpackagesite() from RELENG_4 that allows the code to be the same.

mdoc(7) police: sanitize previous commit.

In light of the dismal transfer times from ftp.FreeBSD.org, add a new
`PACKAGEROOT' env var which you would set to a proper mirror of
ftp.FreeBSD.org (say "export PACKAGEROOT=ftp://ftp3.FreeBSD.org"), to
fetch from an alternate place. This is easier to use than `PACKAGESITE'
for true mirrors, and can be used in your dot files across all versions
of FreeBSD.

Prevent the commands output of pkg_version.pl from being executed without the
user actually editing the output. Too many people were rampantly abusing
this feature via "pkg_version -c | sh" without really being cognizant
of the dangers involved (ports upgrade kits) or the fact that it
just plain wasn't designed for it (dependencies). We'll try to keep
people from shooting themselves in the foot.

Will be MFC-ed to RELENG_4 and RELENG_3 after cooling-off period.

mdoc(7) police: cosmetics.

- By default treat supplied arguments as a shell globs to be matched against
names of installed packages;
- add new `-G' option to disable glob matching and revert to previous
behaviour (I have no idea why this could be necessary, though);
- add a new `-x' option, which instructs pkg_info(1) to treat supplied
arguments as a regular expressions.

For example:
$ pkg_info foo\* - displays information about all packages whose names start
from foo
$ pkg_info -G foo\*-1.1 - displays information about package named "foo*-1.1"
$ pkg_info -x ^foo.\* - displays information about all packages whose names
start from foo

Original idea submitted by: Edwin Groothuis <mavetju@chello.nl> (bin/24695)
Reviewed by: jkh, roam
Approved by: jkh

mdoc(7) police: Change -filled displays (which just happen
to be the same as -ragged in the current implementation) to
-ragged. With mdocNG, -filled displays produce the correct
output, formatted and justified to both margins.

Fix typo: seperate -> separate.

Seperate does not exist in the english language.

Add package signing utilities; somebody might actually want them.
These are not enabled in the pkg_install Makefile as of yet;
adding the "sign" directory to the SUBDIR list will enable
building of sign.

Submitted by: Wes Peters
Obtained from: Original framework from OpenBSD 2.7, X.509 bits from DoBox.

-pedantic mode:
- Add a missed prototype for the recently added show_cksum() function;
- put in "explicit braces to avoid ambitious else" suggested by gcc(1).

Add a -g flag for verifying an installed package against its recorded
checksums (to see if it's been modified post-installation). Naturally,
this mechanism is only as secure as the contents of /var/db/pkg if you're
using it for auditing purposes.

Submitted by: Roman Shterenzon <roman@xpert.com>

mdoc(7) police: split punctuation characters + misc fixes.

Make `-y' option actually work.

Submitted by: reg

Use .Pa instead of .Dq.

Submitted by: ru

- Add ability to handle bzip2-compressed packages;
- fix cosmetics to shut-up compiler in -pedantic mode (axe several unused vars
and provide default clause in several switch() statements).

No response from: -ports

mdoc(7) police: removed leading whitespaces that are not inside
Bd/Ed; these hardly degrade the quality of the produced output.

Prepare for mdoc(7)NG.

- Fix a nasty bug where pkg_create doesn't gzip package if lengh of package
name is less than 5 and doesn't contain recognizeable suffix (one of .tar or
.tgz), while gzip's it if lengh of the name greater than 4. For example
`pkg_create [options] pkg1' will create pkg1.tar, while
`pkg_create [options] pkg11' will create pkg11.tgz;
- use TRUE/FALSE as a values for boolean variables instead of explicit 1/0 and
erroneous YES in one case.

MFC candidate.

Fix a bug arised from the ')' in the wrong place when calling printf()-like
varargs function, which lead to one of the arguments was left out. This resulted
in failure when inwoking mtree, warning message "mtree returned a non-zero
status - continuing" and probably is the reason for zillion mtree errors on
bento.

Fix a nasty bug whereby if the package file didn't have a version number
then all packages would be deinstalled!

The tightening up of version number checking also fixes a bug where
a package file such as gtk.tgz would have resulting in gtk-engines
being deinstalled.

Fix a bug where pkg_create does not make an md5 entry for the last item in
the packing list. Also use switch() instead of zillion "else if ()" and for()
loop instead of while() loop for traversing through linked list.

MFC candidate.

Submitted by: Alec Wolman <wolman@cs.washington.edu>

Change open modes from ">$file" to "> $file" because it's much safer should
$file not be what you expect, particularly should $file turn out to be
"+REQUIRES" since ">+" is a valid open mode.

This isn't currently a problem since $file is constructed safely but it removes the potential of future problems.

Pointed out by Anton Berezin.

mdoc(7) police: get rid of hard sentence breaks, add missing .El, etc.

Fix the broken options that were in the development version I committed by mistake.

Bring the man page up to date with the current version of the script.

Add pkg_update, which can replace currently installed ports with new versions
while taking of updating all the dependencies.

Prepare for mdoc(7)NG.

mdoc(7) police: removed history info from the .Os FreeBSD call.

Add `_PATH_DEVZERO'.
Use _PATH_* where where possible.

Alphabetically reorder options in `.Op Fl' macro to be consistent with the
rest of the code.

- Add missed `-s' option into usage printout;
- sort options alphabetically.

mdoc(7) police: use the new features of the Nm macro.

mdoc(7) police: use certified section headers wherever possible.

Use Fx macro wherever possible.

Insetad of using fileno(ftp) as stdin for tar, use a pipe and have the
parent pass the data received from the server to the child.

Sigh. It'd be nice to completely commit a bugfix. Once again:

Fix a bug in which pkg_version(1) was ignoring $PORTREVISION
or $PORTEPOCH from ports' Makefile definitions.

Fix a bug in which pkg_version(1) was ignoring $PORTREVISION
or $PORTEPOCH from ports' Makefile definitions.

Utilize the "-o" (origin) option recently added to pkg_create(1)
and pkg_info(1), for more accurate determination of the
"up-to-date-ness" of installed packages.

Add "-o" option to pkg_create(1) and pkg_info(1). This option intended to record
a path of the port from which package has been created within FreeBSD Ports
Collection and will be used to improve pkg_version(1) and similar tools.

Reviewed by: ports@FreeBSD.org, jkh
Approved by: jkh

Cause fatal error messages to be a little more helpful to the programmer
concerning where they're taking place.

Switch from [r]index() to str[r]chr() functions, which are more ISO
compliant.

Prompted by: Edward Welbourne <eddy@vortigen.demon.co.uk>

Add -L option to limit the package status characters the user *doesn't*
want to see.

Submitted by: Doug Barton <DougB@gorean.org>

Make pkg_version -c -l work.

PR: bin/19019
Submitted by: Stijn Hoop <stijn@win.tue.nl>

Trim index lines down to 79 characters, not 80.

Approved by: jkh

Fix typo

Make the ``-r'' option actually do something :)
Also tidy up it's output.

Approved by: jkh

Fix symlink-to-a-dir handling in pkg_delete.

Reviewed by: -ports
Tested by: bento

pkg_version(1) will now distinguish between the different cases where
the exact relationship between an installed package and its
corresponding entry in the index file can't be determined.

Submitted by: Mark Ovens <marko@freebsd.org>

Arrgh. Back out a change used during debugging and fix a typo.

Remove a workaround for a long-fixed bug in fetch(1).
Update URL for on-line Ports Collection INDEX file.

pkg_version.pl now understands the new package/port numbering scheme
introduced by version 1.349 of ports/Mk/bsd.port.mk and originally
submitted by kris.

In particular, it understands the $PORTREVISION (FreeBSD-specific changes
or patches to a port) and $PORTEPOCH (for re-sorting version numbers
when not used or when broken).

Update my email address in various places in pkg_version.

Now that Bruce Mah is a committer, retire my co-maintainership
of pkg_version.

Fix bug with -c option

PR: 18176
Reviewed by: Bruce A. Mah <bmah@acm.org>

New option "-s" to query size of the installed package(s).

PR: 19445
Submitted by: sobomax
Reviewed by: knu
Approved by: silence

Use libfetch instead of libftpio. This adds support for http and IPv6.

Use `rm -f` if the -f (force) option was given.

Avoid infinite loops when given a package name like 'm4-1.1/'.

Approved by: jkh

Finally remove the restriction introduced from NetBSD in r.1.3 that
pkg_delete be run as root. Now honours -f and checks ownership of
${PKG_DBDIR} before errx()'ing.

Requested by: bin/5718, myself, bin/18373 (in order)

Do not preserve UIDs, permissions nor flags of package system files in
tar files. This fixes clean-up problems during package creation and
does not affect the actual files to be included in the package.

The fix submitted on the attributed PR was identical to the one
obtained from NetBSD.

PR: 17386
Reported by: Adrian Filipi-Martin <adrian@ubergeeks.com>
Obtained from: NetBSD

-CURRENT is now 500000, reflect that.

Remove single-space hard sentence breaks. These degrade the quality
of the typeset output, tend to make diffs harder to read and provide
bad examples for new-comers to mdoc.

Add cross references to pkg_version(1) in all the other pkg_* man pages.
Also, add a cross reference to pkg_info(1) in pkg_version(1). Finally,
in pkg_version(1), don't put a period at the end of the list of see also
man pages.

Noticed by: Matt Ayres <matta@fast.net>

pkg_create doesn't use more(1) for displaying +DISPLAY files, it
just cats it to stdout.

1. If checking for directory-ness, check "dir" and "dir/" to catch
the case where we have a symlink pointing at a dir.

2. Restore stomped character before returning in make_hierarchy()

1. If checking for directory-ness, check "dir" and "dir/" to catch
the case where we have a symlink pointing at a dir.

2. Restore stomped character before returning in make_hierarchy()

While looking for a bug, tripped over style issues with added
code. Fix them.

Use lstat(2) rather than stat(2) in isdir(), so that a symlink to a
directory is not considered a directory. I have a feeling all the other
stat(2) calls should instead be lstat(2) calls, but I have not suffiently
determined that the current behavior [especially in isfile()] isn't
depended upon by someone.

Ok'ed by: JKH

Grammar fix: ``Different than'' should be ``different from''.

Fix a bug in previous commit where pkg_{delete,info} foo-1.0/ would segfault.

Noticed first by: kris

Teach pkg_delete and pkg_info how to deal with full pathnames
(/var/db/pkg/foo-1.0, instead of just foo-1.0).

Submitted by: Matthew D. Fuller <fullermd@futuresouth.com>

Fix bogon in previous commit: pass a string argument to printf(3) to
satisfy the %s conversion format specifier.

Reported by: Mark Huizer <freebsd@xaa.iae.nl>

Use a more helpful fatal error message than "Toto! This doesn't look
like Kansas anymore!" when unable to return to the original working
directory.

PR: bin/16015

Include -f and -t options to SYNOPSYS section (manpage) and usage information
(main.c)

PR: bin/5410
Submitted by: Frank Volf <volf@oasis.IAEhv.nl>

Deal with package filenames which contain spaces.

Submitted by: Ming-I Hsieh <mihs@wm28.csie.ncu.edu.tw>
PR: 15667

Redirect stdout from mtree to /dev/null; we don't really need to know
the list of directories being created when we install a package.

Only pkg_delete the old package if the new one builds properly.

Submitted by: Dan "The Bug" Bugg <bugg@bugg.strangled.net>

Add '-l' which will match a certain status code.
Add the submitter as a contributor in the man page
freebsd -> FreeBSD, while I'm poking around.

PR: bin/15162
Submitted by: Dominic Mitchell <dom@palmerharvey.co.uk>

Correct co-MAINTAINER's e-mail address. I don't know how many
more ways I can screw his address up. Suggestions welcome.

Install man pages in the right place. This is what I get for cheating
and copying a Makefile from another directory over to this one.

PR: docs/15140
Submitted by: Kazuo Horikawa <horikawa@jp.FreeBSD.org>

Add the author as co-maintainer, a la mergemaster.

Welcome pkg_version into the FreeBSD source tree.

pkg_version (as you may well know) matches the existing packages/ports
installed on your system with the ports INDEX and reports which
ports differ from the current INDEX.

Submitted by: Bruce A. Mah <CA.Sandia.GOV>
Reviewed by: ports

Make `pkg_add -r package1 package2 package3 ...` work correctly.

Reviewed by: billf

o Remove all of the objformat logic, it's never coming back.
o Simplify getpackagesite(), it comes back in full glory when we branch
again. It's still needed however to get the i386 or alpha directory.

Document the fact that pkg_add/delete passes INSTALL/DEINSTALL
respectively to rscript.

Use the appropriate macro for double quotes rather than using double
quotes.

Submitted by: Alexey Zelkin <phantom@cris.net>
PR: 13436

Remove some $Log$ debris

$Header$ -> $FreeBSD$

$Id$ -> $FreeBSD$

Various man page cleanup:

- Sort xrefs.
- FreeBSD.ORG -> FreeBSD.org
- Be consistent with section names as outlined in mdoc(7).
- Other misc mdoc cleanup.

PR: doc/13144
Submitted by: Alexey M. Zelkin <phantom@cris.net>

-Wall fixes. Ambigious if/elses, uninitialized values, missing headers,
missing prototypes, and empty format strings.

When listing the installed packages, do it in alphabetical order.

Add $Id$, to make it simpler for members of the translation teams to
track.

The Id line is normally at the bottom of the main comment block in the
man page, separated from the rest of the manpage by an empty comment,
like so;

.\" $Id$
.\"

If the immediately preceding comment is a @(#) format ID marker than the
the $Id$ will line up underneath it with no intervening blank lines.
Otherwise, an additional blank line is inserted.

Approved by: bde

'?' shouldn't be in the usage string. Unknown characters are already
converted to '?'.

If we are going to have a case for '?' then we should define it in Options.

Submitted by: Ben Olson <bseth@chc-chimes.com>

Support Alpha and -CURRENT in the "-r" option case.

where_arge is allocated on stack and return address is overwritten
by buffer overflow.

Submitted by: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp>

Revive the PKG_ADD_BASE stuff a bit.

If pkg_info is run with no args, default to "-aI".

Removed occurrences of consecutive repeated words (such as "the the").

Fix nasty bug where getpackagesite() will return an integer if it doesn't
know what revision of FreeBSD is being run. This case should never happen,
but just in case.

Numbering typo, missed a '0'

Submitted by: Brian Feldman

Update pkg_add's remote package feature to reflect the new structure of
wcarchive. This needs to be updated when:

(a) The directory structure changes on wcarchive
(b) getosreldate() has a new significance
(ie. get ELF packages/get a.out packages)
(c) Branches are changed around

As we stand right now, 3.0-postELFday and 4.0-x all point to the same
directory, but when 4.0 starts to have its own packages, this file will
need to be changed.

Style police, inline ifs.

Submitted by: Brian Feldman <green@unixhelp.org>

enviornment -> environment
PR: docs/9534
Submitted by: rv@fore.com

Add a new option for pkg_add, -r.

The remote option allows for automatic package fetching and installation
using the package repository found on wcarchive. Naturally, this site
can be overridden with a enviornment variable.

This code uses getobjformat() and getosreldate(). This means when some event
causes the package to be fetched to change (such as e-day) the logic also
needs to be changed.

Sorta reviewed by: jkh
Code suggestions: peter, jkh, eivind, msmith

document PKG_DBDIR
Add ENVIRONMENT and FILES sections.

change wording slightly to match other pkg_*.1

Make it possible to have separate install scripts as well as have
an on-delete script.

Submitted by: Rajesh Vaidheeswarran <rv@fore.com>

Fix support for uncompressed (".tar") package types. It's not completely
fixed (chained dependency checking for pkg_add is broken, for one thing)
but at least you can now create one package and use it.

Fix bug where trailing slash could confuse the registry removal.

Noticed by: des

Unlink old contents of package when extracting new.
Submitted by: pst

Revert 1.33; lstat() is indeed the wrong thing to do here. I'll
revisit this after release.

Correct a misleading comment.

Use lstat() rather than stat in determining whether a file exists,
otherwise we'll miss the "symlink exists but points nowhere" case.
Submitted by: asami and/or possibly <ru@ucb.crimea.ua>

Use a more reasonable default umask in case the root umask is too
fascist.
PR: 4014

correct usage of cleanup() everywhere - this became bogus when the warnx/errx
stuff was added and nobody seems to have noticed. :)
Noticed by: Josh MacDonald <jmacd@paris.CS.Berkeley.EDU>

o Set paths internally for pkg_add for tools we might want to invoke.
o Fix bogus suffix handling.
o Tell user when an FTP url is being xferred rather than being silent.
This sort of violates "the unix way" but it stops people from whacking
^C when they think it's hung, too. Sometimes visual indication of
success is important. Doesn't spit out anything if not on a TTY.

Fix bogus suffix stripping to be less naive.
PR: 3418
Noted by: pst

Fail as documented when a dependency cannot be found
PR: 7318
Submitted by: djv@bedford.net

Silence potentially bogus warning.

Fix recursive package add problem (for on-disk package files) I introduced
with the change in semantics to make_playpen(). Now package dependencies
more than 2 levels deep should work again. Pass the hat.

Don't exit() from cleanup() if we got there via a non-signal since
we're only going to exit (after printing a more detailed error message)
afterwards anyway.
PR: 7020

Paranoia: use mkdtemp instead of mktemp
PR: bin/3212
Reviewed by: jkh@FreeBSD.ORG

Clarify "Cannot delete file as directory" errmessage.

PR: bin/1985

Avoid race-conditions on playpen delete.

Add $Id$.

PR: 7251
Submitted by: Norihiro Kumagai <kuma@jp.freebsd.org>

Document `-I' and `-R' options to `pkg_info'.

PR: 7155

MF22: check for null pointer.

Document environment variables used by pkg_{add,create,info}. These
include PKG_TMPDIR, TMPDIR, PKG_DBDIR. Add a FILES section to these
manual pages.

PR: docs/7064

Loosely document the '-s' commandline option.

PR: 6713

Fix dependent-package loading when pkg_adding with an FTP URL. I broke
this when I changed the playpen code to disallow recursion. I know
this fixes a PR someplace but I can't seem to find it with the GNATs
search tool.

.Sh AUTHOR -> .Sh AUTHORS. Use .An/.Aq.

Use `foo/bar.a' instead of `-Lfoo -lbar' for linking to static internal
libraries, so that `ld -f' in can create correct dependencies for
yet-to-be-built libraries.

Eliminate the idea of nested "playpens" entirely - it just obfuscated
the code and, in at least one case, made it more dangerous to no gain.

I must have been smoking crack when I made this change. Using sh -c
in a vsystem() call is just a ludicrous way of calling sh -c "sh -c ..."
Whoops! I don't know my own bloody code here!

Quote filenames more agressively.
Reviewed by: jkh
Submitted by: Hubert Feyrer

MF22: fix to install script handling.

MF22: Additional paranoia in cleanup.

Don't assume install script is directly runnable - use sh -c.

"This is the add^H^H^Hinfo module."

Pedantic comment fix.

PR: bin/5188
Submitted by: Alex [3]garbanzo@hooked.net

MF22: Revert part of -p handling.

The prefix override code was bogus. The original idea was sound
enough, but we're not using the pkg_create tool that way anymore
in the ports collection.

PR: 4894
Submitted by: Adrian Colley <aecolley@ois.ie>

Pkg_add refused to process package whose packing list contains @exec/@unexec
before any file names. This change makes pkg_add to process those
packages if @exec/@unexec commands don't contain any %[fFB]. Also
enable @exec/@unexec that have %D if the installation prefix is known to
pkg_add.
Reviewed by: jkh

- do string-magic on the right variable when trying
to find dependent packages on the local disk (i.e. package given as
filename, not URL)
- document $PKG_PATH
- use -v on pkg_add for dependent packages

Submitted by: hubertf@NetBSD.ORG
Obtained from: NetBSD

Deal with PLIST_UNEXEC properly.
PR: 4784
Submitted by: Stefan `Sec` Zehl <sec@quit.42.org>

Don't return from cleanup() - if it's removed the playpen then very
bad things will happen if we return to unsuspecting code.
Noted to my great dismay by: Tim Vanderhoek <hoek@hwcn.org>

Use err(3). Cosmetics in usage string and man page.

Document pkg_add's dependency auto-install. While I'm here, fix
a couple typos, and consistent double-spacing after sentences.

This is actually a spinoff from the "ports-current discontinued"
blow-up some time ago.

Ack'd by: jkh

Many places in the code NULL is used in integer context, where
plain 0 should be used. This happens to work because we #define
NULL to 0, but is stylistically wrong and can cause problems
for people trying to port bits of code to other environments.

PR: 2752
Submitted by: Arne Henrik Juul <arnej@imf.unit.no>

Typo.

Eliminate an annoying message.

Add proper md5 comments to ports-installed packages also by
masticating it through the same routine used by pkg_create.
Submitted by: se

Change the naming conventions for preserve'd files and also document
the option in pkg_create. Now preserved files start with a . and are
named .<filename>.<pkgname>.backup so that their purpose is more clear.

Note that just using the preserve option without proper pkg_deps
is also foolish since packages being deleted in the incorrect order with
preserve on can generate some odd results.

YAMF22 - deletes and preserve option fixes.

Whoops, only attempt to back up the file if it exists. :-}

Add support for @option preserve - moves existing files out of the way
before replacing them (using pkgname to make this hopefully unique).
Delete also moves them back, if they exist, resulting in a package
which can be "backed out" with reasonable safety.

Fix multiple documentation bogons.
PR: 3798
Submitted by: Jan Kuriyama <kuriyama@opt.phys.waseda.ac.jp>

Add support for srcdir overrides.

When no last file specified for % command user barf(error diagnostic)
instead of segmentation fault

Minor typo.
PR: 3473
Submitted by: Josh Gilliam <soil@quick.net>

compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.

Protect against missing initial @cwd. Closes PR#2893
Submitted-By: pius@iago.ienet.com

Close PR#2459

Revert $FreeBSD$ to $Id$

Prevent potential argument buffer overflow.

Fix a bogon with playpen size calculation for pkg of "-". It's amazing
this ever worked, actually.

Put back @owner/@group/@mode behavior I took out way back when.
Submitted-By: pst

Sort cross references.

Make the long-awaited change from $Id$ to $FreeBSD$

This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore. This update would have been
insane otherwise.

Correct a problem which broke +DISPLAY file handling.

Use new ftpGetURL interface, as result, report FTP error
via ftpErrString or net error via hstrerror(h_errno)

Fix PR#1557 - chained package dependencies using URLs didn't work.

Clean up the english a little, having made the mistake of reading it.

Put verbosity in the right place.

Make -force work for pkg_add.

Add MD5 checksums to packing list for all files during pkg_create and use
later at pkg_delete time to verify that you're deleting what you added.
This, of course, does NOT cover the case where a file you still need
hasn't changed! That's a tougher problem to solve, and this provides
only the minimal amount of safety belt. MD5 checksums are stored in comment
fields, so packages produced with these tools are backwards compatible with
the older ones.

Bring in my changes for removing the pestilent obj links (unless you
really want them) from /usr/src. This is the final version of the
patches, incorporating the feedback I've received from -current.

Make pkg_install understand and use libftpio instead of its own
copies of the ftp support routines. Also some cosmetic and minor
bug fixes I've been meaning to incorporate for awhile.

Make a small optimization which shaves about a second off the time
it takes to build the `All' menu in configPackages.

Change min_free to return free space as an off_t instead of a size_t.

fix PR#599
Submitted-By: jdp

Oh my, looks like I didn't understand .B as well as I thought I did! :-)

Correct some man page xrefs, and some other minor changes to bring some
man pages up to mdoc guidelines and fix some minor formatting glitches.
Also fixed a number of man pages to not abuse the .Xr macro to
display functions and path names and a lot of other junk.

Close a file descriptor that I had (harmlessly) left open in a child
process.

Fix a couple of miscellaneous bugs and make pkg_add also support reading
from stdin.

Initialize the argument list in the unpack() routine to zero.
This prevents a core dump due to the stack being trashed if pkg_add
is asked to process something that really isn't a package file.

Another round of man page cleanups.

Down to only about 100 items left to cleanup! :-)

Fix to catch a stupid oversight on my part which allowed this thing
to remove the current directory under certain circumstances.
Submitted by: Richard J Kuhns <rjk@watson.grauel.com>

Fixed pkg_create to eliminate the limits on the size of the PLIST.
Formerly, there were limits on both the number of files (hard-coded into
the program) and the number of characters (because of the ARG_MAX limit
in exec(2)). In this new version, the filenames are passed to tar through
a pipe, using tar's "-T" option, rather than on the command line.

recording cvs-1.6 file death

Bring my pkg_install improvements forward from 2.1.

Fix the `pkg_add relative to .' bug. Thank you, Ville!
Submitted by: Ville Eerola <ville@vlsi.fi>

Bring forward my changes from 2.1

Don't be needlessly verbose in the pkg_create.

Make the play-pen searching routine even more agile in trying
to create a /usr/tmp dir if it makes sense to do so.

Use size_t properly in all fs size ops. This kills a bug
encountered by someone who had his /tmp on a partition with 3.7GB of
free space!
Spotted by: Francisco Rosich Viana <rosich@power.ci.uv.es>

Some fixes to make this "TMPDIR agile".
Submitted by: jmacd + some of my own fixes.

Make "out of space in ${PKG_TMPDIR}" handling a bit more robust.
Print the right thing, do the right thing. Back to you, Satoshi!

Remove useless -lftp arguments from Makefiles.
Suggested by: ache

Round this out. Now seems to transfer packages properly over ftp
as it was supposed to. PKG_PATH more sorely needed than ever now..
Hmmmm.

Argh! I hate my life! I can't seem to do anything right here today.
This should restore functionality to the pkg_install suite.

Sync this up with ftp.c.

Remove dependency on sysinstall.

Add ftp.c to makefile - that might make it work better. Sheesh!

Change the environment variable this looks for from FTP_PASSIVE to
FTP_PASSIVE_MODE. It would be really nice if we could standardise on
this name so that all tools (like ncftp) that offer passive/active
ftp selection would work seamlessly with one user environment variable
setting.

Document how to get pkg_add to use PASSIVE MODE ftp in such transfers.

Totally eliminate the dependency on libftp (which will be removed from the
FreeBSD source tree) and switch to the internal ftp routines developed
by Poul-Henning and used in sysinstall.

o Fix PR# bin/643 - always set "where_to" properly.

o Nuke dependence on libftp - it's about to die!

The default for temporary directory is /var/tmp, not /tmp.

You can run pkg_info everywhere expect /var/db/pkg directory :-)
Running there you got any kind of strange errors from tar caused
by treating directories as tar files!
Fix it by adding new isfile(name) (check for reg. files) to simple fexists(name) calls.

If some files lost in /var/db/pkg/<port>/ after system crash f.e.,
pkg_manage silently dumps core, pkg_info claims about them to
stderr, which makes very difficult to find what directory cause it via
tons of pkg_info -a output. I found solution which covers both variants,
now pkg_info claims about missing files to stdout among valid output
with ERROR: prefix. It heals pkg_manage to not dump core and makes
easy to find errors in pkg_info -a output by simple /ERROR 'more' command.

Fix coredump for -v flag
Submitted by: Thomas Gellekum <thomas@ghpc8.ihf.rwth-aachen.de>
Obtained from:

Use lstat() instead of access() for checking file existence. It works
for symlinks too, and according to Rod, access() is evil anyway.

Reviewed by: jkh

Merge RELENG_2_0_5 into HEAD

Remove trailing whitespace.

Only apply @mode directives to files.
Don't use the -p flag to tar; it sets the files to the wrong permissions.
Submitted by: jmz

Fix a long-standing bug that broke pkg_info utterly and probably made
pkg_add a little wiggy too.

Fix a long-standing bug that broke pkg_info utterly and probably made
pkg_add a little wiggy too. Document the fact that pkg_info can also
take a URL.

Bump the number of allowable args by a factor of 4. I just scanned
all possible packing lists and found that at least one of them is
pretty large!

Document fetch-by-URL.

Re-work make_dist() routine to build the tar command more reasonably.
This should eliminate the problem with truncated packages.

Whoops! One of my automatics was initialized to garbage. Fix it.

Use mtree -U instead of -u and put back error check. Thanks Rod!

Don't bother checking the return status of the mtree command - it returns
non-zero stats when it changes things, too.

Add code for dealing with URLs.

Make pkg_info URL aware (and also make it use the PKG_PATH properly, like
everyone else). Try this:
pkg_info ftp://freebsd.org/pub/FreeBSD/packages/all/gmake-3.73.tgz

Add depend on libftp since this is now in lib.

Add a great deal more error checking to various things.

Further work on making all this more robust in the face of failure.

Also allow URL specification for a package. This works for things the
package may depend on, too.

Allow PKG_PATH to be used anywhere a package is being searched for.

Yikes! How did that typo slip past! I'd swear I compiled it. Oh well,
thanks, Satoshi!

Embarrassed by: asami

As per Bruce's advice, use sysconf to get the max argument size and
dynamically allocate that much space, also using snprintf() and strncat()
to do proper bounds checking.

Check dependencies BEFORE doing final extraction of package.
Fix a bug where direct-extract mode would have still invoked the
packing list reordering commands.

My handling of the missing dependency but !Verbose was wrong. Make
the right message come out.

Use ARG_MAX instead of _POSIX_ARG_MAX: 4K is too small!
This should stop the SIGBUS errors in pkg_create for some packages.

Stage almost nothing through the playpen now - this should speed pkg_creates
up by a couple of factors, as well as decrease the amount of temporary space
required to build a package down to almost nothing.

Export the min_free() function.

Second round:

1. Make paths work correctly.
2. Make pkg_add generally more robust in the face of failure.
3. Make the depend messages come out on stderr or stdout, but not both
interspersed! :-)

1. Add an new @option directive. You'll understand it better in a moment.
2. Fix a long-standing bug in pkg_add where the failure of one package in
a multipackage installation (pkg_add *.tgz) would blow you right out of
the water. Ick.

Argh - missed a printf! That should be the last of plist-spewers.

Don't spew garbage into the packing list when PlistOnly and verbose are
both on. Whoops!

Some patches to make deletions of non-existent files and directories slightly
less fatal (so that the database entry is subsequently removed anyway).
Submitted by: Edward Wang <edward@edcom.com>

1. Add proper dependencies to the library in my Makefiles. This was pointed
out by Bruce.
2. Add a "feature" to pkg_create (OK, OK, it's a miserable hack!) to get
it to dump its internal packing list out so that the `fake-pkg' rule in
bsd.port.mk can generate a more meaningful packing list.

Correct a bogusly formatted printf().

Greatly simplify the calling of mtree - the error handling wasn't working
anyway, at least not with FreeBSD's mtree, and the arguments were being
built incorrectly.

Add support for the ${PKG_DBDIR} environment variable. /var/db/pkg is the
default, and probably not something you'd ever change, but now it's
possible to do so for local/custom installations.

Use a more nicely formatted message when we run out of space.

Neither of these tools really told you what you needed to know neatly
and succinctly in verbose mode. I hope people find this more to their
liking.

Add true support for dependency lists.

1. pkg_create now has a -P argument for specifying dependencies on the
command line.
2. pkg_add will honor dependencies and chain-load them automatically if
it finds the required package(s) in the same directory as the package
that is being loaded. For best results, install packages from a directory
containing all the packages you'll possibly need
(like /usr/ports/packages/all).

2 remaining flaws:

1. pkg_add looks in one place (where you were when you loaded the primary
pkg) for depended packages. If you can come up with a search path scheme
that's not a total hack - be my guest!

2. Recursive dependency expansion can result in the name of a dep being
listed more than once. This doesn't bother pkg_add since it checks
for package existance with pkg_info and will skip already-loaded packages.
I don't know how/if pkg_delete handles this yet, however. I need to look
into it.

Rename TMPDIR to PKG_TMPDIR, just to make Jeff happy.. :-)