- Copy stable/10 (r259064) to releng/10.0 as part of the
10.0-RELEASE cycle.
- Update __FreeBSD_version [1]
- Set branch name to -RC1

[1] 10.0-CURRENT __FreeBSD_version value ended at '55', so
start releng/10.0 at '100' so the branch is started with
a value ending in zero.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Copy head (r256279) to stable/10 as part of the 10.0-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

More -Wmissing-variable-declarations fixes.

In addition to adding `static' where possible:

- bin/date: Move `retval' into extern.h to make it visible to date.c.
- bin/ed: Move globally used variables into ed.h.
- sbin/camcontrol: Move `verbose' into camcontrol.h and fix shadow warnings.
- usr.bin/calendar: Remove unneeded variables.
- usr.bin/chat: Make `line' local instead of global.
- usr.bin/elfdump: Comment out unneeded function.
- usr.bin/rlogin: Use _Noreturn instead of __dead2.
- usr.bin/tset: Pull `Ospeed' into extern.h.
- usr.sbin/mfiutil: Put global variables in mfiutil.h.
- usr.sbin/pkg: Remove unused `os_corres'.
- usr.sbin/quotaon, usr.sbin/repquota: Remove unused `qfname'.

Bump date missed in r202756

PR: docs/171624
Submitted by: bdrewery
Approved by: gabor
MFC after: 3 days

Replace index() and rindex() calls with strchr() and strrchr().

The index() and rindex() functions were marked LEGACY in the 2001
revision of POSIX and were subsequently removed from the 2008 revision.
The strchr() and strrchr() functions are part of the C standard.

This makes the source code a lot more consistent, as most of these C
files also call into other str*() routines. In fact, about a dozen
already perform strchr() calls.

Spelling fixes for usr.bin/

Build finger(1) with WARNS=6.

Staticify cleanup() which is not referenced in other places.

MFC after: 2 weeks

Check return code of setuid() and setgid() in finger.

While they will not fail in normal circumstances, better safe than
sorry.

MFC after: 1 week

Remove the advertising clause from UCB copyrighted files in usr.bin. This
is in accordance with the information provided at
ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change

Also add $FreeBSD$ to a few files to keep svn happy.

Discussed with: imp, rwatson

Remove stale references to utmp(5) and its corresponding filenames.

I removed utmp and its manpage, but not other manpages referring to it.

Migrate finger(1) towards utmpx.

It was already ported to use libulog, which makes it simpler now. Be
sure to catch the error returned by setutxdb(). Otherwise it may perform
a lookup on the utx.active database.

Build usr.bin/ with WARNS=6 by default.

Also add some missing $FreeBSD$ to keep svn happy.

Migrate finger(1) away from <utmp.h>.

Unfortunately it also uses lastlog, which means we must resort to local
extensions of the utmpx-interface. Because the user name and TTY name
are now nul-terminated, there is no need to copy around strings as
often.

Plug a memory leak.

PR: bin/141836
Submitted by: Henning Petersen <henning.petersen at t-online.de>
MFC after: 2 weeks

Revert most part of 200420 as requested, as more review and polish is
needed.

Remove unneeded header includes from usr.bin/ except contributed code.

Tested with: make universe

Restore the ".Sh BUGS" line that was accidentally removed
in the previous commit.

Remove irrelevant comment about T/TCP in BUGS.

Spotted by: ru@

Remove -T from getopt() spec and usage string.

Submitted by: ru@

Bump Dd.

Remove T/TCP support, and the -T option which was needed to disable it.

MFC after: 3 weeks

Reduce number of spaces for full name by four, and reduce padding
after tty entry by one space in order to provide extra spaces for
the tty entry. As a result, full pts names are now visible (up
to 999 pts's anyway):

Before:
Login Name TTY Idle Login Time Office Phone
robert Robert Watson *v0 3:55 Fri 02:54
robert Robert Watson p0 19 Sat 11:01
robert Robert Watson pts Sat 14:55

After:

Login Name TTY Idle Login Time Office Phone
robert Robert Watson *v0 5:08 Fri 02:54
robert Robert Watson p0 8 Sat 11:01
robert Robert Watson pts/5 Sat 14:55

MFC after: 1 week

Setting .nofinger will not hide you from root.

Sync program's usage() with manpage's SYNOPSIS.

Fixed the misplaced $FreeBSD$.

Sort sections.

Document incorrect handling of multibyte characters.

Mechanically kill hard sentence breaks.

Remove spurious semicolons. Outside of functions they are actually errors but
GCC doesn't warn about them without -pedantic.

Approved by: das (mentor)
PR: 56649
Reviewed by: md5

Add multiple inclusion guards. Mostly this is for extern.h, which was
included twice by lprint.c, which included both finger.h and extern.h.
finger.h, in turn, includes extern.h. The redundant include of extern.h
was removed from lprint.c, as part of this change, but the include guards
were added anyway out of spite.

Fixed a misspelling of 0 as NULL.

Add code to keep going if you're really intent on fingering someone, but
can't use utmp(5).

If stat() on the terminal specified in utmp fails due to ENOENT, don't
print a warning, and set the idletime variable for the entry to -1;
then pick up the -1 later in sprint() and lprint() and ignore those
idle times by printing just whitespace. When third party applications,
such as kdm, insert utmp entries, they sometimes use strings like ":0",
which can't be stat()'d and currently result in warnings that are
not helpful to the user.

mdoc(7) police: Deal with self-xrefs.

Make a CR/LF sequence measure up to its name: the order of the CR and LF
characters was reversed, resulting in some network appliances, including
at least some NAS devices from Ascend, not recognizing our finger(1)
request.

PR: 45914
Submitted by: J R Matthews <jrm@delta-e.com.au>
Approved by: re (rwatson)
MFC after: 2 weeks

mdoc(7) police: bump document date, use the canonical option list width,
removed a bunch of extraneous .Pp and .Dq calls.

Approved by: re

Back out previous commit - it was not well thought out.

Clue beaten in by: ume
Pointy hat to: sobomax

Fix POLA breakage in 1.29: IPv4 should be default. This makes `-4' option
a nop, but we'll probably want to keep it for compatibility with other
KAME-based systems.

Complained about by: Andrey Lakhno <land@dnepr.net>
MFC after: 3 days

ANSIify function definitions.
Add some constness to avoid some warnings.
Remove use register keyword.
Deal with missing/unneeded extern/prototypes.
Some minor type changes/casts to avoid warnings.

Reviewed by: md5

add -4 and -6 option to be able to specify an address family.

Requested by: matusita
MFC after: 1 week

Add -g option, which restricts printing of the gecos fields to just the user's
real name.

PR: bin/39462
Submitted by: Mike Makonnen <makonnen@pacbell.net>
Obtained from: NetBSD
MFC after: 1 week

Clean up malloc(3)'s argument. Remove casts which do nothing when we're
using sizeof() anyway. Use slightly more consistent (per-file) error
reporting for malloc(3) returning NULL. If "malloc failed" was being printed,
don't use err(3). If a NULL format is being used, use err(3). In one case
errx(3) was being used with strerror(3), so just use err(3).

Use `The .Nm utility'

remove __P

Unremoved used includes. <sys/time.h> is needed if <sys/stat.h> isn't
polluted, and <sys/types.h> is strictly a prerequisite for <sys/stat.h>
untiil we drop support for pre-2001 versions of POSIX.

Remove leaf node WARNS?=2 (that mainly I added). This should
help the GCC3 transition and CURRENT in general.

GRR. Unbreak WARNS=2.
cc1: warnings being treated as errors
usr.bin/finger/lprint.c: In function `lprint':
usr.bin/finger/lprint.c:191: warning: precision is not type int (arg 2)
*** Error code 1

Pointy hat to: markm

Style improvements recommended by Bruce as a follow up to some
of the recent WARNS commits. The idea is:

1) FreeBSD id tags should follow vendor tags.
2) Vendor tags should not be compiled (though copyrights probably should).
3) There should be no blank line between including cdefs and __FBSDIF.

WARNS=2 fix, remove 'register' and use __FBSDID().

Replace the condemned access(2) by stat(2),
as per the discussion in -audit.

Don't use ".nofinger" as a string constant from within the code
since there is the ``pathnames.h'' file; use _PATH_NOFINGER instead.

mdoc(7) police: removed HISTORY info from the .Os call.

mdoc(7) police: sort SEE ALSO xrefs (sort -b -f +2 -3 +1 -2).

Include missing header files which define functions for which gcc has
builtins (e.g., exit, strcmp).

MAN[1-9] -> MAN.

Don't attempt to parse %c

MAXPATHLEN is enough.

Also, snprinf is guaranteed by the new ansi standard to NUL terminate the
string, so we don't need to do that ourselves.

Spelling
Remove unused #includes

Check strdup() return values

Reviewed by: kris

.publickey -> .pubkey to match other finger daemons.

Suggested by: assar

Add support for a .publickey file.

Submitted by: Svein Skogen <tds@nsn.no>
Reviewed by: brian, ru

If the utmp login time is greater than the tty atime, use it to calculate
the idle time instead of the atime.

This makes entries for people that have logged in but done nothing
else show up correctly.

Reviewed by: markk@knigma.org

Prepare for mdoc(7)NG.

Document what Idle=* means in a short format display.

mdoc(7) police: use the new features of the Nm macro.

The -o is the default for "short" display, not the -h.

-Wall cleanup.

PR: 22187

Do not allow `finger -m /somefile' as well.

Don't allow finger /somefile, only allow filname expansions from
inside /etc/finger.conf

PR: 21704

Don't assume ai0->ai_canonname will always be filled in. Print the
user-supplied host name if we can't get a canonical name.

Obtained from: contrib/tcp_wrappers/socket.c rev. 1.4 (in spirit)

Implement IPv6 support. Also restructure the way multi-homed hosts
are treated, regardless of protocol.

Delete a bogus reference to T/TCP -- the problem still exists on Standard
TCP.

Don't drop out when we've processed argc - 1 names.... arguments
may expand to more than one user.

PR: 21228

Finger.conf first appeared in 4.2 (now that it's been MFCd)

Fix the -m option - broken by the last commit.

Submitted by: Mark Knight <markk@knigma.org>

Add a missing comma.

Allow finger.conf to contain aliases for files that will be displayed
when fingered.

Submitted by: Mark Knight <markk@knigma.org>

Remove extraneous arguments to the Os (operating system) and Nm
(name) macros.

Do not terminate the cross-reference list in the SEE ALSO section
with a period.

Allow a /etc/finger.conf file that contains finger aliases
This allows people who's email address differs from their account name
to be fingerable.

Submitted by: Mark Knight <markk@knigma.org>

Backout previous commit.
(Mental note: don't forget -rRELENG_4 next time.)

MFC: fix some output cosmetics so that the finger -s output is properly
lined up

Fix finger -s output on an user who never logged in.
This is purely a cosmetic patch.

PR: 9809
Submitted by: se
Nagged about: nrahlstr

Don't call warn() with no format string.

Remove single-space hard sentence breaks. These degrade the quality
of the typeset output, tend to make diffs harder to read and provide
bad examples for new-comers to mdoc.

$Id$ -> $FreeBSD$

Use the final version of the patch for the overflow, not the next to
final.

Noticed by: eivind

Fix possible buffer overflow with finger and fingerd.

Submitted by: Lukasz Luzar <lluzar@noname.kki.krakow.pl> and
Eivind Eklund <eivind@yes.no>

This patch is actually a combination of those two patches.

Clean up some ambiguous nested if/elses.

Impliment elements of TCP Wrappers's `safe_finger'.
* if run by root (or root process) drop privs
* ensure output size is not infinate (net finger only)
* ensure output lines are not infinate in length (net finger only)
* do not allow finger client to run longer than 3 minutes (net finger only)

fix 8bit clean issue
PR: 7519

Don't assume that hp->h_lenght == 4. Be conservative in its use.
Submitted by: J. Assange a long time ago.

Document the bogus standard requirement of delaying the close.
Also include a reference to the FINGER RFC.

So somebody actually found language in the FINGER RFC which requires
implementations to leave the client side open until the server closes.
While this is totally idiotic, it seems as if some servers actually require
it (e.g., the one at mit.mit.edu). So, we bow to the weight of the bogus
standard and disable the initial close. Hopefully now fetch(1) can serve
the role of T/TCP demonstration application.

Add rcsid, usage(). Silent -Wall. Use warn(3).

compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.

Skip \r character while printing Plan/etc. text files, it allows to
handle \r\n and \n\r files properly.
Previous variant put ^M for \r\n and ^M\n for \n\r

Merge from Lite2

This commit was generated by cvs2svn to compensate for changes in r23690,
which included commits to RCS files with non-trunk default branches.

Adjust line to not overflow 80 cols (result of recent utmp changes)

Allow the user to disable the use of T/TCP by setting the -T option.
This option becomes useless when all TCP stacks are fixed out there.

Print 8bit chars from the net if current locale allows them

Implement client-side transaction TCP. This has little effect
if the server doesn't support it. (This is intended mostly as
an example.)

Change locale to LC_ALL, there is no bitmask

Add setlocale LC_TIME|LC_CTYPE

Reverse out some of the previous commit I did, which shortened the
finger output from 80 to 79 characters to stop the syscons
every-second-line-is-blank problem.

Also, redo the TTY column mod so that it steals one of the (usually) two
blank spaces from the before the tty column rather than from the office
phone number.

This means the office phone field width in the short finger is back to 15
characters instead of 13.

Increase the tty column width from 2 to 3 characters.

This gives us more room to breath with tty names, especially with drivers
that support large numbers of ports.. eg: specialix and digiboard.

This does not actually change the current tty names, it just allows room
for reporting more characters if the drivers use them.

Allow national printable chars in .plan

Replace asctime/ctime by strftime %c to use national representation

Delete bogus referneces to timezone code internal header file `tzfile.h',
which is no longer bogusly installed in /usr/include.

Fix finger not check all users ~/.nofinger, only for actually
matched. Close PR 539
Submitted by: tom@haven.uniserve.com

Remove trailing whitespace.

Make finger(1) accept "cua" to be also a tty, and use the suffix instead
of the very meaningful string "cu" to describe the tty.

Add Sean Eric Fagan's support for a ~/.nofinger file for user who prefer
their privacy.
Submitted by: sef

Remove extra newline introduced in 44lite (oops)

Remove extra newline introduced in Net/2

Add code to pull options out of FINGER environment variable if present.
Yes, has same stupid bug as more(1), options must be specified as one
argument.

Submitted by: pst

Install Luke's enhancements for finger.

By default, behave like the old ugly 4.4bsd finger and print office
information instead of remote login information.

It's an easy one line fix to make it behave like most other vendor's
fingers if we decide to change the default.

Reviewed by: pst

This commit was generated by cvs2svn to compensate for changes in r1590,
which included commits to RCS files with non-trunk default branches.