- Copy stable/10 (r259064) to releng/10.0 as part of the
10.0-RELEASE cycle.
- Update __FreeBSD_version [1]
- Set branch name to -RC1

[1] 10.0-CURRENT __FreeBSD_version value ended at '55', so
start releng/10.0 at '100' so the branch is started with
a value ending in zero.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Copy head (r256279) to stable/10 as part of the 10.0-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Fix warnings found by -Wmising-variable-declarations.

This self-written compiler warning, which is hopefully going to be
committed into LLVM sources soon, warns about potentially missing
`static' keywords, similar to -Wmissing-prototypes.

- bin/pax: Move external declaration of chdname and s_mask into extern.h.
- bin/setfacl: Move setfacl.c-specific stuff out of setfacl.h.
- sbin/mount_fusefs: Remove char *progname; use getprogname().
- others: add `static' where possible.

Fix a bunch of typos and a couple of whitespace nits.

Helped by: codespell and vim's spellchecker

Touch the man page date after updating the ustar limitations.

MFC after: 3 weeks

Correct an out-by-one error when earlying out ustar filenames that
are too long. Filenames escaping this test are caught later on,
so the bug doesn't cause any breakage.

Document the correct ustar limitations in pax. As I have no access
to the IEEE 1003.2 spec, I can only assume that the limitations
imposed are in fact correct.

Add regression tests for the filename limitations imposed by pax.

MFC after: 3 weeks

Fix an off-by-one error where we try to split a path name that's
more than 100 characters long and the 101th last character is a
'/'.

MFC after: 3 weeks

Fix back references in substitute command for pax(1)

pax(1) was trying to copy the back-referenced data from
the match pattern, not the matched data.

PR: bin/118132
Obtained from: Debian bug #451361
Reviewed by: jilles
MFC after: 3 weeks

Merge OpenBSD revisions 1.4 through 1.9, mostly style cleanups.

Obtained from: OpenBSD
MFC after: 3 month

Remove unused files.

Tell the compiler these structures are aligned to a byte boundary.
All the elements of these structs are char anyway, so it won't hurt
performance.

Bump warns back up to the default.

# we likely should have CTASSERTS to make sure they are the right size.
# but with libarchive based tar maybe we shouldn't bother.

Arm doesn't seem to need such kit gloves. Bump the warnings to 3 here
as well.

Port everything in bin/ from utmp to utmpx.

date: use libc utmpx routines instead of the ones provided by libulog.
pax: don't depend on <utmp.h>

Add missing `void' for function without arguments.

Plug a memory leak.

PR: bin/141835
Submitted by: Henning Petersen <henning.petersen t-online.de>
MFC after: 2 weeks

Before this fix, pax would stop the restore sequence for
symlinks after setting the owner. As a result, mode
and timestamp were not restored. This patch corrects the
problem by simply removing the short-circuit for symlinks
and using lchown()/lchmod()/lutimes() always for restoring
metadata.

PR: bin/91316
Submitted by: Jaakko Heinonen
Reviewed by: Joerg Sonnenberger
MFC after: 14 days

Remove unnecessary free argument casts.
Don't abuse arcname's constness.

Cleanup pax(1) sources a little bit while I poked around in them:
- remove a superfluous doubled trailing semicolon.
- remove the extra void casts on calls to void-function free(3).

Fix some of the alignment warnings on ARM.

Markup fixes.

Fix the wording about the blocksize (-b) parameter. The existing
wording makes it look like pax archives > 32256 bytes are not
POSIX-compliant! Correct this to state that pax archives with
block sizes > 32256 are not POSIX compliant...and settle our fears.

PR: docs/97059
Reviewed by: Giorgos Keramidas <keramida>

Fix bin/pax doesn't wait for compress/gzip before exiting.

Submitted by: Joerg Sonnenberger <joerg@britannica.bec.de>
Obtained from: OpenBSD (commited fix to PR 3455)

Expand *n't contractions.

Fixed the misplaced $FreeBSD$.

Add the new standard EXIT STATUS section where appropriate.
Sort standard sections in the (documented) preferred order.

Don't decend into directories when -d is set and the directory itself doesn't
match.

PR: 28095
Submitted by: bill at twwells dot com
MFC after: 7 days

/*- or .\"- or #- to begin license clauses.

Fix off-by-one errors and potential buffer overruns
WRT handling file and link names that reach the allowed
maximum for old tar and ustar archive formats.

PR: bin/40466
Submitted by: Cyrille Lefevre <email in the PR> (portions)
Reviewed by: freebsd-arch (silence)
MFC after: 1 month

Document missing multibyte character handling in utilities specified
by POSIX.

Deal with double whitespace.

Mechanically kill hard sentence breaks.

Don't continue if the '-C' option (a-la GNUtar; commited in options.c
rev 1.18, but not documented in the man page) caused a failed chdir.
Otherwise, one can easily overwrite files.

Submitted by: Robert Nagy <robert@openbsd.org>
Obtained from: OpenBSD

Use WARNS?=3 for these in the arm case for now, due to toolchain issues.

Remove clause 3 from the UCB licenses.

OK'ed by: imp, core

Fix memory leak

PR: bin/64321
Submitted by: Rodney Ruddock <rodney@interopsystems.com>
MFOpenBSD: rev 1.17
MFC after: 3 days

Make NULL a (void*)0 whereever possible, and fix the warnings(-Werror)
that this provokes. "Wherever possible" means "In the kernel OR NOT
C++" (implying C).

There are places where (void *) pointers are not valid, such as for
function pointers, but in the special case of (void *)0, agreement
settles on it being OK.

Most of the fixes were NULL where an integer zero was needed; many
of the fixes were NULL where ascii <nul> ('\0') was needed, and a
few were just "other".

Tested on: i386 sparc64

Get this area compiling with the highest WARNS= that it works with.
Obsolete WFORMAT= junk also removed where possible.

OK'ed by: obrien
Tested on: sparc64, alpha, i386

Fix a bazillion warnings. This makes almost the whole of src/bin/*
WARNS=6, std=c99 clean.

Tested on: i386, alpha

Quiet warnings about copyright[].

Fix signed/unsigned mix comparisons involving sizeof.

Add the -j and -y options to the synopsis.

Make the "tarcp" example more direct.

Correct typos, mostly s/ a / an / where appropriate. Some whitespace cleanup,
especially in troff files.

Ensure all va_starts have a matching va_end.

Obtained from: NetBSD

/dev/sa0 is the default tape device, not /dev/rst0.

Fix format string errors relating mainly to the use of %qu to print off_t's.
Instead use %ju and cast the argument.

WFORMAT=0 is still required in the Makefile because gcc warns about
some strftime() calls (I don't think this behaviour is useful.)

Tested on: sparc64, alpha, i386

Removed extra $FreeBSD$. Moved #if 0 for the vendor id to the correct
place. Restored indent protection of copyright comment.

s/filesystem/file system/ as discussed on -developers

Fix a couple of typos in a comment.

PR: docs/33559
Submitted by: Marc Olzheim <marcolz@ilse.nl>

Consistently use FBSDID

more file system > filesystem

Consistancy check s/file system/filesystem/

Reviewed by: brian

Use `The .Nm utility'

Use `The .Nm utility'

Do not return(f_returning_void());. Spell FALLTHROUGH to make it lint()able.

No need to cast; ().gr_gid is already the correct type.

Correct inadvertent style botches in previous commit.

Lock down with WFORMAT=1 except those directories with unfixed warnings.
Tested on i386 and alpha.

Ooops, forgot to remove the registers here.

o __P has been reoved
o Old-style K&R declarations have been converted to new C89 style
o register has been removed
o prototype for main() has been removed (gcc3 makes it an error)
o int main(int argc, char *argv[]) is the preferred main definition.
o Attempt to not break style(9) conformance for declarations more than
they already are.

Default to WARNS=2. Binary builds that cannot handle this must explicitly
set WARNS=0.

Reviewed by: mike

Use a quad int conversion routine for time_t instead of ulong, capable of
decoding tar's full time buffer (12 digits).

Various string fields for certain cpio types are 11 rather then 8
characters. Use quad conversion functions rather then long conversion
where appropriate to handle the available range. Mainly fixes time_t
but there was also a st_size ulong conversion in there that has to be
quad or cpio cannot be used to copy files > 2G.

MFC after: 1 day

Remove unnecessary casts in timeval.tv_sec load from st_*time

mdoc(7) police: s/BSD/.Bx/ where appropriate.

Initialize listf at main()

mdoc(7) police: join split punctuation to macro calls.

Remove whitespace at EOL.

mdoc(7) police: removed HISTORY info from the .Os call.

mdoc(7) police: remove extraneous .Pp before and/or after .Sh.

Fix the type of the NULL arg to execl()

Idea from: Theo de Raadt <deraadt@openbsd.org>

Include missing header files which define functions for which gcc has
builtins (e.g., exit, strcmp).

Minor comment fix

mdoc(7) police: fix markup, rename and reorder some sections.

mdoc(7) police: sort xrefs.

Sync up with OpenBSD. Too many changes to note, but the major features
are:
* Implement cpio compatibility mode when pax is invoked as cpio
* Extend tar compatibility mode to cover many of the GNU tar single-letter
options (bzip2 mode, aka -y/-j is not present in OpenBSD). When
invoked as tar, pax is now full-featured enough for use by the ports
collection to extract distfiles and create packages.
* Many bug fixes to the operation of pax and the tar compatibility modes
* Code fixes for things like correct string buffer termination.

I tried to preserve existing FreeBSD fixes to this utility; please let me
know if I have inadvertently spammed something.

Add -z flag to pax to allow gzipping of archive output. Add -z and -Z (gzip
and compress) to pax when used in tar mode (invoked as 'tar') for
compatibility with GNU tar.

bzip2 functionality for further GNU tar compatibility will be added at a
later date.

Note in the manpage that -z is non-standard.

Obtained from: OpenBSD
Reviewed by: -hackers
MFC after: 2 weeks

Whitespace cleanup pass; reduce diffs with OpenBSD. No functional changes.

Reduce diffs with OpenBSD:
#if __STDC__ -> #ifdef __STDC__
pax_warn() -> paxwarn()
sys_warn() -> syswarn()
(foo *)NULL -> NULL
bcopy -> memmove()/memcpy()
bzero -> memset()
Typo fixes
sprintf() -> snprintf()
rindex() -> strrchr()
index() -> strchr()
sys_errlist[] -> strerror()

Obtained from: OpenBSD

Use mkstemp() for secure tempfile creation instead of tempnam()

Obtained from: OpenBSD
Reviewed by: mikeh

-Wnon-const-format sweep: make format strings const char *'s, add
__printflike()/__printf0like() to function prototypes, as appropriate.

Reviewed by: bde, -audit

Use nl_langinfo instead of %Ef

POSIX wrote:

: LC_TIME This variable shall determine the format and
: contents of date and time strings when the -v
: option is specified.

Developers took this wrong. LC_TIME specifies the locale
name, not the ``format'' argument of strftime().

Oops:
pax -w -f /tmp/foo /dev/null
LC_TIME=de_DE.ISO_8859-1 pax -v -f /tmp/foo

mdoc(7) police: use the default ``file ...'' feature of the .Ar macro.

Fix typo: seperate -> separate.

Seperate does not exist in the english language.

Submitted to look at by: kris

mdoc(7) police: split punctuation characters + misc fixes.

Prepare for mdoc(7)NG.

mdoc(7) police: use the new features of the Nm macro.

Don't explicitly declare optarg and optind. These are declared in
unistd.h, which is already included.

Use %Ef

Remove more single-space hard sentence breaks.

Remove single-space hard sentence breaks. These degrade the quality
of the typeset output, tend to make diffs harder to read and provide
bad examples for new-comers to mdoc.

$Id$ -> $FreeBSD$

Various spelling/formatting changes.

Submitted by: Philippe Charnier <charnier@xp11.frmug.org>

Rev 1.13 fixes PR bin/8958

There is a bug in /bin/pax -s option processing. The code assumes that all
pattern matches will occur at offset zero of the source string. The bug causes
the input source string pointer to be incremented by the offset of the end of
the match, instead of it's length. The fix is to only increment the pointer by
the length of the pattern match (eo-so).

Of course, the one example in the man page shows a situation where the match
occurs at offset 0.

Submitted by: John W. DeBoskey <jwd@unx.sas.com>
Obtained from: freebsd-current@freebsd.org

- Fix off-by-one problem in tar where filenames of length 100
and dirnames of length 99 don't archive.

Submitted by: Wilfredo Sanchez <wsanchez@apple.com>
Obtained from: OpenBSD

Make sure we pass the length - 1 to readlink, since it adds its own
NUL at the end of the path.
Inspired by: OpenBSD's changes in this area by theo de raadt

Clarify the example a bit.

PR: 6801
Reviewed by: David Kelly <dkelly@hiwaay.net>

Correct use of .Nm. Add rcsid.

.Sh AUTHOR -> .Sh AUTHORS
Use .An/.Aq

Make code slightly more robust towards change by calculating size
in-place.

Obtained from: OpenBSD ar_subs.c rev 1.7 by Tood Miller <millert@openbsd.org)

Remove simultaneous include of <sys/param.h> and <sys/types.h>.
Reorder includes to be alphabetical some places since I already was in
here.

Dont have an internal function named "warn" it clashes with libc..
Needed for ELF.

Off by 1 adjustment. Properly NUL terminate after strncpy.
Obtained from: {Net|Open}BSD

compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.

Revert $FreeBSD$ to $Id$

Make the long-awaited change from $Id$ to $FreeBSD$

This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore. This update would have been
insane otherwise.

-Wall cleaning.

Pick collate info for RE character ranges

Remove unneded ctype.h everywhere
Add setlocale LC_TIME

Fix possible FS corruption caused by extra parameter to pax.
oo
Turns out, it's pretty important if you use PAX for backup. In the man
page for PAX, there is an error (OK, we could call it a "potentially
catastrophic incompleteness"). It reads:

> The command:
>
> pax -r -v -f filename
>
> gives the verbose table of contents for an archive stored in filename.

Yup, it does do that. With a side effect: it also _replaces_ all the
files that come in from the archive. As is my custom, I did my
backup-validation real soon after the backup was written. Precisely
because I've seen the same sort of thing happen on other systems. So all
that file-restoring didn't do a lot of damage. Probably helped my
fragmentation somewhat (aha, an online defragger?) It did confuse one
hapless user, who lost an email message he _knew_ he hadn't deleted.
Apparently the system restored the file as of just before that critical
message came in.

The correct entry should read:

> The command:
>
> pax -v -f filename
>




> gives the verbose table of contents for an archive stored in filename.


Submitted by: John Beckett <jbeckett@southern.edu> via the BSDI mailing list

Delete bogus referneces to timezone code internal header file `tzfile.h',
which is no longer bogusly installed in /usr/include.

Improve the handling of large minor numbers:

cpio/copyout.c:
Don't output a file if the major, minor or totality of its rdev would be
truncated. Print a message about the skipped files to stderr but don't
report the error in the exit status. cpio's abysmal error handling doesn't
allow continuing after an error, and the rdev checks had to be misplaced
to avoid the problem of returning an error code from routines that return
void.

pax/pax.h:
Use the system macros for major(), minor() and makedev().

pax already checks _all_ output conversions for overflow. This has the
undesirable effect that failure to convert relatively useless fields
such as st_dev for regular files causes files not to be output. pax
doesn't report exactly which fields couldn't be converted.

tar/create.c:
Don't output a file if the major or minor its rdev would be truncated.
Print a message about the skipped files to stderr and report the error
in the exit status.

tar/tar.c:
For not immediately fatal errors, exit with status 1, not the error count
(mod 256).

All:
Minor numbers are limited to 21 bits in pax's ustar format and to 18
bits in archives created by gnu tar (gnu tar wastes 3 bits for padding).
pax's and cpio's ustar format is incompatible with gnu tar's ustar
format for other reasons (see cpio/README).

Remove trailing whitespace.

Reviewed by: phk

You will find enclosed some changes to make gcc -Wall more happy in
/usr/src/bin. Note that some patches are still needed in that directory.

I (Joerg) finished most of Philippe's cleanup. /bin/sh will still
need *allot* of work, however.

Submitted by: charnier@lirmm.fr (Philippe Charnier)

Added $Id$

This commit was generated by cvs2svn to compensate for changes in r1556,
which included commits to RCS files with non-trunk default branches.