MFC r318790, r319336

r318790:
Fix a buffer overflow in bootparamd(8)

If /etc/bootparams contains a line with an excessively long pathname, and a
client asks for that path, then bootparamd will overflow a buffer and crash
while parsing that line. This is not remotely exploitable since it requires
a malformed /etc/bootparams file.

Reported by: Coverity
CID: 1305954
Sponsored by: Spectra Logic Corp

r319336:
Fix uninitialized variable in bootparamd.c

Restore line that was accidentally deleted in change 318790

Reported by: Coverity
CID: 1375855
X-MFC-With: 318790
Sponsored by: Spectra Logic Corp

MFC r290645:

Fix some trivial warnings with bootparamd/main.c

- Convert K&R to something a bit less ancient
- Remove an incorrect, duplicate prototype for bootparamprog_1(..)

PR: 71667
Submitted by: bcran
Sponsored by: EMC / Isilon Storage Division

Copy head (r256279) to stable/10 as part of the 10.0-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

mdoc sweep.

mdoc: terminate quoted strings.

Reviewed by: brueffer

Consistently set RPCGEN_CPP when running rpcgen, so the C preprocessor
set via ${CPP} is used, instead of always using hardcoded /usr/bin/cpp.

MFC after: 1 week

Replace index() and rindex() calls with strchr() and strrchr().

The index() and rindex() functions were marked LEGACY in the 2001
revision of POSIX and were subsequently removed from the 2008 revision.
The strchr() and strrchr() functions are part of the C standard.

This makes the source code a lot more consistent, as most of these C
files also call into other str*() routines. In fact, about a dozen
already perform strchr() calls.

Spelling fixes for usr.sbin/

Unbreak bootparamd when setting WITHOUT_NIS.

Submitted by: bf1783 googlemail com

Remove a useless cast.

Spotted out by: stefanf

Char is unsigned on arm, so is not suitable to store the return value of
getopt(). Use an int instead.

Submitted by: Matthew Luckie
MFC after: 3 days

Fix bootparamd on 64 bit platforms - at least amd64 was broken due to the
code believing long == 64 bits and using it to store/compare IPv4 addresses.

PR: bin/112163
Submitted by: Tyler Spivey <tspivey@pcdesk.net>
Reviewed by: imp
Approved by: imp (mentor)
MFC after: 1 week

Cleanup of userland __P use

Reimplementation of world/kernel build options. For details, see:

http://lists.freebsd.org/pipermail/freebsd-current/2006-March/061725.html

The src.conf(5) manpage is to follow in a few days.

Brought to you by: imp, jhb, kris, phk, ru (all bugs are mine)

Sort sections.

Add knob NO_NIS (fka NO_YP_LIBC) and make world compileable when set.
If turned on no NIS support and related programs will be built.

Lost parts rediscovered by: Danny Braniss <danny at cs.huji.ac.il>
PR: bin/68303
No objections: des, gshapiro, nectar
Reviewed by: ru
Approved by: rwatson (mentor)
MFC after: 2 weeks

- Don't use argv[i] when i is uninitialised.
- Cast isdigit's argument to unsigned char.
- Remove the now unused variable i.

Approved by: das (mentor)

Make this compile cleanly. Switch to using rpcgen to generate
code that can be compiled on an ansi-C compiler, so that it puts the
xdrproc_t casts in. This also implies a slight function name change.

The .Nm utility

can not -> cannot

s/adress/address/

Inspired by: OpenBSD
MFC After: 1 week

Perform a major cleanup of the usr.sbin Makefiles.
These are not perfectly in agreement with each other style-wise, but they
are orders of orders of magnitude more consistent style-wise than before.

Remove whitespace at EOL.

- Backout botched attempt to introduce MANSECT feature.
- MAN[1-9] -> MAN.

mdoc(7) police: Remove the debug line that prevents hyphenation
for the purposes of spelling checking that left in after my last
visit to this file.

Mdoc(7)ify.

Add a workaround in the EXAMPLE section for booting diskless SPARC/SunOS
Xkernel machines. Might save people some hair pulling..

Submitted by: rene@tcja.nl

Remove single-space hard sentence breaks. These degrade the quality
of the typeset output, tend to make diffs harder to read and provide
bad examples for new-comers to mdoc.

$Id$ -> $FreeBSD$

Add $Id$, to make it simpler for members of the translation teams to
track.

The Id line is normally at the bottom of the main comment block in the
man page, separated from the rest of the manpage by an empty comment,
like so;

.\" $Id$
.\"

If the immediately preceding comment is a @(#) format ID marker than the
the $Id$ will line up underneath it with no intervening blank lines.
Otherwise, an additional blank line is inserted.

Approved by: bde

#include <arpa/inet.h> for inet_* definitions.

o be careful about buffer overflows
o Use snprintf rather than sprintf

This is only lightly tested.

Fixed `make -j9' by putting generated headers in ${SRCS}. Removed bogus
dependencies of generated .c files on generated headers (these made
`make -JN' work provided `depend' was made first). Sorted sources lists.

.Sh AUTHOR -> .Sh AUTHORS. Use .An/.Aq.

Restored xref to diskless(8). diskless(8) existed but was not installed.

PR: 2153

Fix a number of buffer overflow conditions.

PR: bin/4610
Submitted by: David Holland (dholland@burgundy.eecs.harvard.edu)

Use err(3). Add usage and prototypes. Remove Xref: Diskless(8) does not
exist. Use An/Aq macros for Author.

Show the real revision date and not the date that this
manpage is being viewed.

compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.

Revert $FreeBSD$ to $Id$

#include <string.h> to help silence -Wall.

Sort cross references.

Make the long-awaited change from $Id$ to $FreeBSD$

This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore. This update would have been
insane otherwise.

Convert to mdoc format.

Correct the syntax of the example to reflect reality, and note that the
'host:' element is mandatory.
A better fix would involve reworking bootparamd not to require a ':'
in the response string.

Change references from rpc.bootparamd to bootparamd.

Add bootparams.5.

Obtained from: NetBSD

This commit was generated by cvs2svn to compensate for changes in r13122,
which included commits to RCS files with non-trunk default branches.

main.c:
- use daemon() to daemonify ourselves
- the 'Usage' printf() was missing an argument
- remove declaration of rindex and #include <string.h> instead

bootparam.c:
- get rid of local declarations of YP functions and include headers
from /usr/include/rpcsvc instead.

Add a dependency on the .x source file and avoid copying it.

bootparam_prot.x was changed for nfsv3 but bootparamd and callbootd
kept using the old version which fortunately failed at build time.
Copying hasn't been necessary since path handling was fixed in
rpcgen/rpc_main.c some time ago.

Remove trailing whitespace.

Took out .include "../../Makefile.inc" which shouldn't be needed now that I
put a proper Makefile.inc in the top level of the bootparam heirarchy.
(Someday I'll learn. *sigh*)

My patch this morning was not complete. I never tested make install - stupidly
thinking that it would work :( The install program never get a destination
directory. Here is another patch that should also be added. I think this
should be the last one for these makefiles :)

[Note: I realize that there are more things wrong than this, but this should
at least get the tree compiling again! -jkh]

Submitted by: John Hay <jhay@mikom.csir.co.za>

The current bootparamd makefiles break if you do a make obj first. It does
work if you don't have the obj link. Here is a patch for it. It will still
work if you don't have an obj link:)

(I stuck a ${DESTDIR} in front of the absolute path to /usr/include... /phk)
Reviewed by: phk
Submitted by: John Hay <jhay@mikom.csir.co.za>

This commit was generated by cvs2svn to compensate for changes in r6751,
which included commits to RCS files with non-trunk default branches.