MFC r314653:

libexec: normalize paths using SRCTOP-relative paths or :H when possible

This simplifies make logic/output

MFC r274364:

Add baud rate support to telnet(1)

This implements part of RFC-2217

It's based off a patch originally written by Sujal Patel at Isilon, and
contributions from other Isilon employees.

PR: 173728
Phabric: D995
Reviewed by: markj, markm
Sponsored by: EMC / Isilon Storage Division

Copy head (r256279) to stable/10 as part of the 10.0-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Convert telnetd(8) to use posix_openpt(2).

Some time ago I got some reports MPSAFE TTY broke telnetd(8). Even
though it turned out to be a different problem within the TTY code, I
spotted a small issue with telnetd(8). Instead of allocating PTY's using
openpty(3) or posix_openpt(2), it used its own PTY allocation routine.
This means that telnetd(8) still uses /dev/ptyXX-style devices.

I've also increased the size of line[]. Even though 16 should be enough,
we already use 13 bytes ("/dev/pts/999", including '\0'). 32 bytes gives
us a little more freedom.

Also enable -DSTREAMSPTY. Otherwise telnetd(8) strips the PTY's pathname
to the latest slash instead of just removing "/dev/" (e.g. /dev/pts/0 ->
0, instead of pts/0).

Reviewed by: rink

Fix conflicts after heimdal-1.1 import and add build infrastructure. Import
all non-style changes made by heimdal to our own libgssapi.

inetd and telnetd are not included in the standard release
crunched floppies, but they can be included as options in
src/release/picobsd (omitted by default though.) Therefore
preserve the RELEASE_CRUNCH knob in their Makefiles, but
tell its real purpose in a comment.

Stop enforcing dependencies between MK_* options at Makefile level.
All the dependencies are satisfied now in <bsd.own.mk>.

telnetd(8) doesn't really go to the crunched floppies,
so its Makefile needn't test for RELEASE_CRUNCH.

Suggested by: ru

Respect MK_INET6_SUPPORT.
Apply style.Makefile(5).

Reimplementation of world/kernel build options. For details, see:

http://lists.freebsd.org/pipermail/freebsd-current/2006-March/061725.html

The src.conf(5) manpage is to follow in a few days.

Brought to you by: imp, jhb, kris, phk, ru (all bugs are mine)

Remove kludges intended to support src trees with partial obj trees.

Discussed with: ru

NOCRYPT -> NO_CRYPT

Join the 21st century: Cryptography is no longer an optional component
of releases. The -DNOCRYPT build option still exists for anyone who
really wants to build non-cryptographic binaries, but the "crypto"
release distribution is now part of "base", and anyone installing from a
release will get cryptographic binaries.

Approved by: re (scottl), markm
Discussed on: freebsd-current, in late April 2004

Make sure that a "make release" (more accurately the bit that makes
the crunched binary) get a non-cryptographic telnet. This is overkill
in that it covers stuff that is not normally used in a crunched binary.

Ensure that for the cryptographic instances of *telnet*, the "crypto"
distribution is used. This only affects release-building.

Test correct macro for "without crypto" option(s).

Very big makeover in the way telnet, telnetd and libtelnet are built.

Previously, there were two copies of telnet; a non-crypto version
that lived in the usual places, and a crypto version that lived in
crypto/telnet/. The latter was built in a broken manner somewhat akin
to other "contribified" sources. This meant that there were 4 telnets
competing with each other at build time - KerberosIV, Kerberos5,
plain-old-secure and base. KerberosIV is no longer in the running, but
the other three took it in turns to jump all over each other during a
"make buildworld".

As the crypto issue has been clarified, and crypto _calls_ are not
a problem, crypto/telnet has been repo-copied to contrib/telnet,
and with this commit, all telnets are now "contribified". The contrib
path was chosen to not destroy history in the repository, and differs
from other contrib/ entries in that it may be worked on as "normal"
BSD code. There is no dangerous crypto in these sources, only a
very weak system less strong than enigma(1).

Kerberos5 telnet and Secure telnet are now selected by using the usual
macros in /etc/make.conf, and the build process is unsurprising and
less treacherous.

Mrege from crypto telnet with "make unifdef". This gets a bunch of
$FreeBSD$ tags and some debug variable safety belts.

Replace various spelling with FALLTHROUGH which is lint()able

The .Nm utility

Don't risk catching a signal while handling a signal for a dying child, as we
can then end up not properly clearing wtmp/utmp entries.

PR: bin/37934
Submitted by: Sandeep Kumar <skumar@juniper.net>
Reviewed by: markm
MFC after: 2 weeks

Set WFORMAT=0, overlooked in previous commits to libexec/.

Reported by: jhay

Don't use non-signal-safe functions (exit(3) in this case) in
signal handlers. In this case, use _exit(2) instead, following
the call to shutdown(2).

This fixes rare telnetd hangs.

PR: misc/33672
Submitted by: Umesh Krishnaswamy <umesh@juniper.net>
MFC after: 1 month

MFCrypto: Remove -r, -s, sort -p.

Merge from master (crypto) telnet. WARNS fixes for alpha.

Merge the (in)complete ANSIfication work from src/crypto/telnet.

After running a "make unifdef", commit the resultant diffs.

This code is now a complete sunset of the crypto (master) code.

Diff-reduce WRT src/secure/*telnet*/Makefile.

Also, add an "unifdef:" target, so that the telnet sources can
be remade from the crypto sources in src/crypto/telnet.

Manually unifdef(1) CRAY, UNICOS, hpux and sun uselsess code.

Remove description of an option that only applies to UNICOS < 7.0.
That define may still be present in the source, but I don't think
anyone has plans to try to use it.

Obtained from: NetBSD

Feature merging and diff reduction between this code and crypto telnet.
Also remove conditional (AUTHENTICATION) code as we have never compiled
it here, and it is doubtful that it even works in this scenario.

mdoc(7) police: s/BSD/.Bx/ where appropriate.

MFcrypto/telnet/telnetd: Correct semantics of output_data*() and netflush()
to ensure deterministic operation

MFCrypto: fixed the remote buffer overflow.

Remove whitespace at EOL.

mdoc(7) police: removed HISTORY info from the .Os call.

Fix the type of the NULL arg to execl()

Idea from: Theo de Raadt <deraadt@openbsd.org>

Fix the number of bytes allocated by realloc when more space is needed
for the vector of arguments.

MFC after: 1 week

Bye-bye /usr/lib/libtelnet.a. This should fix ``make release'' brokeness.

Approved by: markm

- Backout botched attempt to intoduce MANSECT feature.
- MAN[1-9] -> MAN.

Set the default manual section for libexec/ to 8.

Preceed/preceeding are not english words. Use precede or preceding.

Synch: Properly constify sccsid[].
Replace bcopy() with memmove().

Synch: Prefer memmove() over bcopy().

Synch: Properly constify sccsid[].

Synch: prefer memmove() over bcopy(), since the first is a C-standard
interface, whilst the latter is a BSD'ism.

Fix typo: seperate -> separate.

Seperate does not exist in the english language.

Submitted to look at by: kris

Fix typo: wierd -> weird.

There is no such thing as wierd in the english language.

mdoc(7) police: split punctuation characters + misc fixes.

Prepare for mdoc(7)NG.

Prepare for mdoc(7)NG.

(scrub_env): change to only accept a listed set of variables,
including only non-filename contents for TERMCAP

Add `_PATH_DEVZERO'.
Use _PATH_* where where possible.

Correct definition of MAXHOSTNAMELEN in ifdef'ed code.

Submitted by: Edwin Groothuis <mavetju@chello.nl>
PR: bin/22787

mdoc(7) police: use the new features of the Nm macro.

Don't use sizeof() on a pointer when we really wanted to measure
the length of the array.

Noticed by: Christos Zoulas <christos@ZOULAS.COM>
Obtained from: OpenBSD

Filter out some more magic environment variables used by libraries linked
with telnetd. This should really be done with a positive filter - i.e.
only allow through a configured list of variables.

Also do some buffer-safety cleanups while I'm here - I don't think these
are exploitable.

Minor mdoc cleanup.

PR: docs/13218

several tcp apps IPv6 update
-inetd
-rshd
-rlogind
-telnetd
-rsh
-rlogin

Reviewed by: freebsd-arch, cvs-committers
Obtained from: KAME project

We do not support the -B option.

PR: 15925
Submitted by: Thierry Herbelot

$Id$ -> $FreeBSD$

Back out previous commit - it's not necessary now that tty.h properly includes
the queue macros.

Add a missing include (sys/queue.h for sys/tty.h SLIST usage.)

Determine the host name using an array size of
MAXHOSTNAMELEN and call trimdomain() before implementing
the -u option.

This allows local hosts of a lan with a long domain name to
appear properly in utmp by base host name (w/o domain) rather
than by IP number.

Really fix -u....

Ensure that things returned by gethostname() and
friends are terminated and allow for a maximum
host name length of MAXHOSTNAMELEN - 1.
Put parenthesis around sizeof args.
Make some variables static.
Fix telnetd -u (broken by my last commit)

Prompted by: bde

Use realhostname() rather than various combinations of
gethostbyaddr() & gethostbyname().

Remove brokeness in ftpd for hosts of MAXHOSTNAMELEN length.

After receiving a connection and doing a reverse
lookup on the incoming IP, do a forward lookup on
the result and make sure that the IP is in the
resulting list. If it's not, put the IP number
in utmp/wtmp instead of the rogue name.

Stolen from: rlogind
Suggested by: sef

Old stuff laying around: Don't use a function called getstr(), that has
nasty consequences when the system curses is ncurses as this conflicts
with a ncurses funciton and causes recursion.

Sort cross references.

Remove a bogus prototype for time() and let time.h do that.

Change pointer casts from int to long. The code that looks to index -1
of argv is still broken on alpha.

Clarify use of 'if' capability.

PR: 6499
Submitted by: Doug Barton <Studded@san.rr.com>

Avoid stairstep effect on output of 'if=...' file.

PR: part of 6492
Submitted by: Chip Norkus via Doug White <studded@san.rr.com>

telnetd does not recognize the if (display file before login) gettytab flag.

PR: 6365
Reviewed by: phk
Submitted by: Jason Garman <init@risen.org>

Add missing dot.

sprintf->snprintf paranoia. The one thing that looks like a hole in
the diff is in an ifdef that isn't enabled for FreeBSD.
Obtained from: OpenBSD(?)

Sync with diffs I found in kerberised versions: -Wall, no `;' in macros.

Use err(3). Remove progname and trailing \n in syslog strings.

PR: bin/771 and bin/1037 are resolved by this change
This change changes the default handling of linemode so that older and/or
stupider telnet clients can still get wakeup characters like <ESC> and
<CTRL>D to work correctly multiple times on the same line, as in csh
"set filec" operations. It also causes CR and LF characters to be read by
apps in certain terminal modes consistently, as opposed to returning
CR sometimes and LF sometimes, which broke existing apps. The change
was shown to fix the problem demonstrated in the FreeBSD telnet client,
along with the telnet client in Solaris, SCO, Windows '95 & NT, DEC OSF,
NCSA, and others.

A similar change will be incorporated in the crypto version of telnetd.

This resolves bin/771 and bin/1037.

There is a clear separation of the crypto telnet and the non-crypto telnet.
As this is the non-crypto version, remove the useless (commented out)
directives and macros.

-p flag misdocumented in telnetd(8)
PR: 4462
Submitted by: hfir@math.rochester.edu

compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.

Revert $FreeBSD$ to $Id$

Added support for %s (sysname) %m (machine) %r (release) and %v (version)
prompt macros to agree with getty(8).

Make the long-awaited change from $Id$ to $FreeBSD$

This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore. This update would have been
insane otherwise.

Sort cross references.

Some buffer overrun fixes and removed check for username starting with "-"
(replacied it with a getopt stopper (--) instead, which is more correct).

Obtained from: OpenBSD

correct spelling of 'X Window System' (tm)

delete doubled words, e.g.: "the the" -> "the"

add forgotten $Id$

Fixed DPADD.

Add a ``-P altlogin'' option which allows the sysadmin to specify an
alternate login(1) type program to run.

Localize time

This commit was generated by cvs2svn to compensate for changes in r13122,
which included commits to RCS files with non-trunk default branches.

Remove LD_NOSTD_PATH unsetenv, isn't exist anymore

Fix original patch error with ! before strncmp
Zap only needed LD_* variables

Don't allow LD_* env. variables to be tricked
Submitted by: Sam Hartman <hartmans@mit.edu>

Fixed bug introduced with the change of startslave()...two arguments
were chopped off of the function call and garbage was passed instead.
The solution involves making some variable globals as well as fixing the
call to have all the arguments.

Move erase cleanup outside linemode conditional

Properly set the erase character for the login prompt.

Submitted by: John Capo <jc@irbs.com> & Peter Wemm

Delay starting login process until option negotiation is complete to
avoid race condition on connections with larger round-trip-times.

Submitted by: John Capo & Peter Wemm

Fix some typos in a comment BUAD -> BAUD.

Change default banner fro 4.4 BSD to FreeBSD.
Reviewed by:
Submitted by:
Obtained from:

Use the same DECODE_BAUD trick like in new telnetd to obtain
termios speed.
Obtained from: Pre-Lite2 telnet

The final negotiation of DO_BINARY in the LINEMODE portion of the telnetd code
causes some clients that do not support linemode to mis-interpret the return
key (i.e. double returns).
The fix is to only do the state check for binary options if linemode will
be used.
Closes PR#505.

Submitted by: Charles Henrich

Remove trailing whitespace.

Fix bug:
When hostname len > 8, name replaced with dot notation when -u flag
not specified (default case).
Use _PATH_* for utmp/wtmp.

Support for >32 PTYs.
Submitted by: Heikki Suonsivu <hsu@cs.hut.fi>

Change all references to LIBTERM and -ltermlib to LIBTERMCAP and -ltermcap

Don't define KLUDGELINEMODE.
(If you do, you will have problems trying to telnet into a FreeBSD-2.0
box from a Sun, and I WANT TO DO THAT.)
Submitted by: Geoff

Plug already known security hole. (Brought over from 1.1.5):
Fixed security problem with telnetd, which allowed
telnet -l -hcert.org localhost
to change the user's host in utmp.
Thanks to Matthew Green <mrgreen@@mame.mu.oz.au> for showing me this one.


Reviewed by: karl, guido
Submitted by: mrgreen@@mame.mu.oz.au

Remove the scary bits from telnetd - no more encryption left here.
Only crypt.c in libc remains.
Reviewed by: Geoff Rehmet

Change bogus --I to -I to make compilation happen again.
Submitted by: jkh

Update to new make macros and disable Kerberos because we haven't got it
set up right yet.

This commit was generated by cvs2svn to compensate for changes in r1592,
which included commits to RCS files with non-trunk default branches.