MFC r267667:
use .Mt to mark up email addresses consistently (part1)

PR: 191174
Submitted by: Franco Fichtner <franco at lastsummer.de>

MFC r301582

Explicitly NUL terminate the buffer filled by fread().

The fix in r300649 was not sufficient to convince Coverity that the
buffer was NUL terminated, even with the buffer pre-zeroed. Swap
the size and nmemb arguments to fread() so that a valid lenght is
returned, which we can use to terminate the string in the buffer
at the correct location. This should also quiet the complaint about
the return value of fread() not being checked.

Reported by: Coverity
CID: 1019054, 1009614
Secur3ty:
Sponsore dby:

MFC r300649

Fix Coverity CID 1019054 (String not null terminated) in setfacl.

Increase the size of buf[] by one to allow room for a NUL character
at the end.

Reported by: Coverity
CID: 1019054

MFC r289195:

Integrate the tests from lib/libarchive, usr.bin/cpio, and usr.bin/tar in to
the FreeBSD test suite

functional_test.sh was ported from bin/sh/tests/functional_test.sh, as a
small wrapper around libarchive_test, bsdcpio_test, and bsdtar_test provided
by upstream.

A handful of testcases in lib/libarchive/tests have been disabled as they
were failing when run with kyua test (see BROKEN_TESTS in
lib/libarchive/tests/Makefile)

As a sidenote: this removes the check/test targets from the Makefiles as they
don't match the pattern used in the rest of the FreeBSD test suite.

Sponsored by: EMC / Isilon Storage Division

Conflicts:
lib/libarchive/test
usr.bin/cpio/test

Copy head (r256279) to stable/10 as part of the 10.0-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

Mention that read_attributes, write_attributes, read_acl and write_acl
are always permitted for the file owner.

PR: kern/174948
MFC after: 1 week

Fix NFSv4 permission description in setfacl(1) manual page: the 'D'
means delete_child, not delete.

MFC after: 1 week

Improve description of the "-m" option to setfacl(1).

Submitted by: scottl
MFC after: 1 week

In the setfacl(1) manual page, make it clear that for NFSv4 ACLs,
one should really use -a and -x instead of -m.

MFC after: 1 week

Fix warnings found by -Wmising-variable-declarations.

This self-written compiler warning, which is hopefully going to be
committed into LLVM sources soon, warns about potentially missing
`static' keywords, similar to -Wmissing-prototypes.

- bin/pax: Move external declaration of chdname and s_mask into extern.h.
- bin/setfacl: Move setfacl.c-specific stuff out of setfacl.h.
- sbin/mount_fusefs: Remove char *progname; use getprogname().
- others: add `static' where possible.

Fix an error in setfacl(1) that manifested like this:

# setfacl -m u:trasz:rwx x
# setfacl -m u:root:rwx x
# getfacl x
# file: x
# owner: root
# group: wheel
user::rw-
user:root:rwx
user:trasz:rwx
group::r--
mask::rwx
other::r--
# setfacl -m u:root:rwx x
setfacl: x: acl_calc_mask() failed: Invalid argument
setfacl: x: failed to set ACL mask

For NFSv4 ACLs, this sort of situation would result in duplicated
entries.

MFC after: 1 month

Make "setfacl -bd" an alias for "setfacl -k". Previously it would crash
on assert.

PR: bin/165807
MFC after: 1 month

Make setfacl(1) behave properly in situations like "setfacl -kd".

MFC after: 1 month

Fix compact form of "synchronize" permission in setfacl(1) manual page - it
should be "s", not "S".

PR: docs/162380
MFC after: 2 weeks

Remove trailing whitespace per mdoc lint warning

Disussed with: gavin
No objection from: doc
Approved by: joel
MFC after: 3 days

Make it possible to use permission sets (full_set, modify_set, read_set
and write_set) with setfacl(1).

PR: kern/154113
Submitted by: Shawn Webb <lattera at gmail dot com> (earlier version)
MFC after: 1 month

Increase carried_error if we skip a file due to an error. This ensures
that setfacl(1) exits with proper exit status on failure.

PR: bin/149780
Submitted by: Ævar Arnfjörð Bjarmason (original version)
Reviewed by: trasz
MFC after: 3 weeks

Typo fix: s/ommited/omitted

MFC after: 4 days

Update authors and history.

MFC after: 1 week

Switch to our preferred license text.

Approved by: jedgar

Fix breakage introduced in last commit.

Improve ACL branding mismatch detection and reporting in some rare cases,
such as "setfacl -m ''".

Add NFSv4 support to setfacl(1).

Reviewed by: rwatson

Fix double free in setfacl(1). Description from the author:

Initially, 'acl' (an 'acl_t *') is allocated, and its ACCESS_ACL and
DEFAULT_ACL fields are passed to the 'libc' ACL routines for subsequent
allocation. If the '-m' option (merge existing ACL with a new one) is
specified, then 'set_acl_mask()' will be called and passed one of the
two ACLs. This function, in turn, replaces this given ACL structure by
another, freshly allocated. However, the pointer in the 'acl' variable
in the caller is not updated. The caller then proceeds to free the ACL,
incurring in a double free condition.

Submitted by: Pedro Martelletto <pedro at ambientworks.net>
Approved by: rwatson (mentor)

Add hard sentence breaks.

Pointed out by: rwatson
MFC after: 1 week

Document default ACLs and how to use them.
MFC after: 1 week

Implement the -h flag (set an ACL on a symbolic link).
Before this fix the -h flag was ignored (i.e. setfacl
always set the ACL on the file pointed to by the symbolic
link even when the -h flag requested that the ACL be set
on the symbolic link itself).

Markup fixes.

o Fix grammar, format.

Document the way to get list of files to process from the stdin.

MFC after: 1 week
Approved by: kan (mentor)

Copy filename read from the stdin into the private buffer. Otherwise,
next read filename overwrite previous one, resulting in acl being
applied only to the last name in the list.

Submitted by: Oleg Lomaka <oleg.lomaka at gmail com>
MFC after: 1 week
Approved by: kan (mentor)

[mdoc] add missing space before a punctuation type argument.

Sync program's usage() with manpage's SYNOPSIS.

Add the new standard EXIT STATUS section where appropriate.
Sort standard sections in the (documented) preferred order.

/*- or .\"- or #- to begin license clauses.

Mechanically kill hard sentence breaks.

style.Makefile(5)

Add additional documentation to setfacl(1) regarding the behavior of
tools such as chmod(1) and ls(1) when it comes to acting on objects
that have POSIX.1e extended ACLs. Specifically, discuss the
substitution of the mask entry for the group entry in the mode
representation of the ACL. Differently worded from the submission,
and could probably use further refinement.

PR: 55319
Submitted by: Grzegorz Czaplinski <G.Czaplinski@prioris.mini.pw.edu.pl>

-v no longer a valid argument to setfacl(1) -- remove from usage().

PR: 55318
Submitted by: Grzegorz Czaplinski <G.Czaplinski@prioris.mini.pw.edu.pl>

When reporting an error internalizing an ACL string, print out the
ACL that generated the error, rather than the function, which is
more user-friendly.

Obtained from: TrustedBSD Project
Product of: France

Add "-h" arguments to getfacl and setfacl, which behave in a manner
similar to "-h" on chown, chmod, etc, causing the operation to occur
on a final symlink in the provided path, rather than its target.

Obtained from: TrustedBSD Project

Consistently use FBSDID

Remove extraneous blank line

Use acl_dup() to duplicate an ACL instead of rolling our own

Use a more correct method of copying entire ACLs (fixes
operation under Linux).

Spelling.

Default to WARNS=2. Binary builds that cannot handle this must explicitly
set WARNS=0.

Reviewed by: mike

Move the code merging ACL_USER and ACL_GROUP objects from under
two nested while loops into a separate function.

Obtained from: TrustedBSD Project

Add defines for access and default ACLs (ACCESS_ACL/DEFAULT_ACL)
to enhance readability.

Obtained from: TrustedBSD Project

style(9) cleanups mostly consisting of:
o explicitly check return values and variables against a value
o return x; -> return (x);
o fix inconsistent sysexits usage by nuking it (partially
suggested by bde)

Obtained from: TrustedBSD Project

Correct example to remove *all* extended ACL entries and
clarify description.

o Expand the explaination of the -b option WRT the resulting
group ACL entry in relation to the existing group and mask
ACL entries.
o Move the explanation of multiple ACL entries on the command
line to the ACL ENTRIES section.

Obtained from: TrustedBSD Project

o Correct error message forgotten in the last commit (malloc() -> calloc())
o Fix style nits

Submitted by: bde

Use calloc(3) instead of rolling our own.

mdoc(7) police: utilize the new .Ex macro.

WARNS= -> WARNS?=

Submitted by: Mike Barcroft <mike@q9media.com>

Silence WARNS=2 and BDECFLAGS on alpha and i386

MFC After: 1 week

Correct assignment of the resulting ACL allowing the mask entry to
be properly set.

Obtained from: TrustedBSD Project

o Separate acl_t into internal and external representations as
required by POSIX.1e. This maintains the current 'struct acl'
in the kernel while providing the generic external acl_t
interface required to complete the ACL editing library.
o Add the acl_get_entry() function.
o Convert the existing ACL utilities, getfacl and setfacl, to
fully make use of the ACL editing library.

Obtained from: TrustedBSD Project

mdoc(7) police: normalize .Nd.

setfacl and getfacl no longer need to link against libposix1e, since it
has been integrated into libc.

Approved by: rwatson
Obtained from: TrustedBSD Project

mdoc(7) police: fix markup and some spelling.

Remove extra CFLAGS
Add DPADD

Submitted by: bde

Remove 'NOSHARED=yes' (../Makefile.inc already sets this)

o Missed in addition of setfacl.h in setfacl(1)

o POSIX.2c Userland tool support for POSIX.1e ACLs -- getfacl retrieves ACLs
from files and directories, and setfacl sets ACLs on files and directories.

Submitted by: jedgar
Obtained from: TrustedBSD Project